Re: svn commit: r320897 - in stable/11/sys: conf dev/ixgbe modules/ix modules/ixv

2017-07-12 Thread Sean Bruno
Just so that its clear, this will be changed back to the original string shortly. sean On 07/12/17 11:16, Mike Tancsa wrote: > Hi Eric, > For stable users, can the loader.conf variable not be the original one > ? Especially for servers that are physically remote, a sysadmin might > expect (

Re: svn commit: r320897 - in stable/11/sys: conf dev/ixgbe modules/ix modules/ixv

2017-07-12 Thread Mike Tancsa
Hi Eric, For stable users, can the loader.conf variable not be the original one ? Especially for servers that are physically remote, a sysadmin might expect (wrongly or not) for the name not the change in a stable branch. If the box is remote, they would not be able to see the new dmesg err

Re: svn commit: r320897 - in stable/11/sys: conf dev/ixgbe modules/ix modules/ixv

2017-07-12 Thread Eric Joyner
Olivier, There is a message about it in dmesg, right? For the error code, there's not much we can do there aside from adding a new unsupported SFP+ code to errno.h, which doesn't seem appropriate. On Wed, Jul 12, 2017 at 9:27 AM Olivier Cochard-Labbé wrote: > On Wed, Jul 12, 2017 at 5:39 PM, Er

Re: svn commit: r320897 - in stable/11/sys: conf dev/ixgbe modules/ix modules/ixv

2017-07-12 Thread Olivier Cochard-Labbé
On Wed, Jul 12, 2017 at 5:39 PM, Eric Joyner wrote: > I think it may have been silently renamed to "allow_unsupported_sfp" > instead of "unsupported_sfp". Could you try changing the name of that > tunable in your config? > > ​Thanks Eric! Replacing this previous line into my /boot/loader.conf hw

Re: svn commit: r320897 - in stable/11/sys: conf dev/ixgbe modules/ix modules/ixv

2017-07-12 Thread Eric Joyner
I think it may have been silently renamed to "allow_unsupported_sfp" instead of "unsupported_sfp". Could you try changing the name of that tunable in your config? On Wed, Jul 12, 2017 at 7:58 AM Olivier Cochard-Labbé wrote: > On Wed, Jul 12, 2017 at 4:34 PM, Sean Bruno wrote: > >> Huh ... is th

Re: svn commit: r320897 - in stable/11/sys: conf dev/ixgbe modules/ix modules/ixv

2017-07-12 Thread Olivier Cochard-Labbé
On Wed, Jul 12, 2017 at 4:34 PM, Sean Bruno wrote: > Huh ... is there anything in your console boot messages that would seem > to indicate an error on attach? > > ​Good catch, I didn't notice it before: "device_attach: ix0 attach returned 5". dmeg before this commit: ix0: port 0x2020-0x203f me

Re: svn commit: r320897 - in stable/11/sys: conf dev/ixgbe modules/ix modules/ixv

2017-07-12 Thread Sean Bruno
On 07/12/17 06:35, Olivier Cochard-Labbé wrote: > On Tue, Jul 11, 2017 at 11:25 PM, Eric Joyner > wrote: > > Author: erj > Date: Tue Jul 11 21:25:07 2017 > New Revision: 320897 > URL: https://svnweb.freebsd.org/changeset/base/320897 >

Re: svn commit: r320897 - in stable/11/sys: conf dev/ixgbe modules/ix modules/ixv

2017-07-12 Thread Olivier Cochard-Labbé
On Tue, Jul 11, 2017 at 11:25 PM, Eric Joyner wrote: > Author: erj > Date: Tue Jul 11 21:25:07 2017 > New Revision: 320897 > URL: https://svnweb.freebsd.org/changeset/base/320897 > > Log: > MFC r316541, r316544, and r320688 from HEAD to stable/11. > > ​Hi Eric, I've got a regression with this

svn commit: r320897 - in stable/11/sys: conf dev/ixgbe modules/ix modules/ixv

2017-07-11 Thread Eric Joyner
Author: erj Date: Tue Jul 11 21:25:07 2017 New Revision: 320897 URL: https://svnweb.freebsd.org/changeset/base/320897 Log: MFC r316541, r316544, and r320688 from HEAD to stable/11. r316541: Fix a double free in ixgbe_rxeof() r316544: Don't overwrite vf->flags variable at the end of