Re: svn commit: r327354 - head/sys/vm

2018-01-19 Thread Bruce Evans
On Fri, 19 Jan 2018, Conrad Meyer wrote: On Fri, Jan 19, 2018 at 9:04 AM, Rodney W. Grimes wrote: BUT I do not believe this bit of "style" has anything to do with readability of code, and has more to do with how code runs on a processor and stack frames. If

Re: svn commit: r327354 - head/sys/vm

2018-01-19 Thread Rodney W. Grimes
[ Charset UTF-8 unsupported, converting... ] > On Thu, Jan 18, 2018 at 1:32 PM, Conrad Meyer wrote: > > > On Thu, Jan 18, 2018 at 12:01 PM, Eric van Gyzen > > wrote: > > > On 01/17/2018 16:40, Gleb Smirnoff wrote: > > >> Yeah, style is sacred, but is there a

Re: svn commit: r327354 - head/sys/vm

2018-01-19 Thread Brooks Davis
On Fri, Jan 19, 2018 at 09:25:34AM -0800, Conrad Meyer wrote: > On Fri, Jan 19, 2018 at 9:04 AM, Rodney W. Grimes > wrote: > > BUT I do not believe this bit of "style" has anything to do with > > readability of code, and has more to do with how code runs on a > >

Re: svn commit: r327354 - head/sys/vm

2018-01-19 Thread Conrad Meyer
On Fri, Jan 19, 2018 at 9:04 AM, Rodney W. Grimes wrote: > BUT I do not believe this bit of "style" has anything to do with > readability of code, and has more to do with how code runs on a > processor and stack frames. If you defer the declaration of > "int i"

Re: svn commit: r327354 - head/sys/vm

2018-01-19 Thread Rodney W. Grimes
> On 01/17/2018 16:40, Gleb Smirnoff wrote: > > On Fri, Dec 29, 2017 at 07:05:07PM +, Konstantin Belousov wrote: > > K> Author: kib > > K> Date: Fri Dec 29 19:05:07 2017 > > K> New Revision: 327354 > > K> URL: https://svnweb.freebsd.org/changeset/base/327354 > > K> > > K> Log: > > K> Style.

Re: svn commit: r327354 - head/sys/vm

2018-01-18 Thread Bruce Evans
On Thu, 18 Jan 2018, Eric van Gyzen wrote: On 01/17/2018 16:40, Gleb Smirnoff wrote: On Fri, Dec 29, 2017 at 07:05:07PM +, Konstantin Belousov wrote: K> Author: kib K> Date: Fri Dec 29 19:05:07 2017 K> New Revision: 327354 K> URL: https://svnweb.freebsd.org/changeset/base/327354 K> K> Log:

Re: svn commit: r327354 - head/sys/vm

2018-01-18 Thread Ian Lepore
On Fri, 2018-01-19 at 00:21 +0200, Andriy Gapon wrote: > On 18/01/2018 23:10, Matt Joras wrote: > > > > "/* Insert an empty line if the function has no local variables. > > */" > And if there is a single silly rule in style(9) then it is this. > Waste a line for no possible benefit at all. >

Re: svn commit: r327354 - head/sys/vm

2018-01-18 Thread Andriy Gapon
On 18/01/2018 23:10, Matt Joras wrote: > "/* Insert an empty line if the function has no local variables. */" And if there is a single silly rule in style(9) then it is this. Waste a line for no possible benefit at all. -- Andriy Gapon ___

Re: svn commit: r327354 - head/sys/vm

2018-01-18 Thread Conrad Meyer
On Thu, Jan 18, 2018 at 1:04 PM, Warner Losh wrote: > On Thu, Jan 18, 2018 at 1:32 PM, Conrad Meyer wrote: >> 1. Allowing local / block scoped variables >> 2. Allowing C99 for loop initial declarations > > Tell me again where #1/#2 are disallowed? I can't seem

Re: svn commit: r327354 - head/sys/vm

2018-01-18 Thread Warner Losh
On Thu, Jan 18, 2018 at 2:10 PM, Matt Joras wrote: > On Thu, Jan 18, 2018 at 1:04 PM, Warner Losh wrote: > > > >> 1. Allowing local / block scoped variables > >> 2. Allowing C99 for loop initial declarations > >> > >> But I could see the argument that (2) is

Re: svn commit: r327354 - head/sys/vm

2018-01-18 Thread Matt Joras
On Thu, Jan 18, 2018 at 1:04 PM, Warner Losh wrote: > >> 1. Allowing local / block scoped variables >> 2. Allowing C99 for loop initial declarations >> >> But I could see the argument that (2) is just a boring subset of (1). > > > Tell me again where #1/#2 are disallowed? I can't

Re: svn commit: r327354 - head/sys/vm

2018-01-18 Thread Warner Losh
On Thu, Jan 18, 2018 at 1:32 PM, Conrad Meyer wrote: > On Thu, Jan 18, 2018 at 12:01 PM, Eric van Gyzen > wrote: > > On 01/17/2018 16:40, Gleb Smirnoff wrote: > >> Yeah, style is sacred, but is there a single person on Earth who would > >> not agree that

Re: svn commit: r327354 - head/sys/vm

2018-01-18 Thread Conrad Meyer
On Thu, Jan 18, 2018 at 12:01 PM, Eric van Gyzen wrote: > On 01/17/2018 16:40, Gleb Smirnoff wrote: >> Yeah, style is sacred, but is there a single person on Earth who would >> not agree that moving variables from smaller blocks to function block >> reduces readability of the

Re: svn commit: r327354 - head/sys/vm

2018-01-18 Thread Eric van Gyzen
On 01/17/2018 16:40, Gleb Smirnoff wrote: > On Fri, Dec 29, 2017 at 07:05:07PM +, Konstantin Belousov wrote: > K> Author: kib > K> Date: Fri Dec 29 19:05:07 2017 > K> New Revision: 327354 > K> URL: https://svnweb.freebsd.org/changeset/base/327354 > K> > K> Log: > K> Style. > K> > K>

Re: svn commit: r327354 - head/sys/vm

2018-01-17 Thread Gleb Smirnoff
On Fri, Dec 29, 2017 at 07:05:07PM +, Konstantin Belousov wrote: K> Author: kib K> Date: Fri Dec 29 19:05:07 2017 K> New Revision: 327354 K> URL: https://svnweb.freebsd.org/changeset/base/327354 K> K> Log: K> Style. K> K> Reviewed by: alc K> Sponsored by: The FreeBSD

svn commit: r327354 - head/sys/vm

2017-12-29 Thread Konstantin Belousov
Author: kib Date: Fri Dec 29 19:05:07 2017 New Revision: 327354 URL: https://svnweb.freebsd.org/changeset/base/327354 Log: Style. Reviewed by: alc Sponsored by: The FreeBSD Foundation MFC after:1 week Differential revision:https://reviews.freebsd.org/D13678 Modified: