Re: svn commit: r329237 - head/sys/libkern

2018-02-13 Thread Bruce Evans
On Tue, 13 Feb 2018, Ian Lepore wrote: On Tue, 2018-02-13 at 14:43 -0500, Ed Maste wrote: On 13 February 2018 at 14:23, Ian Lepore wrote: On Tue, 2018-02-13 at 19:17 +, Ed Maste wrote: Author: emaste Date: Tue Feb 13 19:17:48 2018 New Revision: 329237 URL:

Re: svn commit: r329237 - head/sys/libkern

2018-02-13 Thread Warner Losh
d.org>, Ian Lepore <i...@freebsd.org> > Cc: src-committers <src-committ...@freebsd.org>, <svn-src-all@freebsd.org>, > <svn-src-h...@freebsd.org> > Subject: Re: svn commit: r329237 - head/sys/libkern > > > ... > > > > I prefer '\0' here beca

Re: svn commit: r329237 - head/sys/libkern

2018-02-13 Thread Ravi Pokala
t;svn-src-all@freebsd.org>, <svn-src-h...@freebsd.org> Subject: Re: svn commit: r329237 - head/sys/libkern > ... > > I prefer '\0' here because it tells the reader that it's a NUL > character, as opposed to a NULL pointer or a zero integer. Yes, the > reader shoul

Re: svn commit: r329237 - head/sys/libkern

2018-02-13 Thread Conrad Meyer
On Tue, Feb 13, 2018 at 11:52 AM, Eric van Gyzen wrote: > On 02/13/2018 13:43, Ed Maste wrote: >> On 13 February 2018 at 14:23, Ian Lepore wrote: >>> There are many ways to spell 0. Why are we using something other than >>> the simplest way? Is it a style

Re: svn commit: r329237 - head/sys/libkern

2018-02-13 Thread Ian Lepore
On Tue, 2018-02-13 at 14:43 -0500, Ed Maste wrote: > On 13 February 2018 at 14:23, Ian Lepore wrote: > > > > On Tue, 2018-02-13 at 19:17 +, Ed Maste wrote: > > > > > > Author: emaste > > > Date: Tue Feb 13 19:17:48 2018 > > > New Revision: 329237 > > > URL:

Re: svn commit: r329237 - head/sys/libkern

2018-02-13 Thread Eric van Gyzen
On 02/13/2018 13:43, Ed Maste wrote: > On 13 February 2018 at 14:23, Ian Lepore wrote: >> On Tue, 2018-02-13 at 19:17 +, Ed Maste wrote: >>> Author: emaste >>> Date: Tue Feb 13 19:17:48 2018 >>> New Revision: 329237 >>> URL: https://svnweb.freebsd.org/changeset/base/329237

Re: svn commit: r329237 - head/sys/libkern

2018-02-13 Thread Ed Maste
On 13 February 2018 at 14:23, Ian Lepore wrote: > On Tue, 2018-02-13 at 19:17 +, Ed Maste wrote: >> Author: emaste >> Date: Tue Feb 13 19:17:48 2018 >> New Revision: 329237 >> URL: https://svnweb.freebsd.org/changeset/base/329237 >> >> Log: >> libkern: use nul for

Re: svn commit: r329237 - head/sys/libkern

2018-02-13 Thread Ian Lepore
On Tue, 2018-02-13 at 19:17 +, Ed Maste wrote: > Author: emaste > Date: Tue Feb 13 19:17:48 2018 > New Revision: 329237 > URL: https://svnweb.freebsd.org/changeset/base/329237 > > Log: >   libkern: use nul for terminating char rather than 0 >    >   Akin to the change made in r188080 for

svn commit: r329237 - head/sys/libkern

2018-02-13 Thread Ed Maste
Author: emaste Date: Tue Feb 13 19:17:48 2018 New Revision: 329237 URL: https://svnweb.freebsd.org/changeset/base/329237 Log: libkern: use nul for terminating char rather than 0 Akin to the change made in r188080 for lib/libc/string/. Reported by: bde Sponsored by: The FreeBSD