Re: svn commit: r334880 - head/sys/dev/vnic

2018-07-08 Thread Ian Lepore
On Sun, 2018-07-08 at 12:14 -0400, Mark Johnston wrote: > On Sun, Jul 08, 2018 at 09:58:35AM -0600, Warner Losh wrote: > > > > On Sun, Jul 8, 2018 at 9:55 AM, Sean Bruno > > wrote: > > > > > > > > > > > > > > On 07/08/18 09:26, Mark Johnston wrote: > > > > > > > > On Sun, Jul 08, 2018 at

Re: svn commit: r334880 - head/sys/dev/vnic

2018-07-08 Thread Mark Johnston
On Sun, Jul 08, 2018 at 10:23:52AM -0600, Warner Losh wrote: > On Sun, Jul 8, 2018 at 10:14 AM, Mark Johnston wrote: > > Being unfamiliar with FDT, could I ask you to explain how the code could > > be using phandles to find the PHYs? > > > > Allwinner provides a good example, and says it in code

Re: svn commit: r334880 - head/sys/dev/vnic

2018-07-08 Thread Warner Losh
On Sun, Jul 8, 2018 at 10:14 AM, Mark Johnston wrote: > On Sun, Jul 08, 2018 at 09:58:35AM -0600, Warner Losh wrote: > > On Sun, Jul 8, 2018 at 9:55 AM, Sean Bruno wrote: > > > > > > > > > > > On 07/08/18 09:26, Mark Johnston wrote: > > > > On Sun, Jul 08, 2018 at 09:10:27AM -0600, Sean Bruno

Re: svn commit: r334880 - head/sys/dev/vnic

2018-07-08 Thread Mark Johnston
On Sun, Jul 08, 2018 at 09:58:35AM -0600, Warner Losh wrote: > On Sun, Jul 8, 2018 at 9:55 AM, Sean Bruno wrote: > > > > > > > On 07/08/18 09:26, Mark Johnston wrote: > > > On Sun, Jul 08, 2018 at 09:10:27AM -0600, Sean Bruno wrote: > > >> > > >> > > >> On 07/07/18 11:43, Mark Johnston wrote: >

Re: svn commit: r334880 - head/sys/dev/vnic

2018-07-08 Thread Sean Bruno
> > ofwdump isn't very useful, you'll get much nicer output with: > >   sysctl -b hw.fdt.dtb | dtc -I dtb -O dts >somefile.dts > > BTW, the whole idea of searching for a phy by walking the node > hierarchy doing string comparisons on node names sounds pretty > antithetical to the whole design

Re: svn commit: r334880 - head/sys/dev/vnic

2018-07-08 Thread Warner Losh
On Sun, Jul 8, 2018 at 9:55 AM, Sean Bruno wrote: > > > On 07/08/18 09:26, Mark Johnston wrote: > > On Sun, Jul 08, 2018 at 09:10:27AM -0600, Sean Bruno wrote: > >> > >> > >> On 07/07/18 11:43, Mark Johnston wrote: > >>> On Sat, Jun 09, 2018 at 02:47:49PM +, Andrew Turner wrote: >

Re: svn commit: r334880 - head/sys/dev/vnic

2018-07-08 Thread Sean Bruno
On 07/08/18 09:26, Mark Johnston wrote: > On Sun, Jul 08, 2018 at 09:10:27AM -0600, Sean Bruno wrote: >> >> >> On 07/07/18 11:43, Mark Johnston wrote: >>> On Sat, Jun 09, 2018 at 02:47:49PM +, Andrew Turner wrote: Author: andrew Date: Sat Jun 9 14:47:49 2018 New Revision:

Re: svn commit: r334880 - head/sys/dev/vnic

2018-07-08 Thread Ian Lepore
On Sun, 2018-07-08 at 11:26 -0400, Mark Johnston wrote: > On Sun, Jul 08, 2018 at 09:10:27AM -0600, Sean Bruno wrote: > > > > > > > > On 07/07/18 11:43, Mark Johnston wrote: > > > > > > On Sat, Jun 09, 2018 at 02:47:49PM +, Andrew Turner wrote: > > > > > > > > Author: andrew > > > > Date:

Re: svn commit: r334880 - head/sys/dev/vnic

2018-07-08 Thread Mark Johnston
On Sun, Jul 08, 2018 at 09:10:27AM -0600, Sean Bruno wrote: > > > On 07/07/18 11:43, Mark Johnston wrote: > > On Sat, Jun 09, 2018 at 02:47:49PM +, Andrew Turner wrote: > >> Author: andrew > >> Date: Sat Jun 9 14:47:49 2018 > >> New Revision: 334880 > >> URL:

Re: svn commit: r334880 - head/sys/dev/vnic

2018-07-08 Thread Sean Bruno
On 07/07/18 11:43, Mark Johnston wrote: > On Sat, Jun 09, 2018 at 02:47:49PM +, Andrew Turner wrote: >> Author: andrew >> Date: Sat Jun 9 14:47:49 2018 >> New Revision: 334880 >> URL: https://svnweb.freebsd.org/changeset/base/334880 >> >> Log: >> In the ThunderX BGX network driver we were

Re: svn commit: r334880 - head/sys/dev/vnic

2018-07-07 Thread Mark Johnston
On Sat, Jun 09, 2018 at 02:47:49PM +, Andrew Turner wrote: > Author: andrew > Date: Sat Jun 9 14:47:49 2018 > New Revision: 334880 > URL: https://svnweb.freebsd.org/changeset/base/334880 > > Log: > In the ThunderX BGX network driver we were skipping the NULL terminator > when parsing the

svn commit: r334880 - head/sys/dev/vnic

2018-06-09 Thread Andrew Turner
Author: andrew Date: Sat Jun 9 14:47:49 2018 New Revision: 334880 URL: https://svnweb.freebsd.org/changeset/base/334880 Log: In the ThunderX BGX network driver we were skipping the NULL terminator when parsing the phy type, however this is included in the length returned by OF_getprop. To