Author: cy
Date: Sat Mar 23 04:32:10 2019
New Revision: 345437
URL: https://svnweb.freebsd.org/changeset/base/345437

Log:
  The check for $ippool_rules in start_cmd is tautological.
  
  Reported by:  hrs@
  MFC after:    13 days
  X-MFC with:   r345400

Modified:
  head/libexec/rc/rc.d/ippool

Modified: head/libexec/rc/rc.d/ippool
==============================================================================
--- head/libexec/rc/rc.d/ippool Sat Mar 23 03:37:08 2019        (r345436)
+++ head/libexec/rc/rc.d/ippool Sat Mar 23 04:32:10 2019        (r345437)
@@ -14,19 +14,16 @@ name="ippool"
 desc="user interface to the IPFilter pools"
 rcvar="ippool_enable"
 load_rc_config $name
-start_cmd="ippool_start"
+start_precmd="ippool_start_precmd"
 stop_cmd="${ippool_program} -F"
 reload_cmd="ippool_reload"
 extra_commands="reload"
 required_files="${ippool_rules}"
 required_modules="ipl:ipfilter"
 
-ippool_start()
+ippool_start_precmd()
 {
-       if [ -r "${ippool_rules}" ]; then
-               echo "Loading IP Pools."
-               ${ippool_program} -f ${ippool_rules} ${ippool_flags}
-       fi
+       rc_flags="-f ${ippool_rules} ${rc_flags}"
 }
 
 ippool_reload()
_______________________________________________
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Reply via email to