Re: svn commit: r353408 - head

2019-10-11 Thread Brooks Davis
It worked for a default non-CROSS_TOOLCHAIN build, but I didn't test for repeatably or in other configurations. Enhancements welcome. -- Brooks On Thu, Oct 10, 2019 at 11:07:52PM -0700, Conrad Meyer wrote: > Fwiw, this doesn???t seem to fix the NO_CLEAN build for amd64-xtoolchain-gcc. > > On

Re: svn commit: r353408 - head

2019-10-11 Thread Conrad Meyer
That might be the problem in the CI rig, but xtoolchain on CURRENT doesn't appear to provide the incorrect "12" value, and it's still broken — nothing to do with gets(3). $ x86_64-unknown-freebsd13.0-gcc-6.4.0 -std=c99 -dM -E - < /dev/null | grep FreeBSD #define __FreeBSD__ 13 The error I hit

Re: svn commit: r353408 - head

2019-10-11 Thread Dimitry Andric
On 11 Oct 2019, at 08:24, Andriy Gapon wrote: > > On 11/10/2019 09:07, Conrad Meyer wrote: >> Fwiw, this doesn’t seem to fix the NO_CLEAN build for amd64-xtoolchain-gcc. > > Does a clean build work for that configuration? > I looked at one of CI builds and it had this: > In file included from

Re: svn commit: r353408 - head

2019-10-11 Thread Andriy Gapon
On 11/10/2019 09:07, Conrad Meyer wrote: > Fwiw, this doesn’t seem to fix the NO_CLEAN build for amd64-xtoolchain-gcc. Does a clean build work for that configuration? I looked at one of CI builds and it had this: In file included from /workspace/src/contrib/libc++/include/__debug:26:0,

Re: svn commit: r353408 - head

2019-10-11 Thread Andriy Gapon
On 10/10/2019 19:29, Brooks Davis wrote: > Author: brooks > Date: Thu Oct 10 16:29:13 2019 > New Revision: 353408 > URL: https://svnweb.freebsd.org/changeset/base/353408 > > Log: > Fix -DNO_CLEAN build across r353340 and r353381 > > opensolaris_atomic.S is now only used on i386 with

Re: svn commit: r353408 - head

2019-10-11 Thread Conrad Meyer
Fwiw, this doesn’t seem to fix the NO_CLEAN build for amd64-xtoolchain-gcc. On Thu, Oct 10, 2019 at 09:29 Brooks Davis wrote: > Author: brooks > Date: Thu Oct 10 16:29:13 2019 > New Revision: 353408 > URL: https://svnweb.freebsd.org/changeset/base/353408 > > Log: > Fix -DNO_CLEAN build across

svn commit: r353408 - head

2019-10-10 Thread Brooks Davis
Author: brooks Date: Thu Oct 10 16:29:13 2019 New Revision: 353408 URL: https://svnweb.freebsd.org/changeset/base/353408 Log: Fix -DNO_CLEAN build across r353340 and r353381 opensolaris_atomic.S is now only used on i386 with opensolaris_atomic.c used on other platforms. After r353381 it