Re: svn commit: r355137 - head/sys/vm

2019-12-03 Thread Gleb Smirnoff
On Tue, Dec 03, 2019 at 12:59:18PM -0800, Ryan Libby wrote: R> > If I understand the change correct, now items from UMA_ZONE_NOFREE zones R> > will be trashed, too. That would undermine purpose of UMA_ZONE_NOFREE. R> > Of course the flag is a hack, but some systems rely on it working. R> > R> The i

Re: svn commit: r355137 - head/sys/vm

2019-12-03 Thread Ryan Libby
On Tue, Dec 3, 2019 at 1:12 PM Ian Lepore wrote: > > On Tue, 2019-12-03 at 12:59 -0800, Ryan Libby wrote: > > > +* XXX UMA_ZONE_OFFPAGE. > > All over freebsd we have cryptic XXX comments that have no meaning to > anyone except whoever wrote them (and, I suspect, no meaning to those > peopl

Re: svn commit: r355137 - head/sys/vm

2019-12-03 Thread Ian Lepore
On Tue, 2019-12-03 at 12:59 -0800, Ryan Libby wrote: > > +* XXX UMA_ZONE_OFFPAGE. All over freebsd we have cryptic XXX comments that have no meaning to anyone except whoever wrote them (and, I suspect, no meaning to those people either after a couple months have elapsed). To the degree th

Re: svn commit: r355137 - head/sys/vm

2019-12-03 Thread Ryan Libby
On Tue, Dec 3, 2019 at 12:43 PM Gleb Smirnoff wrote: > > Ryan, > > On Wed, Nov 27, 2019 at 07:49:56PM +, Ryan Libby wrote: > R> Author: rlibby > R> Date: Wed Nov 27 19:49:55 2019 > R> New Revision: 355137 > R> URL: https://svnweb.freebsd.org/changeset/base/355137 > R> > R> Log: > R> uma: t

Re: svn commit: r355137 - head/sys/vm

2019-12-03 Thread Gleb Smirnoff
Ryan, On Wed, Nov 27, 2019 at 07:49:56PM +, Ryan Libby wrote: R> Author: rlibby R> Date: Wed Nov 27 19:49:55 2019 R> New Revision: 355137 R> URL: https://svnweb.freebsd.org/changeset/base/355137 R> R> Log: R> uma: trash memory when ctor/dtor supplied too R> R> On INVARIANTS kernels,

svn commit: r355137 - head/sys/vm

2019-11-27 Thread Ryan Libby
Author: rlibby Date: Wed Nov 27 19:49:55 2019 New Revision: 355137 URL: https://svnweb.freebsd.org/changeset/base/355137 Log: uma: trash memory when ctor/dtor supplied too On INVARIANTS kernels, UMA has a use-after-free detection mechanism. This mechanism previously required that all of t