Author: rmacklem
Date: Mon Feb 17 19:32:54 2020
New Revision: 358036
URL: https://svnweb.freebsd.org/changeset/base/358036

Log:
  MFC: r357149
  Fix a crash in the NFSv4 server.
  
  The PR reported a crash that occurred when a file was removed while
  client(s) were actively doing lock operations on it.
  Since nfsvno_getvp() will return NULL when the file does not exist,
  the bug was obvious and easy to fix via this patch. It is a little
  surprising that this wasn't found sooner, but I guess the above
  case rarely occurs.
  
  PR:           242768

Modified:
  stable/12/sys/fs/nfsserver/nfs_nfsdstate.c
Directory Properties:
  stable/12/   (props changed)

Modified: stable/12/sys/fs/nfsserver/nfs_nfsdstate.c
==============================================================================
--- stable/12/sys/fs/nfsserver/nfs_nfsdstate.c  Mon Feb 17 19:31:34 2020        
(r358035)
+++ stable/12/sys/fs/nfsserver/nfs_nfsdstate.c  Mon Feb 17 19:32:54 2020        
(r358036)
@@ -1555,7 +1555,8 @@ nfsrv_freeallnfslocks(struct nfsstate *stp, vnode_t vp
                                tvp = NULL;
                        else if (vp == NULL && cansleep != 0) {
                                tvp = nfsvno_getvp(&lfp->lf_fh);
-                               NFSVOPUNLOCK(tvp, 0);
+                               if (tvp != NULL)
+                                       NFSVOPUNLOCK(tvp, 0);
                        } else
                                tvp = vp;
                        gottvp = 1;
_______________________________________________
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Reply via email to