Re: svn commit: r360068 - in head/sys: kern net sys

2020-04-21 Thread Kristof Provost
On 21 Apr 2020, at 4:34, Kyle Evans wrote: On Mon, Apr 20, 2020 at 9:14 PM Kyle Evans wrote: On Mon, Apr 20, 2020 at 8:15 PM Eric van Gyzen wrote: + sz = asprintf(, M_TEMP, "%s-%s-%s", uuid, if_name(ifp), + jailname); + if (sz < 0) { + /* Fall back to a random mac

Re: svn commit: r360068 - in head/sys: kern net sys

2020-04-20 Thread Kyle Evans
On Mon, Apr 20, 2020 at 9:14 PM Kyle Evans wrote: > > On Mon, Apr 20, 2020 at 8:15 PM Eric van Gyzen wrote: > > > > + sz = asprintf(, M_TEMP, "%s-%s-%s", uuid, if_name(ifp), > > + jailname); > > + if (sz < 0) { > > + /* Fall back to a random mac address. */ >

Re: svn commit: r360068 - in head/sys: kern net sys

2020-04-20 Thread Kyle Evans
On Mon, Apr 20, 2020 at 8:15 PM Eric van Gyzen wrote: > > + sz = asprintf(, M_TEMP, "%s-%s-%s", uuid, if_name(ifp), > + jailname); > + if (sz < 0) { > + /* Fall back to a random mac address. */ > >>> > >>> > >>> I was wondering if it would be valuable to give

Re: svn commit: r360068 - in head/sys: kern net sys

2020-04-20 Thread Eric van Gyzen
+ sz = asprintf(, M_TEMP, "%s-%s-%s", uuid, if_name(ifp), + jailname); + if (sz < 0) { + /* Fall back to a random mac address. */ I was wondering if it would be valuable to give this fall back something like: printf("%s: unable to create fixed

Re: svn commit: r360068 - in head/sys: kern net sys

2020-04-19 Thread Shawn Webb
On Sun, Apr 19, 2020 at 04:19:06PM +0200, Kristof Provost wrote: > On 19 Apr 2020, at 15:33, Ronald Klop wrote: > > On Sat, 18 Apr 2020 09:50:30 +0200, Kristof Provost > > wrote: > > > > > Author: kp > > > Date: Sat Apr 18 07:50:30 2020 > > > New Revision: 360068 > > > URL:

Re: svn commit: r360068 - in head/sys: kern net sys

2020-04-19 Thread Kristof Provost
On 19 Apr 2020, at 15:33, Ronald Klop wrote: On Sat, 18 Apr 2020 09:50:30 +0200, Kristof Provost wrote: Author: kp Date: Sat Apr 18 07:50:30 2020 New Revision: 360068 URL: https://svnweb.freebsd.org/changeset/base/360068 Log: ethersubr: Make the mac address generation more robust If we

Re: svn commit: r360068 - in head/sys: kern net sys

2020-04-19 Thread Ronald Klop
Nice feature. A question below. On Sat, 18 Apr 2020 09:50:30 +0200, Kristof Provost wrote: Author: kp Date: Sat Apr 18 07:50:30 2020 New Revision: 360068 URL: https://svnweb.freebsd.org/changeset/base/360068 Log: ethersubr: Make the mac address generation more robust If we create two

svn commit: r360068 - in head/sys: kern net sys

2020-04-18 Thread Kristof Provost
Author: kp Date: Sat Apr 18 07:50:30 2020 New Revision: 360068 URL: https://svnweb.freebsd.org/changeset/base/360068 Log: ethersubr: Make the mac address generation more robust If we create two (vnet) jails and create a bridge interface in each we end up with the same mac address on both