svn commit: r205115 - head/sys/mips/cavium/dev/rgmii

2010-03-12 Thread Juli Mallett
Author: jmallett Date: Sat Mar 13 04:55:47 2010 New Revision: 205115 URL: http://svn.freebsd.org/changeset/base/205115 Log: o) Use octeon_fpa_alloc_phys in a situation in which we don't need a usable pointer, rather than octeon_fpa_alloc. o) Report half duplex status properly. o) Do not

Re: svn commit: r205014 - in head: . sys/amd64/amd64 sys/amd64/conf sys/amd64/include sys/amd64/linux32 sys/compat/freebsd32 sys/compat/ia32 sys/conf sys/fs/procfs sys/ia64/conf sys/ia64/ia64 sys/ia64

2010-03-12 Thread Rui Paulo
On 13 Mar 2010, at 11:53, Carlos A. M. dos Santos wrote: On Fri, Mar 12, 2010 at 10:52 AM, Rui Paulo wrote: On 12 Mar 2010, at 21:36, Carlos A. M. dos Santos wrote: On Thu, Mar 11, 2010 at 11:49 AM, Nathan Whitehorn wrote: Author: nwhitehorn Date: Thu Mar 11 14:49:06 2010 New Revision:

svn commit: r205113 - head/lib

2010-03-12 Thread Warner Losh
Author: imp Date: Sat Mar 13 03:06:48 2010 New Revision: 205113 URL: http://svn.freebsd.org/changeset/base/205113 Log: Make this conform to the other top-level Makefile subdir listings with one file per line. Suggested by: bde Modified: head/lib/Makefile Modified: head/lib/Makefile ==

Re: svn commit: r205014 - in head: . sys/amd64/amd64 sys/amd64/conf sys/amd64/include sys/amd64/linux32 sys/compat/freebsd32 sys/compat/ia32 sys/conf sys/fs/procfs sys/ia64/conf sys/ia64/ia64 sys/ia6

2010-03-12 Thread Carlos A. M. dos Santos
On Fri, Mar 12, 2010 at 10:52 AM, Rui Paulo wrote: > > On 12 Mar 2010, at 21:36, Carlos A. M. dos Santos wrote: > >> On Thu, Mar 11, 2010 at 11:49 AM, Nathan Whitehorn >> wrote: >>> >>> Author: nwhitehorn >>> Date: Thu Mar 11 14:49:06 2010 >>> New Revision: 205014 >>> URL: http://svn.freebsd.org/

svn commit: r205112 - head/lib/csu/mips

2010-03-12 Thread Juli Mallett
Author: jmallett Date: Sat Mar 13 02:10:20 2010 New Revision: 205112 URL: http://svn.freebsd.org/changeset/base/205112 Log: Fix spelling of noreorder. Modified: head/lib/csu/mips/crti.S Modified: head/lib/csu/mips/crti.S ===

svn commit: r205108 - head/lib/libc/string

2010-03-12 Thread Xin LI
Author: delphij Date: Sat Mar 13 00:15:06 2010 New Revision: 205108 URL: http://svn.freebsd.org/changeset/base/205108 Log: Correct bugs fixed but not merged from my own tree. Pointy hat to:delphij MFC after:1 month Modified: head/lib/libc/string/strlen.c Modified: head/lib

svn commit: r205105 - head/tools/regression/bin/sh/expansion

2010-03-12 Thread Jilles Tjoelker
Author: jilles Date: Fri Mar 12 23:23:46 2010 New Revision: 205105 URL: http://svn.freebsd.org/changeset/base/205105 Log: sh: Add tests for " and $ inside `. Added: head/tools/regression/bin/sh/expansion/cmdsubst2.0 (contents, props changed) Added: head/tools/regression/bin/sh/expansion/cm

svn commit: r205104 - in head/sys: dev/xen/netback netinet netinet6

2010-03-12 Thread Randall Stewart
Author: rrs Date: Fri Mar 12 22:58:52 2010 New Revision: 205104 URL: http://svn.freebsd.org/changeset/base/205104 Log: The proper fix for the delayed SCTP checksum is to have the delayed function take an argument as to the offset to the SCTP header. This allows it to work for V4 and V6. Th

svn commit: r205103 - head/sys/arm/conf

2010-03-12 Thread Bernd Walter
Author: ticso Date: Fri Mar 12 22:39:35 2010 New Revision: 205103 URL: http://svn.freebsd.org/changeset/base/205103 Log: fix type in comment Modified: head/sys/arm/conf/BWCT.hints Modified: head/sys/arm/conf/BWCT.hints =

svn commit: r205102 - head/sys/dev/agp

2010-03-12 Thread Robert Noland
Author: rnoland Date: Fri Mar 12 21:34:23 2010 New Revision: 205102 URL: http://svn.freebsd.org/changeset/base/205102 Log: Add support of Intel Pineview chips, aka IGD. MFC after:3 days Modified: head/sys/dev/agp/agp_i810.c Modified: head/sys/dev/agp/agp_i810.c =

svn commit: r205100 - head/lib/libc/string

2010-03-12 Thread Xin LI
Author: delphij Date: Fri Mar 12 21:15:35 2010 New Revision: 205100 URL: http://svn.freebsd.org/changeset/base/205100 Log: Follow up commit to reindent the code. MFC after:1 month Modified: head/lib/libc/string/strlen.c Modified: head/lib/libc/string/strlen.c ===

svn commit: r205099 - head/lib/libc/string

2010-03-12 Thread Xin LI
Author: delphij Date: Fri Mar 12 21:14:56 2010 New Revision: 205099 URL: http://svn.freebsd.org/changeset/base/205099 Log: Two optimizations to MI strlen(3) inspired by David S. Miller's blog posting [1]. - Use word-sized test for unaligned pointer before working the hard way.

Re: svn commit: r205024 - head/sys/net

2010-03-12 Thread M. Warner Losh
julian> probably should add a flag that means "we have media state" julian> and if it is not set, assume it is always on. qing> That's a good idea. I will take your approach. I do too. While I have many of the older cards that don't support media detect (because the chips don't report that info)

svn commit: r205097 - head/sys/net

2010-03-12 Thread Kip Macy
Author: kmacy Date: Fri Mar 12 19:58:51 2010 New Revision: 205097 URL: http://svn.freebsd.org/changeset/base/205097 Log: flowtable_get_hashkey is only used by a DDB function - move under #ifdef DDB pointed out by jkim@ Modified: head/sys/net/flowtable.c Modified: head/sys/net/flowtable.

svn commit: r205096 - head/sys/dev/agp

2010-03-12 Thread Robert Noland
Author: rnoland Date: Fri Mar 12 19:43:39 2010 New Revision: 205096 URL: http://svn.freebsd.org/changeset/base/205096 Log: Add pci ids for Intel Ironlake chipsets. These behave just like g45 for agp. Tested by:Torfinn Ingolfsen MFC after:3 days Modified: head/sys/dev/ag

svn commit: r205095 - head/sys/net

2010-03-12 Thread Jung-uk Kim
Author: jkim Date: Fri Mar 12 19:42:42 2010 New Revision: 205095 URL: http://svn.freebsd.org/changeset/base/205095 Log: Fix a style(9) nit. Modified: head/sys/net/bpf.c Modified: head/sys/net/bpf.c == --- head/sys/ne

Re: svn commit: r205024 - head/sys/net

2010-03-12 Thread Robert N. M. Watson
On Mar 12, 2010, at 6:56 PM, Qing Li wrote: > Right now I like to implement Robert's suggestion of using if_capabilities > field. I'd like to create a new flag, IFCAP_LINKSTATE_NOTIFY flag. > The routing decision will check against the if_link_state if this bit > is set. > > Only a handful of dr

svn commit: r205093 - head/sys/net

2010-03-12 Thread Kip Macy
Author: kmacy Date: Fri Mar 12 19:26:45 2010 New Revision: 205093 URL: http://svn.freebsd.org/changeset/base/205093 Log: re-update copyright to 2010 pointed out by danfe@ Modified: head/sys/net/flowtable.c Modified: head/sys/net/flowtable.c =

svn commit: r205092 - head/sys/net

2010-03-12 Thread Jung-uk Kim
Author: jkim Date: Fri Mar 12 19:14:58 2010 New Revision: 205092 URL: http://svn.freebsd.org/changeset/base/205092 Log: Tidy up callout for select(2) and read timeout. - Add a missing callout_drain(9) before the descriptor deallocation.[1] - Prefer callout_init_mtx(9) over callout_init(9)

Re: svn commit: r205024 - head/sys/net

2010-03-12 Thread Qing Li
> > We've got LINK_STATE_UNKNOWN, we can just initialize if_link_state to > this value in ether_ifattach(). And Qing should treat this value as > LINK_STATE_UP in routing decision until better times. > Thanks everyone for your input. I generally try to avoid overloading a variable to have more th

svn commit: r205091 - head/sys/dev/msk

2010-03-12 Thread Pyun YongHyeon
Author: yongari Date: Fri Mar 12 18:41:41 2010 New Revision: 205091 URL: http://svn.freebsd.org/changeset/base/205091 Log: Implement Rx checksum offloading for Yukon EC, Yukon Ultra, Yukon FE and Yukon Ultra2. These controllers provide very simple checksum computation mechanism and it requir

svn commit: r205090 - head/sys/dev/bge

2010-03-12 Thread Pyun YongHyeon
Author: yongari Date: Fri Mar 12 18:18:04 2010 New Revision: 205090 URL: http://svn.freebsd.org/changeset/base/205090 Log: Reorder interrupt handler a bit such that producer/consumer index of status block is read first before acknowledging the interrupts. Otherwise bge(4) may get stale statu

svn commit: r205089 - head/usr.bin/unifdef

2010-03-12 Thread Tony Finch
Author: fanf Date: Fri Mar 12 17:55:29 2010 New Revision: 205089 URL: http://svn.freebsd.org/changeset/base/205089 Log: Update to upstream version 2.3 Add -V (display version) and -S (list controlling symbols per #if with nesting information) options, and improve unifdefall debug output.

Re: svn commit: r205024 - head/sys/net

2010-03-12 Thread M. Warner Losh
In message: Juli Mallett writes: : On Thu, Mar 11, 2010 at 15:30, Qing Li wrote: : >> : >> A couple of questions: : >> : >> (1) It used to be the case that quite a few interface drivers and types : >> didn't have a notion of "link up" -- especially older ethernet devices.  Do : >> th

Re: svn commit: r205014 - in head: . sys/amd64/amd64 sys/amd64/conf sys/amd64/include sys/amd64/linux32 sys/compat/freebsd32 sys/compat/ia32 sys/conf sys/fs/procfs sys/ia64/conf sys/ia64/ia64 sys/ia64

2010-03-12 Thread David O'Brien
On Fri, Mar 12, 2010 at 10:52:27PM +0900, Rui Paulo wrote: > On 12 Mar 2010, at 21:36, Carlos A. M. dos Santos wrote: >> On Thu, Mar 11, 2010 at 11:49 AM, Nathan Whitehorn >> wrote: >>> Author: nwhitehorn >>> Date: Thu Mar 11 14:49:06 2010 >>> New Revision: 205014 >>> URL: http://svn.freebsd.org/c

Re: svn commit: r205024 - head/sys/net

2010-03-12 Thread Gleb Smirnoff
On Thu, Mar 11, 2010 at 11:15:21PM -0800, Julian Elischer wrote: J> Juli Mallett wrote: J> > On Thu, Mar 11, 2010 at 15:39, Qing Li wrote: J> >> I guess it's a good time to clean things up. The if_link_state code has been J> >> around for quite some time, either it be fully utilized or not be the

Re: svn commit: r205014 - in head: . sys/amd64/amd64 sys/amd64/conf sys/amd64/include sys/amd64/linux32 sys/compat/freebsd32 sys/compat/ia32 sys/conf sys/fs/procfs sys/ia64/conf sys/ia64/ia64 sys/ia64

2010-03-12 Thread Alexander Leidinger
Quoting Nathan Whitehorn (from Fri, 12 Mar 2010 08:19:00 -0600): This name was picked for the following reasons, after discussion with several others: it is analogous to the existing COMPAT_LINUX32, the Datapoint: COMPAT_LINUX is native (64bit on 64bit arch, 32bit on 32bit arch) emulati

svn commit: r205083 - in head: sys/netgraph usr.bin/netstat

2010-03-12 Thread Gleb Smirnoff
Author: glebius Date: Fri Mar 12 15:04:59 2010 New Revision: 205083 URL: http://svn.freebsd.org/changeset/base/205083 Log: Now fix functionality of 'netstat -f netgraph' that hasn't worked starting from netgraph import in 1999. netstat(8) used pointer to node as node address, oops. That d

svn commit: r205082 - head/sys/netgraph

2010-03-12 Thread Gleb Smirnoff
Author: glebius Date: Fri Mar 12 14:51:42 2010 New Revision: 205082 URL: http://svn.freebsd.org/changeset/base/205082 Log: Fix 'netstat -f netgraph', which I had broken in r163463 ling time ago in 2006. This linked list is actually needed for userland. PR: kern/140446 Submitte

Re: svn commit: r205014 - in head: . sys/amd64/amd64 sys/amd64/conf sys/amd64/include sys/amd64/linux32 sys/compat/freebsd32 sys/compat/ia32 sys/conf sys/fs/procfs sys/ia64/conf sys/ia64/ia64 sys/ia64

2010-03-12 Thread Alexander Leidinger
Quoting Rui Paulo (from Fri, 12 Mar 2010 22:52:27 +0900): On 12 Mar 2010, at 21:36, Carlos A. M. dos Santos wrote: On Thu, Mar 11, 2010 at 11:49 AM, Nathan Whitehorn wrote: Author: nwhitehorn Date: Thu Mar 11 14:49:06 2010 New Revision: 205014 URL: http://svn.freebsd.org/changeset/base/205

Re: svn commit: r205014 - in head: . sys/amd64/amd64 sys/amd64/conf sys/amd64/include sys/amd64/linux32 sys/compat/freebsd32 sys/compat/ia32 sys/conf sys/fs/procfs sys/ia64/conf sys/ia64/ia64 sys/ia64

2010-03-12 Thread Nathan Whitehorn
Dag-Erling Smørgrav wrote: Rui Paulo writes: Carlos A. M. dos Santos writes: COMPAT_FREEBSD32 is an unfortunate choice. It can be easily interpreted as "compatible with FreeBSD 3.2". Something like "COMPAT_32BIT" would be more meaningful. This is unlikely to be changed and ema

Re: svn commit: r205014 - in head: . sys/amd64/amd64 sys/amd64/conf sys/amd64/include sys/amd64/linux32 sys/compat/freebsd32 sys/compat/ia32 sys/conf sys/fs/procfs sys/ia64/conf sys/ia64/ia64 sys/ia64

2010-03-12 Thread Dag-Erling Smørgrav
Rui Paulo writes: > Carlos A. M. dos Santos writes: > > COMPAT_FREEBSD32 is an unfortunate choice. It can be easily > > interpreted as "compatible with FreeBSD 3.2". Something like > > "COMPAT_32BIT" would be more meaningful. > This is unlikely to be changed and emailing the committer who provide

Re: svn commit: r205014 - in head: . sys/amd64/amd64 sys/amd64/conf sys/amd64/include sys/amd64/linux32 sys/compat/freebsd32 sys/compat/ia32 sys/conf sys/fs/procfs sys/ia64/conf sys/ia64/ia64 sys/ia64

2010-03-12 Thread Rui Paulo
On 12 Mar 2010, at 21:36, Carlos A. M. dos Santos wrote: On Thu, Mar 11, 2010 at 11:49 AM, Nathan Whitehorn wrote: Author: nwhitehorn Date: Thu Mar 11 14:49:06 2010 New Revision: 205014 URL: http://svn.freebsd.org/changeset/base/205014 Log: Provide groundwork for 32-bit binary compatibility

Re: svn commit: r205079 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2010-03-12 Thread Dag-Erling Smørgrav
Pawel Jakub Dawidek writes: > Grr, it was bug 6920880. Unfortunately no forced commits in subversion. Forced commits are possible, as discussed on -developers a few months ago. DES -- Dag-Erling Smørgrav - d...@des.no ___ svn-src-head@freebsd.org mail

svn commit: r205080 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2010-03-12 Thread Pawel Jakub Dawidek
Author: pjd Date: Fri Mar 12 13:36:58 2010 New Revision: 205080 URL: http://svn.freebsd.org/changeset/base/205080 Log: Force commit to correct Bug ID: Obtained from:OpenSolaris, Bug ID 6920880 Modified: head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dbuf.c Modified: head/sy

Re: svn commit: r205024 - head/sys/net

2010-03-12 Thread Bruce Simpson
Any objections to making AF_NETLINK Foundation proposal public? Might help FreeBSD get out of the niche a bit more; energy quantum wells are never great. ___ svn-src-head@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-head

Re: svn commit: r205014 - in head: . sys/amd64/amd64 sys/amd64/conf sys/amd64/include sys/amd64/linux32 sys/compat/freebsd32 sys/compat/ia32 sys/conf sys/fs/procfs sys/ia64/conf sys/ia64/ia64 sys/ia6

2010-03-12 Thread Carlos A. M. dos Santos
On Thu, Mar 11, 2010 at 11:49 AM, Nathan Whitehorn wrote: > Author: nwhitehorn > Date: Thu Mar 11 14:49:06 2010 > New Revision: 205014 > URL: http://svn.freebsd.org/changeset/base/205014 > > Log: >  Provide groundwork for 32-bit binary compatibility on non-x86 platforms, >  for upcoming 64-bit Pow

Re: svn commit: r205079 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2010-03-12 Thread Pawel Jakub Dawidek
On Fri, Mar 12, 2010 at 12:07:21PM +, Pawel Jakub Dawidek wrote: > Author: pjd > Date: Fri Mar 12 12:07:21 2010 > New Revision: 205079 > URL: http://svn.freebsd.org/changeset/base/205079 > > Log: > Remove bogus assertion. > > Reported by:Johan Ström > Obtained from: Open

svn commit: r205079 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2010-03-12 Thread Pawel Jakub Dawidek
Author: pjd Date: Fri Mar 12 12:07:21 2010 New Revision: 205079 URL: http://svn.freebsd.org/changeset/base/205079 Log: Remove bogus assertion. Reported by: Johan Ström Obtained from:OpenSolaris, Bug ID 6827260 MFC after:1 week Modified: head/sys/cddl/contrib/opensolaris

svn commit: r205078 - in head/contrib/bsnmp: gensnmptree snmpd

2010-03-12 Thread Ulrich Spoerlein
Author: uqs Date: Fri Mar 12 11:05:37 2010 New Revision: 205078 URL: http://svn.freebsd.org/changeset/base/205078 Log: Fix typo in macro name and macro usage. Found by: make manlint Reviewed by: ru Approved by: harti, philip (mentor) Modified: head/contrib/bsnmp/gensnmptree/gen

svn commit: r205077 - head/sys/net

2010-03-12 Thread Qing Li
Author: qingli Date: Fri Mar 12 10:24:58 2010 New Revision: 205077 URL: http://svn.freebsd.org/changeset/base/205077 Log: The flow-table module retrieves the destination and source address as well as the transport protocol port information from the outbound packets. The routing code is gener

svn commit: r205076 - in head: games/pom lib/libc/compat-43 lib/libgssapi lib/libkvm lib/librpcsec_gss lib/msun/man libexec/tftpd sbin/quotacheck share/man/man4 share/man/man9 usr.bin/tar usr.sbin/...

2010-03-12 Thread Ulrich Spoerlein
Author: uqs Date: Fri Mar 12 10:01:06 2010 New Revision: 205076 URL: http://svn.freebsd.org/changeset/base/205076 Log: Fix several typos in macros or macro misusage. Found by: make manlint Reviewed by: ru Approved by: philip (mentor) Modified: head/games/pom/pom.6 head/lib/li

Re: svn commit: r205024 - head/sys/net

2010-03-12 Thread Robert N. M. Watson
On Mar 12, 2010, at 8:44 AM, Julian Elischer wrote: > I'm confused about Julian's proposal because it seems to me that we > already know when a driver hasn't set or is unable to determine the link > state: it will (should) be set to LINK_STATE_UNKNOWN by default. > > the question i

Re: svn commit: r205024 - head/sys/net

2010-03-12 Thread Julian Elischer
Julian Elischer wrote: Robert N. M. Watson wrote: Today, we support three link state values: 170 /* 171 * Values for if_link_state. 172 */ 173 #define LINK_STATE_UNKNOWN 0 /* link invalid/unknown */ 174 #define LINK_STATE_DOWN 1 /* link is down */ 175 #define LINK_

Re: svn commit: r205024 - head/sys/net

2010-03-12 Thread Julian Elischer
Robert N. M. Watson wrote: On Mar 12, 2010, at 8:30 AM, Qing Li wrote: I believe what Julian means is the following: 1. in the driver, I do this ifp->if_flags |= IFF_KNOWS_LINK_STATE; 2. In route.h, I do this if (ifp->flags & IFF_KNOWS_LINK_STATE) && (ifp->if_link_state == LINK_STATE

Re: svn commit: r205024 - head/sys/net

2010-03-12 Thread Robert N. M. Watson
On Mar 12, 2010, at 8:30 AM, Qing Li wrote: > I believe what Julian means is the following: > > 1. in the driver, I do this > > ifp->if_flags |= IFF_KNOWS_LINK_STATE; > > 2. In route.h, I do this > >if (ifp->flags & IFF_KNOWS_LINK_STATE) && (ifp->if_link_state == > LINK_STATE_UP) >

Re: svn commit: r205024 - head/sys/net

2010-03-12 Thread Qing Li
Nope, I meant Julian, and what he proposed, and if I understood correctly, is the simplest approach and easily done. -- Qing On Fri, Mar 12, 2010 at 12:29 AM, Robert N. M. Watson wrote: > > On Mar 12, 2010, at 8:11 AM, Qing Li wrote: > >> I like Julian's suggestion because it is simple and very

Re: svn commit: r205024 - head/sys/net

2010-03-12 Thread Qing Li
I believe what Julian means is the following: 1. in the driver, I do this ifp->if_flags |= IFF_KNOWS_LINK_STATE; 2. In route.h, I do this if (ifp->flags & IFF_KNOWS_LINK_STATE) && (ifp->if_link_state == LINK_STATE_UP) return 1; -- Qing On Fri, Mar 12, 2010 at 12:26 AM, Robert

Re: svn commit: r205024 - head/sys/net

2010-03-12 Thread Robert N. M. Watson
On Mar 12, 2010, at 8:11 AM, Qing Li wrote: > I like Julian's suggestion because it is simple and very low risk. > And there isn't a need to check for interface type any more. > Here is why: Re-reading this e-mail: perhaps you mean Juli, not Julian? Robert > > 1. The interfaces that are popul

Re: svn commit: r205024 - head/sys/net

2010-03-12 Thread Juli Mallett
On Fri, Mar 12, 2010 at 00:11, Qing Li wrote: > I like Julian's suggestion because it is simple and very low risk. > And there isn't a need to check for interface type any more. > Here is why: For actual link state, you can already see whether a driver is in UNKNOWN state, like: %%% /* * Values

Re: svn commit: r205024 - head/sys/net

2010-03-12 Thread Robert N. M. Watson
On Mar 12, 2010, at 8:11 AM, Qing Li wrote: > I like Julian's suggestion because it is simple and very low risk. > And there isn't a need to check for interface type any more. > Here is why: > > 1. The interfaces that are popular and modern are already supporting >link_state. So for these dr

Re: svn commit: r205024 - head/sys/net

2010-03-12 Thread Qing Li
I like Julian's suggestion because it is simple and very low risk. And there isn't a need to check for interface type any more. Here is why: 1. The interfaces that are popular and modern are already supporting link_state. So for these drivers, and there are just a few, I will go set its if

svn commit: r205075 - head/sys/netinet6

2010-03-12 Thread Randall Stewart
Author: rrs Date: Fri Mar 12 08:10:30 2010 New Revision: 205075 URL: http://svn.freebsd.org/changeset/base/205075 Log: With the recent change of the sctp checksum to support offload, no delayed checksum was added to the ip6 output code. This causes cards that do not support SCTP checksum of

Re: svn commit: r205024 - head/sys/net

2010-03-12 Thread Robert N. M. Watson
On Mar 12, 2010, at 7:52 AM, Qing Li wrote: >> Is there any way we can pick up via an assertion that an interface driver >> has failed to implement this functionality? This has never been a historic >> requirement, so I suspect there are a lot of drivers floating around that >> fail to meet th