svn commit: r218986 - head/etc/rc.d

2011-02-23 Thread Doug Barton
Author: dougb Date: Thu Feb 24 06:28:48 2011 New Revision: 218986 URL: http://svn.freebsd.org/changeset/base/218986 Log: The new accounting file needs to be 644 so that unprivileged users can use lastcomm(1) Modified: head/etc/rc.d/accounting Modified: head/etc/rc.d/accounting

Re: svn commit: r218984 - head/lib/librt

2011-02-23 Thread Bruce Evans
On Wed, 23 Feb 2011, Dimitry Andric wrote: On 2011-02-23 23:13, Bruce Evans wrote: Now found it easly using gcc -v. gcc -c -v foo.c produces "... /usr/bin/as -o foo.o /var/tmp/whatever.s", but gcc -c -v foo.s produces "... /usr/bin/as -gdwarf2 -o foo.o foo.s". gcc's generation of -gdwarf2 i

Re: svn commit: r218966 - head/sys/vm

2011-02-23 Thread Bruce Evans
On Wed, 23 Feb 2011, Bruce Cran wrote: On Thu, 2011-02-24 at 08:23 +1100, Bruce Evans wrote: The bug seems to have been overflow in this calculation. [swap_bcount * SWAP_META_PAGES * n / ] I've attached a patch which changes 'n' to be of type vm_ooffset_t. I think this should fix the overflo

Re: svn commit: r218984 - head/lib/librt

2011-02-23 Thread Dimitry Andric
On 2011-02-23 23:13, Bruce Evans wrote: Now found it easly using gcc -v. gcc -c -v foo.c produces "... /usr/bin/as -o foo.o /var/tmp/whatever.s", but gcc -c -v foo.s produces "... /usr/bin/as -gdwarf2 -o foo.o foo.s". gcc's generation of -gdwarf2 is inconsistent with itself. Do we use a nonsta

Re: svn commit: r218984 - head/lib/librt

2011-02-23 Thread Dimitry Andric
On 2011-02-23 23:04, Bruce Evans wrote: Hard-coded -g is a style bug, but I wonder if this works even with -g in DEBUG_FLAGS. Yes, it works, I tested it. The issue is that bsd.lib.mk contains this fragment: .if defined(WITH_CTF) .undef NO_CTF .endif .if defined(DEBUG_FLAGS) CFLAGS+= ${DEBUG_

Re: svn commit: r218984 - head/lib/librt

2011-02-23 Thread Bruce Evans
PS: On Thu, 24 Feb 2011, Bruce Evans wrote: This may be related to the bug that -g is broken if the compilation is via an intermediate asm file: "cc -g -o foo foo.c" != "cc -g -S foo.c; cc -g -o foo foo.s" The former works, but the latter gives: % Script started on Wed Feb 23 21:47:

Re: svn commit: r218966 - head/sys/vm

2011-02-23 Thread Bruce Cran
On Thu, 2011-02-24 at 08:23 +1100, Bruce Evans wrote: > The bug seems to have been overflow in this calculation. `start' and > `end' have type vm_offset_t and large style bugs (missing prefixes in > their names) so they are hard to grep for. When n is 32 bits int and > PAGE_SIZE is 2**12, the as

Re: svn commit: r218984 - head/lib/librt

2011-02-23 Thread Bruce Evans
On Wed, 23 Feb 2011, Dimitry Andric wrote: Log: Fix the 32-bit build stage on amd64 when WITH_CTF is enabled. It seems ctfconvert will corrupt object files that are compiled with -g, if it is not run with -g itself. To fix it, remove -g from CFLAGS in lib/librt/Makefile. If you need to c

svn commit: r218985 - head/sys/compat/ndis

2011-02-23 Thread Bruce Cran
Author: brucec Date: Wed Feb 23 21:45:28 2011 New Revision: 218985 URL: http://svn.freebsd.org/changeset/base/218985 Log: Use the cprd_mem field when setting the start and length for a memory resource - the layout of cprd_port is identical but using cprd_mem makes the code easier to understa

Re: svn commit: r218966 - head/sys/vm

2011-02-23 Thread Bruce Evans
On Wed, 23 Feb 2011, Bruce Cran wrote: Log: Calculate and return the count in vmspace_swap_count as a vm_offset_t instead of an int to avoid overflow. While here, clean up some style(9) issues. vm_offset_t should not be abused to hold a count. PR:kern/152200 Reviewed by:

Re: svn commit: r218984 - head/lib/librt

2011-02-23 Thread Jung-uk Kim
On Wednesday 23 February 2011 04:17 pm, Dimitry Andric wrote: > Author: dim > Date: Wed Feb 23 21:17:38 2011 > New Revision: 218984 > URL: http://svn.freebsd.org/changeset/base/218984 > > Log: > Fix the 32-bit build stage on amd64 when WITH_CTF is enabled. It > seems ctfconvert will corrupt obje

Re: svn commit: r218967 - head/sys/kern

2011-02-23 Thread Alexander Best
On Thu Feb 24 11, Bruce Evans wrote: > On Wed, 23 Feb 2011, Alexander Best wrote: > > >On Wed Feb 23 11, Kostik Belousov wrote: > >>On Wed, Feb 23, 2011 at 12:56:25PM +, John Baldwin wrote: > >>>... > >>>Log: > >>> Fix off-by-one error in check against max_threads_per_proc. > >>> > >>> Submi

svn commit: r218984 - head/lib/librt

2011-02-23 Thread Dimitry Andric
Author: dim Date: Wed Feb 23 21:17:38 2011 New Revision: 218984 URL: http://svn.freebsd.org/changeset/base/218984 Log: Fix the 32-bit build stage on amd64 when WITH_CTF is enabled. It seems ctfconvert will corrupt object files that are compiled with -g, if it is not run with -g itself.

Re: svn commit: r218967 - head/sys/kern

2011-02-23 Thread Bruce Evans
On Wed, 23 Feb 2011, Alexander Best wrote: On Wed Feb 23 11, Kostik Belousov wrote: On Wed, Feb 23, 2011 at 12:56:25PM +, John Baldwin wrote: ... Log: Fix off-by-one error in check against max_threads_per_proc. Submitted by: arundel MFC after:1 week Modified: head/sys/kern/ke

svn commit: r218976 - head/sys/kern

2011-02-23 Thread Sergey Kandaurov
Author: pluknet Date: Wed Feb 23 18:22:40 2011 New Revision: 218976 URL: http://svn.freebsd.org/changeset/base/218976 Log: Clean up the now unused #include statement. Approved by: kib (mentor) MFC after:1 week X-MFC with: r218972 Modified: head/sys/kern/kern_thread.c Modified

svn commit: r218975 - head/usr.sbin/pc-sysinstall/backend-query

2011-02-23 Thread Josh Paetzel
Author: jpaetzel Date: Wed Feb 23 17:52:26 2011 New Revision: 218975 URL: http://svn.freebsd.org/changeset/base/218975 Log: Alter comment to reflect change in code. Try atacontrol if camcontrol fails. Approved by: kib (mentor, implicit) Modified: head/usr.sbin/pc-sysinstall/backend-qu

Re: svn commit: r218974 - in head/sys/boot: common efi/libefi

2011-02-23 Thread Bruce Cran
On Wed, 2011-02-23 at 17:17 +, Bruce Cran wrote: > Author: brucec > Date: Wed Feb 23 17:17:05 2011 > New Revision: 218974 > URL: http://svn.freebsd.org/changeset/base/218974 > > Log: > Handle memory allocation failures in include(). > > if (EFI_ERROR(status)) > - printf

svn commit: r218974 - in head/sys/boot: common efi/libefi

2011-02-23 Thread Bruce Cran
Author: brucec Date: Wed Feb 23 17:17:05 2011 New Revision: 218974 URL: http://svn.freebsd.org/changeset/base/218974 Log: Handle memory allocation failures in include(). PR: i386/85652 Submitted by: Ben Thomas MFC after:3 days Modified: head/sys/boot/common/interp.c

Re: svn commit: r218967 - head/sys/kern

2011-02-23 Thread Alexander Best
On Wed Feb 23 11, Hans Petter Selasky wrote: > On Wednesday 23 February 2011 14:57:34 Alexander Best wrote: > > On Wed Feb 23 11, Kostik Belousov wrote: > > > On Wed, Feb 23, 2011 at 12:56:25PM +, John Baldwin wrote: > > > > Author: jhb > > > > Date: Wed Feb 23 12:56:25 2011 > > > > New Revisio

Re: svn commit: r218967 - head/sys/kern

2011-02-23 Thread Alexander Best
On Wed Feb 23 11, Kostik Belousov wrote: > On Wed, Feb 23, 2011 at 01:57:34PM +, Alexander Best wrote: > > On Wed Feb 23 11, Kostik Belousov wrote: > > > On Wed, Feb 23, 2011 at 12:56:25PM +, John Baldwin wrote: > > > > Author: jhb > > > > Date: Wed Feb 23 12:56:25 2011 > > > > New Revision

Re: svn commit: r218967 - head/sys/kern

2011-02-23 Thread Hans Petter Selasky
On Wednesday 23 February 2011 14:57:34 Alexander Best wrote: > On Wed Feb 23 11, Kostik Belousov wrote: > > On Wed, Feb 23, 2011 at 12:56:25PM +, John Baldwin wrote: > > > Author: jhb > > > Date: Wed Feb 23 12:56:25 2011 > > > New Revision: 218967 > > > URL: http://svn.freebsd.org/changeset/bas

Re: svn commit: r218967 - head/sys/kern

2011-02-23 Thread Kostik Belousov
On Wed, Feb 23, 2011 at 01:57:34PM +, Alexander Best wrote: > On Wed Feb 23 11, Kostik Belousov wrote: > > On Wed, Feb 23, 2011 at 12:56:25PM +, John Baldwin wrote: > > > Author: jhb > > > Date: Wed Feb 23 12:56:25 2011 > > > New Revision: 218967 > > > URL: http://svn.freebsd.org/changeset/

Re: svn commit: r218967 - head/sys/kern

2011-02-23 Thread Alexander Best
On Wed Feb 23 11, Kostik Belousov wrote: > On Wed, Feb 23, 2011 at 12:56:25PM +, John Baldwin wrote: > > Author: jhb > > Date: Wed Feb 23 12:56:25 2011 > > New Revision: 218967 > > URL: http://svn.freebsd.org/changeset/base/218967 > > > > Log: > > Fix off-by-one error in check against max_th

svn commit: r218973 - head/usr.sbin/bsdinstall/partedit

2011-02-23 Thread Nathan Whitehorn
Author: nwhitehorn Date: Wed Feb 23 13:51:41 2011 New Revision: 218973 URL: http://svn.freebsd.org/changeset/base/218973 Log: Add a catch-all for miscellaneous RAID volumes while seeking a better solution here. It would really help if CAM devices were part of newbus. Modified: head/usr.sbin

svn commit: r218972 - head/sys/kern

2011-02-23 Thread Konstantin Belousov
Author: kib Date: Wed Feb 23 13:50:24 2011 New Revision: 218972 URL: http://svn.freebsd.org/changeset/base/218972 Log: Move the max_threads_per_proc and max_threads_hits variables to the file where they are used. Declare the kern.threads sysctl node at the same location. Since no external u

Re: svn commit: r218967 - head/sys/kern

2011-02-23 Thread John Baldwin
On Wednesday, February 23, 2011 8:12:28 am Kostik Belousov wrote: > On Wed, Feb 23, 2011 at 12:56:25PM +, John Baldwin wrote: > > Author: jhb > > Date: Wed Feb 23 12:56:25 2011 > > New Revision: 218967 > > URL: http://svn.freebsd.org/changeset/base/218967 > > > > Log: > > Fix off-by-one erro

svn commit: r218971 - head/sys/kern

2011-02-23 Thread John Baldwin
Author: jhb Date: Wed Feb 23 13:25:42 2011 New Revision: 218971 URL: http://svn.freebsd.org/changeset/base/218971 Log: Revert previous change, the existing check was correct. Pointy hat to:jhb Modified: head/sys/kern/kern_thr.c Modified: head/sys/kern/kern_thr.c

svn commit: r218970 - in head/sys: compat/linux sys

2011-02-23 Thread John Baldwin
Author: jhb Date: Wed Feb 23 13:23:28 2011 New Revision: 218970 URL: http://svn.freebsd.org/changeset/base/218970 Log: Use umtx_key objects to uniquely identify futexes. Private futexes in different processes that happen to use the same user address in the separate processes will now be tre

svn commit: r218969 - in head/sys: kern sys

2011-02-23 Thread John Baldwin
Author: jhb Date: Wed Feb 23 13:19:14 2011 New Revision: 218969 URL: http://svn.freebsd.org/changeset/base/218969 Log: Expose the umtx_key structure and API to the rest of the kernel. MFC after:3 days Modified: head/sys/kern/kern_umtx.c head/sys/sys/umtx.h Modified: head/sys/kern/

Re: svn commit: r218967 - head/sys/kern

2011-02-23 Thread Kostik Belousov
On Wed, Feb 23, 2011 at 12:56:25PM +, John Baldwin wrote: > Author: jhb > Date: Wed Feb 23 12:56:25 2011 > New Revision: 218967 > URL: http://svn.freebsd.org/changeset/base/218967 > > Log: > Fix off-by-one error in check against max_threads_per_proc. > > Submitted by: arundel >

svn commit: r218968 - head/sys/dev/pci

2011-02-23 Thread John Baldwin
Author: jhb Date: Wed Feb 23 12:58:50 2011 New Revision: 218968 URL: http://svn.freebsd.org/changeset/base/218968 Log: Properly handle BARs bigger than 4G. The '1' was treated as an int causing the size calculation to be truncated to the size of an int (32-bits on all current architectures)

Re: svn commit: r218967 - head/sys/kern

2011-02-23 Thread Alexander Best
On Wed Feb 23 11, John Baldwin wrote: > Author: jhb > Date: Wed Feb 23 12:56:25 2011 > New Revision: 218967 > URL: http://svn.freebsd.org/changeset/base/218967 > > Log: > Fix off-by-one error in check against max_threads_per_proc. thanks a lot. :) > > Submitted by: arundel > MFC a

svn commit: r218967 - head/sys/kern

2011-02-23 Thread John Baldwin
Author: jhb Date: Wed Feb 23 12:56:25 2011 New Revision: 218967 URL: http://svn.freebsd.org/changeset/base/218967 Log: Fix off-by-one error in check against max_threads_per_proc. Submitted by: arundel MFC after:1 week Modified: head/sys/kern/kern_thr.c Modified: head/sys/kern/kern

svn commit: r218966 - head/sys/vm

2011-02-23 Thread Bruce Cran
Author: brucec Date: Wed Feb 23 10:28:37 2011 New Revision: 218966 URL: http://svn.freebsd.org/changeset/base/218966 Log: Calculate and return the count in vmspace_swap_count as a vm_offset_t instead of an int to avoid overflow. While here, clean up some style(9) issues. PR:

svn commit: r218965 - in head: sbin/growfs share/doc/papers/devfs share/doc/psd/23.rpc sys/fs/nullfs sys/libkern sys/net80211 sys/x86/isa usr.bin/tip/tip

2011-02-23 Thread Bruce Cran
Author: brucec Date: Wed Feb 23 09:22:33 2011 New Revision: 218965 URL: http://svn.freebsd.org/changeset/base/218965 Log: Fix typos - remove duplicate "is". PR: docs/154934 Submitted by: Eitan Adler MFC after:3 days Modified: head/sbin/growfs/growfs.c head/share/doc/