Re: svn commit: r223356 - head/sbin/geom/class/part

2011-06-21 Thread Xin LI
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 06/20/11 22:03, Andrey V. Elsukov wrote: On 21.06.2011 8:46, Xin LI wrote: Author: delphij Date: Tue Jun 21 04:46:00 2011 New Revision: 223356 URL: http://svn.freebsd.org/changeset/base/223356 Log: Mod the offset padding by alignment.

Re: svn commit: r223356 - head/sbin/geom/class/part

2011-06-21 Thread Xin LI
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 06/20/11 22:03, Andrey V. Elsukov wrote: I don't think this changeset do anything with mediasize? No, an alignment value of 1 makes offset = 0, which is the intended behavior. Or did I misunderstood the code? Thanks in advance! - --

svn commit: r223358 - head/sys/netinet/ipfw

2011-06-21 Thread Andrey V. Elsukov
Author: ae Date: Tue Jun 21 06:06:47 2011 New Revision: 223358 URL: http://svn.freebsd.org/changeset/base/223358 Log: Do not use SET_HOST_IPLEN() macro for IPv6 packets. PR: kern/157239 MFC after:2 weeks Modified: head/sys/netinet/ipfw/ip_dn_io.c

svn commit: r223359 - head/sys/net

2011-06-21 Thread Bjoern A. Zeeb
Author: bz Date: Tue Jun 21 07:19:03 2011 New Revision: 223359 URL: http://svn.freebsd.org/changeset/base/223359 Log: Garbage collect never used global, sysctl, externs. MFC after:1 week Modified: head/sys/net/route.c head/sys/net/route.h Modified: head/sys/net/route.c

Re: svn commit: r223356 - head/sbin/geom/class/part

2011-06-21 Thread Xin LI
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 06/20/11 23:23, Andrey V. Elsukov wrote: On 21.06.2011 10:04, Xin LI wrote: Mod the offset padding by alignment. Without this change we may pad too much when underlying GEOM object have a zero stripesize. No. In any way offset value

svn commit: r223364 - head/sbin/geom/class/part

2011-06-21 Thread Andrey V. Elsukov
Author: ae Date: Tue Jun 21 10:35:20 2011 New Revision: 223364 URL: http://svn.freebsd.org/changeset/base/223364 Log: When user specifies the bootcode with size smaller than VTOC_BOOTCODE, gpart_write_partcode_vtoc8 does access out of range of allocated memory. Check size of bootcode before

svn commit: r223365 - head/sys/ia64/conf

2011-06-21 Thread Alan Cox
Author: alc Date: Tue Jun 21 12:38:40 2011 New Revision: 223365 URL: http://svn.freebsd.org/changeset/base/223365 Log: Use a non-standard page size that is supported. Modified: head/sys/ia64/conf/NOTES Modified: head/sys/ia64/conf/NOTES

Re: svn commit: r223350 - head/sys/dev/e1000

2011-06-21 Thread John Baldwin
On Monday, June 20, 2011 6:59:29 pm Jack F Vogel wrote: Author: jfv Date: Mon Jun 20 22:59:29 2011 New Revision: 223350 URL: http://svn.freebsd.org/changeset/base/223350 Log: Eliminate some global tuneables in favor of adapter-specific, particular flow control and dma coalesce. Also

Re: svn commit: r222866 - head/sys/x86/x86

2011-06-21 Thread John Baldwin
On Monday, June 20, 2011 7:41:00 pm Jung-uk Kim wrote: My questions to you: a) Why do we care TSC timecounter when it is not invariant where we *know* it is unusable and set to negative quality? What if the user knows they will not enable CPU throttling so for them the TSC is safe? In

Re: svn commit: r223350 - head/sys/dev/e1000

2011-06-21 Thread Guy Helmer
On Jun 21, 2011, at 8:07 AM, John Baldwin wrote: On Monday, June 20, 2011 6:59:29 pm Jack F Vogel wrote: Author: jfv Date: Mon Jun 20 22:59:29 2011 New Revision: 223350 URL: http://svn.freebsd.org/changeset/base/223350 Log: Eliminate some global tuneables in favor of adapter-specific,

Re: svn commit: r222866 - head/sys/x86/x86

2011-06-21 Thread Jung-uk Kim
On Tuesday 21 June 2011 09:10 am, John Baldwin wrote: On Monday, June 20, 2011 7:41:00 pm Jung-uk Kim wrote: My questions to you: a) Why do we care TSC timecounter when it is not invariant where we *know* it is unusable and set to negative quality? What if the user knows they will not

Re: svn commit: r222866 - head/sys/x86/x86

2011-06-21 Thread John Baldwin
On Tuesday, June 21, 2011 11:48:55 am Jung-uk Kim wrote: On Tuesday 21 June 2011 09:10 am, John Baldwin wrote: On Monday, June 20, 2011 7:41:00 pm Jung-uk Kim wrote: My questions to you: a) Why do we care TSC timecounter when it is not invariant where we *know* it is unusable and

Re: svn commit: r223350 - head/sys/dev/e1000

2011-06-21 Thread Jack Vogel
LOL, the old adage is true, you just can't please all the people... :) The way the code now is it assigns a default, but you could still have a loader entry that would change it for all adapters if you wanted to, but ok, if you prefer the older for this. What other globals do you think should be

Re: svn commit: r222866 - head/sys/x86/x86

2011-06-21 Thread Jung-uk Kim
On Tuesday 21 June 2011 11:56 am, John Baldwin wrote: On Tuesday, June 21, 2011 11:48:55 am Jung-uk Kim wrote: On Tuesday 21 June 2011 09:10 am, John Baldwin wrote: On Monday, June 20, 2011 7:41:00 pm Jung-uk Kim wrote: My questions to you: a) Why do we care TSC timecounter when

Re: svn commit: r223350 - head/sys/dev/e1000

2011-06-21 Thread Guy Helmer
On Jun 21, 2011, at 11:07 AM, Jack Vogel wrote: LOL, the old adage is true, you just can't please all the people... :) The way the code now is it assigns a default, but you could still have a loader entry that would change it for all adapters if you wanted to, but ok, if you prefer the

Re: svn commit: r223350 - head/sys/dev/e1000

2011-06-21 Thread Jack Vogel
There IS a global default for flow control, its just hardcoded.. :) Flow control was something my validation group specifically ragged on me about... and was the reason I changed to a per-adapter setting. Let me think about it. Jack On Tue, Jun 21, 2011 at 9:17 AM, Guy Helmer

Re: svn commit: r223350 - head/sys/dev/e1000

2011-06-21 Thread Guy Helmer
Ahh, I meant to say global tunables. It is nice to have flow control as a per-interface setting also - didn't have that back in FreeBSD 8.1. Thanks, Guy On Jun 21, 2011, at 11:34 AM, Jack Vogel wrote: There IS a global default for flow control, its just hardcoded.. :) Flow control was

Re: svn commit: r223350 - head/sys/dev/e1000

2011-06-21 Thread John Baldwin
On Tuesday, June 21, 2011 12:07:23 pm Jack Vogel wrote: LOL, the old adage is true, you just can't please all the people... :) The way the code now is it assigns a default, but you could still have a loader entry that would change it for all adapters if you wanted to, but ok, if you prefer

svn commit: r223367 - head/libexec/ulog-helper

2011-06-21 Thread Ed Schouten
Author: ed Date: Tue Jun 21 17:59:51 2011 New Revision: 223367 URL: http://svn.freebsd.org/changeset/base/223367 Log: Minor cleanups to ulog-helper: - Remove unneeded linking against libmd. libulog depends on this library, but the ulog-helper tool itself does not. - Change the

svn commit: r223369 - head/lib/libc/stdlib

2011-06-21 Thread Marius Strobl
Author: marius Date: Tue Jun 21 19:15:23 2011 New Revision: 223369 URL: http://svn.freebsd.org/changeset/base/223369 Log: Change sparc64 to use the initial exec TLS model, too. This avoids random assertion failures in _malloc_thread_cleanup(). Modified: head/lib/libc/stdlib/malloc.c

svn commit: r223370 - head/sys/dev/acpica

2011-06-21 Thread John Baldwin
Author: jhb Date: Tue Jun 21 19:29:27 2011 New Revision: 223370 URL: http://svn.freebsd.org/changeset/base/223370 Log: Use AcpiWalkResources() to parse the resource list from _CRS rather than using a home-rolled loop. While here, add support for 64-bit address range resources. Silence

svn commit: r223371 - head/sys/dev/pci

2011-06-21 Thread John Baldwin
Author: jhb Date: Tue Jun 21 19:31:31 2011 New Revision: 223371 URL: http://svn.freebsd.org/changeset/base/223371 Log: Minor whitespace and style fixes. Modified: head/sys/dev/pci/pci.c Modified: head/sys/dev/pci/pci.c

svn commit: r223372 - head/bin/realpath

2011-06-21 Thread Ruslan Ermilov
Author: ru Date: Tue Jun 21 19:34:57 2011 New Revision: 223372 URL: http://svn.freebsd.org/changeset/base/223372 Log: Make ``realpath'' behave like ``realpath .''. Modified: head/bin/realpath/realpath.1 head/bin/realpath/realpath.c Modified: head/bin/realpath/realpath.1

svn commit: r223373 - head/sys/fs/nfsserver

2011-06-21 Thread Rick Macklem
Author: rmacklem Date: Tue Jun 21 19:58:29 2011 New Revision: 223373 URL: http://svn.freebsd.org/changeset/base/223373 Log: Fix the new NFSv4 server so that it checks for VREAD_ACL when a client does a Getattr for an ACL and not VREAD_ATTRIBUTES. This was found during the recent NFSv4

Re: svn commit: r223372 - head/bin/realpath

2011-06-21 Thread Jilles Tjoelker
On Tue, Jun 21, 2011 at 07:34:57PM +, Ruslan Ermilov wrote: Author: ru Date: Tue Jun 21 19:34:57 2011 New Revision: 223372 URL: http://svn.freebsd.org/changeset/base/223372 Log: Make ``realpath'' behave like ``realpath .''. Is this being added for compatibility with something? If

Re: svn commit: r223307 - head/sys/vm

2011-06-21 Thread Bjoern A. Zeeb
On Jun 19, 2011, at 7:13 PM, Alan Cox wrote: Hi Alan, Author: alc Date: Sun Jun 19 19:13:24 2011 New Revision: 223307 URL: http://svn.freebsd.org/changeset/base/223307 Log: Precisely document the synchronization rules for the page's dirty field. (Saying that the lock on the object

svn commit: r223374 - head/usr.bin/finger

2011-06-21 Thread Xin LI
Author: delphij Date: Tue Jun 21 20:33:55 2011 New Revision: 223374 URL: http://svn.freebsd.org/changeset/base/223374 Log: Staticify cleanup() which is not referenced in other places. MFC after:2 weeks Modified: head/usr.bin/finger/net.c Modified: head/usr.bin/finger/net.c

svn commit: r223375 - head/usr.bin/lastcomm

2011-06-21 Thread Xin LI
Author: delphij Date: Tue Jun 21 20:36:10 2011 New Revision: 223375 URL: http://svn.freebsd.org/changeset/base/223375 Log: Remove unneeded headers. MFC after:2 weeks Modified: head/usr.bin/lastcomm/lastcomm.c head/usr.bin/lastcomm/readrec.c Modified:

svn commit: r223376 - head/usr.bin/cmp

2011-06-21 Thread Xin LI
Author: delphij Date: Tue Jun 21 20:44:06 2011 New Revision: 223376 URL: http://svn.freebsd.org/changeset/base/223376 Log: Eliminate unneeded headers. Modified: head/usr.bin/cmp/regular.c head/usr.bin/cmp/special.c Modified: head/usr.bin/cmp/regular.c

Re: svn commit: r223370 - head/sys/dev/acpica

2011-06-21 Thread Jung-uk Kim
On Tuesday 21 June 2011 03:29 pm, John Baldwin wrote: Author: jhb Date: Tue Jun 21 19:29:27 2011 New Revision: 223370 URL: http://svn.freebsd.org/changeset/base/223370 Log: Use AcpiWalkResources() to parse the resource list from _CRS rather than using a home-rolled loop. While here, add

svn commit: r223377 - head/sys/sparc64/sparc64

2011-06-21 Thread Marius Strobl
Author: marius Date: Tue Jun 21 20:47:03 2011 New Revision: 223377 URL: http://svn.freebsd.org/changeset/base/223377 Log: On machines where we don't need to lock the kernel TSB into the dTLB and thus may basically use the entire 64-bit kernel address space increase the kernel virtual memory

svn commit: r223378 - head/sys/sparc64/include

2011-06-21 Thread Marius Strobl
Author: marius Date: Tue Jun 21 20:48:14 2011 New Revision: 223378 URL: http://svn.freebsd.org/changeset/base/223378 Log: On machines where we don't need to lock the kernel TSB into the dTLB and thus may basically use the entire 64-bit kernel address space reduce VM_KMEM_SIZE_SCALE to 1

svn commit: r223379 - head/sys/sparc64/include

2011-06-21 Thread Marius Strobl
Author: marius Date: Tue Jun 21 20:50:55 2011 New Revision: 223379 URL: http://svn.freebsd.org/changeset/base/223379 Log: Fix whitespace Modified: head/sys/sparc64/include/vmparam.h Modified: head/sys/sparc64/include/vmparam.h

svn commit: r223380 - head/sys/dev/xl

2011-06-21 Thread Warner Losh
Author: imp Date: Tue Jun 21 20:51:09 2011 New Revision: 223380 URL: http://svn.freebsd.org/changeset/base/223380 Log: Supress warning that command didn't complete when the parent bus thinks the card is gone. Modified: head/sys/dev/xl/if_xl.c Modified: head/sys/dev/xl/if_xl.c

svn commit: r223381 - head/sys/dev/dc

2011-06-21 Thread Warner Losh
Author: imp Date: Tue Jun 21 20:52:55 2011 New Revision: 223381 URL: http://svn.freebsd.org/changeset/base/223381 Log: Supress command completion failure warning when the card isn't present. Only call the bus to check if we actually do timeout so we don't affect the normal case (since this

Re: svn commit: r223380 - head/sys/dev/xl

2011-06-21 Thread Ben Kaduk
On Tue, Jun 21, 2011 at 4:51 PM, Warner Losh i...@freebsd.org wrote: Author: imp Date: Tue Jun 21 20:51:09 2011 New Revision: 223380 URL: http://svn.freebsd.org/changeset/base/223380 --- head/sys/dev/xl/if_xl.c     Tue Jun 21 20:50:55 2011        (r223379) +++ head/sys/dev/xl/if_xl.c    

Re: svn commit: r223307 - head/sys/vm

2011-06-21 Thread Bruce Evans
On Tue, 21 Jun 2011, Bjoern A. Zeeb wrote: On Jun 19, 2011, at 7:13 PM, Alan Cox wrote: Hi Alan, Author: alc Date: Sun Jun 19 19:13:24 2011 New Revision: 223307 URL: http://svn.freebsd.org/changeset/base/223307 Log: Precisely document the synchronization rules for the page's dirty field.

svn commit: r223382 - head/usr.sbin/nfsuserd

2011-06-21 Thread Rick Macklem
Author: rmacklem Date: Tue Jun 21 21:07:33 2011 New Revision: 223382 URL: http://svn.freebsd.org/changeset/base/223382 Log: Change the NFSv4 nfsuserd(8) daemon so that it doesn't preload the uid-username mapping cache with an entry when another entry for that uid is already loaded. This

Re: svn commit: r223307 - head/sys/vm

2011-06-21 Thread Attilio Rao
2011/6/21 Bruce Evans b...@optusnet.com.au: On Tue, 21 Jun 2011, Bjoern A. Zeeb wrote: On Jun 19, 2011, at 7:13 PM, Alan Cox wrote: Hi Alan, Author: alc Date: Sun Jun 19 19:13:24 2011 New Revision: 223307 URL: http://svn.freebsd.org/changeset/base/223307 Log:  Precisely document the

Re: svn commit: r223380 - head/sys/dev/xl

2011-06-21 Thread Bruce Evans
On Tue, 21 Jun 2011, Ben Kaduk wrote: On Tue, Jun 21, 2011 at 4:51 PM, Warner Losh i...@freebsd.org wrote: Author: imp Date: Tue Jun 21 20:51:09 2011 New Revision: 223380 URL: http://svn.freebsd.org/changeset/base/223380 --- head/sys/dev/xl/if_xl.c ? ? Tue Jun 21 20:50:55 2011 ? ? ?

svn commit: r223383 - head/sys/dev/acpica

2011-06-21 Thread John Baldwin
Author: jhb Date: Tue Jun 21 21:30:20 2011 New Revision: 223383 URL: http://svn.freebsd.org/changeset/base/223383 Log: Fix build with ACPI_DEBUG defined. Submitted by: jkim Pointy hat to:jhb Modified: head/sys/dev/acpica/acpi_resource.c Modified:

svn commit: r223384 - head/sys/dev/xl

2011-06-21 Thread Warner Losh
Author: imp Date: Tue Jun 21 22:16:04 2011 New Revision: 223384 URL: http://svn.freebsd.org/changeset/base/223384 Log: My broken 'u' key scks! Modified: head/sys/dev/xl/if_xl.c Modified: head/sys/dev/xl/if_xl.c ==

svn commit: r223385 - head/sys/dev/xl

2011-06-21 Thread Warner Losh
Author: imp Date: Tue Jun 21 22:17:28 2011 New Revision: 223385 URL: http://svn.freebsd.org/changeset/base/223385 Log: Really spell suppress the right way Modified: head/sys/dev/xl/if_xl.c Modified: head/sys/dev/xl/if_xl.c

Re: svn commit: r223307 - head/sys/vm

2011-06-21 Thread Warner Losh
On Jun 21, 2011, at 2:30 PM, Bjoern A. Zeeb wrote: On Jun 19, 2011, at 7:13 PM, Alan Cox wrote: Hi Alan, Author: alc Date: Sun Jun 19 19:13:24 2011 New Revision: 223307 URL: http://svn.freebsd.org/changeset/base/223307 Log: Precisely document the synchronization rules for the

svn commit: r223386 - head/sys/dev/cardbus

2011-06-21 Thread Warner Losh
Author: imp Date: Tue Jun 21 22:45:31 2011 New Revision: 223386 URL: http://svn.freebsd.org/changeset/base/223386 Log: Minor cleanup: o Consider No CIS a normal event and stop whining about it so much (too many cards are like this, espeically usb/firewire cards). o Add comments to the

Re: svn commit: r223307 - head/sys/vm

2011-06-21 Thread Bruce Evans
On Tue, 21 Jun 2011, Attilio Rao wrote: 2011/6/21 Bruce Evans b...@optusnet.com.au: vm_page.o: In function `vm_page_clear_dirty': /sys/vm/vm_page.c:(.text+0x18d0): undefined reference to `atomic_clear_8' /sys/vm/vm_page.c:(.text+0x18d0): relocation truncated to fit: R_MIPS_26 against

Re: svn commit: r223307 - head/sys/vm

2011-06-21 Thread Alan Cox
On 06/21/2011 16:09, Attilio Rao wrote: 2011/6/21 Bruce Evansb...@optusnet.com.au: On Tue, 21 Jun 2011, Bjoern A. Zeeb wrote: On Jun 19, 2011, at 7:13 PM, Alan Cox wrote: Hi Alan, Author: alc Date: Sun Jun 19 19:13:24 2011 New Revision: 223307 URL:

Re: svn commit: r223307 - head/sys/vm

2011-06-21 Thread Warner Losh
On Jun 21, 2011, at 5:27 PM, Alan Cox wrote: On 06/21/2011 16:09, Attilio Rao wrote: 2011/6/21 Bruce Evansb...@optusnet.com.au: On Tue, 21 Jun 2011, Bjoern A. Zeeb wrote: On Jun 19, 2011, at 7:13 PM, Alan Cox wrote: Hi Alan, Author: alc Date: Sun Jun 19 19:13:24 2011 New Revision:

svn commit: r223404 - head/sys/powerpc/ps3

2011-06-21 Thread Nathan Whitehorn
Author: nwhitehorn Date: Wed Jun 22 02:11:42 2011 New Revision: 223404 URL: http://svn.freebsd.org/changeset/base/223404 Log: The IOMMU is not involved for the storage bus. Modified: head/sys/powerpc/ps3/ps3bus.c Modified: head/sys/powerpc/ps3/ps3bus.c

svn commit: r223405 - head/sys/dev/vr

2011-06-21 Thread Pyun YongHyeon
Author: yongari Date: Wed Jun 22 02:18:45 2011 New Revision: 223405 URL: http://svn.freebsd.org/changeset/base/223405 Log: Remove link state change callback handler. There is no need to register both status change and link state change callbacks. Implement checking valid link in state

svn commit: r223406 - head/sys/powerpc/ps3

2011-06-21 Thread Nathan Whitehorn
Author: nwhitehorn Date: Wed Jun 22 02:23:18 2011 New Revision: 223406 URL: http://svn.freebsd.org/changeset/base/223406 Log: This is more complicated than I expected. Storage devices need the IOMMU set up, but must not use it. Modified: head/sys/powerpc/ps3/ps3bus.c Modified:

Re: svn commit: r223307 - head/sys/vm

2011-06-21 Thread Warner Losh
On Jun 21, 2011, at 5:27 PM, Alan Cox wrote: On 06/21/2011 16:09, Attilio Rao wrote: 2011/6/21 Bruce Evansb...@optusnet.com.au: On Tue, 21 Jun 2011, Bjoern A. Zeeb wrote: On Jun 19, 2011, at 7:13 PM, Alan Cox wrote: Hi Alan, Author: alc Date: Sun Jun 19 19:13:24 2011 New Revision:

Re: svn commit: r223307 - head/sys/vm

2011-06-21 Thread Alan Cox
On 06/21/2011 21:27, Warner Losh wrote: On Jun 21, 2011, at 5:27 PM, Alan Cox wrote: On 06/21/2011 16:09, Attilio Rao wrote: 2011/6/21 Bruce Evansb...@optusnet.com.au mailto:b...@optusnet.com.au: On Tue, 21 Jun 2011, Bjoern A. Zeeb wrote: On Jun 19, 2011, at 7:13 PM, Alan Cox wrote: Hi

Re: svn commit: r223307 - head/sys/vm

2011-06-21 Thread Julian Elischer
On 6/21/11 7:27 PM, Warner Losh wrote: On Jun 21, 2011, at 5:27 PM, Alan Cox wrote: On 06/21/2011 16:09, Attilio Rao wrote: 2011/6/21 Bruce Evansb...@optusnet.com.au mailto:b...@optusnet.com.au: On Tue, 21 Jun 2011, Bjoern A. Zeeb wrote: On Jun 19, 2011, at 7:13 PM, Alan Cox wrote: Hi

Re: svn commit: r223307 - head/sys/vm

2011-06-21 Thread Warner Losh
On Jun 21, 2011, at 9:27 PM, Julian Elischer wrote: On 6/21/11 7:27 PM, Warner Losh wrote: On Jun 21, 2011, at 5:27 PM, Alan Cox wrote: On 06/21/2011 16:09, Attilio Rao wrote: 2011/6/21 Bruce Evansb...@optusnet.com.au: On Tue, 21 Jun 2011, Bjoern A. Zeeb wrote: On Jun 19, 2011, at