Re: svn commit: r229415 - head/lib/libvgl

2012-01-09 Thread Eitan Adler
On Mon, Jan 9, 2012 at 11:02 PM, John-Mark Gurney wrote: > Last time I did benchmarking on this ~10 years ago, it was slower to > use xor instead of using assignments... I'd be shocked if the compiler didn't optimize this away to an XCHG. -- Eitan Adler _

Re: svn commit: r229415 - head/lib/libvgl

2012-01-09 Thread Pedro Giffuni
Hi John; --- Lun 9/1/12, John-Mark Gurney ha scritto: ... > Pedro F. Giffuni wrote this message > on Tue, Jan 03, 2012 at 19:47 +: > > +#define SL_SWAP(a,b)        >    {a^=b; b^=a; a^=b;} > > Can we replace this w/ a normal swap function? > > Last time I did benchmarking on this ~10 years

Re: svn commit: r229415 - head/lib/libvgl

2012-01-09 Thread John-Mark Gurney
Pedro F. Giffuni wrote this message on Tue, Jan 03, 2012 at 19:47 +: > +#define SL_SWAP(a,b) {a^=b; b^=a; a^=b;} Can we replace this w/ a normal swap function? Last time I did benchmarking on this ~10 years ago, it was slower to use xor instead of using assignments... -- John-Ma

svn commit: r229919 - head/sbin/camcontrol

2012-01-09 Thread Eitan Adler
Author: eadler (ports committer) Date: Tue Jan 10 02:59:58 2012 New Revision: 229919 URL: http://svn.freebsd.org/changeset/base/229919 Log: Fix warning when compiling with gcc46: error: variable 'freq' set but not used error: variable 'mode_pars' set but not used Reviewed by

svn commit: r229917 - head/sbin/fsirand

2012-01-09 Thread Eitan Adler
Author: eadler (ports committer) Date: Tue Jan 10 02:59:43 2012 New Revision: 229917 URL: http://svn.freebsd.org/changeset/base/229917 Log: Fix warning when compiling with gcc46: error: variable 'inumber' set but not used Approved by: dim MFC after:3 days Modified: head/sb

svn commit: r229914 - head/sbin/ifconfig

2012-01-09 Thread Eitan Adler
Author: eadler (ports committer) Date: Tue Jan 10 02:59:18 2012 New Revision: 229914 URL: http://svn.freebsd.org/changeset/base/229914 Log: Fix warning when compiling with gcc46: error: variable 'firstkey' set but not used Approved by: dim MFC after:3 days Modified: head/s

svn commit: r229913 - head/sbin/newfs

2012-01-09 Thread Eitan Adler
Author: eadler (ports committer) Date: Tue Jan 10 02:59:09 2012 New Revision: 229913 URL: http://svn.freebsd.org/changeset/base/229913 Log: Fix warning when compiling with gcc46: error: variable 'c' set but not used Approved by: dim MFC after:3 days Modified: head/sbin/new

svn commit: r229912 - head/sbin/ping6

2012-01-09 Thread Eitan Adler
Author: eadler (ports committer) Date: Tue Jan 10 02:59:01 2012 New Revision: 229912 URL: http://svn.freebsd.org/changeset/base/229912 Log: Fix warning when compiling with gcc46: error: variable 'origextlen' set but not used Approved by: dim MFC after:3 days Modified: head

svn commit: r229911 - head/sbin/tunefs

2012-01-09 Thread Eitan Adler
Author: eadler (ports committer) Date: Tue Jan 10 02:58:52 2012 New Revision: 229911 URL: http://svn.freebsd.org/changeset/base/229911 Log: Fix warning when compiling with gcc46: error: variable 'Sflag' set but not used Approved by: dim MFC after:3 days Modified: head/sbin

svn commit: r229918 - head/sbin/fsck_ffs

2012-01-09 Thread Eitan Adler
Author: eadler (ports committer) Date: Tue Jan 10 02:59:50 2012 New Revision: 229918 URL: http://svn.freebsd.org/changeset/base/229918 Log: Fix warning when compiling with gcc46: error: variable 'blksfree' set but not used Reviewed by: pjd Approved by: dim MFC after:3 days

svn commit: r229916 - head/sbin/geom/class/part

2012-01-09 Thread Eitan Adler
Author: eadler (ports committer) Date: Tue Jan 10 02:59:35 2012 New Revision: 229916 URL: http://svn.freebsd.org/changeset/base/229916 Log: Fix warning when compiling with gcc46: error: variable 'secsz' set but not used Reviewed by: ae Approved by: dim MFC after:3 days Mo

svn commit: r229915 - head/sbin/gvinum

2012-01-09 Thread Eitan Adler
Author: eadler (ports committer) Date: Tue Jan 10 02:59:26 2012 New Revision: 229915 URL: http://svn.freebsd.org/changeset/base/229915 Log: Fix warning when compiling with gcc46: error: variable 'op' set but not used error: variable 'cmd' set but not used Approved by: dim

svn commit: r229910 - head/usr.bin/bsdiff/bsdiff

2012-01-09 Thread Eitan Adler
Author: eadler (ports committer) Date: Tue Jan 10 02:58:44 2012 New Revision: 229910 URL: http://svn.freebsd.org/changeset/base/229910 Log: Silence bogus warning when compiling with gcc46: error: 'pos' may be used uninitialized in this function Reviewed by: cperciva Approved by:

svn commit: r229909 - head/usr.bin/netstat

2012-01-09 Thread Eitan Adler
Author: eadler (ports committer) Date: Tue Jan 10 02:58:36 2012 New Revision: 229909 URL: http://svn.freebsd.org/changeset/base/229909 Log: Fix warning when compiling with gcc46: error: variable 'ifnetfound' set but not used Approved by: dim MFC after: 3 days Modified: he

svn commit: r229908 - head/usr.bin/brandelf

2012-01-09 Thread Eitan Adler
Author: eadler (ports committer) Date: Tue Jan 10 02:58:29 2012 New Revision: 229908 URL: http://svn.freebsd.org/changeset/base/229908 Log: Fix warning when compiling with gcc46: error: variable 'verbose' set but not use Approved by: dim MFC after: 3 days Modified: head/

svn commit: r229907 - head/usr.bin/ncplist

2012-01-09 Thread Eitan Adler
Author: eadler (ports committer) Date: Tue Jan 10 02:58:20 2012 New Revision: 229907 URL: http://svn.freebsd.org/changeset/base/229907 Log: Fix warning when compiling with gcc46: error: variable 'wdone' set but not use Approved by: dim MFC after:3 days Modified: head/usr.b

svn commit: r229905 - head/usr.bin/split

2012-01-09 Thread Eitan Adler
Author: eadler (ports committer) Date: Tue Jan 10 02:55:43 2012 New Revision: 229905 URL: http://svn.freebsd.org/changeset/base/229905 Log: Fix warning when compiling with gcc46: error: variable 'defname' set but not use Approved by: dim MFC after:3 day Modified: head/usr

svn commit: r229904 - head/libexec/tftpd

2012-01-09 Thread Eitan Adler
Author: eadler (ports committer) Date: Tue Jan 10 02:55:35 2012 New Revision: 229904 URL: http://svn.freebsd.org/changeset/base/229904 Log: Fix warning when compiling with gcc46: error: variable 'bp' set but not use Approved by: dim MFC After:3 days Modified: head/libexec

svn commit: r229898 - head/sys/net

2012-01-09 Thread Lawrence Stewart
Author: lstewart Date: Tue Jan 10 00:48:29 2012 New Revision: 229898 URL: http://svn.freebsd.org/changeset/base/229898 Log: Consumers of bpfdetach() expect it to remove all bpf_if structs from the bpf_iflist list which reference the specified ifnet. The existing implementation only removes

Re: svn commit: r229887 - in head/sys: conf dev/random modules/random

2012-01-09 Thread Kostik Belousov
On Mon, Jan 09, 2012 at 11:20:30PM +, Jung-uk Kim wrote: > Author: jkim > Date: Mon Jan 9 23:20:30 2012 > New Revision: 229887 > URL: http://svn.freebsd.org/changeset/base/229887 > > Log: > Enable hardware RNG for VIA Nano processors. > > PR: kern/163974 Can we, please, have VI

svn commit: r229887 - in head/sys: conf dev/random modules/random

2012-01-09 Thread Jung-uk Kim
Author: jkim Date: Mon Jan 9 23:20:30 2012 New Revision: 229887 URL: http://svn.freebsd.org/changeset/base/229887 Log: Enable hardware RNG for VIA Nano processors. PR: kern/163974 Modified: head/sys/conf/files.amd64 head/sys/dev/random/probe.c head/sys/modules/random/Makef

svn commit: r229886 - in head: sbin/geom/class/raid sys/geom/raid

2012-01-09 Thread Jim Harris
Author: jimharris Date: Mon Jan 9 23:01:42 2012 New Revision: 229886 URL: http://svn.freebsd.org/changeset/base/229886 Log: Add support for >2TB disks in GEOM RAID for Intel metadata format. Reviewed by: mav Approved by: scottl MFC after: 1 week Modified: head/sbin/geom/class/raid/g

Re: svn commit: r228939 - head/sys/dev/mps

2012-01-09 Thread Maksim Yevmenkin
2012/1/9 Alexander Motin : > On 09.01.2012 21:01, Maksim Yevmenkin wrote: >> >> 2012/1/9 Alexander Motin: >>> >>> On 09.01.2012 20:54, Maksim Yevmenkin wrote: On Wed, Dec 28, 2011 at 2:49 PM, Alexander Motin  wrote: > > > Author: mav > Date: Wed Dec 28 22:49:28 2

Re: svn commit: r228985 - head/sys/boot/forth

2012-01-09 Thread Sergey Kandaurov
On 9 January 2012 16:49, Dimitry Andric wrote: > On 2012-01-08 21:35, Sergey Kandaurov wrote: > ... > >> So, the problem arise when beastie_disable is set. >> >> In this case menu.rc is not evaluated and consequently menu-unset does >> not have a body yet. This results in the ficl warning "not fou

svn commit: r229881 - head/sys/boot/forth

2012-01-09 Thread Sergey Kandaurov
Author: pluknet Date: Mon Jan 9 20:25:14 2012 New Revision: 229881 URL: http://svn.freebsd.org/changeset/base/229881 Log: Get rid of a spurious warning on the console when booting the kernel from the interactive loader(8) prompt and beastie_disable="YES" is set in loader.conf(5). In this ca

svn commit: r229873 - in head/sys: kern net

2012-01-09 Thread John Baldwin
Author: jhb Date: Mon Jan 9 19:34:12 2012 New Revision: 229873 URL: http://svn.freebsd.org/changeset/base/229873 Log: Convert the per-interface address list lock from a mutex to a reader/writer lock. Reviewed by: bz Modified: head/sys/kern/subr_witness.c head/sys/net/if_var.h Modi

Re: svn commit: r228939 - head/sys/dev/mps

2012-01-09 Thread Alexander Motin
On 09.01.2012 21:04, Garrett Cooper wrote: 2012/1/9 Alexander Motin: On 09.01.2012 20:54, Maksim Yevmenkin wrote: On Wed, Dec 28, 2011 at 2:49 PM, Alexander Motinwrote: Author: mav Date: Wed Dec 28 22:49:28 2011 New Revision: 228939 URL: http://svn.freebsd.org/changeset/base/228939 Log:

Re: svn commit: r228939 - head/sys/dev/mps

2012-01-09 Thread John Baldwin
On Monday, January 09, 2012 2:04:23 pm Garrett Cooper wrote: > 2012/1/9 Alexander Motin : > > On 09.01.2012 20:54, Maksim Yevmenkin wrote: > >> > >> On Wed, Dec 28, 2011 at 2:49 PM, Alexander Motin wrote: > >> > >>> Author: mav > >>> Date: Wed Dec 28 22:49:28 2011 > >>> New Revision: 228939 > >>>

Re: svn commit: r228939 - head/sys/dev/mps

2012-01-09 Thread Maksim Yevmenkin
On Wed, Dec 28, 2011 at 2:49 PM, Alexander Motin wrote: > Author: mav > Date: Wed Dec 28 22:49:28 2011 > New Revision: 228939 > URL: http://svn.freebsd.org/changeset/base/228939 > > Log: >  Set maximum I/O size for mps(4) to MAXPHYS. Looking into the code, I see >  no reason why it should be limit

Re: svn commit: r228939 - head/sys/dev/mps

2012-01-09 Thread Alexander Motin
On 09.01.2012 21:01, Maksim Yevmenkin wrote: 2012/1/9 Alexander Motin: On 09.01.2012 20:54, Maksim Yevmenkin wrote: On Wed, Dec 28, 2011 at 2:49 PM, Alexander Motinwrote: Author: mav Date: Wed Dec 28 22:49:28 2011 New Revision: 228939 URL: http://svn.freebsd.org/changeset/base/228939 Lo

Re: svn commit: r228939 - head/sys/dev/mps

2012-01-09 Thread Maksim Yevmenkin
2012/1/9 Alexander Motin : > On 09.01.2012 20:54, Maksim Yevmenkin wrote: >> >> On Wed, Dec 28, 2011 at 2:49 PM, Alexander Motin  wrote: >>> >>> Author: mav >>> Date: Wed Dec 28 22:49:28 2011 >>> New Revision: 228939 >>> URL: http://svn.freebsd.org/changeset/base/228939 >>> >>> Log: >>>  Set maximu

Re: svn commit: r228939 - head/sys/dev/mps

2012-01-09 Thread Garrett Cooper
2012/1/9 Alexander Motin : > On 09.01.2012 20:54, Maksim Yevmenkin wrote: >> >> On Wed, Dec 28, 2011 at 2:49 PM, Alexander Motin  wrote: >> >>> Author: mav >>> Date: Wed Dec 28 22:49:28 2011 >>> New Revision: 228939 >>> URL: http://svn.freebsd.org/changeset/base/228939 >>> >>> Log: >>>  Set maximum

Re: svn commit: r228939 - head/sys/dev/mps

2012-01-09 Thread Alexander Motin
On 09.01.2012 20:54, Maksim Yevmenkin wrote: On Wed, Dec 28, 2011 at 2:49 PM, Alexander Motin wrote: Author: mav Date: Wed Dec 28 22:49:28 2011 New Revision: 228939 URL: http://svn.freebsd.org/changeset/base/228939 Log: Set maximum I/O size for mps(4) to MAXPHYS. Looking into the code, I see

* Re: svn commit: r228985 - head/sys/boot/forth

2012-01-09 Thread Devin Teske
On Jan 9, 2012, at 4:49 AM, Dimitry Andric wrote: > On 2012-01-08 21:35, Sergey Kandaurov wrote: > ... >> So, the problem arise when beastie_disable is set. >> >> In this case menu.rc is not evaluated and consequently menu-unset does >> not have a body yet. This results in the ficl warning "no

Re: svn commit: r229800 - head/sys/conf

2012-01-09 Thread K. Macy
> > The problem with having ZFS compiled into the kernel is that OpenSolaris > compatiblity layer needs its headers to be included before system > headers, which is/was impossible or hard to express for kernel > compilation. AFAIR Kip Macy was working on it and my understanding was > that he finish

svn commit: r229857 - head/sys/contrib/pf/net

2012-01-09 Thread Gleb Smirnoff
Author: glebius Date: Mon Jan 9 14:35:05 2012 New Revision: 229857 URL: http://svn.freebsd.org/changeset/base/229857 Log: Can't pass MSIZE to m_cljget(), an mbuf can't be attached as external storage to another mbuf. Modified: head/sys/contrib/pf/net/if_pfsync.c Modified: head/sys/contrib

Re: svn commit: r229800 - head/sys/conf

2012-01-09 Thread Pawel Jakub Dawidek
On Mon, Jan 09, 2012 at 08:15:44AM -0500, John Baldwin wrote: > On Sunday, January 08, 2012 5:43:30 am Pawel Jakub Dawidek wrote: > > On Sun, Jan 08, 2012 at 12:55:22AM +, Adrian Chadd wrote: > > > Author: adrian > > > Date: Sun Jan 8 00:55:22 2012 > > > New Revision: 229800 > > > URL: http://

Re: svn commit: r229800 - head/sys/conf

2012-01-09 Thread John Baldwin
On Sunday, January 08, 2012 5:43:30 am Pawel Jakub Dawidek wrote: > On Sun, Jan 08, 2012 at 12:55:22AM +, Adrian Chadd wrote: > > Author: adrian > > Date: Sun Jan 8 00:55:22 2012 > > New Revision: 229800 > > URL: http://svn.freebsd.org/changeset/base/229800 > > > > Log: > > Make these two f

Re: svn commit: r228985 - head/sys/boot/forth

2012-01-09 Thread Dimitry Andric
On 2012-01-08 21:35, Sergey Kandaurov wrote: ... So, the problem arise when beastie_disable is set. In this case menu.rc is not evaluated and consequently menu-unset does not have a body yet. This results in the ficl warning "not found" when try-menu-unset calls menu-unset. The warning cannot be

Re: svn commit: r229828 - in head/sys: kern ufs/ufs

2012-01-09 Thread Kostik Belousov
On Mon, Jan 09, 2012 at 12:55:06AM -0800, Doug Barton wrote: > On 01/08/2012 15:06, Konstantin Belousov wrote: > > Author: kib > > Date: Sun Jan 8 23:06:53 2012 > > New Revision: 229828 > > URL: http://svn.freebsd.org/changeset/base/229828 > > > > Log: > > Avoid LOR between vfs_busy() lock and

svn commit: r229854 - in head: . sys/kern

2012-01-09 Thread Andriy Gapon
PEOPLE WHO THINK THAT FreeBSD 10 machines to maximize performance. (To disable malloc debugging, run ln -s aj /etc/malloc.conf.) +20120109: + panic(9) now stops other CPUs in the SMP systems, disables interrupts + on the current CPU and prevents other threads from

svn commit: r229853 - head/sys/contrib/pf/net

2012-01-09 Thread Gleb Smirnoff
Author: glebius Date: Mon Jan 9 12:06:02 2012 New Revision: 229853 URL: http://svn.freebsd.org/changeset/base/229853 Log: Backout of backout: we need SI_SUB_PROTO_DOMAIN for pfsync, since it needs existing inetdomain on startup. Modified: head/sys/contrib/pf/net/if_pfsync.c Modified: head

svn commit: r229852 - head/sys/contrib/pf/net

2012-01-09 Thread Gleb Smirnoff
Author: glebius Date: Mon Jan 9 09:19:00 2012 New Revision: 229852 URL: http://svn.freebsd.org/changeset/base/229852 Log: Revert sub argument of MODULE_DECLARE back to r226532. Noticed by: bz Modified: head/sys/contrib/pf/net/if_pfsync.c head/sys/contrib/pf/net/pf_ioctl.c Modified:

svn commit: r229851 - head/sys/contrib/pf/net

2012-01-09 Thread Gleb Smirnoff
Author: glebius Date: Mon Jan 9 08:55:23 2012 New Revision: 229851 URL: http://svn.freebsd.org/changeset/base/229851 Log: In FreeBSD we determine presence of pfsync(4) at run-time, not at compile time, so define NPFSYNC to 1 always. While here, remove unused defines. Modified: head/sys/c

Re: svn commit: r229828 - in head/sys: kern ufs/ufs

2012-01-09 Thread Doug Barton
On 01/08/2012 15:06, Konstantin Belousov wrote: > Author: kib > Date: Sun Jan 8 23:06:53 2012 > New Revision: 229828 > URL: http://svn.freebsd.org/changeset/base/229828 > > Log: > Avoid LOR between vfs_busy() lock and covered vnode lock on quotaon(). Does this mean that if we turn witness back

svn commit: r229850 - in head: etc/rc.d sys/contrib/pf/net sys/netinet

2012-01-09 Thread Gleb Smirnoff
Author: glebius Date: Mon Jan 9 08:50:22 2012 New Revision: 229850 URL: http://svn.freebsd.org/changeset/base/229850 Log: Bunch of fixes to pfsync(4) module load/unload: o Make the pfsync.ko actually usable. Before this change loading it didn't register protosw, so was a nop. However,

svn commit: r229849 - head/sys/contrib/pf/net

2012-01-09 Thread Gleb Smirnoff
Author: glebius Date: Mon Jan 9 08:36:12 2012 New Revision: 229849 URL: http://svn.freebsd.org/changeset/base/229849 Log: o Fix panic on module unload, that happened due to mutex being destroyed prior to pfsync_uninit(). To do this, move all the initialization to the module_t method, in