Re: svn commit: r230037 - head/lib/libutil

2012-01-17 Thread Bruce Evans
On Mon, 16 Jan 2012, Guy Helmer wrote: On Jan 14, 2012, at 3:02 PM, Bruce Evans wrote: ... I've pasted the diff below that I think captures the majority of the issues you have brought up. I have not attempted to tackle the property.3/properties.3 issues, nor the objections to the prefixes

Re: svn commit: r230037 - head/lib/libutil

2012-01-17 Thread Bruce Evans
On Mon, 16 Jan 2012, Pawel Jakub Dawidek wrote: On Mon, Jan 16, 2012 at 11:14:32AM -0600, Guy Helmer wrote: I've pasted the diff below that I think captures the majority of the issues you have brought up. I have not attempted to tackle the property.3/properties.3 issues, nor the objections

svn commit: r230264 - head/sys/sys

2012-01-17 Thread Gleb Smirnoff
Author: glebius Date: Tue Jan 17 12:13:36 2012 New Revision: 230264 URL: http://svn.freebsd.org/changeset/base/230264 Log: Provide a function m_get2() that allocates a minimal mbuf that would fit specified size. Returned mbuf may be a single mbuf, an mbuf with a cluster from packet zone, or

svn commit: r230265 - head/sys/contrib/pf/net

2012-01-17 Thread Gleb Smirnoff
Author: glebius Date: Tue Jan 17 12:14:26 2012 New Revision: 230265 URL: http://svn.freebsd.org/changeset/base/230265 Log: Allocate our mbuf with m_get2(). Modified: head/sys/contrib/pf/net/if_pfsync.c Modified: head/sys/contrib/pf/net/if_pfsync.c

Re: svn commit: r230264 - head/sys/sys

2012-01-17 Thread Gleb Smirnoff
On Tue, Jan 17, 2012 at 12:13:37PM +, Gleb Smirnoff wrote: T Author: glebius T Date: Tue Jan 17 12:13:36 2012 T New Revision: 230264 T URL: http://svn.freebsd.org/changeset/base/230264 T T Log: T Provide a function m_get2() that allocates a minimal mbuf that T would fit specified size.

Re: svn commit: r230262 - head/sys/amd64/include

2012-01-17 Thread Bruce Evans
On Tue, 17 Jan 2012, Konstantin Belousov wrote: Log: Implement xsetbv(), xsave() and xrstor() providing C access to the similarly named CPU instructions. Please don't add to the unsorting in this file. Modified: head/sys/amd64/include/cpufunc.h

Re: svn commit: r230264 - head/sys/sys

2012-01-17 Thread Andre Oppermann
On 17.01.2012 13:16, Gleb Smirnoff wrote: On Tue, Jan 17, 2012 at 12:13:37PM +, Gleb Smirnoff wrote: T Author: glebius T Date: Tue Jan 17 12:13:36 2012 T New Revision: 230264 T URL: http://svn.freebsd.org/changeset/base/230264 T T Log: TProvide a function m_get2() that allocates a

Re: svn commit: r230025 - head/contrib/compiler-rt/lib/sparc64

2012-01-17 Thread Ed Schouten
Hi Marius, * Marius Strobl mar...@alchemy.franken.de, 20120113 01:00: Uhm, these are V8-specific, for V9 the C compiler frame size should be 192 instead of 64 and the function alignment should be 32 instead of 4 bytes (at least with GCC and US1-optimizations enabled as we default to on

Re: svn commit: r230208 - head/sys/fs/tmpfs

2012-01-17 Thread John Baldwin
On Monday, January 16, 2012 5:25:23 am Kevin Lo wrote: Author: kevlo Date: Mon Jan 16 10:25:22 2012 New Revision: 230208 URL: http://svn.freebsd.org/changeset/base/230208 Log: Add nfs export support to tmpfs(5) Reviewed by:kib Modified:

Re: svn commit: r230201 - head/lib/libc/gen

2012-01-17 Thread John Baldwin
On Monday, January 16, 2012 1:15:14 am David Xu wrote: Author: davidxu Date: Mon Jan 16 06:15:14 2012 New Revision: 230201 URL: http://svn.freebsd.org/changeset/base/230201 Log: Insert read memory barriers. I think using atomic_load_acq() on sem-nwaiters would be clearer as it would

Re: svn commit: r230125 - head/sys/kern

2012-01-17 Thread John Baldwin
On Sunday, January 15, 2012 6:32:43 pm Colin Percival wrote: On 01/15/12 15:28, John Baldwin wrote: On 1/15/12 2:09 AM, Eitan Adler wrote: Log: - Fix undefined behavior when device_get_name is null - Make error message more informative The in-kernel printf(9) always prints

svn commit: r230267 - head/include

2012-01-17 Thread David Chisnall
Author: theraven Date: Tue Jan 17 15:20:41 2012 New Revision: 230267 URL: http://svn.freebsd.org/changeset/base/230267 Log: Fix clang atomic to use for atomic_is_lock_free(). Reviewed by: ed Approved by: dim (mentor) Modified: head/include/stdatomic.h Modified:

Re: svn commit: r230208 - head/sys/fs/tmpfs

2012-01-17 Thread John Baldwin
On Tuesday, January 17, 2012 9:50:15 am John Baldwin wrote: On Monday, January 16, 2012 5:25:23 am Kevin Lo wrote: Author: kevlo Date: Mon Jan 16 10:25:22 2012 New Revision: 230208 URL: http://svn.freebsd.org/changeset/base/230208 Log: Add nfs export support to tmpfs(5)

svn commit: r230268 - head/sys/kern

2012-01-17 Thread Alan Cox
Author: alc Date: Tue Jan 17 16:20:50 2012 New Revision: 230268 URL: http://svn.freebsd.org/changeset/base/230268 Log: Explain why it is safe to unlock the vnode. Requested by: kib Modified: head/sys/kern/imgact_elf.c Modified: head/sys/kern/imgact_elf.c

Re: svn commit: r230265 - head/sys/contrib/pf/net

2012-01-17 Thread Ermal Luçi
Maybe it does not hurt in general to keep the V_ Some work was done to add it, no?! On Tue, Jan 17, 2012 at 1:14 PM, Gleb Smirnoff gleb...@freebsd.org wrote: Author: glebius Date: Tue Jan 17 12:14:26 2012 New Revision: 230265 URL: http://svn.freebsd.org/changeset/base/230265 Log:

svn commit: r230269 - head/sys/amd64/include

2012-01-17 Thread Konstantin Belousov
Author: kib Date: Tue Jan 17 16:53:41 2012 New Revision: 230269 URL: http://svn.freebsd.org/changeset/base/230269 Log: Modernize the fpusave structures definitions by using uint*_t types. MFC after:1 week Modified: head/sys/amd64/include/fpu.h Modified: head/sys/amd64/include/fpu.h

svn commit: r230270 - in head/sys: amd64/include i386/include

2012-01-17 Thread Konstantin Belousov
Author: kib Date: Tue Jan 17 17:07:13 2012 New Revision: 230270 URL: http://svn.freebsd.org/changeset/base/230270 Log: Add definitions for the FPU extended state header, legacy extended state and AVX state. MFC after:1 week Modified: head/sys/amd64/include/fpu.h

Re: svn commit: r230125 - head/sys/kern

2012-01-17 Thread Eitan Adler
On Tue, Jan 17, 2012 at 10:08 AM, John Baldwin j...@freebsd.org wrote: On Sunday, January 15, 2012 6:32:43 pm Colin Percival wrote: On 01/15/12 15:28, John Baldwin wrote: On 1/15/12 2:09 AM, Eitan Adler wrote: Log:    - Fix undefined behavior when device_get_name is null    - Make error

Re: svn commit: r230025 - head/contrib/compiler-rt/lib/sparc64

2012-01-17 Thread Marius Strobl
On Tue, Jan 17, 2012 at 03:55:05PM +0100, Ed Schouten wrote: Hi Marius, * Marius Strobl mar...@alchemy.franken.de, 20120113 01:00: Uhm, these are V8-specific, for V9 the C compiler frame size should be 192 instead of 64 and the function alignment should be 32 instead of 4 bytes (at least

Re: svn commit: r230125 - head/sys/kern

2012-01-17 Thread Andriy Gapon
on 17/01/2012 19:12 Eitan Adler said the following: To me seeing (null) from the output of printf indicates There is a bug here, printf should never be given a NULL argument.. However, given that it isn't undefined here, and the objections I've received I will revert this part of the change

Re: svn commit: r230252 - head/sys/fs/tmpfs

2012-01-17 Thread Jaakko Heinonen
On 2012-01-17, Kevin Lo wrote: Return EOPNOTSUPP since we only support update mounts for NFS export. @@ -150,8 +150,12 @@ tmpfs_mount(struct mount *mp) return (EINVAL); if (mp-mnt_flag MNT_UPDATE) { + /* + * Only support update mounts

Re: svn commit: r230265 - head/sys/contrib/pf/net

2012-01-17 Thread Gleb Smirnoff
On Tue, Jan 17, 2012 at 05:48:10PM +0100, Ermal Lu?i wrote: E Maybe it does not hurt in general to keep the V_ E Some work was done to add it, no?! The V_ has been left under __FreeBSD__. E On Tue, Jan 17, 2012 at 1:14 PM, Gleb Smirnoff gleb...@freebsd.org wrote: E E Author: glebius E Date:

svn commit: r230272 - head/sys/netgraph

2012-01-17 Thread Gleb Smirnoff
Author: glebius Date: Tue Jan 17 18:10:25 2012 New Revision: 230272 URL: http://svn.freebsd.org/changeset/base/230272 Log: The newhook method can be called in ISR context at certain circumstances, so better use M_NOWAIT in it. Modified: head/sys/netgraph/ng_tag.c Modified:

svn commit: r230273 - head/sys/modules/wtap

2012-01-17 Thread Adrian Chadd
Author: adrian Date: Tue Jan 17 18:20:34 2012 New Revision: 230273 URL: http://svn.freebsd.org/changeset/base/230273 Log: Tidy-up. Modified: head/sys/modules/wtap/Makefile Modified: head/sys/modules/wtap/Makefile ==

Re: svn commit: r230125 - head/sys/kern

2012-01-17 Thread John Baldwin
On Tuesday, January 17, 2012 12:29:06 pm Andriy Gapon wrote: on 17/01/2012 19:12 Eitan Adler said the following: To me seeing (null) from the output of printf indicates There is a bug here, printf should never be given a NULL argument.. However, given that it isn't undefined here, and the

Re: svn commit: r230125 - head/sys/kern

2012-01-17 Thread Doug Barton
On 01/17/2012 10:48, John Baldwin wrote: On Tuesday, January 17, 2012 12:29:06 pm Andriy Gapon wrote: on 17/01/2012 19:12 Eitan Adler said the following: To me seeing (null) from the output of printf indicates There is a bug here, printf should never be given a NULL argument.. However, given

svn commit: r230275 - head/sys/dev/re

2012-01-17 Thread Pyun YongHyeon
Author: yongari Date: Tue Jan 17 19:31:03 2012 New Revision: 230275 URL: http://svn.freebsd.org/changeset/base/230275 Log: Use a RX DMA tag to free loaded RX DMA maps. Previously it used a TX DMA tag. Modified: head/sys/dev/re/if_re.c Modified: head/sys/dev/re/if_re.c

svn commit: r230276 - head/sys/dev/re

2012-01-17 Thread Pyun YongHyeon
Author: yongari Date: Tue Jan 17 19:36:53 2012 New Revision: 230276 URL: http://svn.freebsd.org/changeset/base/230276 Log: Free allocated jumbo buffers when controller is stopped. Modified: head/sys/dev/re/if_re.c Modified: head/sys/dev/re/if_re.c

Re: svn commit: r230125 - head/sys/kern

2012-01-17 Thread Scott Long
On Jan 17, 2012, at 8:08 AM, John Baldwin wrote: On Sunday, January 15, 2012 6:32:43 pm Colin Percival wrote: On 01/15/12 15:28, John Baldwin wrote: On 1/15/12 2:09 AM, Eitan Adler wrote: Log: - Fix undefined behavior when device_get_name is null - Make error message more informative

svn commit: r230277 - head/sys/sys

2012-01-17 Thread Ed Schouten
Author: ed Date: Tue Jan 17 20:21:31 2012 New Revision: 230277 URL: http://svn.freebsd.org/changeset/base/230277 Log: Don't expose __generic() when not using C++. According to the GCC documentation, the constructs used to implement tgmath.h are only available in C mode. They only cause

svn commit: r230278 - head/include

2012-01-17 Thread Ed Schouten
Author: ed Date: Tue Jan 17 20:22:10 2012 New Revision: 230278 URL: http://svn.freebsd.org/changeset/base/230278 Log: Only use the static assertion when __generic is available. Reported by: tijl Modified: head/include/complex.h Modified: head/include/complex.h

Re: svn commit: r230125 - head/sys/kern

2012-01-17 Thread John Baldwin
On Tuesday, January 17, 2012 2:22:26 pm Scott Long wrote: On Jan 17, 2012, at 8:08 AM, John Baldwin wrote: On Sunday, January 15, 2012 6:32:43 pm Colin Percival wrote: On 01/15/12 15:28, John Baldwin wrote: On 1/15/12 2:09 AM, Eitan Adler wrote: Log: - Fix undefined behavior when

Re: svn commit: r230277 - head/sys/sys

2012-01-17 Thread Ed Schouten
* Ed Schouten e...@freebsd.org, 20120117 21:21: Don't expose __generic() when not using C++. d'oh! I mean the opposite. Don't expose __generic() when using C++. -- Ed Schouten e...@80386.nl WWW: http://80386.nl/ pgpr5swLoYMJB.pgp Description: PGP signature

Re: svn commit: r228790 - in head/usr.sbin: fwcontrol newsyslog ypserv

2012-01-17 Thread Hiroki Sato
Eitan Adler ead...@freebsd.org wrote in 201112212027.pblkrfpk084...@svn.freebsd.org: ea Author: eadler (ports committer) ea Date: Wed Dec 21 20:27:41 2011 ea New Revision: 228790 ea URL: http://svn.freebsd.org/changeset/base/228790 ea ea Log: ea - Remove extraneous null ptr deref checks ea

Re: svn commit: r228790 - in head/usr.sbin: fwcontrol newsyslog ypserv

2012-01-17 Thread Eitan Adler
On Tue, Jan 17, 2012 at 3:57 PM, Hiroki Sato h...@freebsd.org wrote:  I suspects you did not test ypserv after this change.  Freeing the  pointer sname at the end of create_service() is completely wrong and  probably people get the following error message when invoking ypserv:  getaddrinfo():

svn commit: r230281 - in head/libexec/rtld-elf: amd64 i386

2012-01-17 Thread Ed Schouten
Author: ed Date: Tue Jan 17 21:55:20 2012 New Revision: 230281 URL: http://svn.freebsd.org/changeset/base/230281 Log: Remove unneeded dtv variable. It is only assigned and not used at all. The object files stay identical when the variables are removed. Approved by: kib Modified:

svn commit: r230286 - head/sys/dev/bge

2012-01-17 Thread Pyun YongHyeon
Author: yongari Date: Tue Jan 17 22:15:33 2012 New Revision: 230286 URL: http://svn.freebsd.org/changeset/base/230286 Log: Introduce a tunable that disables use of MSI. Non-zero value will use INTx. Modified: head/sys/dev/bge/if_bge.c head/sys/dev/bge/if_bgereg.h Modified:

svn commit: r230287 - head/bin/ps

2012-01-17 Thread Ed Schouten
Author: ed Date: Tue Jan 17 22:17:10 2012 New Revision: 230287 URL: http://svn.freebsd.org/changeset/base/230287 Log: Remove unused variables. Simply annotate the function parameters with __unused, instead of adding the ve-variables. This makes the code build with GCC 4.7 and -Werror.

svn commit: r230289 - head/sbin/growfs

2012-01-17 Thread Ed Schouten
Author: ed Date: Tue Jan 17 22:19:35 2012 New Revision: 230289 URL: http://svn.freebsd.org/changeset/base/230289 Log: Allow growfs to be built with GCC 4.7 and -Werror. The dp1 variable is only used when FSIRAND is defined. Just place the variable behind #ifdefs entirely. Modified:

Re: svn commit: r230265 - head/sys/contrib/pf/net

2012-01-17 Thread Ermal Luçi
2012/1/17 Gleb Smirnoff gleb...@freebsd.org On Tue, Jan 17, 2012 at 05:48:10PM +0100, Ermal Lu?i wrote: E Maybe it does not hurt in general to keep the V_ E Some work was done to add it, no?! The V_ has been left under __FreeBSD__. E On Tue, Jan 17, 2012 at 1:14 PM, Gleb Smirnoff

Re: svn commit: r230279 - head/usr.sbin/ypserv

2012-01-17 Thread Eitan Adler
On Tue, Jan 17, 2012 at 3:39 PM, Hiroki Sato h...@freebsd.org wrote: Author: hrs Date: Tue Jan 17 20:39:33 2012 New Revision: 230279 URL: http://svn.freebsd.org/changeset/base/230279 Log:  Revert changes in r228790.  It prevented the ypserv daemon from working with  with multiple

Re: svn commit: r230201 - head/lib/libc/gen

2012-01-17 Thread David Xu
On 2012/1/17 22:57, John Baldwin wrote: On Monday, January 16, 2012 1:15:14 am David Xu wrote: Author: davidxu Date: Mon Jan 16 06:15:14 2012 New Revision: 230201 URL: http://svn.freebsd.org/changeset/base/230201 Log: Insert read memory barriers. I think using atomic_load_acq() on

svn commit: r230291 - head/share/man/man9

2012-01-17 Thread Kevin Lo
Author: kevlo Date: Wed Jan 18 02:27:09 2012 New Revision: 230291 URL: http://svn.freebsd.org/changeset/base/230291 Log: vfs_object_create() function is obsolete. Use vnode_create_vobject() to create the backing object. Reviewed by: kib Modified: head/share/man/man9/vnode.9

svn commit: r230292 - head/share/man/man9

2012-01-17 Thread Kevin Lo
Author: kevlo Date: Wed Jan 18 02:29:11 2012 New Revision: 230292 URL: http://svn.freebsd.org/changeset/base/230292 Log: NOOBJ is long time dead Reviewed by: kib Modified: head/share/man/man9/namei.9 Modified: head/share/man/man9/namei.9

svn commit: r230293 - head/usr.sbin/wpa/wpa_supplicant

2012-01-17 Thread Ed Maste
Author: emaste Date: Wed Jan 18 02:44:22 2012 New Revision: 230293 URL: http://svn.freebsd.org/changeset/base/230293 Log: Add missing line continuation \. It did not cause any issue because the same path is already being included in ../Makefile.inc. PR: 164192 Submitted by:

svn commit: r230294 - head/share/man/man4

2012-01-17 Thread Lawrence Stewart
Author: lstewart Date: Wed Jan 18 03:03:21 2012 New Revision: 230294 URL: http://svn.freebsd.org/changeset/base/230294 Log: Specify the correct section (4 instead of 9) in the h_ertt man page's title and bump the document date. MFC after:3 days Modified:

svn commit: r230296 - head/usr.sbin/tzsetup

2012-01-17 Thread Ed Maste
Author: emaste Date: Wed Jan 18 04:12:32 2012 New Revision: 230296 URL: http://svn.freebsd.org/changeset/base/230296 Log: Don't write /var/db/zoneinfo when zone is not actually changed. If the specified zone file does not exist or the -n flag is specified, do not update /var/db/zoneinfo.

Re: svn commit: r230265 - head/sys/contrib/pf/net

2012-01-17 Thread Gleb Smirnoff
On Tue, Jan 17, 2012 at 11:38:12PM +0100, Ermal Lu?i wrote: E On Tue, Jan 17, 2012 at 05:48:10PM +0100, Ermal Lu?i wrote: E E Maybe it does not hurt in general to keep the V_ E E Some work was done to add it, no?! E E The V_ has been left under __FreeBSD__. E E E On Tue, Jan 17, 2012 at

svn commit: r230299 - head/usr.sbin/tzsetup

2012-01-17 Thread Ed Maste
Author: emaste Date: Wed Jan 18 04:37:35 2012 New Revision: 230299 URL: http://svn.freebsd.org/changeset/base/230299 Log: Fix #ifdef VERBOSE for UTC case Update verbose output to match what actually happens when selecting the UTC option, and when the -n option is used. Patch updated

Re: svn commit: r230230 - head/sys/dev/random

2012-01-17 Thread Andrey Chernov
On Mon, Jan 16, 2012 at 08:18:10PM +, David Schultz wrote: Author: das Date: Mon Jan 16 20:18:10 2012 New Revision: 230230 URL: http://svn.freebsd.org/changeset/base/230230 Log: Generate a warning if the kernel's arc4random() is seeded with bogus entropy. While you are here, could