Author: adrian
Date: Tue Jun 5 06:03:55 2012
New Revision: 236599
URL: http://svn.freebsd.org/changeset/base/236599
Log:
Mostly revert previous commit(s). After doing a bunch of local testing,
it turns out that it negatively affects performance. I'm stil investigating
exactly why
On Mon, Jun 04, 2012 at 09:34:49PM +, Andrey A. Chernov wrote:
Author: ache
Date: Mon Jun 4 21:34:49 2012
New Revision: 236582
URL: http://svn.freebsd.org/changeset/base/236582
Log:
1) IEEE Std 1003.1-2008, errno section, is explicit that
The setting of errno after a
On 2012-06-04 23:34, Andrey A. Chernov wrote: Author: ache
Date: Mon Jun 4 21:34:49 2012
New Revision: 236582
URL: http://svn.freebsd.org/changeset/base/236582
Log:
1) IEEE Std 1003.1-2008, errno section, is explicit that
The setting of errno after a successful call to a function
On Tue, Jun 05, 2012 at 10:08:09AM +0200, Dimitry Andric wrote:
On 2012-06-04 23:34, Andrey A. Chernov wrote: Author: ache
Date: Mon Jun 4 21:34:49 2012
New Revision: 236582
URL: http://svn.freebsd.org/changeset/base/236582
Log:
1) IEEE Std 1003.1-2008, errno section, is explicit
Author: mav
Date: Tue Jun 5 09:45:42 2012
New Revision: 236602
URL: http://svn.freebsd.org/changeset/base/236602
Log:
Tune and add some missing CAM_DEBUG() points for better consistency.
Modified:
head/sys/cam/ata/ata_da.c
head/sys/cam/ata/ata_pmp.c
head/sys/cam/scsi/scsi_cd.c
Author: mav
Date: Tue Jun 5 10:08:22 2012
New Revision: 236604
URL: http://svn.freebsd.org/changeset/base/236604
Log:
Do not reinvent a wheel and let default error handler do its job.
Modified:
head/sys/cam/scsi/scsi_da.c
Modified: head/sys/cam/scsi/scsi_da.c
Author: mav
Date: Tue Jun 5 10:23:41 2012
New Revision: 236605
URL: http://svn.freebsd.org/changeset/base/236605
Log:
Replace #ifdef CAMDEBUG + if + panic() with single KASSERT().
Modified:
head/sys/cam/cam_xpt.c
Modified: head/sys/cam/cam_xpt.c
Author: mav
Date: Tue Jun 5 11:48:32 2012
New Revision: 236613
URL: http://svn.freebsd.org/changeset/base/236613
Log:
Tune and add some more CAM_DEBUG() points for the probe sequences.
Modified:
head/sys/cam/ata/ata_xpt.c
head/sys/cam/scsi/scsi_xpt.c
Modified: head/sys/cam/ata/ata_xpt.c
Author: des
Date: Tue Jun 5 12:34:08 2012
New Revision: 236614
URL: http://svn.freebsd.org/changeset/base/236614
Log:
Add mangled symbols for operator new / delete on 64-bit platforms.
Reported by: decke@
MFC after:1 week
Modified:
head/gnu/lib/libsupc++/Version.map
Modified:
On Tue, Jun 05, 2012 at 10:08:09AM +0200, Dimitry Andric wrote:
On 2012-06-04 23:34, Andrey A. Chernov wrote: Author: ache
Date: Mon Jun 4 21:34:49 2012
New Revision: 236582
URL: http://svn.freebsd.org/changeset/base/236582
Log:
1) IEEE Std 1003.1-2008, errno section, is explicit
On Tue, Jun 05, 2012 at 11:35:53AM +0300, Konstantin Belousov wrote:
Not to mention that the patch was committed to _our_ implementation of
libc, which uses _our_ free, and not some abstract free(3). Our free changing
errno means that process state is so messed that worrying about realpath(3)
On Tue, Jun 05, 2012 at 04:39:01PM +0400, Andrey Chernov wrote:
Actually, it says the following:
RETURN VALUE
The free() function shall not return a value.
ERRORS
No errors are defined.
How much clearer do you want it? ;)
It is pretty clear.
The
On Tue, Jun 05, 2012 at 04:39:01PM +0400, Andrey Chernov wrote:
Moreover, standard metion unsuccessful call case for free() where errno
state is totally undefined.
...which would be a programming mistake in first place and is valid as
justification.
Joerg
On Tue, Jun 05, 2012 at 09:47:42AM +0200, Pawel Jakub Dawidek wrote:
The setting of errno after a successful call to a function is
unspecified unless the description of that function specifies that
errno shall not be modified.
Very interesting. However free(3) is always successful.
Pawel Jakub Dawidek p...@freebsd.org writes:
Very interesting. However free(3) is always successful. Maybe we need
more context here, but the sentence above might talk about functions
that can either succeed or fail and such functions do set errno on
failure, but we don't know what they do to
On Tue, Jun 05, 2012 at 02:55:20PM +0200, Joerg Sonnenberger wrote:
On Tue, Jun 05, 2012 at 04:39:01PM +0400, Andrey Chernov wrote:
Moreover, standard metion unsuccessful call case for free() where errno
state is totally undefined.
...which would be a programming mistake in first place
Author: bz
Date: Tue Jun 5 13:27:37 2012
New Revision: 236615
URL: http://svn.freebsd.org/changeset/base/236615
Log:
Plug two interface address refcount leaks in early error return cases
in the ioctl path.
Reported by: rpaulo
Reviewed by: emax
MFC after:3 days
Modified:
On Tue, Jun 05, 2012 at 03:10:06PM +0200, Dag-Erling Sm??rgrav wrote:
Pawel Jakub Dawidek p...@freebsd.org writes:
Very interesting. However free(3) is always successful. Maybe we need
more context here, but the sentence above might talk about functions
that can either succeed or fail and
On Mon, Jun 04, 2012 at 09:34:49PM +, Andrey A. Chernov wrote:
1) IEEE Std 1003.1-2008, errno section, is explicit that
The setting of errno after a successful call to a function is
unspecified unless the description of that function specifies that
errno shall not be modified.
Author: imp
Date: Tue Jun 5 14:19:59 2012
New Revision: 236617
URL: http://svn.freebsd.org/changeset/base/236617
Log:
Remove dead code.
Modified:
head/sys/arm/at91/at91rm92reg.h
Modified: head/sys/arm/at91/at91rm92reg.h
On Tue, Jun 05, 2012 at 05:13:05PM +0400, Andrey Chernov wrote:
On Tue, Jun 05, 2012 at 02:55:20PM +0200, Joerg Sonnenberger wrote:
On Tue, Jun 05, 2012 at 04:39:01PM +0400, Andrey Chernov wrote:
Moreover, standard metion unsuccessful call case for free() where errno
state is totally
On Tue, Jun 05, 2012 at 04:25:10PM +0200, Joerg Sonnenberger wrote:
Please see
http://austingroupbugs.net/view.php?id=385
That is about explicitly recognizing how stupid the notion of free(3)
not preserving errno is. Seriously, before you start to randomly bloat
code all over the place,
On Tue, Jun 05, 2012 at 06:31:14PM +0400, Andrey Chernov wrote:
BTW, if general consensus will be to track unpublished standard, I will
back out my change (in hope our malloc() maintainer will change free() to
directly save errno).
The standard is quite irrelevant here. FreeBSD is free to
On Jun 5, 2012, at 7:31 AM, Andrey Chernov wrote:
On Tue, Jun 05, 2012 at 04:25:10PM +0200, Joerg Sonnenberger wrote:
Please see
http://austingroupbugs.net/view.php?id=385
That is about explicitly recognizing how stupid the notion of free(3)
not preserving errno is. Seriously, before you
On Tue, Jun 05, 2012 at 08:23:20AM -0700, Marcel Moolenaar wrote:
If we the resolution of the ID 385 indicates that a future version
will have the suggested text, then one can definitely argue that it's
not unreasonable to start changing our functions to match the new text
(like free(3))
Author: ache
Date: Tue Jun 5 16:16:33 2012
New Revision: 236618
URL: http://svn.freebsd.org/changeset/base/236618
Log:
1) Although unpublished version of standard
http://austingroupbugs.net/view.php?id=385#c713
(Resolved state) recommend this way for the current standard (called
earlier
Author: mav
Date: Tue Jun 5 16:46:34 2012
New Revision: 236619
URL: http://svn.freebsd.org/changeset/base/236619
Log:
Add missing newlines into XML output.
MFC after:3 days
Sponsored by: iXsystems, Inc.
Modified:
head/sys/geom/multipath/g_multipath.c
Modified:
On Tue, Jun 05, 2012 at 05:17:33PM +0200, Joerg Sonnenberger wrote:
On Tue, Jun 05, 2012 at 06:31:14PM +0400, Andrey Chernov wrote:
BTW, if general consensus will be to track unpublished standard, I will
back out my change (in hope our malloc() maintainer will change free() to
directly
On Tue, Jun 05, 2012 at 11:07:48AM +1200, Andrew Thompson wrote:
Does the race have to be managed between the parent SET_PID ioctl and
the child doing something?
Thank you for catching that. I committed an older version of that.
(had copies of this on multiple machines...)
--
-- David
Author: obrien
Date: Tue Jun 5 17:36:28 2012
New Revision: 236620
URL: http://svn.freebsd.org/changeset/base/236620
Log:
Correct examples to the latest version I had.
Modified:
head/share/man/man4/filemon.4
head/tools/regression/filemon/filemontest.c
Modified:
Author: obrien
Date: Tue Jun 5 17:44:54 2012
New Revision: 236621
URL: http://svn.freebsd.org/changeset/base/236621
Log:
Only build filemon(4) on x86.
Modified:
head/sys/modules/Makefile
Modified: head/sys/modules/Makefile
Author: joel (doc committer)
Date: Tue Jun 5 17:46:50 2012
New Revision: 236622
URL: http://svn.freebsd.org/changeset/base/236622
Log:
Various mdoc fixes.
Modified:
head/share/man/man4/filemon.4
Modified: head/share/man/man4/filemon.4
Author: obrien
Date: Tue Jun 5 17:49:11 2012
New Revision: 236623
URL: http://svn.freebsd.org/changeset/base/236623
Log:
RAID is an acronym.
Modified:
head/share/man/man4/mpt.4
Modified: head/share/man/man4/mpt.4
Author: joel (doc committer)
Date: Tue Jun 5 17:58:47 2012
New Revision: 236624
URL: http://svn.freebsd.org/changeset/base/236624
Log:
Remove end of line whitespace.
Modified:
head/share/man/man4/bce.4
Modified: head/share/man/man4/bce.4
Author: joel (doc committer)
Date: Tue Jun 5 18:07:20 2012
New Revision: 236625
URL: http://svn.freebsd.org/changeset/base/236625
Log:
Minor spelling fixes.
Modified:
head/sbin/camcontrol/camcontrol.8
Modified: head/sbin/camcontrol/camcontrol.8
On Jun 5, 2012, at 10:44 AM, David E. O'Brien wrote:
Author: obrien
Date: Tue Jun 5 17:44:54 2012
New Revision: 236621
URL: http://svn.freebsd.org/changeset/base/236621
Log:
Only build filemon(4) on x86.
Why?
--
Marcel Moolenaar
mar...@xcllnt.net
Author: joel (doc committer)
Date: Tue Jun 5 18:19:52 2012
New Revision: 236626
URL: http://svn.freebsd.org/changeset/base/236626
Log:
Remove repeated words.
Modified:
head/lib/libelf/elf_begin.3
head/lib/libgssapi/gss_unwrap.3
head/lib/libgssapi/gss_wrap.3
Author: emax
Date: Tue Jun 5 18:48:02 2012
New Revision: 236627
URL: http://svn.freebsd.org/changeset/base/236627
Log:
Before it gets lost in the noise.
Put a bandaid to prevent ixgbe(4) from completely locking up the system
under high load. Our platform has a few CPU cores and a single
Author: gnn
Date: Tue Jun 5 18:58:05 2012
New Revision: 236628
URL: http://svn.freebsd.org/changeset/base/236628
Log:
Add DTrace's io.d, which handles tranlsations for file, buffer and
device info structures as well as the fds[] array. This is a raw
version of the file, unmodified, to be
On Tue, 5 Jun 2012, Andrey Chernov wrote:
On Tue, Jun 05, 2012 at 09:47:42AM +0200, Pawel Jakub Dawidek wrote:
The setting of errno after a successful call to a function is
unspecified unless the description of that function specifies that
errno shall not be modified.
Very interesting.
On Wed, Jun 06, 2012 at 04:57:29AM +1000, Bruce Evans wrote:
POSIX may require errno to not be clobbered, especially for its functions.
It probably shouldn't do this for Standard C library functions like free(),
since this would be an extension and any use of the extension would give
Author: ed
Date: Tue Jun 5 19:42:57 2012
New Revision: 236629
URL: http://svn.freebsd.org/changeset/base/236629
Log:
Fix a small typo. Fireware - firmware.
MFC after:2 weeks
Modified:
head/include/fmtmsg.h
Modified: head/include/fmtmsg.h
Author: glebius
Date: Tue Jun 5 20:08:59 2012
New Revision: 236634
URL: http://svn.freebsd.org/changeset/base/236634
Log:
Don't crash trying to load symbols from striped file.
PR: bin/167361
Submitted by: Slawa Olhovchenkov slw zxy.spb.ru
Silence from: jkoshy
Modified:
On Tue, 5 Jun 2012, Andrey Chernov wrote:
On Wed, Jun 06, 2012 at 04:57:29AM +1000, Bruce Evans wrote:
POSIX may require errno to not be clobbered, especially for its functions.
It probably shouldn't do this for Standard C library functions like free(),
since this would be an extension and any
On Mon, 4 Jun 2012, David E. O'Brien wrote:
Author: obrien
Date: Mon Jun 4 22:59:06 2012
New Revision: 236593
URL: http://svn.freebsd.org/changeset/base/236593
Log:
Add a man page for filemon(4) [r236592].
[...]
Added: head/share/man/man4/filemon.4
Author: obrien
Date: Tue Jun 5 20:32:38 2012
New Revision: 236637
URL: http://svn.freebsd.org/changeset/base/236637
Log:
mdoc police.
Submitted by: ru
Much thanks to: ru
Modified:
head/share/man/man4/filemon.4
Modified: head/share/man/man4/filemon.4
Author: tuexen
Date: Tue Jun 5 20:48:13 2012
New Revision: 236640
URL: http://svn.freebsd.org/changeset/base/236640
Log:
The cmsg_len field includes the cmsg header. So use CMSG_LEN().
MFC after: 3 days
Modified:
head/share/man/man4/ip.4
Modified: head/share/man/man4/ip.4
On Wed, Jun 06, 2012 at 06:11:01AM +1000, Bruce Evans wrote:
This is essentially unusable (so a bad idea). Instead of unconditionally
saving and restoring errno around calls to free(), portable POSIX code
can soon use a messy ifdef to avoid doing this in some cases, but still
has to do it in
On Wed, Jun 06, 2012 at 01:01:54AM +0400, Andrey Chernov wrote:
On Wed, Jun 06, 2012 at 06:11:01AM +1000, Bruce Evans wrote:
This is essentially unusable (so a bad idea). Instead of unconditionally
saving and restoring errno around calls to free(), portable POSIX code
can soon use a messy
Author: emax
Date: Tue Jun 5 21:35:47 2012
New Revision: 236644
URL: http://svn.freebsd.org/changeset/base/236644
Log:
Add a very simple debug tool that would dump list of interfaces,
addresses on each interface, and, associated refcounter. I found
it handy to check for address refcounter
On Tue, Jun 05, 2012 at 11:30:34PM +0200, Joerg Sonnenberger wrote:
On Wed, Jun 06, 2012 at 01:01:54AM +0400, Andrey Chernov wrote:
On Wed, Jun 06, 2012 at 06:11:01AM +1000, Bruce Evans wrote:
This is essentially unusable (so a bad idea). Instead of unconditionally
saving and restoring
Author: emax
Date: Tue Jun 5 22:02:27 2012
New Revision: 236645
URL: http://svn.freebsd.org/changeset/base/236645
Log:
Fix license
Pointed by: brueffer
Modified:
head/tools/tools/ifpifa/ifpifa.c
Modified: head/tools/tools/ifpifa/ifpifa.c
Author: kevlo
Date: Wed Jun 6 02:42:30 2012
New Revision: 236649
URL: http://svn.freebsd.org/changeset/base/236649
Log:
Check the return value of pci_find_cap()
Modified:
head/sys/dev/ae/if_ae.c
Modified: head/sys/dev/ae/if_ae.c
53 matches
Mail list logo
