Re: svn commit: r274340 - in head/sys: crypto/rijndael dev/random geom/bde

2014-11-11 Thread Dag-Erling Smørgrav
Bjoern A. Zeeb b...@freebsd.org writes: This fails to compile on all gcc platforms. cc1: warnings being treated as errors /scratch/tmp/bz/head.svn/sys/modules/geom/geom_bde/../../../crypto/rijndael/rijndael-api-fst.c: In function 'rijndael_padEncrypt':

svn commit: r274374 - head/sys/net

2014-11-11 Thread Gleb Smirnoff
Author: glebius Date: Tue Nov 11 10:22:33 2014 New Revision: 274374 URL: https://svnweb.freebsd.org/changeset/base/274374 Log: Move struct ether_vlan_header to ethernet.h, out of if_vlan_var.h, since this structure is protocol definition, not part of implementation. Modified:

Re: svn commit: r273582 - in head/sys/amd64: amd64 include

2014-11-11 Thread Konstantin Belousov
On Mon, Nov 10, 2014 at 03:18:04PM -0500, Ed Maste wrote: On 24 October 2014 05:48, Roger Pau Monn?? roy...@freebsd.org wrote: Author: royger Date: Fri Oct 24 09:48:58 2014 New Revision: 273582 URL: https://svnweb.freebsd.org/changeset/base/273582 Log: amd64: make uiomove_fromphys

Re: svn commit: r274340 - in head/sys: crypto/rijndael dev/random geom/bde

2014-11-11 Thread Bruce Evans
On Tue, 11 Nov 2014, [utf-8] Dag-Erling Sm??rgrav wrote: Bjoern A. Zeeb b...@freebsd.org writes: This fails to compile on all gcc platforms. cc1: warnings being treated as errors /scratch/tmp/bz/head.svn/sys/modules/geom/geom_bde/../../../crypto/rijndael/rijndael-api-fst.c: In function

svn commit: r274376 - in head/sys: net netinet

2014-11-11 Thread Hans Petter Selasky
Author: hselasky Date: Tue Nov 11 12:05:59 2014 New Revision: 274376 URL: https://svnweb.freebsd.org/changeset/base/274376 Log: Fix some minor TSO issues: - Improve description of TSO limits. - Remove a not needed KASSERT() - Remove some not needed variable casts. Sponsored by:

svn commit: r274377 - head/sys/dev/agp

2014-11-11 Thread Konstantin Belousov
Author: kib Date: Tue Nov 11 12:37:13 2014 New Revision: 274377 URL: https://svnweb.freebsd.org/changeset/base/274377 Log: On 965 and higher, map GTT as write-combining. Sponsored by: The FreeBSD Foundation MFC after:1 week Modified: head/sys/dev/agp/agp_i810.c Modified:

svn commit: r274378 - head/sys/dev/agp

2014-11-11 Thread Konstantin Belousov
Author: kib Date: Tue Nov 11 12:52:45 2014 New Revision: 274378 URL: https://svnweb.freebsd.org/changeset/base/274378 Log: Based on some BIOS configuration (GGC register in host bridge, bit 1), IGP may declare subclass as either VGA-compatible, or non-VGA. The difference is that in the

svn commit: r274379 - head/sys/dev/agp

2014-11-11 Thread Konstantin Belousov
Author: kib Date: Tue Nov 11 12:56:30 2014 New Revision: 274379 URL: https://svnweb.freebsd.org/changeset/base/274379 Log: Initial attachment of the agp(4) to Haswell IGP. There is no handling of cacheablility control bits in GTT PTEs yet. Sponsored by: The FreeBSD Foundation MFC

Re: svn commit: r274365 - head/contrib/tzcode/stdtime

2014-11-11 Thread Andrey Chernov
On 11.11.2014 7:07, Garrett Cooper wrote: Author: ngie Date: Tue Nov 11 04:07:41 2014 New Revision: 274365 URL: https://svnweb.freebsd.org/changeset/base/274365 Log: Revert WiP to contrib/tzcode accidentally committed with r274364 This code is wrong in any case, setting EOVERFLOW even

svn commit: r274380 - head/sys/crypto/rijndael

2014-11-11 Thread Dag-Erling Smørgrav
Author: des Date: Tue Nov 11 13:37:28 2014 New Revision: 274380 URL: https://svnweb.freebsd.org/changeset/base/274380 Log: Fix gcc build: preserve const qualifier when casting input values. Noticed by: bz@ Submitted by: dim@ Modified: head/sys/crypto/rijndael/rijndael-api-fst.c

Re: svn commit: r274340 - in head/sys: crypto/rijndael dev/random geom/bde

2014-11-11 Thread Dag-Erling Smørgrav
Bruce Evans b...@optusnet.com.au writes: -Wcast-qual is not a very good warning option since the official way to remove qualifiers in C is to cast them away. Casting them away is better than using the __DECONST() abomination. The option exists because it is too easy for sloppy code to cast

svn commit: r274381 - head/sys/dev/random

2014-11-11 Thread Konstantin Belousov
Author: kib Date: Tue Nov 11 14:30:35 2014 New Revision: 274381 URL: https://svnweb.freebsd.org/changeset/base/274381 Log: Update comment. Noted by: dim Approved by: secteam (des) MFC after:4 days Modified: head/sys/dev/random/ivy.c Modified: head/sys/dev/random/ivy.c

svn commit: r274382 - head/sys/amd64/include

2014-11-11 Thread Ed Maste
Author: emaste Date: Tue Nov 11 14:59:46 2014 New Revision: 274382 URL: https://svnweb.freebsd.org/changeset/base/274382 Log: Add workaround for vt efifb's early use of PHYS_TO_DMAP In vt_efifb_init the framebuffer's physaddr is passed to PHYS_TO_DMAP before the DMAP is setup. The result

Re: svn commit: r274365 - head/contrib/tzcode/stdtime

2014-11-11 Thread Garrett Cooper
On Nov 11, 2014, at 05:33, Andrey Chernov a...@freebsd.org wrote: On 11.11.2014 7:07, Garrett Cooper wrote: Author: ngie Date: Tue Nov 11 04:07:41 2014 New Revision: 274365 URL: https://svnweb.freebsd.org/changeset/base/274365 Log: Revert WiP to contrib/tzcode accidentally committed

Re: svn commit: r274365 - head/contrib/tzcode/stdtime

2014-11-11 Thread Andrey Chernov
On 11.11.2014 18:34, Garrett Cooper wrote: This code is wrong in any case, setting EOVERFLOW even in unneeded no-error cases like breaking from the loop. See how NetBSD does it correctly instead. Hi! I saw your reply earlier but hadn't gotten an opportunity to revise the patch like

Re: svn commit: r274340 - in head/sys: crypto/rijndael dev/random geom/bde

2014-11-11 Thread Brooks Davis
On Tue, Nov 11, 2014 at 03:07:54PM +0100, Dag-Erling Sm?rgrav wrote: Bruce Evans b...@optusnet.com.au writes: -Wcast-qual is not a very good warning option since the official way to remove qualifiers in C is to cast them away. Casting them away is better than using the __DECONST()

Re: svn commit: r274340 - in head/sys: crypto/rijndael dev/random geom/bde

2014-11-11 Thread David Chisnall
On 11 Nov 2014, at 16:31, Brooks Davis bro...@freebsd.org wrote: In general, we need to fix the C/C++ standard to us express the things we actually mean when we use const (for example see strchr()'s use of const). I believe the last issue now being tracked on Google's internal list of

svn commit: r274383 - head/contrib/hyperv/tools

2014-11-11 Thread Xin LI
Author: delphij Date: Tue Nov 11 16:49:33 2014 New Revision: 274383 URL: https://svnweb.freebsd.org/changeset/base/274383 Log: Test errno against EEXIST as well. MFC after:3 days Modified: head/contrib/hyperv/tools/hv_kvp_daemon.c Modified: head/contrib/hyperv/tools/hv_kvp_daemon.c

svn commit: r274384 - head

2014-11-11 Thread David Christensen
Author: davidch Date: Tue Nov 11 16:51:00 2014 New Revision: 274384 URL: https://svnweb.freebsd.org/changeset/base/274384 Log: Remove myself from bxe(4) maintenance. Modified: head/MAINTAINERS Modified: head/MAINTAINERS

Re: svn commit: r274365 - head/contrib/tzcode/stdtime

2014-11-11 Thread John Baldwin
On Tuesday, November 11, 2014 11:06:24 am Andrey Chernov wrote: On 11.11.2014 18:34, Garrett Cooper wrote: This code is wrong in any case, setting EOVERFLOW even in unneeded no-error cases like breaking from the loop. See how NetBSD does it correctly instead. Hi! I saw your reply

svn commit: r274386 - in head/sys/dev: acpica pci

2014-11-11 Thread Adrian Chadd
Author: adrian Date: Tue Nov 11 17:14:11 2014 New Revision: 274386 URL: https://svnweb.freebsd.org/changeset/base/274386 Log: Use the correct device (child) when asking the bus layer about which power state said device should go into. This was a snafu introduced in the ACPI/PCI awareness

Re: svn commit: r274151 - head/usr.bin/w

2014-11-11 Thread Andrey V. Elsukov
On 06.11.2014 02:54, Marcel Moolenaar wrote: Author: marcel Date: Wed Nov 5 23:54:33 2014 New Revision: 274151 URL: https://svnweb.freebsd.org/changeset/base/274151 - (void)printf( %d user%s, nusers, nusers == 1 ? : s); + xo_emit( {:users/%d} user%s, nusers, nusers == 1 ? : s);

Re: svn commit: r274151 - head/usr.bin/w

2014-11-11 Thread Andrey V. Elsukov
On 11.11.2014 20:29, Andrey V. Elsukov wrote: On 06.11.2014 02:54, Marcel Moolenaar wrote: Author: marcel Date: Wed Nov 5 23:54:33 2014 New Revision: 274151 URL: https://svnweb.freebsd.org/changeset/base/274151 -(void)printf( %d user%s, nusers, nusers == 1 ? : s); +xo_emit(

Re: svn commit: r274365 - head/contrib/tzcode/stdtime

2014-11-11 Thread Andrey Chernov
On 11.11.2014 19:34, John Baldwin wrote: On Tuesday, November 11, 2014 11:06:24 am Andrey Chernov wrote: On 11.11.2014 18:34, Garrett Cooper wrote: This code is wrong in any case, setting EOVERFLOW even in unneeded no-error cases like breaking from the loop. See how NetBSD does it correctly

Re: svn commit: r273266 - in head: lib/libkvm sys/compat/freebsd32 sys/kern sys/sys

2014-11-11 Thread Adrian Chadd
On 10 November 2014 23:22, Dimitry Andric d...@freebsd.org wrote: It is indeed used to calculate an address offset, but as it is already checked against NOCPU, it should be good: gnu/usr.bin/gdb/kgdb/kthr.c:kt-cpu = td.td_oncpu; gnu/usr.bin/gdb/kgdb/trgt_i386.c: if

svn commit: r274390 - head/sys/dev/rp

2014-11-11 Thread John Baldwin
Author: jhb Date: Tue Nov 11 18:15:05 2014 New Revision: 274390 URL: https://svnweb.freebsd.org/changeset/base/274390 Log: Use the callout(9) API instead of timeout(9). To do this more cleanly, convert a global timer to a per-controller timer. This works much better with locking and

Re: svn commit: r274376 - in head/sys: net netinet

2014-11-11 Thread Gleb Smirnoff
On Tue, Nov 11, 2014 at 12:06:00PM +, Hans Petter Selasky wrote: H Author: hselasky H Date: Tue Nov 11 12:05:59 2014 H New Revision: 274376 H URL: https://svnweb.freebsd.org/changeset/base/274376 H H Log: H Fix some minor TSO issues: H - Improve description of TSO limits. H - Remove a

svn commit: r274391 - head/gnu/usr.bin/gdb/kgdb

2014-11-11 Thread Dimitry Andric
Author: dim Date: Tue Nov 11 18:54:57 2014 New Revision: 274391 URL: https://svnweb.freebsd.org/changeset/base/274391 Log: Change kbdb's kthr::cpu field into an int, to avoid gcc warnings about comparing it with NOCPU, which became -1 recently. While here, avoid using it for address

Re: svn commit: r274365 - head/contrib/tzcode/stdtime

2014-11-11 Thread John Baldwin
On Tuesday, November 11, 2014 12:47:40 pm Andrey Chernov wrote: On 11.11.2014 19:34, John Baldwin wrote: On Tuesday, November 11, 2014 11:06:24 am Andrey Chernov wrote: On 11.11.2014 18:34, Garrett Cooper wrote: This code is wrong in any case, setting EOVERFLOW even in unneeded no-error

svn commit: r274394 - in head/usr.sbin: bsdconfig/timezone tzsetup

2014-11-11 Thread Devin Teske
Author: dteske Date: Tue Nov 11 19:37:17 2014 New Revision: 274394 URL: https://svnweb.freebsd.org/changeset/base/274394 Log: Default `bsdconfig timezone' and `tzsetup' to `-s' in a VM. Recommended by: cperciva Reviewed by: cperciva Relnotes: tzsetup and bsdconfig now assume

Re: svn commit: r274394 - in head/usr.sbin: bsdconfig/timezone tzsetup

2014-11-11 Thread Nathan Whitehorn
On 11/11/14 11:37, Devin Teske wrote: Author: dteske Date: Tue Nov 11 19:37:17 2014 New Revision: 274394 URL: https://svnweb.freebsd.org/changeset/base/274394 Log: Default `bsdconfig timezone' and `tzsetup' to `-s' in a VM. Recommended by: cperciva Reviewed by: cperciva

svn commit: r274397 - head/sys/dev/acpica

2014-11-11 Thread Jung-uk Kim
Author: jkim Date: Tue Nov 11 19:42:10 2014 New Revision: 274397 URL: https://svnweb.freebsd.org/changeset/base/274397 Log: Use the correct device. Note this commit complements r274386. PR: 194884 Modified: head/sys/dev/acpica/acpi.c Modified: head/sys/dev/acpica/acpi.c

RE: svn commit: r274394 - in head/usr.sbin: bsdconfig/timezone tzsetup

2014-11-11 Thread dteske
-Original Message- From: owner-src-committ...@freebsd.org [mailto:owner-src- committ...@freebsd.org] On Behalf Of Nathan Whitehorn Sent: Tuesday, November 11, 2014 11:42 AM To: Devin Teske; src-committ...@freebsd.org; svn-src-...@freebsd.org; svn- src-h...@freebsd.org Subject: Re:

svn commit: r274399 - head/usr.sbin/tzsetup

2014-11-11 Thread Devin Teske
Author: dteske Date: Tue Nov 11 19:45:14 2014 New Revision: 274399 URL: https://svnweb.freebsd.org/changeset/base/274399 Log: Fix whitespace. Thanks to:nwhitehorn Modified: head/usr.sbin/tzsetup/tzsetup.c Modified: head/usr.sbin/tzsetup/tzsetup.c

svn commit: r274398 - head/sys/boot/i386/loader

2014-11-11 Thread John Baldwin
Author: jhb Date: Tue Nov 11 19:44:59 2014 New Revision: 274398 URL: https://svnweb.freebsd.org/changeset/base/274398 Log: Move NFS and TFTP filesystems before the synthetic filesystems (bzip, gzip, and split). Real filesystems should always be listed first so that the bare filename is

Re: svn commit: r274397 - head/sys/dev/acpica

2014-11-11 Thread Adrian Chadd
Hah, good catch! -adrian On 11 November 2014 11:42, Jung-uk Kim j...@freebsd.org wrote: Author: jkim Date: Tue Nov 11 19:42:10 2014 New Revision: 274397 URL: https://svnweb.freebsd.org/changeset/base/274397 Log: Use the correct device. Note this commit complements r274386. PR:

svn commit: r274402 - head/sys/dev/cxgbe

2014-11-11 Thread John Baldwin
Author: jhb Date: Tue Nov 11 20:05:50 2014 New Revision: 274402 URL: https://svnweb.freebsd.org/changeset/base/274402 Log: Add device ID for the T502-BT (dual-port 1G) adapter. Reviewed by: np MFC after:1 week Modified: head/sys/dev/cxgbe/t4_main.c Modified:

Re: svn commit: r274403 - in head/sys: compat/freebsd32 kern sys

2014-11-11 Thread Adrian Chadd
... wait a sec, you're removing this without even asking first? I've been using this locally to implement / benchmark zero-copy socket writes from userland, which is what it was initially intended for. It's the only sane way of implementing notifications for shared memory based sendfile. I was

Re: svn commit: r274398 - head/sys/boot/i386/loader

2014-11-11 Thread John Baldwin
On Tuesday, November 11, 2014 2:45:00 pm John Baldwin wrote: Author: jhb Date: Tue Nov 11 19:44:59 2014 New Revision: 274398 URL: https://svnweb.freebsd.org/changeset/base/274398 Log: Move NFS and TFTP filesystems before the synthetic filesystems (bzip, gzip, and split). Real

svn commit: r274405 - in head/contrib/libxo: . libxo tests/core tests/core/saved

2014-11-11 Thread Marcel Moolenaar
Author: marcel Date: Tue Nov 11 21:37:17 2014 New Revision: 274405 URL: https://svnweb.freebsd.org/changeset/base/274405 Log: Upgrade libxo to 0.1.5 Obtained from: https://github.com/Juniper/libxo Modified: head/contrib/libxo/README.md head/contrib/libxo/configure.ac

svn commit: r274406 - head/usr.bin/w

2014-11-11 Thread Marcel Moolenaar
Author: marcel Date: Tue Nov 11 21:52:10 2014 New Revision: 274406 URL: https://svnweb.freebsd.org/changeset/base/274406 Log: Fix text output for the uptime command. Reported by: Max N. Boyarov zot...@bsd.by, ae@ Modified: head/usr.bin/w/w.c Modified: head/usr.bin/w/w.c

svn commit: r274407 - head/sys/boot/common

2014-11-11 Thread Peter Grehan
Author: grehan Date: Tue Nov 11 22:03:11 2014 New Revision: 274407 URL: https://svnweb.freebsd.org/changeset/base/274407 Log: Fix incorrect reading of 32-bit modinfo by 64-bit loaders. The various structures in the mod_metadata set of a FreeBSD kernel and modules contain pointers. The

svn commit: r274408 - in head/sys: compat/freebsd32 kern

2014-11-11 Thread Gleb Smirnoff
Author: glebius Date: Tue Nov 11 22:08:18 2014 New Revision: 274408 URL: https://svnweb.freebsd.org/changeset/base/274408 Log: Fix build. Modified: head/sys/compat/freebsd32/freebsd32_misc.c head/sys/kern/uipc_syscalls.c Modified: head/sys/compat/freebsd32/freebsd32_misc.c

Re: svn commit: r274403 - in head/sys: compat/freebsd32 kern sys

2014-11-11 Thread Adrian Chadd
Gleb and I talked about this privately. We agreed to keep this out of the tree for the time being, even though I have code that uses this and does do quite a bit of traffic with it. I'm going to use this as an excuse to finally write up a proper wire pages into mbufs and write them out api for

Re: svn commit: r274340 - in head/sys: crypto/rijndael dev/random geom/bde

2014-11-11 Thread Bruce Evans
On Tue, 11 Nov 2014, [utf-8] Dag-Erling Sm??rgrav wrote: Bruce Evans b...@optusnet.com.au writes: -Wcast-qual is not a very good warning option since the official way to remove qualifiers in C is to cast them away. Casting them away is better than using the __DECONST() abomination. The

svn commit: r274409 - head/sys/arm/broadcom/bcm2835

2014-11-11 Thread Luiz Otavio O Souza
Author: loos Date: Tue Nov 11 23:55:37 2014 New Revision: 274409 URL: https://svnweb.freebsd.org/changeset/base/274409 Log: Since r273264 the SD card detection on Raspberry Pi is reliably working and that expose new bugs with HS mode. When the old code could not do the proper card

svn commit: r274410 - head/usr.bin/mkimg

2014-11-11 Thread Marcel Moolenaar
Author: marcel Date: Wed Nov 12 00:10:27 2014 New Revision: 274410 URL: https://svnweb.freebsd.org/changeset/base/274410 Log: SEEK_DATA has interesting behaviour for sparse files on ZFS. A sparse file with 128K of random data and truncated to 800K can have SEEK_DATA return -1 when given an

Re: svn commit: r274340 - in head/sys: crypto/rijndael dev/random geom/bde

2014-11-11 Thread Bruce Evans
On Tue, 11 Nov 2014, Brooks Davis wrote: On Tue, Nov 11, 2014 at 03:07:54PM +0100, Dag-Erling Sm?rgrav wrote: I agree that __DECONST() is ugly (not least because it strips all qualifiers, not just const, so it should be DEQUAL()), but the alternative is worse. In my experience, the majority

svn commit: r274411 - head/sys/cam/scsi

2014-11-11 Thread Alexander Motin
Author: mav Date: Wed Nov 12 01:28:28 2014 New Revision: 274411 URL: https://svnweb.freebsd.org/changeset/base/274411 Log: Improve CAM's reaction on asymmetric access errors. MFC after:1 month Modified: head/sys/cam/scsi/scsi_all.c Modified: head/sys/cam/scsi/scsi_all.c

svn commit: r274412 - head/sys/arm/freescale/imx

2014-11-11 Thread Ian Lepore
Author: ian Date: Wed Nov 12 02:37:27 2014 New Revision: 274412 URL: https://svnweb.freebsd.org/changeset/base/274412 Log: Bugfixes for the imx5/imx6 iomux fdt_pinctrl driver. I originally overlooked a couple flag bits defined in the fdt binding docs. One flag suppresses the pad

svn commit: r274413 - head/sys/dev/fdt

2014-11-11 Thread Ian Lepore
Author: ian Date: Wed Nov 12 02:38:25 2014 New Revision: 274413 URL: https://svnweb.freebsd.org/changeset/base/274413 Log: Remove an #ifdef DEBUG wrapper, and instead use if (bootverbose). Modified: head/sys/dev/fdt/fdt_pinctrl.c Modified: head/sys/dev/fdt/fdt_pinctrl.c

svn commit: r274414 - head/sys/arm/freescale/imx

2014-11-11 Thread Ian Lepore
Author: ian Date: Wed Nov 12 02:44:27 2014 New Revision: 274414 URL: https://svnweb.freebsd.org/changeset/base/274414 Log: Fix the reversed sense of the PADCONF_NONE test. Modified: head/sys/arm/freescale/imx/imx_iomux.c Modified: head/sys/arm/freescale/imx/imx_iomux.c

svn commit: r274415 - head/sys/arm/broadcom/bcm2835

2014-11-11 Thread Luiz Otavio O Souza
Author: loos Date: Wed Nov 12 03:07:46 2014 New Revision: 274415 URL: https://svnweb.freebsd.org/changeset/base/274415 Log: Fix the error checking, broken on r273337, to _not_ ignore controller errors. Without this fix you can't even scan the bus (all operations will always succeed).

svn commit: r274416 - head/usr.sbin/i2c

2014-11-11 Thread Luiz Otavio O Souza
Author: loos Date: Wed Nov 12 03:59:26 2014 New Revision: 274416 URL: https://svnweb.freebsd.org/changeset/base/274416 Log: Fix a few cases of use of uninitialized variables. Found with -Wall. MFC after:1 week Modified: head/usr.sbin/i2c/i2c.c Modified: head/usr.sbin/i2c/i2c.c