Re: svn commit: r277199 - in head/sys: fs/devfs kern

Hi, On 01/15/15 04:31, Konstantin Belousov wrote: Please do not commit (to devfs) without seeking for the review first. I was a bit stuck this time either having the choice to back out a USB patch fixing no problems or to fix the kernel devfs to support what I needed. Actually "devfs" is n

Re: svn commit: r277199 - in head/sys: fs/devfs kern

On Thu, Jan 15, 2015 at 08:41:31AM +0100, Hans Petter Selasky wrote: > On 01/15/15 04:31, Konstantin Belousov wrote: > > On Wed, Jan 14, 2015 at 10:07:13PM +, Hans Petter Selasky wrote: > >> Author: hselasky > >> Date: Wed Jan 14 22:07:13 2015 > >> New Revision: 277199 > >> URL: https://svnweb.

svn commit: r277211 - head/sys/compat/freebsd32

Author: kib Date: Thu Jan 15 10:43:58 2015 New Revision: 277211 URL: https://svnweb.freebsd.org/changeset/base/277211 Log: fcntl F_O{GET,SET}LK take pointer as the arg, handle them properly for compat32. Reported and tested by: Alex Tutubalin Sponsored by: The FreeBSD Foundation

Re: svn commit: r277199 - in head/sys: fs/devfs kern

On 01/15/15 10:38, Konstantin Belousov wrote: On Thu, Jan 15, 2015 at 08:41:31AM +0100, Hans Petter Selasky wrote: On 01/15/15 04:31, Konstantin Belousov wrote: On Wed, Jan 14, 2015 at 10:07:13PM +, Hans Petter Selasky wrote: Author: hselasky Date: Wed Jan 14 22:07:13 2015 New Revision: 27

Re: svn commit: r277199 - in head/sys: fs/devfs kern

On Thu, Jan 15, 2015 at 11:49:09AM +0100, Hans Petter Selasky wrote: > On 01/15/15 10:38, Konstantin Belousov wrote: > > On Thu, Jan 15, 2015 at 08:41:31AM +0100, Hans Petter Selasky wrote: > >> On 01/15/15 04:31, Konstantin Belousov wrote: > >>> On Wed, Jan 14, 2015 at 10:07:13PM +, Hans Pette

Re: svn commit: r277199 - in head/sys: fs/devfs kern

On 01/15/15 12:51, Konstantin Belousov wrote: On Thu, Jan 15, 2015 at 11:49:09AM +0100, Hans Petter Selasky wrote: I see no leakage in that case either! Because these cases come through destroy_dev(). Are there more cases which I don't see? You are breaking existig devfs KPI by your hack.

Re: svn commit: r277204 - head/sys/amd64/conf

On Thu, Jan 15, 2015 at 12:42:07AM +, Warner Losh wrote: > Author: imp > Date: Thu Jan 15 00:42:06 2015 > New Revision: 277204 > URL: https://svnweb.freebsd.org/changeset/base/277204 > > Log: > New MINIMAL kernel config. The goal with this configuration is to > only compile in those optio

Re: svn commit: r277204 - head/sys/amd64/conf

On Thu, Jan 15, 2015 at 04:23:03PM +0300, Slawa Olhovchenkov wrote: > On Thu, Jan 15, 2015 at 12:42:07AM +, Warner Losh wrote: > > New Revision: 277204 > > URL: https://svnweb.freebsd.org/changeset/base/277204 > > > > Log: > > New MINIMAL kernel config. The goal with this configuration is to

Re: svn commit: r277204 - head/sys/amd64/conf

On Thu, Jan 15, 2015 at 01:44:46PM +, Alexey Dokuchaev wrote: > On Thu, Jan 15, 2015 at 04:23:03PM +0300, Slawa Olhovchenkov wrote: > > On Thu, Jan 15, 2015 at 12:42:07AM +, Warner Losh wrote: > > > New Revision: 277204 > > > URL: https://svnweb.freebsd.org/changeset/base/277204 > > > > >

Re: svn commit: r277204 - head/sys/amd64/conf

On Thu, Jan 15, 2015 at 04:53:42PM +0300, Slawa Olhovchenkov wrote: > On Thu, Jan 15, 2015 at 01:44:46PM +, Alexey Dokuchaev wrote: > > intention. AFAIR last time we had a discussion about why our default > > kernel is not MINIMAL, it boiled down to two main problems: 1) loader's > > caching o

Re: svn commit: r255323 - in head/sys: amd64/conf i386/conf

On Sun, Sep 08, 2013 at 01:02:44AM +0400, Slawa Olhovchenkov wrote: > On Sat, Sep 07, 2013 at 10:48:48PM +0200, Edward Tomasz Napiera?a wrote: > > > I'll be happy if someone does this right now, by populating a > > > /boot/loader.modules or something, and then force the "fixing" of > > > loader to

Re: svn commit: r277204 - head/sys/amd64/conf

On 15.01.2015 17:08, Alexey Dokuchaev wrote: >> reading large monolitic kernel is slow too. > > But not nearly as slow as loading 50-60 modules at boot time (on my stable/8 > I have 59 right now). When you read one big file *once* you don't have to > worry about caching reads. With everything mo

Re: svn commit: r277204 - head/sys/amd64/conf

On Thu, Jan 15, 2015 at 05:35:41PM +0300, Andrey V. Elsukov wrote: > On 15.01.2015 17:08, Alexey Dokuchaev wrote: > > When you read one big file *once* you don't have to worry about caching > > reads. With everything moved to modules, loader does a lot of > > superfluous disk access, and to remedy

svn commit: r277212 - head/contrib/ofed/management/opensm/osmtest

Author: hselasky Date: Thu Jan 15 14:47:48 2015 New Revision: 277212 URL: https://svnweb.freebsd.org/changeset/base/277212 Log: Fix compilation for 32-bit architectures. PR: 196580 Sponsored by: Mellanox Technologies MFC after:3 days Modified: head/contrib/ofed/manageme

Re: svn commit: r277163 - head/sys/dev/cardbus

On 1/14/15 7:07 PM, Warner Losh wrote: > >> On Jan 14, 2015, at 7:23 AM, John Baldwin wrote: >> >> On 1/14/15 12:41 AM, Warner Losh wrote: >>> Author: imp >>> Date: Wed Jan 14 05:41:31 2015 >>> New Revision: 277163 >>> URL: https://svnweb.freebsd.org/changeset/base/277163 >>> >>> Log: >>> Add a

svn commit: r277213 - in head: share/man/man9 sys/kern sys/ofed/include/linux sys/sys

Author: hselasky Date: Thu Jan 15 15:32:30 2015 New Revision: 277213 URL: https://svnweb.freebsd.org/changeset/base/277213 Log: Major callout subsystem cleanup and rewrite: - Close a migration race where callout_reset() failed to set the CALLOUT_ACTIVE flag. - Callout callback functions

Re: svn commit: r277204 - head/sys/amd64/conf

On 1/14/15 7:42 PM, Warner Losh wrote: > Author: imp > Date: Thu Jan 15 00:42:06 2015 > New Revision: 277204 > URL: https://svnweb.freebsd.org/changeset/base/277204 > > Log: > New MINIMAL kernel config. The goal with this configuration is to > only compile in those options in GENERIC that cann

Re: svn commit: r277213 - in head: share/man/man9 sys/kern sys/ofed/include/linux sys/sys

On 1/15/15 10:32 AM, Hans Petter Selasky wrote: > Author: hselasky > Date: Thu Jan 15 15:32:30 2015 > New Revision: 277213 > URL: https://svnweb.freebsd.org/changeset/base/277213 > > Log: > Major callout subsystem cleanup and rewrite: > - Close a migration race where callout_reset() failed to

Re: svn commit: r277213 - in head: share/man/man9 sys/kern sys/ofed/include/linux sys/sys

On 15 January 2015 at 10:53, John Baldwin wrote: > On 1/15/15 10:32 AM, Hans Petter Selasky wrote: >> Author: hselasky >> Date: Thu Jan 15 15:32:30 2015 >> New Revision: 277213 >> URL: https://svnweb.freebsd.org/changeset/base/277213 >> > Eh, I have not reviewed this at all. (I still plan to thou

Re: svn commit: r277213 - in head: share/man/man9 sys/kern sys/ofed/include/linux sys/sys

On 01/15/15 16:53, John Baldwin wrote: On 1/15/15 10:32 AM, Hans Petter Selasky wrote: Author: hselasky Date: Thu Jan 15 15:32:30 2015 New Revision: 277213 URL: https://svnweb.freebsd.org/changeset/base/277213 Hi, Eh, I have not reviewed this at all. (I still plan to though.) The "Revi

svn commit: r277214 - in head/sys/dev/sound: pci pcm

Author: bapt Date: Thu Jan 15 16:09:35 2015 New Revision: 277214 URL: https://svnweb.freebsd.org/changeset/base/277214 Log: Sound: fix typos in user visible messages etc. Submitted by: Sascha Wildner Obtained from:DragonFly MFC after:3 days Modified: head/sys/dev/sound/p

Re: svn commit: r277163 - head/sys/dev/cardbus

On 01/14/15 16:07, Warner Losh wrote: On Jan 14, 2015, at 8:32 AM, Justin Hibbits wrote: On Wed, 14 Jan 2015 09:23:05 -0500 John Baldwin wrote: On 1/14/15 12:41 AM, Warner Losh wrote: Author: imp Date: Wed Jan 14 05:41:31 2015 New Revision: 277163 URL: https://svnweb.freebsd.org/changeset/

Re: svn commit: r277204 - head/sys/amd64/conf

On Thu, Jan 15, 2015 at 10:51:55AM -0500, John Baldwin wrote: > > [...] > > +# Pseudo devices. > > +device loop# Network loopback > > +device random # Entropy device > > +device padlock_rng # VIA Padlock RNG > > +d

svn commit: r277215 - in head/sys: amd64/include boot/common boot/fdt boot/forth boot/i386/libi386 boot/i386/loader i386/include x86/xen

Author: royger Date: Thu Jan 15 16:27:20 2015 New Revision: 277215 URL: https://svnweb.freebsd.org/changeset/base/277215 Log: loader: implement multiboot support for Xen Dom0 Implement a subset of the multiboot specification in order to boot Xen and a FreeBSD Dom0 from the FreeBSD bootloa

Re: svn commit: r277213 - in head: share/man/man9 sys/kern sys/ofed/include/linux sys/sys

Hans, On Thu, Jan 15, 2015 at 05:05:58PM +0100, Hans Petter Selasky wrote: H> > Eh, I have not reviewed this at all. (I still plan to though.) H> H> The "Reviewed by" was simply a C&P of the review list in from the H> Differential Revision. When you mention it should probably simply have said

Re: svn commit: r277213 - in head: share/man/man9 sys/kern sys/ofed/include/linux sys/sys

On Thu, Jan 15, 2015 at 08:14:30PM +0300, Gleb Smirnoff wrote: T> I'd dare to say that such important change simply cannot be committed T> with a thorough review from at least two people very confident in this T> area. Of course, I typoed. I meant "cannot be committed withOUT a thorough review".

Re: svn commit: r277213 - in head: share/man/man9 sys/kern sys/ofed/include/linux sys/sys

On Thu, Jan 15, 2015 at 05:05:58PM +0100, Hans Petter Selasky wrote: > The "Reviewed by" was simply a C&P of the review list in from the > Differential Revision. When you mention it should probably simply have said: > > Reviewed by: sbruno @ > > Due to the meaning of "Reviewed by" in commit messa

Re: svn commit: r277213 - in head: share/man/man9 sys/kern sys/ofed/include/linux sys/sys

On Thu, Jan 15, 2015 at 7:32 AM, Hans Petter Selasky wrote: > Author: hselasky > Date: Thu Jan 15 15:32:30 2015 > New Revision: 277213 > URL: https://svnweb.freebsd.org/changeset/base/277213 > > Log: > Major callout subsystem cleanup and rewrite: I plan to review this as well -- although I didn

Re: svn commit: r277213 - in head: share/man/man9 sys/kern sys/ofed/include/linux sys/sys

> On 15 Jan 2015, at 15:32 , Hans Petter Selasky wrote: > > Author: hselasky > Date: Thu Jan 15 15:32:30 2015 > New Revision: 277213 > URL: https://svnweb.freebsd.org/changeset/base/277213 > > Log: > Major callout subsystem cleanup and rewrite: I see this for i386 and amd64 LINT* kernels. I

Re: svn commit: r277163 - head/sys/dev/cardbus

On 1/15/15 11:20 AM, Nathan Whitehorn wrote: > > On 01/14/15 16:07, Warner Losh wrote: >>> On Jan 14, 2015, at 8:32 AM, Justin Hibbits >>> wrote: >>> >>> On Wed, 14 Jan 2015 09:23:05 -0500 >>> John Baldwin wrote: >>> On 1/14/15 12:41 AM, Warner Losh wrote: > Author: imp > Date: Wed

Re: svn commit: r277213 - in head: share/man/man9 sys/kern sys/ofed/include/linux sys/sys

On 1/15/15 12:15 PM, Gleb Smirnoff wrote: > On Thu, Jan 15, 2015 at 08:14:30PM +0300, Gleb Smirnoff wrote: > T> I'd dare to say that such important change simply cannot be committed > T> with a thorough review from at least two people very confident in this > T> area. > > Of course, I typoed. I me

svn commit: r277216 - in head: etc/defaults etc/periodic/daily share/man/man5

Author: gjb Date: Thu Jan 15 19:52:19 2015 New Revision: 277216 URL: https://svnweb.freebsd.org/changeset/base/277216 Log: Evaluate running userland/kernel version in daily periodic(8) run, taken from uname(1) '-U' and '-K' flags. Reviewed by: allanjude, dvl Differential Revi

Re: svn commit: r277163 - head/sys/dev/cardbus

On 01/15/15 10:51, John Baldwin wrote: On 1/15/15 11:20 AM, Nathan Whitehorn wrote: On 01/14/15 16:07, Warner Losh wrote: On Jan 14, 2015, at 8:32 AM, Justin Hibbits wrote: On Wed, 14 Jan 2015 09:23:05 -0500 John Baldwin wrote: On 1/14/15 12:41 AM, Warner Losh wrote: Author: imp Date: We

Re: svn commit: r277213 - in head: share/man/man9 sys/kern sys/ofed/include/linux sys/sys

On 01/15/15 19:46, Bjoern A. Zeeb wrote: On 15 Jan 2015, at 15:32 , Hans Petter Selasky wrote: Author: hselasky Date: Thu Jan 15 15:32:30 2015 New Revision: 277213 URL: https://svnweb.freebsd.org/changeset/base/277213 Log: Major callout subsystem cleanup and rewrite: I see this for i386

svn commit: r277217 - in head: contrib/libc++ contrib/libc++/include contrib/libc++/include/experimental contrib/libc++/include/ext contrib/libc++/src lib/libc++

Author: dim Date: Thu Jan 15 21:17:36 2015 New Revision: 277217 URL: https://svnweb.freebsd.org/changeset/base/277217 Log: Import libc++ trunk r224926. This fixes a number of bugs, completes C++14 support[1], adds more C++1z features[2], and fixes the following LWG issues[3]: 1450: Con

svn commit: r277218 - head/share/man/man4

Author: jfv Date: Thu Jan 15 21:47:02 2015 New Revision: 277218 URL: https://svnweb.freebsd.org/changeset/base/277218 Log: First draft man pages for ixl and ixlv drivers. MFC after: 1 week Added: head/share/man/man4/ixl.4 (contents, props changed) head/share/man/man4/ixlv.4 (conten

Re: svn commit: r277218 - head/share/man/man4

On Thu, Jan 15, 2015 at 09:47:03PM +, Jack F Vogel wrote: > Author: jfv > Date: Thu Jan 15 21:47:02 2015 > New Revision: 277218 > URL: https://svnweb.freebsd.org/changeset/base/277218 > > Log: > First draft man pages for ixl and ixlv drivers. > > MFC after: 1 week > [...] > +.Nm > +dri

svn commit: r277219 - head/share/man/man4

Author: jfv Date: Thu Jan 15 22:17:11 2015 New Revision: 277219 URL: https://svnweb.freebsd.org/changeset/base/277219 Log: Add needed bits to the Makefile, and the Mt to the emails. Thanks to Nathan and Baptiste for the corrections :) MFC after: 1 week Modified: head/share/man/man4/Mak

Re: svn commit: r277215 - in head/sys: amd64/include boot/common boot/fdt boot/forth boot/i386/libi386 boot/i386/loader i386/include x86/xen

On Thu, 2015-01-15 at 16:27 +, Roger Pau Monné wrote: > Author: royger > Date: Thu Jan 15 16:27:20 2015 > New Revision: 277215 > URL: https://svnweb.freebsd.org/changeset/base/277215 > > Log: > loader: implement multiboot support for Xen Dom0 > [...] > > Added: > head/sys/boot/i386/libi

svn commit: r277225 - in head/sys: conf modules/cxgbe/if_cxgbe

Author: np Date: Fri Jan 16 01:28:28 2015 New Revision: 277225 URL: https://svnweb.freebsd.org/changeset/base/277225 Log: Make cxgbe(4) buildable with the gcc in base. Modified: head/sys/conf/files head/sys/modules/cxgbe/if_cxgbe/Makefile Modified: head/sys/conf/files =

svn commit: r277226 - head/sys/dev/cxgbe

Author: np Date: Fri Jan 16 01:32:40 2015 New Revision: 277226 URL: https://svnweb.freebsd.org/changeset/base/277226 Log: Allow cxgbe(4) to be built on i386. Driver attach will succeed only on a subset of i386 systems. Modified: head/sys/dev/cxgbe/t4_main.c head/sys/dev/cxgbe/t4_mp_ring

svn commit: r277227 - in head/sys: amd64/conf arm/conf conf modules powerpc/conf

Author: np Date: Fri Jan 16 01:39:24 2015 New Revision: 277227 URL: https://svnweb.freebsd.org/changeset/base/277227 Log: Plug cxgbe(4) back into !powerpc && !arm builds, instead of building it on amd64 only. Modified: head/sys/amd64/conf/NOTES head/sys/arm/conf/NOTES head/sys/conf/NOTE

svn commit: r277228 - head/sys/dev/ath

Author: adrian Date: Fri Jan 16 01:52:26 2015 New Revision: 277228 URL: https://svnweb.freebsd.org/changeset/base/277228 Log: Check the right value correctly. Thanks to clang for pointing out this silliness. Modified: head/sys/dev/ath/if_ath.c Modified: head/sys/dev/ath/if_ath.c ===

svn commit: r277229 - head/sys/ofed/include/linux

Author: np Date: Fri Jan 16 02:20:24 2015 New Revision: 277229 URL: https://svnweb.freebsd.org/changeset/base/277229 Log: Use parentheses instead of close proximity to ensure layer + 1 is evaluated before the rest of the expression. Modified: head/sys/ofed/include/linux/linux_idr.c Modifie

Re: svn commit: r277227 - in head/sys: amd64/conf arm/conf conf modules powerpc/conf

On 01/15/15 17:39, Navdeep Parhar wrote: Author: np Date: Fri Jan 16 01:39:24 2015 New Revision: 277227 URL: https://svnweb.freebsd.org/changeset/base/277227 Log: Plug cxgbe(4) back into !powerpc && !arm builds, instead of building it on amd64 only. Modified: head/sys/amd64/conf/NOTES

Re: svn commit: r277227 - in head/sys: amd64/conf arm/conf conf modules powerpc/conf

On Thu, Jan 15, 2015 at 06:34:31PM -0800, Nathan Whitehorn wrote: > > On 01/15/15 17:39, Navdeep Parhar wrote: > >Author: np > >Date: Fri Jan 16 01:39:24 2015 > >New Revision: 277227 > >URL: https://svnweb.freebsd.org/changeset/base/277227 > > > >Log: > > Plug cxgbe(4) back into !powerpc && !arm

svn commit: r277230 - head/sys/modules

Author: np Date: Fri Jan 16 03:39:38 2015 New Revision: 277230 URL: https://svnweb.freebsd.org/changeset/base/277230 Log: Build cxgbe(4) on powerpc64 too. Modified: head/sys/modules/Makefile Modified: head/sys/modules/Makefile =

svn commit: r277232 - head/sys/dev/pccbb

Author: imp Date: Fri Jan 16 06:19:08 2015 New Revision: 277232 URL: https://svnweb.freebsd.org/changeset/base/277232 Log: Back out the refactor. It turns out to cause interrupt storms on resume sometimes (but not others). On powerup, other wierd issues show up (sometimes the card comes up,

svn commit: r277234 - head/sys/dev/pccbb

Author: imp Date: Fri Jan 16 06:19:39 2015 New Revision: 277234 URL: https://svnweb.freebsd.org/changeset/base/277234 Log: Move the suspsned and resume functions to the bus attachment. They were accessing PCI config registers, which won't work for the ISA version. Modified: head/sys/dev/p

svn commit: r277233 - head/sys/dev/pccbb

Author: imp Date: Fri Jan 16 06:19:24 2015 New Revision: 277233 URL: https://svnweb.freebsd.org/changeset/base/277233 Log: Suspend and resume were the only two functions not to follow the brdev convention here, so fix that. Modified: head/sys/dev/pccbb/pccbb.c Modified: head/sys/dev/pccbb/

svn commit: r277231 - head/sys/modules

Author: imp Date: Fri Jan 16 06:19:05 2015 New Revision: 277231 URL: https://svnweb.freebsd.org/changeset/base/277231 Log: Add back a couple PC Card devices to amd64. There's only a couple of them that were popular enough, so this doesn't adversly affect build times. Modified: head/sys/mo

svn commit: r277235 - head/sys/dev/pccbb

Author: imp Date: Fri Jan 16 06:19:52 2015 New Revision: 277235 URL: https://svnweb.freebsd.org/changeset/base/277235 Log: Always enable I/O, memory and dma cycles. Some BIOSes don't enable them, sometimes they are reset for power state transitions or during whatever happens while suspended.

svn commit: r277236 - head/sys/kern

Author: kib Date: Fri Jan 16 07:06:58 2015 New Revision: 277236 URL: https://svnweb.freebsd.org/changeset/base/277236 Log: For sigaction(2), ignore possible garbage in sa_flags for sa_handler == SIG_DFL or SIG_IGN. Sloppy code does not fully initialize struct sigaction for such cases, and b