Re: svn commit: r277806 - head/sys/dev/vt

2015-01-27 Thread Bruce Evans
On Tue, 27 Jan 2015, Xin LI wrote: Log: Use unsigned int for index value. Without this change a local attacker could trigger a panic by tricking the kernel into accessing undefined kernel memory. Why not fix the range check instead of using even more type hacks/errors? Modified: head/sys

Re: svn commit: r277737 - in head: etc/pam.d tools/build/mk

2015-01-27 Thread Dag-Erling Smørgrav
Garrett Cooper writes: > I disagree for a few reasons: > 1. style.Makefile(9) makes no mention of having to use an idiom over > the other. That is only one of many things it does not mention. That doesn't mean we don't have idioms and conventions outside what is described in that document. > 2.

svn commit: r277823 - head/sys/dev/ath/ath_rate/sample

2015-01-27 Thread Adrian Chadd
Author: adrian Date: Wed Jan 28 04:44:42 2015 New Revision: 277823 URL: https://svnweb.freebsd.org/changeset/base/277823 Log: Cast everything to something longer than 32 bits so the sample mask doesn't get truncated to 32 bits. Without this, 3x3 NICs transmitting at an MCS rate whose rix

svn commit: r277822 - head/sys/dev/ath/ath_rate/sample

2015-01-27 Thread Adrian Chadd
Author: adrian Date: Wed Jan 28 04:42:40 2015 New Revision: 277822 URL: https://svnweb.freebsd.org/changeset/base/277822 Log: Print out the final_rix if there's a problem. Modified: head/sys/dev/ath/ath_rate/sample/sample.c Modified: head/sys/dev/ath/ath_rate/sample/sample.c

svn commit: r277821 - head/sys/dev/ath/ath_hal

2015-01-27 Thread Adrian Chadd
Author: adrian Date: Wed Jan 28 04:02:56 2015 New Revision: 277821 URL: https://svnweb.freebsd.org/changeset/base/277821 Log: Add a new HAL capability - required to compile the updated AR9300 HAL i have lying about. Modified: head/sys/dev/ath/ath_hal/ah_internal.h Modified: head/sys/dev/at

Re: svn commit: r277737 - in head: etc/pam.d tools/build/mk

2015-01-27 Thread Warner Losh
> On Jan 26, 2015, at 7:26 PM, Garrett Cooper wrote: > > On Jan 26, 2015, at 4:23, Dag-Erling Smørgrav wrote: > >> Garrett Cooper writes: >>> Log: >>> Honor MK_ACCT with etc/pam.d/atrun >> >> The correct idiom would be > > I disagree for a few reasons: > 1. style.Makefile(9) makes no mentio

Re: svn commit: r277806 - head/sys/dev/vt

2015-01-27 Thread Ed Maste
On 27 January 2015 at 14:35, Xin LI wrote: > Author: delphij > Date: Tue Jan 27 19:35:41 2015 > New Revision: 277806 > URL: https://svnweb.freebsd.org/changeset/base/277806 > ... > > More information can be found at CORE Security's advisory at: > http://www.coresecurity.com/content/freebsd-ker

Re: svn commit: r277652 - in head/usr.sbin/pw: . tests

2015-01-27 Thread Baptiste Daroussin
On Tue, Jan 27, 2015 at 04:08:28PM -0800, Devin Teske wrote: > > > On Jan 27, 2015, at 3:44 PM, Baptiste Daroussin wrote: > > > > On Mon, Jan 26, 2015 at 01:20:28PM -0800, Devin Teske wrote: > >> > >>> On Jan 25, 2015, at 7:31 AM, Bruce Evans wrote: > >>> > >>> On Sun, 25 Jan 2015, Slawa Olho

Re: svn commit: r277652 - in head/usr.sbin/pw: . tests

2015-01-27 Thread Devin Teske
> On Jan 27, 2015, at 3:44 PM, Baptiste Daroussin wrote: > > On Mon, Jan 26, 2015 at 01:20:28PM -0800, Devin Teske wrote: >> >>> On Jan 25, 2015, at 7:31 AM, Bruce Evans wrote: >>> >>> On Sun, 25 Jan 2015, Slawa Olhovchenkov wrote: >>> On Sun, Jan 25, 2015 at 04:56:24PM +1100, Bruce Eva

Re: svn commit: r277652 - in head/usr.sbin/pw: . tests

2015-01-27 Thread Baptiste Daroussin
On Mon, Jan 26, 2015 at 01:20:28PM -0800, Devin Teske wrote: > > > On Jan 25, 2015, at 7:31 AM, Bruce Evans wrote: > > > > On Sun, 25 Jan 2015, Slawa Olhovchenkov wrote: > > > >> On Sun, Jan 25, 2015 at 04:56:24PM +1100, Bruce Evans wrote: > >> > >>> Negative ids have historical abuses in plac

Re: svn commit: r277652 - in head/usr.sbin/pw: . tests

2015-01-27 Thread Robert Watson
On Sun, 25 Jan 2015, Bruce Evans wrote: Negative ids have historical abuses in places like mountd. mountd still hard-codes -2 and -2 for the default uid and gid of an unprivileged user. It at least casts these values to uid_t and gid_t before using them. This gives the ids the non-random valu

Re: svn commit: r277681 - in head/sys: conf modules

2015-01-27 Thread Warner Losh
> On Jan 26, 2015, at 7:30 PM, Garrett Cooper wrote: > > On Jan 25, 2015, at 9:46, Warner Losh wrote: > >> The number of MK_foo opts that are intruding into the kernel module builds is >> starting to get out of hand. :( Especially since they are duplicative of the >> MODULES_OVERRIDE functiona

Re: svn commit: r277798 - head/bin/expr

2015-01-27 Thread NGie Cooper
On Tue, Jan 27, 2015 at 10:04 AM, Stefan Esser wrote: > Author: se > Date: Tue Jan 27 18:04:41 2015 > New Revision: 277798 > URL: https://svnweb.freebsd.org/changeset/base/277798 > > Log: > Fix overflow check for multiplication: > - Add special test to detect the case of -1 * INTMAX_MIN > -

Re: svn commit: r277796 - in head/sys: dev/acpica dev/syscons dev/vt sys

2015-01-27 Thread Ivan Klymenko
В Tue, 27 Jan 2015 17:33:19 + (UTC) Andriy Gapon пишет: > Author: avg > Date: Tue Jan 27 17:33:18 2015 > New Revision: 277796 > URL: https://svnweb.freebsd.org/changeset/base/277796 > > Log: > hook userland threads suspend + resume into acpi suspend code > > Also, split power_suspend

svn commit: r277815 - head/sys/netinet

2015-01-27 Thread Michael Tuexen
Author: tuexen Date: Tue Jan 27 21:30:24 2015 New Revision: 277815 URL: https://svnweb.freebsd.org/changeset/base/277815 Log: Whitespace change. Modified: head/sys/netinet/sctp_usrreq.c Modified: head/sys/netinet/sctp_usrreq.c =

svn commit: r277814 - head/contrib/amd/amd

2015-01-27 Thread Pedro F. Giffuni
Author: pfg Date: Tue Jan 27 20:48:05 2015 New Revision: 277814 URL: https://svnweb.freebsd.org/changeset/base/277814 Log: amd: Add extra check for NULL before deref. CID: 274421 Obtained from:NetBSD MFC after:5 days Modified: head/contrib/amd/amd/amfs_generic.c

svn commit: r277811 - head/usr.bin/sed

2015-01-27 Thread Pedro F. Giffuni
Author: pfg Date: Tue Jan 27 19:46:19 2015 New Revision: 277811 URL: https://svnweb.freebsd.org/changeset/base/277811 Log: sed: fix pasto from previous r277802. MFC after:3 days Modified: head/usr.bin/sed/main.c Modified: head/usr.bin/sed/main.c =

svn commit: r277806 - head/sys/dev/vt

2015-01-27 Thread Xin LI
Author: delphij Date: Tue Jan 27 19:35:41 2015 New Revision: 277806 URL: https://svnweb.freebsd.org/changeset/base/277806 Log: Use unsigned int for index value. Without this change a local attacker could trigger a panic by tricking the kernel into accessing undefined kernel memory. W

svn commit: r277805 - head/sys/netinet

2015-01-27 Thread Xin LI
Author: delphij Date: Tue Jan 27 19:35:38 2015 New Revision: 277805 URL: https://svnweb.freebsd.org/changeset/base/277805 Log: Fix SCTP stream reset vulnerability. We would like to acknowledge Gerasimos Dimitriadis who reported the issue and Michael Tuexen who analyzed and provided the

svn commit: r277804 - head/sys/netinet

2015-01-27 Thread Xin LI
Author: delphij Date: Tue Jan 27 19:35:36 2015 New Revision: 277804 URL: https://svnweb.freebsd.org/changeset/base/277804 Log: Fix SCTP SCTP_SS_VALUE kernel memory corruption and disclosure vulnerability. We would like to acknowledge Clement LECIGNE from Google Security Team and Francisco

svn commit: r277802 - head/usr.bin/sed

2015-01-27 Thread Pedro F. Giffuni
Author: pfg Date: Tue Jan 27 18:58:24 2015 New Revision: 277802 URL: https://svnweb.freebsd.org/changeset/base/277802 Log: Fix resource leak and dereference after NULL. process.c: Protect access against NULL. main.c: Prevent outfile overwrite resource leak. CID: 271181 CID:

svn commit: r277800 - head/usr.sbin/pmcstudy

2015-01-27 Thread Randall Stewart
Author: rrs Date: Tue Jan 27 18:56:22 2015 New Revision: 277800 URL: https://svnweb.freebsd.org/changeset/base/277800 Log: Fix yet another coverty warning (missing io is NULL check) and in examining that warning I see yet another issue where we should be pclosing the io in the event of the

svn commit: r277801 - head/lib/libthread_db/arch/i386

2015-01-27 Thread Dimitry Andric
Author: dim Date: Tue Jan 27 18:56:46 2015 New Revision: 277801 URL: https://svnweb.freebsd.org/changeset/base/277801 Log: Constify a struct savexmm pointer in pt_ucontext_to_fpreg(), to silence a -Wcast-qual warning from clang 3.6.0. Modified: head/lib/libthread_db/arch/i386/libpthread_md.

svn commit: r277799 - head/sbin/geom/class/mountver

2015-01-27 Thread Edward Tomasz Napierala
Author: trasz Date: Tue Jan 27 18:27:07 2015 New Revision: 277799 URL: https://svnweb.freebsd.org/changeset/base/277799 Log: Fix sysctl name. MFC after:1 month Sponsored by: The FreeBSD Foundation Modified: head/sbin/geom/class/mountver/gmountver.8 Modified: head/sbin/geom/class/m

svn commit: r277798 - head/bin/expr

2015-01-27 Thread Stefan Esser
Author: se Date: Tue Jan 27 18:04:41 2015 New Revision: 277798 URL: https://svnweb.freebsd.org/changeset/base/277798 Log: Fix overflow check for multiplication: - Add special test to detect the case of -1 * INTMAX_MIN - Protect against elimination of the test division by the optimizer G

Re: svn commit: r277796 - in head/sys: dev/acpica dev/syscons dev/vt sys

2015-01-27 Thread Konstantin Belousov
On Tue, Jan 27, 2015 at 05:33:19PM +, Andriy Gapon wrote: > Author: avg > Date: Tue Jan 27 17:33:18 2015 > New Revision: 277796 > URL: https://svnweb.freebsd.org/changeset/base/277796 > > Log: > hook userland threads suspend + resume into acpi suspend code > > Also, split power_suspend

svn commit: r277797 - head/sys/netipsec

2015-01-27 Thread Andrey V. Elsukov
Author: ae Date: Tue Jan 27 17:46:55 2015 New Revision: 277797 URL: https://svnweb.freebsd.org/changeset/base/277797 Log: key_spdget uses key_setdumpsp() without SPTREE_RLOCK held (it uses referenced pointer to sp). Remove SPTREE_RLOCK_ASSERT from key_setdumpsp() to fix wrong assertion.

svn commit: r277796 - in head/sys: dev/acpica dev/syscons dev/vt sys

2015-01-27 Thread Andriy Gapon
Author: avg Date: Tue Jan 27 17:33:18 2015 New Revision: 277796 URL: https://svnweb.freebsd.org/changeset/base/277796 Log: hook userland threads suspend + resume into acpi suspend code Also, split power_suspend into power_suspend and power_suspend_early. power_suspend_early is called b

svn commit: r277795 - in head/sys/dev: fb vt vt/hw/fb

2015-01-27 Thread Andriy Gapon
Author: avg Date: Tue Jan 27 15:28:46 2015 New Revision: 277795 URL: https://svnweb.freebsd.org/changeset/base/277795 Log: vt(4): Use power_{suspend,resume} event handlers to implement suspend/resume The goal is to avoid that the vt(4) resume happens before the video display is resumed.

svn commit: r277794 - head/sys/ufs/ufs

2015-01-27 Thread Konstantin Belousov
Author: kib Date: Tue Jan 27 10:32:49 2015 New Revision: 277794 URL: https://svnweb.freebsd.org/changeset/base/277794 Log: The sys_quotactl() contract demands that the mount point is vfs_unbusy()ed when the cmd is Q_QUOTAON, regardless of other input parameters or error return. Submitte

svn commit: r277793 - head/share/man/man9

2015-01-27 Thread Konstantin Belousov
Author: kib Date: Tue Jan 27 09:48:02 2015 New Revision: 277793 URL: https://svnweb.freebsd.org/changeset/base/277793 Log: Rewrite pmap_enter(9) man page. In collaboration with:alc Differential Revision: https://reviews.freebsd.org/D1531 Sponsored by: The FreeBSD Foundation and

Re: svn commit: r277737 - in head: etc/pam.d tools/build/mk

2015-01-27 Thread Dag-Erling Smørgrav
Alexey Dokuchaev writes: > As someone who writes makefile daily I would agree, but there should be a > reason why it was always done with _foo. One obvious one is that it shows > up front all possible values, including conditional ones, which can also > help not to forget something when backporti