svn commit: r298694 - head/sys/dev/hyperv/netvsc

2016-04-26 Thread Sepherosa Ziehau
Author: sephe Date: Wed Apr 27 06:49:16 2016 New Revision: 298694 URL: https://svnweb.freebsd.org/changeset/base/298694 Log: hyperv/hn: Add stat for # of chimney sending tries MFC after:1 week Sponsored by: Microsoft OSTC Modified: head/sys/dev/hyperv/netvsc/hv_net_vsc.h head/sys

svn commit: r298693 - head/sys/dev/hyperv/vmbus

2016-04-26 Thread Sepherosa Ziehau
Author: sephe Date: Wed Apr 27 05:45:14 2016 New Revision: 298693 URL: https://svnweb.freebsd.org/changeset/base/298693 Log: hyperv/vmbus: Mark sysctls MPSAFE MFC after:1 week Sponsored by: Microsoft OSTC Modified: head/sys/dev/hyperv/vmbus/hv_channel.c head/sys/dev/hyperv/vmbus/

svn commit: r298690 - head/sys/dev/hyperv/netvsc

2016-04-26 Thread Sepherosa Ziehau
Author: sephe Date: Wed Apr 27 05:18:04 2016 New Revision: 298690 URL: https://svnweb.freebsd.org/changeset/base/298690 Log: hyperv/hn: Mark sysctls MPSAFE MFC after:1 week Sponsored by: Microsoft OSTC Modified: head/sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c Modified: head/sys

svn commit: r298689 - head/sys/dev/hyperv/netvsc

2016-04-26 Thread Sepherosa Ziehau
Author: sephe Date: Wed Apr 27 05:05:54 2016 New Revision: 298689 URL: https://svnweb.freebsd.org/changeset/base/298689 Log: hyperv/hn: Remove unapplied comment. Chimney sending buffers are shared across channels. MFC after:1 week Sponsored by: Microsoft OSTC Modified: head/sy

svn commit: r298688 - head/sys/dev/hyperv/netvsc

2016-04-26 Thread Sepherosa Ziehau
Author: sephe Date: Wed Apr 27 04:51:28 2016 New Revision: 298688 URL: https://svnweb.freebsd.org/changeset/base/298688 Log: hyperv/hn: Restart sending earlier once we gathered some free TX descs This greatly reduces the oqdrops under heavy workload. For TCP send/recv test (10K concurr

svn commit: r298687 - head/usr.sbin/config

2016-04-26 Thread Marcelo Araujo
Author: araujo Date: Wed Apr 27 03:06:53 2016 New Revision: 298687 URL: https://svnweb.freebsd.org/changeset/base/298687 Log: For pointers use NULL instead of 0. Reviewed by: rpaulo MFC after:2 weeks. Differential Revision:https://reviews.freebsd.org/D5946 Modified: head

svn commit: r298686 - head/usr.bin/top

2016-04-26 Thread Marcelo Araujo
Author: araujo Date: Wed Apr 27 02:44:10 2016 New Revision: 298686 URL: https://svnweb.freebsd.org/changeset/base/298686 Log: Use MIN() macro from sys/param.h. MFC after:2 weeks. Modified: head/usr.bin/top/machine.c Modified: head/usr.bin/top/machine.c ==

svn commit: r298685 - head/usr.bin/tftp

2016-04-26 Thread Marcelo Araujo
Author: araujo Date: Wed Apr 27 02:34:25 2016 New Revision: 298685 URL: https://svnweb.freebsd.org/changeset/base/298685 Log: Use MIN() macro from sys/param.h. MFC after:2 weeks. Modified: head/usr.bin/tftp/main.c Modified: head/usr.bin/tftp/main.c ==

svn commit: r298684 - head/usr.bin/systat

2016-04-26 Thread Marcelo Araujo
Author: araujo Date: Wed Apr 27 02:26:31 2016 New Revision: 298684 URL: https://svnweb.freebsd.org/changeset/base/298684 Log: Use macro MIN() from sys/param.h. MFC after:2 weeks. Modified: head/usr.bin/systat/main.c Modified: head/usr.bin/systat/main.c ==

svn commit: r298683 - in head/sys: kern sys

2016-04-26 Thread Jamie Gritton
Author: jamie Date: Wed Apr 27 02:25:21 2016 New Revision: 298683 URL: https://svnweb.freebsd.org/changeset/base/298683 Log: Delay revmoing the last jail reference in prison_proc_free, and instead put it off into the pr_task. This is similar to prison_free, and in fact uses the same task ev

svn commit: r298682 - head/usr.bin/quota

2016-04-26 Thread Marcelo Araujo
Author: araujo Date: Wed Apr 27 02:13:57 2016 New Revision: 298682 URL: https://svnweb.freebsd.org/changeset/base/298682 Log: Use MIN() macro from sys/param.h. MFC after:2 weeks. Modified: head/usr.bin/quota/quota.c Modified: head/usr.bin/quota/quota.c ==

svn commit: r298681 - head/sbin/ifconfig

2016-04-26 Thread Marcelo Araujo
Author: araujo Date: Wed Apr 27 02:02:44 2016 New Revision: 298681 URL: https://svnweb.freebsd.org/changeset/base/298681 Log: Use macro MIN() from sys/param.h. MFC after:2 weeks. Modified: head/sbin/ifconfig/sfp.c Modified: head/sbin/ifconfig/sfp.c ==

svn commit: r298680 - head/sbin/fsck_ffs

2016-04-26 Thread Pedro F. Giffuni
Author: pfg Date: Wed Apr 27 01:36:25 2016 New Revision: 298680 URL: https://svnweb.freebsd.org/changeset/base/298680 Log: fsck_ffs: Revert partially the unsigned changes. Any value of uint16_t will be internally promoted to int so changing them to an unsigned value doesn't help. Mis

svn commit: r298679 - head/sbin/fsck_ffs

2016-04-26 Thread Pedro F. Giffuni
Author: pfg Date: Wed Apr 27 01:32:11 2016 New Revision: 298679 URL: https://svnweb.freebsd.org/changeset/base/298679 Log: fsck_ffs: Revert partially the unsigned changes. Any value of uint16_t will be internally promoted to int so changing them to an unsigned value doesn't help. Mak

svn commit: r298678 - head/sys/kern

2016-04-26 Thread Conrad E. Meyer
Author: cem Date: Wed Apr 27 00:10:32 2016 New Revision: 298678 URL: https://svnweb.freebsd.org/changeset/base/298678 Log: posix4_mib: Don't overrun facility_initialized array The facility_initialized and facility arrays are the same size and were intended to be indexed the same. I belie

svn commit: r298677 - head/sys/kern

2016-04-26 Thread Conrad E. Meyer
Author: cem Date: Tue Apr 26 23:58:55 2016 New Revision: 298677 URL: https://svnweb.freebsd.org/changeset/base/298677 Log: subr_mbpool: Don't free bogus pointer in error paths An mbpool is allocated with a contiguous array of mbpages. Freeing an individual mbpage has never been valid. D

svn commit: r298676 - head/sys/netipsec

2016-04-26 Thread Conrad E. Meyer
Author: cem Date: Tue Apr 26 23:23:44 2016 New Revision: 298676 URL: https://svnweb.freebsd.org/changeset/base/298676 Log: netipsec: Don't leak memory when deep copy fails Reported by: Coverity CID: 1331693 Sponsored by: EMC / Isilon Storage Division Modified: head/sys/neti

svn commit: r298675 - in head/sys: netinet netinet6

2016-04-26 Thread Conrad E. Meyer
Author: cem Date: Tue Apr 26 23:13:48 2016 New Revision: 298675 URL: https://svnweb.freebsd.org/changeset/base/298675 Log: in_lltable_alloc and in6 copy: Don't leak LLE in error path Fix a memory leak in error conditions introduced in r292978. Reported by: Coverity CIDs: 134

svn commit: r298674 - in head/sys: boot/fdt/dts/arm dev/cadence

2016-04-26 Thread Oleksandr Tymoshenko
Author: gonzo Date: Tue Apr 26 23:09:47 2016 New Revision: 298674 URL: https://svnweb.freebsd.org/changeset/base/298674 Log: Refactor DTS files for Zynq-based SoCs - Factor out common part to zynq-7000.dtsi - Fix problem with Zynq interrupts by using interrupt "triples" in .dtsi fil

svn commit: r298673 - head/sys/netinet

2016-04-26 Thread Conrad E. Meyer
Author: cem Date: Tue Apr 26 23:02:18 2016 New Revision: 298673 URL: https://svnweb.freebsd.org/changeset/base/298673 Log: tcp_usrreq: Free allocated buffer in relock case The disgusting macro INP_WLOCK_RECHECK may early-return. In tcp_default_ctloutput() the TCP_CCALGOOPT case allocates

svn commit: r298672 - head/sys/geom/part

2016-04-26 Thread Conrad E. Meyer
Author: cem Date: Tue Apr 26 22:32:33 2016 New Revision: 298672 URL: https://svnweb.freebsd.org/changeset/base/298672 Log: g_part_bsd64: Delete duplicate/dead code RAW_PART is handled earlier in the loop. Reported by: Coverity CID: 1223201 Sponsored by: EMC / Isilon Stora

svn commit: r298671 - head/sys/geom/part

2016-04-26 Thread Conrad E. Meyer
Author: cem Date: Tue Apr 26 22:30:54 2016 New Revision: 298671 URL: https://svnweb.freebsd.org/changeset/base/298671 Log: g_part_bsd64: Check for valid on-disk npartitions value This value is u32 on disk, but assigned to an int in memory. After we do the implicit conversion via assignme

Re: svn commit: r298664 - head/sys/fs/msdosfs

2016-04-26 Thread Pedro Giffuni
On 04/26/16 16:17, Conrad Meyer wrote: On Tue, Apr 26, 2016 at 2:13 PM, Adrian Chadd wrote: You mean "hotplug mount a malicious USB disk via some installed graphical enviornment?" NOone does that... :) Sure, but there the vulnerability is (IMO) that users are allowed to arbitrarily mount s

Re: svn commit: r298669 - head/sys/dev/iscsi_initiator

2016-04-26 Thread Conrad Meyer
On Tue, Apr 26, 2016 at 2:59 PM, Oliver Pinter wrote: > On Tue, Apr 26, 2016 at 11:44 PM, Conrad E. Meyer wrote: >> Author: cem >> Date: Tue Apr 26 21:44:08 2016 >> New Revision: 298669 >> URL: https://svnweb.freebsd.org/changeset/base/298669 >> ... > > MFC of this commit? You can do it whenever

svn commit: r298670 - head/sys/dev/ciss

2016-04-26 Thread Conrad E. Meyer
Author: cem Date: Tue Apr 26 22:01:07 2016 New Revision: 298670 URL: https://svnweb.freebsd.org/changeset/base/298670 Log: ciss(4): Fix overrun of array The softc member 'ciss_logical' is an array of 'ciss_max_logical_bus' members. Most of the time it is iterated correctly. This patch fi

Re: svn commit: r298669 - head/sys/dev/iscsi_initiator

2016-04-26 Thread Oliver Pinter
On Tue, Apr 26, 2016 at 11:44 PM, Conrad E. Meyer wrote: > Author: cem > Date: Tue Apr 26 21:44:08 2016 > New Revision: 298669 > URL: https://svnweb.freebsd.org/changeset/base/298669 > > Log: > iscsi_initiator(4): Fix use-after-free, double-free > > ism_stop() already destroys and frees 'sp',

Re: svn commit: r298664 - head/sys/fs/msdosfs

2016-04-26 Thread Oliver Pinter
On 4/26/16, Kristof Provost wrote: > >> On 26 Apr 2016, at 23:37, Shawn Webb wrote: >> >> On Tue, Apr 26, 2016 at 11:05:38PM +0200, Kristof Provost wrote: >>> On 26 Apr 2016, at 23:01, Shawn Webb wrote: On Tue, Apr 26, 2016 at 08:36:32PM +, Kristof Provost wrote: > Au

svn commit: r298669 - head/sys/dev/iscsi_initiator

2016-04-26 Thread Conrad E. Meyer
Author: cem Date: Tue Apr 26 21:44:08 2016 New Revision: 298669 URL: https://svnweb.freebsd.org/changeset/base/298669 Log: iscsi_initiator(4): Fix use-after-free, double-free ism_stop() already destroys and frees 'sp', including a call to ic_destroy(). Don't dereference 'sp' after ism_sto

Re: svn commit: r298664 - head/sys/fs/msdosfs

2016-04-26 Thread Kristof Provost
> On 26 Apr 2016, at 23:37, Shawn Webb wrote: > > On Tue, Apr 26, 2016 at 11:05:38PM +0200, Kristof Provost wrote: >> >>> On 26 Apr 2016, at 23:01, Shawn Webb wrote: >>> >>> On Tue, Apr 26, 2016 at 08:36:32PM +, Kristof Provost wrote: Author: kp Date: Tue Apr 26 20:36:32 2016 >>

Re: svn commit: r298664 - head/sys/fs/msdosfs

2016-04-26 Thread Shawn Webb
On Tue, Apr 26, 2016 at 11:05:38PM +0200, Kristof Provost wrote: > > > On 26 Apr 2016, at 23:01, Shawn Webb wrote: > > > > On Tue, Apr 26, 2016 at 08:36:32PM +, Kristof Provost wrote: > >> Author: kp > >> Date: Tue Apr 26 20:36:32 2016 > >> New Revision: 298664 > >> URL: https://svnweb.freeb

Re: svn commit: r298664 - head/sys/fs/msdosfs

2016-04-26 Thread Ngie Cooper
On Tue, Apr 26, 2016 at 2:26 PM, Shawn Webb wrote: > On Tue, Apr 26, 2016 at 11:22:32PM +0200, Kristof Provost wrote: >> >> > On 26 Apr 2016, at 23:18, Shawn Webb wrote: >> > Was secteam@ even involved, then? Seems like a user-facing kernel buffer >> > overflow ought to have involved secteam@. >>

Re: svn commit: r298664 - head/sys/fs/msdosfs

2016-04-26 Thread Shawn Webb
On Tue, Apr 26, 2016 at 11:22:32PM +0200, Kristof Provost wrote: > > > On 26 Apr 2016, at 23:18, Shawn Webb wrote: > > Was secteam@ even involved, then? Seems like a user-facing kernel buffer > > overflow ought to have involved secteam@. > > > No, it wasn???t. This bug had been open for quite a

Re: svn commit: r298664 - head/sys/fs/msdosfs

2016-04-26 Thread Kristof Provost
> On 26 Apr 2016, at 23:18, Shawn Webb wrote: > Was secteam@ even involved, then? Seems like a user-facing kernel buffer > overflow ought to have involved secteam@. > No, it wasn’t. This bug had been open for quite a while, and I just happend to see the report and look at it. > Also, the diffe

svn commit: r298668 - head/sys/kern

2016-04-26 Thread Jamie Gritton
Author: jamie Date: Tue Apr 26 21:19:12 2016 New Revision: 298668 URL: https://svnweb.freebsd.org/changeset/base/298668 Log: Use crcopysafe in jail_attach. Modified: head/sys/kern/kern_jail.c Modified: head/sys/kern/kern_jail.c

Re: svn commit: r298664 - head/sys/fs/msdosfs

2016-04-26 Thread Shawn Webb
On Tue, Apr 26, 2016 at 11:05:38PM +0200, Kristof Provost wrote: > > > On 26 Apr 2016, at 23:01, Shawn Webb wrote: > > > > On Tue, Apr 26, 2016 at 08:36:32PM +, Kristof Provost wrote: > >> Author: kp > >> Date: Tue Apr 26 20:36:32 2016 > >> New Revision: 298664 > >> URL: https://svnweb.freeb

Re: svn commit: r298664 - head/sys/fs/msdosfs

2016-04-26 Thread Conrad Meyer
On Tue, Apr 26, 2016 at 2:13 PM, Adrian Chadd wrote: > You mean "hotplug mount a malicious USB disk via some installed > graphical enviornment?" > > NOone does that... :) Sure, but there the vulnerability is (IMO) that users are allowed to arbitrarily mount stuff. That's a huge attack surface an

Re: svn commit: r298664 - head/sys/fs/msdosfs

2016-04-26 Thread Adrian Chadd
You mean "hotplug mount a malicious USB disk via some installed graphical enviornment?" NOone does that... :) -a ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src

svn commit: r298667 - head/sys/arm/conf

2016-04-26 Thread Oleksandr Tymoshenko
Author: gonzo Date: Tue Apr 26 21:11:52 2016 New Revision: 298667 URL: https://svnweb.freebsd.org/changeset/base/298667 Log: Add dtb/zynq to the list of extra modules required by Zedboard Modified: head/sys/arm/conf/ZEDBOARD Modified: head/sys/arm/conf/ZEDBOARD ==

svn commit: r298666 - head/sys/modules/dtb/zynq

2016-04-26 Thread Oleksandr Tymoshenko
Author: gonzo Date: Tue Apr 26 21:11:01 2016 New Revision: 298666 URL: https://svnweb.freebsd.org/changeset/base/298666 Log: Add dtb/zynq to generate dtb files for Zynq-based boards It seems that the only way to supply dtb to loader on Zynq-based SoCs is to manually generate dtb and place

Re: svn commit: r298664 - head/sys/fs/msdosfs

2016-04-26 Thread Conrad Meyer
On Tue, Apr 26, 2016 at 2:01 PM, Shawn Webb wrote: > On Tue, Apr 26, 2016 at 08:36:32PM +, Kristof Provost wrote: >> Author: kp >> Date: Tue Apr 26 20:36:32 2016 >> New Revision: 298664 >> URL: https://svnweb.freebsd.org/changeset/base/298664 >> >> Log: >> msdosfs: Prevent buffer overflow wh

Re: svn commit: r298664 - head/sys/fs/msdosfs

2016-04-26 Thread Kristof Provost
> On 26 Apr 2016, at 23:01, Shawn Webb wrote: > > On Tue, Apr 26, 2016 at 08:36:32PM +, Kristof Provost wrote: >> Author: kp >> Date: Tue Apr 26 20:36:32 2016 >> New Revision: 298664 >> URL: https://svnweb.freebsd.org/changeset/base/298664 >> >> Log: >> msdosfs: Prevent buffer overflow whe

Re: svn commit: r298664 - head/sys/fs/msdosfs

2016-04-26 Thread Shawn Webb
On Tue, Apr 26, 2016 at 08:36:32PM +, Kristof Provost wrote: > Author: kp > Date: Tue Apr 26 20:36:32 2016 > New Revision: 298664 > URL: https://svnweb.freebsd.org/changeset/base/298664 > > Log: > msdosfs: Prevent buffer overflow when expanding win95 names > > In win2unixfn() we expand

svn commit: r298665 - head/sys/dev/aacraid

2016-04-26 Thread Conrad E. Meyer
Author: cem Date: Tue Apr 26 20:59:21 2016 New Revision: 298665 URL: https://svnweb.freebsd.org/changeset/base/298665 Log: aacraid(4): Fix some mostly trivial buffer overruns strcpy(3) emits a trailing nul byte, trampling fields after the intended destination. Instead, use strncpy(3), in

Re: svn commit: r298585 - in head: sys/kern usr.sbin/jail

2016-04-26 Thread Conrad Meyer
I'll borrow my explanation from the NTB review: There is the sbuf itself, and there is some buffer for data. Either can be on the stack or the heap independently. This is controlled with the DYNSTRUCT and DYNAMIC flags respectively. sbuf_new() just initializes an sbuf. Depending on the inputs pas

Re: svn commit: r298585 - in head: sys/kern usr.sbin/jail

2016-04-26 Thread Ulrich Spörlein
On Apr 26, 2016 11:44 AM, "Conrad Meyer" wrote: > > Right. False positive. Coverity doesn't grok sbuf memory management fully. > If someone can explain it to me in very simple words, I can update the model to make these go away ... maybe. ___ svn-src-

Re: svn commit: r298655 - head/sys/kgssapi

2016-04-26 Thread Conrad Meyer
I don't do stable, and that's my choice to make (and final decision). It would be appropriate to ask, "I'd like to MFC this to stable if it makes sense to do so. Does it make sense?" But I think it is totally inappropriate to try to tell me it is my job to push petty fixes to stable/10, a branch

svn commit: r298664 - head/sys/fs/msdosfs

2016-04-26 Thread Kristof Provost
Author: kp Date: Tue Apr 26 20:36:32 2016 New Revision: 298664 URL: https://svnweb.freebsd.org/changeset/base/298664 Log: msdosfs: Prevent buffer overflow when expanding win95 names In win2unixfn() we expand Windows 95 style long names. In some cases that requires moving the data in the n

svn commit: r298663 - head/sys/net

2016-04-26 Thread Conrad E. Meyer
Author: cem Date: Tue Apr 26 20:27:17 2016 New Revision: 298663 URL: https://svnweb.freebsd.org/changeset/base/298663 Log: radix_mpath: Don't derefence a NULL pointer in for loop iteration It seems rn_dupedkey may be NULL, because of the NULL check inside the loop. (Also, the rt gets assi

Re: svn commit: r298655 - head/sys/kgssapi

2016-04-26 Thread Alan Somers
You really ought to. When you MFC yourself, it reduces the likelihood of errors, because you understand the change best. When someone else does it, it's more likely he'll make a mistake, because he may not know the fine details behind the change. In fact, it's hard for anybody else to even know

svn commit: r298662 - head/sys/dev/pci

2016-04-26 Thread Conrad E. Meyer
Author: cem Date: Tue Apr 26 20:06:35 2016 New Revision: 298662 URL: https://svnweb.freebsd.org/changeset/base/298662 Log: PCI Enhanced Allocation: Annotate an intentional switch fallthrough This is a trivial follow-up to r296308. Annotate the intentional fallthrough to make it clear for

svn commit: r298661 - in head: share/man/man9 sys/compat/linux sys/kern sys/sys

2016-04-26 Thread Conrad E. Meyer
Author: cem Date: Tue Apr 26 19:57:35 2016 New Revision: 298661 URL: https://svnweb.freebsd.org/changeset/base/298661 Log: osd(9): Change array pointer to array pointer type from void* This is a minor follow-up to r297422, prompted by a Coverity warning. (It's not a real defect, just a c

Re: svn commit: r298655 - head/sys/kgssapi

2016-04-26 Thread Conrad Meyer
Nope! I don't do stable/. On Tue, Apr 26, 2016 at 12:06 PM, Alan Somers wrote: > Nice catch. Will you be MFCing this to stable/10? > > On Tue, Apr 26, 2016 at 12:11 PM, Conrad E. Meyer wrote: > >> Author: cem >> Date: Tue Apr 26 18:11:45 2016 >> New Revision: 298655 >> URL: https://svnweb.fre

svn commit: r298660 - head/contrib/netbsd-tests/lib/libc/ssp

2016-04-26 Thread Garrett Cooper
Author: ngie Date: Tue Apr 26 19:21:35 2016 New Revision: 298660 URL: https://svnweb.freebsd.org/changeset/base/298660 Log: Fix up r298368 Remove the semicolon accidentally added after the new conditional that tests that /dev/zero is opened successfully. MFC after: 1 week X-MFC wit

svn commit: r298659 - head/sys/dev/iwm

2016-04-26 Thread Conrad E. Meyer
Author: cem Date: Tue Apr 26 19:06:28 2016 New Revision: 298659 URL: https://svnweb.freebsd.org/changeset/base/298659 Log: iwm(4): Don't dereference potentially NULL pointer before NULL check Introduced in r298594. There is no path before the 'vap == NULL' check where vap is not already

Re: svn commit: r298655 - head/sys/kgssapi

2016-04-26 Thread Alan Somers
Nice catch. Will you be MFCing this to stable/10? On Tue, Apr 26, 2016 at 12:11 PM, Conrad E. Meyer wrote: > Author: cem > Date: Tue Apr 26 18:11:45 2016 > New Revision: 298655 > URL: https://svnweb.freebsd.org/changeset/base/298655 > > Log: > kgssapi: Don't leak memory in error cases > > R

svn commit: r298658 - head/usr.sbin/etcupdate

2016-04-26 Thread Bjoern Heidotting
Author: bhd (doc committer) Date: Tue Apr 26 18:54:44 2016 New Revision: 298658 URL: https://svnweb.freebsd.org/changeset/base/298658 Log: Remove redundant word. Reviewed by: bjk, bcr Differential Revision:https://reviews.freebsd.org/D6064 Modified: head/usr.sbin/etcupdate/et

Re: svn commit: r298656 - head/sys/kern

2016-04-26 Thread James Gritton
It turns out I was just about to commit that anyway, so the only difference is I didn't need to put "(mis)" in the comment :-). ipcs(1) was prone to allocation errors that I could bypass by rewriting the sysctls without sbufs. So false positive, but for the best anyway. - Jamie On 2016-04-

Re: svn commit: r298656 - head/sys/kern

2016-04-26 Thread Conrad Meyer
The sbuf use here was fine before. Best, Conrad On Tue, Apr 26, 2016 at 11:17 AM, Jamie Gritton wrote: > Author: jamie > Date: Tue Apr 26 18:17:44 2016 > New Revision: 298656 > URL: https://svnweb.freebsd.org/changeset/base/298656 > > Log: > Redo the changes to the SYSV IPC sysctl functions f

Re: svn commit: r298585 - in head: sys/kern usr.sbin/jail

2016-04-26 Thread Conrad Meyer
Right. False positive. Coverity doesn't grok sbuf memory management fully. On Tue, Apr 26, 2016 at 11:22 AM, NGie Cooper wrote: > > > On Apr 26, 2016, at 11:03, Ulrich Spörlein wrote: > > > > 2016-04-25 10:06 GMT-07:00 Jamie Gritton : > >> Author: jamie > >> Date: Mon Apr 25 17:06:50 2016 > >

Re: svn commit: r298657 - head/sys/dev/sound/pci

2016-04-26 Thread Pedro Giffuni
On 04/26/16 13:20, Conrad E. Meyer wrote: Author: cem Date: Tue Apr 26 18:20:41 2016 New Revision: 298657 URL: https://svnweb.freebsd.org/changeset/base/298657 Log: emu10kx: Don't iterate beyond array bounds Reported by: Coverity CID: 1354978 Sponsored by: EMC / Isilon Stora

Re: svn commit: r298585 - in head: sys/kern usr.sbin/jail

2016-04-26 Thread NGie Cooper
> On Apr 26, 2016, at 11:03, Ulrich Spörlein wrote: > > 2016-04-25 10:06 GMT-07:00 Jamie Gritton : >> Author: jamie >> Date: Mon Apr 25 17:06:50 2016 >> New Revision: 298585 >> URL: https://svnweb.freebsd.org/changeset/base/298585 >> >> Log: >> Encapsulate SYSV IPC objects in jails. Define pe

svn commit: r298657 - head/sys/dev/sound/pci

2016-04-26 Thread Conrad E. Meyer
Author: cem Date: Tue Apr 26 18:20:41 2016 New Revision: 298657 URL: https://svnweb.freebsd.org/changeset/base/298657 Log: emu10kx: Don't iterate beyond array bounds Reported by: Coverity CID: 1354978 Sponsored by: EMC / Isilon Storage Division Modified: head/sys/dev/sound/

svn commit: r298656 - head/sys/kern

2016-04-26 Thread Jamie Gritton
Author: jamie Date: Tue Apr 26 18:17:44 2016 New Revision: 298656 URL: https://svnweb.freebsd.org/changeset/base/298656 Log: Redo the changes to the SYSV IPC sysctl functions from r298585, so they don't (mis)use sbufs. PR: 48471 Modified: head/sys/kern/sysv_msg.c head/sys/k

svn commit: r298655 - head/sys/kgssapi

2016-04-26 Thread Conrad E. Meyer
Author: cem Date: Tue Apr 26 18:11:45 2016 New Revision: 298655 URL: https://svnweb.freebsd.org/changeset/base/298655 Log: kgssapi: Don't leak memory in error cases Reported by: Coverity CIDs: 1007046, 1007047, 1007048 Sponsored by: EMC / Isilon Storage Division Modified: he

svn commit: r298654 - head

2016-04-26 Thread Bryan Drewery
Author: bdrewery Date: Tue Apr 26 18:08:51 2016 New Revision: 298654 URL: https://svnweb.freebsd.org/changeset/base/298654 Log: WITH_META_MODE: Allow buildkernel to create .meta files with curdir==objdir. Without this the incremental build was broken since .depend.* are not generated with

Re: svn commit: r298585 - in head: sys/kern usr.sbin/jail

2016-04-26 Thread Ulrich Spörlein
2016-04-25 10:06 GMT-07:00 Jamie Gritton : > Author: jamie > Date: Mon Apr 25 17:06:50 2016 > New Revision: 298585 > URL: https://svnweb.freebsd.org/changeset/base/298585 > > Log: > Encapsulate SYSV IPC objects in jails. Define per-module parameters > sysvmsg, sysvsem, and sysvshm, with the fo

Re: svn commit: r298585 - in head: sys/kern usr.sbin/jail

2016-04-26 Thread Konstantin Belousov
On Mon, Apr 25, 2016 at 05:06:50PM +, Jamie Gritton wrote: > Author: jamie > Date: Mon Apr 25 17:06:50 2016 > New Revision: 298585 > URL: https://svnweb.freebsd.org/changeset/base/298585 > > Log: > Encapsulate SYSV IPC objects in jails. Define per-module parameters > sysvmsg, sysvsem, and

svn commit: r298652 - head/sys/mips/mips

2016-04-26 Thread Adrian Chadd
Author: adrian Date: Tue Apr 26 16:40:04 2016 New Revision: 298652 URL: https://svnweb.freebsd.org/changeset/base/298652 Log: [mips] correctly represent memory region allocations >> 2^^31 Without this, it'd get promoted incorrectly and fail allocation. Submitted by: Mori Hiroki Revi

svn commit: r298651 - head/sys/dev/spibus

2016-04-26 Thread Ruslan Bukin
Author: br Date: Tue Apr 26 16:02:13 2016 New Revision: 298651 URL: https://svnweb.freebsd.org/changeset/base/298651 Log: Fix the parameter type according to method declaration. This fixes compilation on riscv with GCC 5.2.0 Modified: head/sys/dev/spibus/spibus.c Modified: head/sys/dev/spi

Re: svn commit: r298650 - head/sys/boot/kshim

2016-04-26 Thread Hans Petter Selasky
On 04/26/16 17:44, Pedro Giffuni wrote: Thank you, and sorry for breakage! No problem. Fix is trivial. --HPS ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src

Re: svn commit: r298650 - head/sys/boot/kshim

2016-04-26 Thread Pedro Giffuni
Thank you, and sorry for breakage! Pedro. On 04/26/16 10:41, Hans Petter Selasky wrote: Author: hselasky Date: Tue Apr 26 15:41:31 2016 New Revision: 298650 URL: https://svnweb.freebsd.org/changeset/base/298650 Log: Build fix. Add howmany() and nitems() macros to bootloader kernel shim. Mod

svn commit: r298650 - head/sys/boot/kshim

2016-04-26 Thread Hans Petter Selasky
Author: hselasky Date: Tue Apr 26 15:41:31 2016 New Revision: 298650 URL: https://svnweb.freebsd.org/changeset/base/298650 Log: Build fix. Add howmany() and nitems() macros to bootloader kernel shim. Modified: head/sys/boot/kshim/bsd_kernel.h Modified: head/sys/boot/kshim/bsd_kernel.h ==

svn commit: r298649 - in head/sys: cam/ata cam/scsi compat/ndis fs/msdosfs geom/part geom/raid geom/uzip kern kgssapi/krb5 net netgraph

2016-04-26 Thread Pedro F. Giffuni
Author: pfg Date: Tue Apr 26 15:38:17 2016 New Revision: 298649 URL: https://svnweb.freebsd.org/changeset/base/298649 Log: sys: extend use of the howmany() macro when available. We have a howmany() macro in the header that is convenient to re-use as it makes things easier to read. Modif

svn commit: r298648 - head/sys/arm/arm

2016-04-26 Thread Bjoern A. Zeeb
Author: bz Date: Tue Apr 26 15:34:00 2016 New Revision: 298648 URL: https://svnweb.freebsd.org/changeset/base/298648 Log: Mark the unused period argument __unused. Reviewed by: andrew MFC after:2 weeks Sponsored by: DARPA/AFRL Modified: head/sys/arm/arm/generic_timer.c Modified

svn commit: r298647 - head/sys/boot/usb

2016-04-26 Thread Hans Petter Selasky
Author: hselasky Date: Tue Apr 26 15:33:53 2016 New Revision: 298647 URL: https://svnweb.freebsd.org/changeset/base/298647 Log: Add function needed for linking USB test application. Modified: head/sys/boot/usb/bsd_usbloader_test.c Modified: head/sys/boot/usb/bsd_usbloader_test.c

svn commit: r298646 - in head/sys/dev: age amr bwn cy fatm fb jme mcd mfi mlx mmc/host ncr patm ral sbni scd sfxge siba sound/usb sym usb usb/controller usb/wlan vt/hw/vga xen/grant_table xen/netback

2016-04-26 Thread Pedro F. Giffuni
Author: pfg Date: Tue Apr 26 15:03:15 2016 New Revision: 298646 URL: https://svnweb.freebsd.org/changeset/base/298646 Log: sys/dev: extend use of the howmany() macro when available. We have a howmany() macro in the header that is convenient to re-use as it makes things easier to read. M

svn commit: r298645 - in head/sys/boot: common powerpc/ps3 sparc64/boot1

2016-04-26 Thread Pedro F. Giffuni
Author: pfg Date: Tue Apr 26 14:51:58 2016 New Revision: 298645 URL: https://svnweb.freebsd.org/changeset/base/298645 Log: sys/boot: make use of the howmany() macro when available. We have a howmany() macro in the header that is convenient to re-use as it makes things easier to read. Mo

svn commit: r298644 - head/sbin/devd

2016-04-26 Thread Alan Somers
Author: asomers Date: Tue Apr 26 14:48:58 2016 New Revision: 298644 URL: https://svnweb.freebsd.org/changeset/base/298644 Log: Add GEOM::physpath documentation to devd.conf(5) Suggested by: trasz Reviewed by: trasz MFC after:4 weeks Sponsored by: Spectra Logic Corp Differential

svn commit: r298643 - in head/sys/arm: arm at91 freescale/imx nvidia

2016-04-26 Thread Pedro F. Giffuni
Author: pfg Date: Tue Apr 26 14:47:52 2016 New Revision: 298643 URL: https://svnweb.freebsd.org/changeset/base/298643 Log: sys/arm: make use of the howmany() macro when available. We have a howmany() macro in the header that is convenient to re-use as it makes things easier to read. Mod

svn commit: r298642 - in head/sys/powerpc: booke mpc85xx powerpc

2016-04-26 Thread Pedro F. Giffuni
Author: pfg Date: Tue Apr 26 14:44:49 2016 New Revision: 298642 URL: https://svnweb.freebsd.org/changeset/base/298642 Log: sys/powerpc: make use of the howmany() macro when available. We have a howmany() macro in the header that is convenient to re-use as it makes things easier to read.

Re: svn commit: r298580 - in head/sys/riscv: include riscv

2016-04-26 Thread Ruslan Bukin
On Mon, Apr 25, 2016 at 06:50:44PM +0300, Konstantin Belousov wrote: > On Mon, Apr 25, 2016 at 02:47:51PM +, Ruslan Bukin wrote: > > +/* An entry in the list of all pmaps */ > > +struct pmap_list_entry { > > + SLIST_ENTRY(pmap_list_entry) pmap_link; > > + struct pmap *pmap; > > +}; > > Thi

svn commit: r298641 - in head/sys/riscv: include riscv

2016-04-26 Thread Ruslan Bukin
Author: br Date: Tue Apr 26 14:38:18 2016 New Revision: 298641 URL: https://svnweb.freebsd.org/changeset/base/298641 Log: Rework the list of all pmaps: embed the list link into pmap. Modified: head/sys/riscv/include/pmap.h head/sys/riscv/riscv/pmap.c Modified: head/sys/riscv/include/pmap.h

svn commit: r298640 - head/bin/ed

2016-04-26 Thread Pedro F. Giffuni
Author: pfg Date: Tue Apr 26 14:31:48 2016 New Revision: 298640 URL: https://svnweb.freebsd.org/changeset/base/298640 Log: ed(1): switch two statements so we check the index before dereferencing. This is related to r270256 but was missed in that occasion. MFC after:3 days Modified

svn commit: r298639 - head/sys/arm64/conf

2016-04-26 Thread Andrew Turner
Author: andrew Date: Tue Apr 26 14:21:39 2016 New Revision: 298639 URL: https://svnweb.freebsd.org/changeset/base/298639 Log: Disable ACPI on arm64 ad it has only had minimal testing and is causing boot issues when booting with FDT. It is planned to re-enable this at a later date. Obtai

Re: svn commit: r298612 - head/sys/dev/iwm

2016-04-26 Thread Adrian Chadd
it's a dirty habit I learnt from linux. Seeing the '!!' says "it's always 1 or 0". I get into that habit so the same thing happens when you do bit masking, eg: do_stop = (foo & 0x10) ; is 0x10 or 0, but do_stop = !! (foo & 0x10); is 1 or 0. -adrian On 25 April 2016 at 21:45, Ravi Pokala

Re: svn commit: r298612 - head/sys/dev/iwm

2016-04-26 Thread Adrian Chadd
You're right in all counts; this was just a first cut to at least get it done and working. We can iterate over it and tidy things up. (It's creepy being able to use iwm now and have it magically "work"..) -adrian ___ svn-src-head@freebsd.org mailing li

svn commit: r298638 - in head/sys: boot/fdt/dts/riscv conf riscv/conf

2016-04-26 Thread Ruslan Bukin
Author: br Date: Tue Apr 26 13:22:08 2016 New Revision: 298638 URL: https://svnweb.freebsd.org/changeset/base/298638 Log: o Add device tree files and kernel configuration files for RISC-V cpus synthesized on FPGA hardware. o Include new files to the build. Added: head/sys/boot/fdt/dts/r

svn commit: r298637 - head/sys/dev/uart

2016-04-26 Thread Andrew Turner
Author: andrew Date: Tue Apr 26 13:16:45 2016 New Revision: 298637 URL: https://svnweb.freebsd.org/changeset/base/298637 Log: Stop including machine/fdt.h from the fdt uart code, it's unneeded. Sponsored by: ABT Systems Ltd Modified: head/sys/dev/uart/uart_cpu_fdt.c Modified: head/sys/d

svn commit: r298636 - in head/sys/riscv: include riscv

2016-04-26 Thread Ruslan Bukin
Author: br Date: Tue Apr 26 12:56:44 2016 New Revision: 298636 URL: https://svnweb.freebsd.org/changeset/base/298636 Log: Add the non-standard "IO interrupt" vector used by lowRISC. For now they provide UART irq only. Sponsored by: DARPA, AFRL Sponsored by: HEIF5 Modified: head/sys/r

svn commit: r298635 - head/sys/riscv/riscv

2016-04-26 Thread Ruslan Bukin
Author: br Date: Tue Apr 26 12:45:01 2016 New Revision: 298635 URL: https://svnweb.freebsd.org/changeset/base/298635 Log: Add the implementation of basic bus_space_read/write functions. Sponsored by: DARPA, AFRL Sponsored by: HEIF5 Added: head/sys/riscv/riscv/bus_space_asm.S (content

svn commit: r298634 - head/sys/arm/allwinner/clk

2016-04-26 Thread Jared McNeill
Author: jmcneill Date: Tue Apr 26 12:36:12 2016 New Revision: 298634 URL: https://svnweb.freebsd.org/changeset/base/298634 Log: Fix calculation of LCD CH1 SCLK1 output frequency when SCLK2 /2 is used as source. PR: 208680 Reported by: David Binderman Modified: head/sys/ar

svn commit: r298633 - head/sys/riscv/riscv

2016-04-26 Thread Ruslan Bukin
Author: br Date: Tue Apr 26 12:33:25 2016 New Revision: 298633 URL: https://svnweb.freebsd.org/changeset/base/298633 Log: Add the implementation of OF_decode_addr(). Added: head/sys/riscv/riscv/ofw_machdep.c (contents, props changed) Added: head/sys/riscv/riscv/ofw_machdep.c ==

svn commit: r298632 - head/sys/dev/uart

2016-04-26 Thread Ruslan Bukin
Author: br Date: Tue Apr 26 12:31:23 2016 New Revision: 298632 URL: https://svnweb.freebsd.org/changeset/base/298632 Log: Do not include fdt.h on RISC-V. Modified: head/sys/dev/uart/uart_cpu_fdt.c Modified: head/sys/dev/uart/uart_cpu_fdt.c

svn commit: r298631 - head/sys/kern

2016-04-26 Thread Ruslan Bukin
Author: br Date: Tue Apr 26 12:29:47 2016 New Revision: 298631 URL: https://svnweb.freebsd.org/changeset/base/298631 Log: Add support for RISC-V. Modified: head/sys/kern/subr_devmap.c Modified: head/sys/kern/subr_devmap.c ==

svn commit: r298630 - head/sys/arm/allwinner

2016-04-26 Thread Jared McNeill
Author: jmcneill Date: Tue Apr 26 12:02:36 2016 New Revision: 298630 URL: https://svnweb.freebsd.org/changeset/base/298630 Log: Add support for 8-bit eMMC. Set MMC_CAP_4_BIT_DATA and MMC_CAP_8_BIT_DATA based on the "bus-width" DT property and reduce maximum bus frequency from 52MHz to 50M

svn commit: r298627 - in head/sys: arm/allwinner arm/altera/socfpga arm/amlogic/aml8726 arm/annapurna/alpine arm/arm arm/at91 arm/broadcom/bcm2835 arm/cavium/cns11xx arm/freescale arm/freescale/imx...

2016-04-26 Thread Ruslan Bukin
Author: br Date: Tue Apr 26 11:53:37 2016 New Revision: 298627 URL: https://svnweb.freebsd.org/changeset/base/298627 Log: Move arm's devmap to some generic place, so it can be used by other architectures. Reviewed by: imp Differential Revision:https://reviews.freebsd.org/D6091

svn commit: r298626 - head/bin/csh

2016-04-26 Thread Andrew Turner
Author: andrew Date: Tue Apr 26 11:39:32 2016 New Revision: 298626 URL: https://svnweb.freebsd.org/changeset/base/298626 Log: Stop using sbrk in csh. This is a legacy interface and its use within csh is invalid. It is used to find the size of allocated memory. As malloc may allocate memory w

svn commit: r298625 - in head/sys/arm: allwinner allwinner/a10 conf

2016-04-26 Thread Emmanuel Vadot
Author: manu Date: Tue Apr 26 11:15:48 2016 New Revision: 298625 URL: https://svnweb.freebsd.org/changeset/base/298625 Log: Convert A10 interrupt controller to INTRNG Reviewed by: skra Approved by: cognet (mentor) Differential Revision:https://reviews.freebsd.org/D5573 Added:

svn commit: r298624 - head/usr.sbin/bsdinstall/partedit

2016-04-26 Thread Ed Schouten
Author: ed Date: Tue Apr 26 10:04:06 2016 New Revision: 298624 URL: https://svnweb.freebsd.org/changeset/base/298624 Log: Remove unportable calls to basename(). The POSIX version of basename() doesn't use a 'const char *' argument; the function may overwrite its input buffer. Instead of c