svn commit: r301777 - head/lib/libc/stdio

Author: pfg Date: Fri Jun 10 05:21:52 2016 New Revision: 301777 URL: https://svnweb.freebsd.org/changeset/base/301777 Log: Fix regression from r301461. The fix to the __collate_range_cmp() ABI breakage missed some replacements in libc's vfscanf(). Replace them with

Re: svn commit: r301741 - head/sys/cam

I'm about to commit a real fix. Warner On Fri, Jun 10, 2016 at 12:39 AM, Jung-uk Kim wrote: > On 06/ 9/16 08:35 PM, Conrad Meyer wrote: >> i386 as well (although we are replying to the wrong commit, I think >> r301771 is what broke it): >> >> In file included from

Re: svn commit: r301741 - head/sys/cam

On Fri, Jun 10, 2016 at 12:39:56AM -0400, Jung-uk Kim wrote: > On 06/ 9/16 08:35 PM, Conrad Meyer wrote: > > i386 as well (although we are replying to the wrong commit, I think > > r301771 is what broke it): > > > > In file included from /usr/src/sbin/camcontrol/camcontrol.c:56: > >

Re: svn commit: r301741 - head/sys/cam

On 06/ 9/16 08:35 PM, Conrad Meyer wrote: > i386 as well (although we are replying to the wrong commit, I think > r301771 is what broke it): > > In file included from /usr/src/sbin/camcontrol/camcontrol.c:56: > /usr/obj/usr/src/tmp/usr/include/cam/cam_ccb.h:44:10: fatal error: >

Re: svn commit: r301751 - head/sys/kern

On Thu, Jun 09, 2016 at 06:27:41PM +, Conrad E. Meyer wrote: > Author: cem > Date: Thu Jun 9 18:27:41 2016 > New Revision: 301751 > URL: https://svnweb.freebsd.org/changeset/base/301751 > > Log: > Add DDB command "kldstat" > > It prints much the same information as kldstat(8) without

svn commit: r301775 - head/contrib/ipfilter/man

Author: cy Date: Fri Jun 10 01:10:48 2016 New Revision: 301775 URL: https://svnweb.freebsd.org/changeset/base/301775 Log: Clarify the wording to be more accurate. Approved by: re@ (gjb) MFC after:1 week X-MFC with: r301773 Modified: head/contrib/ipfilter/man/ipf.8 Modified:

Re: svn commit: r301741 - head/sys/cam

i386 as well (although we are replying to the wrong commit, I think r301771 is what broke it): In file included from /usr/src/sbin/camcontrol/camcontrol.c:56: /usr/obj/usr/src/tmp/usr/include/cam/cam_ccb.h:44:10: fatal error: 'cam/nvme/nvme_all.h' file not found #include ^ Best, Conrad

svn commit: r301773 - head/contrib/ipfilter/man

Author: cy Date: Fri Jun 10 00:06:58 2016 New Revision: 301773 URL: https://svnweb.freebsd.org/changeset/base/301773 Log: Update the man ipf.8 man page to accurately reflect that the -6 option is a noop and only here for backward compatibility. MFC after:1 week Modified:

Re: svn commit: r301741 - head/sys/cam

On Thu, Jun 09, 2016 at 04:05:56PM +, Warner Losh wrote: > Author: imp > Date: Thu Jun 9 16:05:56 2016 > New Revision: 301741 > URL: https://svnweb.freebsd.org/changeset/base/301741 > > Log: > Add place holder for SDIO CAM stuff for CCB XPT type. > One of these commits breaks sparc64.

svn commit: r301771 - in head/sys: cam cam/nvme conf

Author: imp Date: Thu Jun 9 22:39:02 2016 New Revision: 301771 URL: https://svnweb.freebsd.org/changeset/base/301771 Log: New NVMe front end (nda). Added: head/sys/cam/nvme/ head/sys/cam/nvme/nvme_all.c (contents, props changed) head/sys/cam/nvme/nvme_all.h (contents, props changed)

svn commit: r301770 - head/usr.sbin/rpcbind

Author: pfg Date: Thu Jun 9 22:25:00 2016 New Revision: 301770 URL: https://svnweb.freebsd.org/changeset/base/301770 Log: rpcbind(8): Make use of some xdr_* macros. xdr_rpcproc, xdr_rpcprog and xdr_rpcvers were broken in older versions of FreeBSD but fixed in r296394. Give them some

svn commit: r301769 - head/lib/libc/rpc

Author: pfg Date: Thu Jun 9 22:18:25 2016 New Revision: 301769 URL: https://svnweb.freebsd.org/changeset/base/301769 Log: libc/rpc: Make use of some xdr_* macros. (part 2) xdr_rpcproc, xdr_rpcprog and xdr_rpcvers were broken in older versions of FreeBSD but fixed in r296394. Give them

svn commit: r301768 - in head/lib/libc: gen sys

Author: jilles Date: Thu Jun 9 22:14:58 2016 New Revision: 301768 URL: https://svnweb.freebsd.org/changeset/base/301768 Log: utimes(2),utime(3): Add deprecation in favour of utimensat(2) and futimens(2). Setting time by seconds or microseconds may cause unexpected effects especially if

svn commit: r301767 - head/sys/dev/ath

Author: adrian Date: Thu Jun 9 22:01:05 2016 New Revision: 301767 URL: https://svnweb.freebsd.org/changeset/base/301767 Log: [ath] add a placeholder event for debuggin EDMA TX FIFO push events. Some later code I'll commit pushes lists of frames into the EDMA TX FIFO, rather than a

svn commit: r301766 - head/sys/dev/ath

Author: adrian Date: Thu Jun 9 21:59:36 2016 New Revision: 301766 URL: https://svnweb.freebsd.org/changeset/base/301766 Log: [ath] report node queue overflows. I need to also update athstats to report this too. Modified: head/sys/dev/ath/if_ath_sysctl.c Modified:

svn commit: r301765 - in head/usr.bin/xinstall: . tests

Author: jilles Date: Thu Jun 9 21:59:35 2016 New Revision: 301765 URL: https://svnweb.freebsd.org/changeset/base/301765 Log: install: When preserving timestamps, also copy the nanoseconds part. Now that we have utimensat in -legacy, install(1) can use it. This is a revert of r299942

svn commit: r301764 - head/sys/kern

Author: jamie Date: Thu Jun 9 21:59:11 2016 New Revision: 301764 URL: https://svnweb.freebsd.org/changeset/base/301764 Log: Fix a vnode leak when giving a child jail a too-long path when debug.disablefullpath=1. Modified: head/sys/kern/kern_jail.c Modified: head/sys/kern/kern_jail.c

svn commit: r301763 - in head: . tools/build

Author: jilles Date: Thu Jun 9 21:57:34 2016 New Revision: 301763 URL: https://svnweb.freebsd.org/changeset/base/301763 Log: build: Add legacy support for futimens() and utimensat(). In order to allow using utimensat() in install(1), add futimens() and utimensat() to -legacy. The

svn commit: r301762 - head/sys/dev/urtwn

Author: avos Date: Thu Jun 9 21:19:46 2016 New Revision: 301762 URL: https://svnweb.freebsd.org/changeset/base/301762 Log: urtwn: reinstall group keys on every device startup. Since key table is cleared on every device shutdown, static WEP keys (which are set only once) need to be

svn commit: r301761 - head/lib/msun/src

Author: trasz Date: Thu Jun 9 20:49:26 2016 New Revision: 301761 URL: https://svnweb.freebsd.org/changeset/base/301761 Log: Fix frexpl() declaration to not include the field name. MFC after:1 month Modified: head/lib/msun/src/math.h Modified: head/lib/msun/src/math.h

svn commit: r301760 - head/sys/kern

Author: jamie Date: Thu Jun 9 20:43:14 2016 New Revision: 301760 URL: https://svnweb.freebsd.org/changeset/base/301760 Log: Re-order some jail parameter reading to prevent a vnode leak. Modified: head/sys/kern/kern_jail.c Modified: head/sys/kern/kern_jail.c

svn commit: r301759 - head/contrib/ldns-host

Author: des Date: Thu Jun 9 20:40:12 2016 New Revision: 301759 URL: https://svnweb.freebsd.org/changeset/base/301759 Log: Update to latest upstream version PR: 209177 Reported by: Vitaly Magerya MFC after:1 week Modified: head/contrib/ldns-host/Makefile

svn commit: r301758 - head/sys/kern

Author: jamie Date: Thu Jun 9 20:39:57 2016 New Revision: 301758 URL: https://svnweb.freebsd.org/changeset/base/301758 Log: Clean up some logic in jail error messages, replacing a missing test and a redundant test with a single correct test. Modified: head/sys/kern/kern_jail.c Modified:

svn commit: r301757 - head/sys/kern

Author: oshogbo Date: Thu Jun 9 20:23:30 2016 New Revision: 301757 URL: https://svnweb.freebsd.org/changeset/base/301757 Log: Define tunable instead of using CTLFLAG_RWTUN flag with kern.corefile. The allproc_lock lock used in the sysctl_kern_corefile function is initialized in the

svn commit: r301754 - head/lib/libc/rpc

Author: pfg Date: Thu Jun 9 19:44:47 2016 New Revision: 301754 URL: https://svnweb.freebsd.org/changeset/base/301754 Log: libc/rpc: Make use of some xdr_* macros. xdr_rpcprog and xdr_rpcvers were broken in older versions of FreeBSD but were fixed in r296394. Give them some use hoping

svn commit: r301753 - head/contrib/netbsd-tests/lib/libc/db

Author: ngie Date: Thu Jun 9 19:12:51 2016 New Revision: 301753 URL: https://svnweb.freebsd.org/changeset/base/301753 Log: Fix up r274061 Detect /usr/share/dict/words the "right way" by using require.files instead of the hacked up attempt in the dict(..) function, which didn't work

Re: svn commit: r301752 - head/contrib/netbsd-tests/lib/libc/string

> On Jun 9, 2016, at 14:35, Garrett Cooper wrote: > > Author: ngie > Date: Thu Jun 9 18:35:37 2016 > New Revision: 301752 > URL: https://svnweb.freebsd.org/changeset/base/301752 > > Log: > Update `goodResult` after recent changes made to the PRNG in libc > > The PRNG was

svn commit: r301752 - head/contrib/netbsd-tests/lib/libc/string

Author: ngie Date: Thu Jun 9 18:35:37 2016 New Revision: 301752 URL: https://svnweb.freebsd.org/changeset/base/301752 Log: Update `goodResult` after recent changes made to the PRNG in libc The PRNG was changed in r300953/r300956, and subsequently, the numbers generated have changed.

Re: svn commit: r301751 - head/sys/kern

> On Jun 9, 2016, at 14:27, Conrad E. Meyer wrote: > > Author: cem > Date: Thu Jun 9 18:27:41 2016 > New Revision: 301751 > URL: https://svnweb.freebsd.org/changeset/base/301751 > > Log: > Add DDB command "kldstat" > > It prints much the same information as kldstat(8)

svn commit: r301751 - head/sys/kern

Author: cem Date: Thu Jun 9 18:27:41 2016 New Revision: 301751 URL: https://svnweb.freebsd.org/changeset/base/301751 Log: Add DDB command "kldstat" It prints much the same information as kldstat(8) without any arguments. Suggested by: jhibbits Sponsored by: EMC / Isilon Storage

svn commit: r301750 - head/sys/kern

Author: cem Date: Thu Jun 9 18:24:51 2016 New Revision: 301750 URL: https://svnweb.freebsd.org/changeset/base/301750 Log: kvprintf: Pad %*c to width, like %*s Sponsored by: EMC / Isilon Storage Division Modified: head/sys/kern/subr_prf.c Modified: head/sys/kern/subr_prf.c

svn commit: r301749 - head/contrib/netbsd-tests/lib/libc/string

Author: ngie Date: Thu Jun 9 18:11:42 2016 New Revision: 301749 URL: https://svnweb.freebsd.org/changeset/base/301749 Log: Add debug output to aid in determining why `goodResult` != `result` MFC after: 1 week PR: 210619 (for diagnosis) Sponsored by: EMC / Isilon Storage Division

svn commit: r301748 - head/share/man/man4

Author: avos Date: Thu Jun 9 17:26:54 2016 New Revision: 301748 URL: https://svnweb.freebsd.org/changeset/base/301748 Log: urtwn(4): refresh manpage. Mention URTWN_WITHOUT_UCODE option (r295871), hardware encryption support (r292175), IBSS (r290651) and HOSTAP (r290631) mode support;

svn commit: r301747 - in head/sys: boot/fdt/dts/arm modules/dtb/allwinner

Author: manu Date: Thu Jun 9 17:10:19 2016 New Revision: 301747 URL: https://svnweb.freebsd.org/changeset/base/301747 Log: Add PCDuino3b dts. It uses the pcduino3 dts from upstream and adds the hdmi node, axp gpio and changes the phy mode to rgmii. Approved by: andrew (mentor)

svn commit: r301746 - head

Author: emaste Date: Thu Jun 9 17:03:03 2016 New Revision: 301746 URL: https://svnweb.freebsd.org/changeset/base/301746 Log: Use -L to specify compat32 library paths instead of -Y -Y is an uncommon linker option that is rather similar to -L. In discussion with Peter it seems early

svn commit: r301745 - head/sys/kern

Author: jamie Date: Thu Jun 9 16:41:41 2016 New Revision: 301745 URL: https://svnweb.freebsd.org/changeset/base/301745 Log: Make sure the OSD methods for jail set and remove can't run concurrently, by holding allprison_lock exclusively (even if only for a moment before downgrading) on all

svn commit: r301742 - head/sys/dev/xen/timer

Author: royger Date: Thu Jun 9 16:15:01 2016 New Revision: 301742 URL: https://svnweb.freebsd.org/changeset/base/301742 Log: xen/timer: re-introduce the inittodr call in the resume path r298930 removed the inittodr call, but it seems like this prevents "calcru: runtime went backwards

svn commit: r301741 - head/sys/cam

Author: imp Date: Thu Jun 9 16:05:56 2016 New Revision: 301741 URL: https://svnweb.freebsd.org/changeset/base/301741 Log: Add place holder for SDIO CAM stuff for CCB XPT type. Sponsored by: Netflix Modified: head/sys/cam/cam_ccb.h head/sys/cam/cam_xpt.c Modified:

svn commit: r301739 - head/sys/cam

Author: imp Date: Thu Jun 9 16:05:40 2016 New Revision: 301739 URL: https://svnweb.freebsd.org/changeset/base/301739 Log: Improve debugging of xpt. Sponsored by: Netflix Modified: head/sys/cam/cam_xpt.c Modified: head/sys/cam/cam_xpt.c

svn commit: r301740 - head/sys/cam

Author: imp Date: Thu Jun 9 16:05:49 2016 New Revision: 301740 URL: https://svnweb.freebsd.org/changeset/base/301740 Log: Add NVME IO type. Modified: head/sys/cam/cam_ccb.h head/sys/cam/cam_xpt.c Modified: head/sys/cam/cam_ccb.h

svn commit: r301737 - head/sys/kern

Author: jamie Date: Thu Jun 9 15:34:33 2016 New Revision: 301737 URL: https://svnweb.freebsd.org/changeset/base/301737 Log: Remove a comment that was part of copied code, and is misleading in the new location. Modified: head/sys/kern/sysv_msg.c Modified: head/sys/kern/sysv_msg.c

svn commit: r301736 - head/contrib/blacklist/libexec

Author: lidl Date: Thu Jun 9 15:19:48 2016 New Revision: 301736 URL: https://svnweb.freebsd.org/changeset/base/301736 Log: Add IPFW support to blacklistd-helper Relnotes: YES Sponsored by: The FreeBSD Foundation Differential Revision:https://reviews.freebsd.org/D6753

Re: svn commit: r301706 - head/sys/boot/efi

On Wed, 8 Jun 2016 22:30:15 -0400 Warner Losh wrote: > > On Jun 8, 2016, at 7:23 PM, Andrew Turner > > wrote: > > > > Author: andrew > > Date: Wed Jun 8 23:23:16 2016 > > New Revision: 301706 > > URL: https://svnweb.freebsd.org/changeset/base/301706 > >

svn commit: r301735 - head/sys/dev/random

Author: sjg Date: Thu Jun 9 14:44:05 2016 New Revision: 301735 URL: https://svnweb.freebsd.org/changeset/base/301735 Log: Revert previous commit, until issue with sparc64 resolved. Approved by: so (implicit) Modified: head/sys/dev/random/random_harvestq.h Modified:

svn commit: r301733 - head/share/man/man4

Author: avos Date: Thu Jun 9 14:18:12 2016 New Revision: 301733 URL: https://svnweb.freebsd.org/changeset/base/301733 Log: rum(4): refresh manpage. Add a note about hardware encryption support (r288633), adhoc-demo mode (r288622) and remove BUGS section (fixed in r288632). Modified:

svn commit: r301734 - in head: lib/libc/rpc sys/rpc

Author: kevlo Date: Thu Jun 9 14:33:00 2016 New Revision: 301734 URL: https://svnweb.freebsd.org/changeset/base/301734 Log: Fix the rpcb_getaddr() definition to match its declaration. Submitted by: Sebastian Huber Modified: head/lib/libc/rpc/rpcb_clnt.c head/sys/rpc/rpcb_clnt.c

Re: svn commit: r301713 - head/sys/dev/random

On Thu, Jun 09, 2016 at 06:25:34AM -0700, Simon J. Gerraty wrote: > Glen Barber wrote: > > > > > > -void read_rate_increment(u_int); > > > +void random_harvest_queue(const void *, u_int, u_int, > > > + enum random_entropy_source); > > > +void

Re: svn commit: r301714 - head/sys/boot/efi/libefi

We already have debugging framework for boot1.efi which we could use here? I’m working on setting / getting of UEFI variables with support for UEFI’s bootmgr protocol. That’s going to need some way to debug it because it’s kinda complex... Warner > On Jun 9, 2016, at 8:43 AM, Emmanuel Vadot

svn commit: r301732 - head/release/tools

Author: cperciva Date: Thu Jun 9 13:58:31 2016 New Revision: 301732 URL: https://svnweb.freebsd.org/changeset/base/301732 Log: Switch from console="comconsole" to boot_multicons="YES" in EC2. Amazon recently introduced an API for capturing screenshots of an emulated VGA device; this

svn commit: r301731 - head/sys/net80211

Author: avos Date: Thu Jun 9 13:42:18 2016 New Revision: 301731 URL: https://svnweb.freebsd.org/changeset/base/301731 Log: net80211: discard an injected frame if it is smaller than header length. Do not try to pass such frames; a correct frame cannot be smaller than (the corresponding)

svn commit: r301730 - head/release/doc/en_US.ISO8859-1/relnotes

Author: skreuzer (doc,ports committer) Date: Thu Jun 9 13:36:31 2016 New Revision: 301730 URL: https://svnweb.freebsd.org/changeset/base/301730 Log: Document 292432, OpenBSM updated to version 1.2 alpha 4. Approved by: re (gjb, implicit, relnotes) Modified:

svn commit: r301729 - head/release/doc/en_US.ISO8859-1/relnotes

Author: skreuzer (doc,ports committer) Date: Thu Jun 9 13:33:13 2016 New Revision: 301729 URL: https://svnweb.freebsd.org/changeset/base/301729 Log: Document 300879, acpica updated to version 20160527 Approved by: re (gjb, implicit, relnotes) Modified:

Re: svn commit: r301713 - head/sys/dev/random

Glen Barber wrote: > > > > -void read_rate_increment(u_int); > > +void random_harvest_queue(const void *, u_int, u_int, > > + enum random_entropy_source); > > +void read_rate_increment(u_int); > > > > #defineRANDOM_HARVESTQ_BOOT_ENTROPY_FILE

svn commit: r301728 - head/release/doc/en_US.ISO8859-1/relnotes

Author: skreuzer (doc,ports committer) Date: Thu Jun 9 13:23:13 2016 New Revision: 301728 URL: https://svnweb.freebsd.org/changeset/base/301728 Log: Document 291125, xz updated to version 5.2.2 Approved by: re (gjb, implicit, relnotes) Modified:

Re: svn commit: r301713 - head/sys/dev/random

Glen Barber wrote: > This breaks sparc64. Ouch. I only tested on x86 before commit. I can back it out, while we work out what's up. > > cc1: warnings being treated as errors > In file included from > /usr/src/sys/modules/random_other/../../dev/random/other_algorithm.c:62: >

svn commit: r301727 - head/sys/kern

Author: markj Date: Thu Jun 9 13:17:08 2016 New Revision: 301727 URL: https://svnweb.freebsd.org/changeset/base/301727 Log: Fix some cosmetic issues in kern_fail.c omitted from r296927. Obtained from:Matthew Bryan Modified: head/sys/kern/kern_fail.c

svn commit: r301726 - head/sys/dev/iscsi

Author: trasz Date: Thu Jun 9 13:04:57 2016 New Revision: 301726 URL: https://svnweb.freebsd.org/changeset/base/301726 Log: Consistently use 'unsigned int' for session IDs. MFC after:1 month Modified: head/sys/dev/iscsi/iscsi_ioctl.h Modified: head/sys/dev/iscsi/iscsi_ioctl.h

Re: svn commit: r301713 - head/sys/dev/random

On Thu, Jun 09, 2016 at 01:50:43AM +, Simon J. Gerraty wrote: > Author: sjg > Date: Thu Jun 9 01:50:43 2016 > New Revision: 301713 > URL: https://svnweb.freebsd.org/changeset/base/301713 > > Log: > Add a prototype for random_harvest_queue to dev/random/random_harvestq.h > This fixes a

Re: svn commit: r301714 - head/sys/boot/efi/libefi

I wanted to more verbose in case of the system don't have partition o n disk (or the EFI implementation only support raw disks like U-Boot) but this might be a bad way of doing saw, I didn't think about the implication you're talking about. I'll try to figure a better way to do this. On Wed, 8

svn commit: r301725 - head/sys/dev/sfxge

Author: arybchik Date: Thu Jun 9 12:33:53 2016 New Revision: 301725 URL: https://svnweb.freebsd.org/changeset/base/301725 Log: sfxge(4): bump version to the closest out-of-tree driver version Sponsored by: Solarflare Communications, Inc. MFC after: 1 week Modified:

svn commit: r301724 - head/sys/dev/sfxge

Author: arybchik Date: Thu Jun 9 12:29:03 2016 New Revision: 301724 URL: https://svnweb.freebsd.org/changeset/base/301724 Log: sfxge(4): handle negative ticks difference correctly ticks are signed int and if statistics is not updated for a long time (more than INT_MAX ticks, but less

svn commit: r301723 - head/sys/dev/iscsi

Author: trasz Date: Thu Jun 9 11:39:50 2016 New Revision: 301723 URL: https://svnweb.freebsd.org/changeset/base/301723 Log: Add some spares to structs used by iscsi(4), to avoid ABI problems during 11-STABLE. MFC after:1 month Modified: head/sys/dev/iscsi/iscsi_ioctl.h Modified:

svn commit: r301722 - head/sys/net80211

Author: avos Date: Thu Jun 9 08:19:42 2016 New Revision: 301722 URL: https://svnweb.freebsd.org/changeset/base/301722 Log: net80211: fix duplicate packet counter incrementation. Remove 'if_inc_counter(ifp, IFCOUNTER_OPACKETS, 1);' from raw xmit and apbridge path; it will be incremented

svn commit: r301721 - head/usr.sbin/iscsid

Author: trasz Date: Thu Jun 9 07:49:20 2016 New Revision: 301721 URL: https://svnweb.freebsd.org/changeset/base/301721 Log: Decouple MaxBurstLength and FirstBurstLength from MaxRecvDataSegmentLength reported by the ICL module in iscsid(8). This harmed performance and was just wrong.

svn commit: r301720 - head/usr.sbin/ctld

Author: trasz Date: Thu Jun 9 07:19:02 2016 New Revision: 301720 URL: https://svnweb.freebsd.org/changeset/base/301720 Log: Don't cap FirstBurstLength to maximum MaxRecvDataSegmentLength claimed by the offload driver; there is no reason to do so, and it actually harms performance. MFC

svn commit: r301719 - in head/share/man: man4 man5 man9

Author: trasz Date: Thu Jun 9 06:55:00 2016 New Revision: 301719 URL: https://svnweb.freebsd.org/changeset/base/301719 Log: Fix a bunch of "xref refers to *this* page" igor(1) warnings. MFC after:1 month Modified: head/share/man/man4/bcma.4 head/share/man/man4/dcons.4

svn commit: r301718 - in head/contrib/jemalloc: . doc include/jemalloc include/jemalloc/internal src

Author: jasone Date: Thu Jun 9 06:10:20 2016 New Revision: 301718 URL: https://svnweb.freebsd.org/changeset/base/301718 Log: Update jemalloc to 4.2.1. Modified: head/contrib/jemalloc/ChangeLog head/contrib/jemalloc/FREEBSD-diffs head/contrib/jemalloc/VERSION