svn commit: r327719 - head/sbin/ldconfig

2018-01-08 Thread Eitan Adler
Author: eadler Date: Tue Jan 9 06:51:41 2018 New Revision: 327719 URL: https://svnweb.freebsd.org/changeset/base/327719 Log: ldconfig(8): use .Nm instead of 'ldconfig' Modified: head/sbin/ldconfig/ldconfig.8 Modified: head/sbin/ldconfig/ldconfig.8 ===

svn commit: r327718 - head/sys/contrib/ipfilter/netinet

2018-01-08 Thread Cy Schubert
Author: cy Date: Tue Jan 9 06:43:58 2018 New Revision: 327718 URL: https://svnweb.freebsd.org/changeset/base/327718 Log: When growing the state, also grow the seed array. Otherwise memory that was not allocated will be accessed. This necessitated refactoring state seed allocation from

Re: svn commit: r327715 - head/sys/conf

2018-01-08 Thread Michael Zhilin
Hi, Could you please tell what is plan to back MIPS works? Thanks! On Tue, Jan 9, 2018 at 6:28 AM, Conrad Meyer wrote: > Author: cem > Date: Tue Jan 9 03:28:24 2018 > New Revision: 327715 > URL: https://svnweb.freebsd.org/changeset/base/327715 > > Log: > Fix Zstd kernel build with GCC 4.2 >

svn commit: r327715 - head/sys/conf

2018-01-08 Thread Conrad Meyer
Author: cem Date: Tue Jan 9 03:28:24 2018 New Revision: 327715 URL: https://svnweb.freebsd.org/changeset/base/327715 Log: Fix Zstd kernel build with GCC 4.2 By disabling the -Winline warning. Fixes the powerpc and sparc64 build after r327706. Note: MIPS and RISCV builds still broke

Re: svn commit: r327699 - head/sys/sys

2018-01-08 Thread Rodney W. Grimes
[ Charset UTF-8 unsupported, converting... ] > Hello; > > On 08/01/2018 15:27, Conrad Meyer wrote: > > I'm (again, atypically) with rgrimes here. Revert has a specific > > meaning and shouldn't be used like this. Making a commit with the > > subject "Revert rXXX" that does more than just "svn re

Re: svn commit: r327699 - head/sys/sys

2018-01-08 Thread Rodney W. Grimes
[ Charset UTF-8 unsupported, converting... ] > > On 08/01/2018 11:09, Rodney W. Grimes wrote: > >> Author: pfg > >> Date: Mon Jan 8 15:54:29 2018 > >> New Revision: 327699 > >> URL: https://svnweb.freebsd.org/changeset/base/327699 > >> > >> Log: > >>Revert r327697: > >>malloc(9): drop the

svn commit: r327711 - head/sys/cam/nvme

2018-01-08 Thread Scott Long
Author: scottl Date: Tue Jan 9 00:17:15 2018 New Revision: 327711 URL: https://svnweb.freebsd.org/changeset/base/327711 Log: Don't hold the periph locks during dump. Obtained from:Netflix Modified: head/sys/cam/nvme/nvme_da.c Modified: head/sys/cam/nvme/nvme_da.c ==

svn commit: r327710 - in head/sys/cam: . ata scsi

2018-01-08 Thread Scott Long
Author: scottl Date: Tue Jan 9 00:10:59 2018 New Revision: 327710 URL: https://svnweb.freebsd.org/changeset/base/327710 Log: Don't hold the periph lock when calling into cam_periph_runccb() from the ada and da dump routines. This avoids difficult locking problems from needing to be handled

svn commit: r327709 - head/sys/cam

2018-01-08 Thread Scott Long
Author: scottl Date: Tue Jan 9 00:00:55 2018 New Revision: 327709 URL: https://svnweb.freebsd.org/changeset/base/327709 Log: Protect against a possible NULL deference from an accessor function. Obtained from:Netflix Modified: head/sys/cam/cam_periph.h Modified: head/sys/cam/c

svn commit: r327707 - in head: share/man/man5 sys/conf sys/ddb sys/kern sys/sys

2018-01-08 Thread Mark Johnston
Author: markj Date: Mon Jan 8 21:27:41 2018 New Revision: 327707 URL: https://svnweb.freebsd.org/changeset/base/327707 Log: Generalize the gzio API. We currently use a set of subroutines in kern_gzio.c to perform compression of user and kernel core dumps. In the interest of adding supp

Re: svn commit: r327699 - head/sys/sys

2018-01-08 Thread Conrad Meyer
On Mon, Jan 8, 2018 at 12:54 PM, Pedro Giffuni wrote: > Yeah, I understand where that comes from and I will take it into account for > future commits, but I think it should be *documented* and not assume that > everybody thinks that is the way version control is supposed to be used. If you want

Re: svn commit: r327699 - head/sys/sys

2018-01-08 Thread Pedro Giffuni
Hello; On 08/01/2018 15:27, Conrad Meyer wrote: I'm (again, atypically) with rgrimes here. Revert has a specific meaning and shouldn't be used like this. Making a commit with the subject "Revert rXXX" that does more than just "svn revert rXXX" makes life harder for developers looking at code h

Re: svn commit: r327699 - head/sys/sys

2018-01-08 Thread Conrad Meyer
I'm (again, atypically) with rgrimes here. Revert has a specific meaning and shouldn't be used like this. Making a commit with the subject "Revert rXXX" that does more than just "svn revert rXXX" makes life harder for developers looking at code history after you. Making two separate commits for

Re: svn commit: r327699 - head/sys/sys

2018-01-08 Thread Pedro Giffuni
On 08/01/2018 11:09, Rodney W. Grimes wrote: Author: pfg Date: Mon Jan 8 15:54:29 2018 New Revision: 327699 URL: https://svnweb.freebsd.org/changeset/base/327699 Log: Revert r327697: malloc(9): drop the __result_use_check attribute for the kernel allocator. My bad: __result_use_ch

svn commit: r327706 - in head/sys: conf contrib/zstd/lib/freebsd

2018-01-08 Thread Conrad Meyer
Author: cem Date: Mon Jan 8 20:14:16 2018 New Revision: 327706 URL: https://svnweb.freebsd.org/changeset/base/327706 Log: Integrate zstd into the kernel Mock userspace headers and include mocked headers first in compilation command to inject kernel headers and override e.g., malloc(3) wi

Re: svn commit: r327697 - head/sys/sys

2018-01-08 Thread Pedro Giffuni
Hi; On 08/01/2018 13:08, Conrad Meyer wrote: Hi, Response inline. On Mon, Jan 8, 2018 at 7:41 AM, Pedro F. Giffuni wrote: Author: pfg Date: Mon Jan 8 15:41:48 2018 New Revision: 327697 URL: https://svnweb.freebsd.org/changeset/base/327697 Log: malloc(9): drop the __result_use_check attr

Re: svn commit: r327705 - head/stand/mips/beri/common

2018-01-08 Thread Warner Losh
This should have been a nop... libsa specifically creates 'safe' headers for all the standard ones. Ah, libsa creates a perfectly fine stdint.h, but not a inttypes.h... Warner On Mon, Jan 8, 2018 at 11:47 AM, John Baldwin wrote: > Author: jhb > Date: Mon Jan 8 18:47:35 2018 > New Revision: 32

svn commit: r327705 - head/stand/mips/beri/common

2018-01-08 Thread John Baldwin
Author: jhb Date: Mon Jan 8 18:47:35 2018 New Revision: 327705 URL: https://svnweb.freebsd.org/changeset/base/327705 Log: Use instead of and in boot code. In the freestanding boot compile environment, standard headers are not available. Curiously, only building with clang exposed thi

svn commit: r327704 - head/stand/mips/beri/loader

2018-01-08 Thread John Baldwin
Author: jhb Date: Mon Jan 8 18:46:10 2018 New Revision: 327704 URL: https://svnweb.freebsd.org/changeset/base/327704 Log: Fix printf missing format variables warnings. Include the failing kernel file name for errors in beri_elf64_exec(). Sponsored by: DARPA / AFRL Modified: head/st

svn commit: r327703 - head/stand/mips/beri/boot2

2018-01-08 Thread John Baldwin
Author: jhb Date: Mon Jan 8 18:44:36 2018 New Revision: 327703 URL: https://svnweb.freebsd.org/changeset/base/327703 Log: Define __dmadat after #include'ing ufsread.c. The __dmadat variable is a statically allocated I/O buffer. The type is declared in the ufsread.c source file and clang

Re: svn commit: r327697 - head/sys/sys

2018-01-08 Thread Conrad Meyer
Hi, Response inline. On Mon, Jan 8, 2018 at 7:41 AM, Pedro F. Giffuni wrote: > Author: pfg > Date: Mon Jan 8 15:41:48 2018 > New Revision: 327697 > URL: https://svnweb.freebsd.org/changeset/base/327697 > > Log: > malloc(9): drop the __result_use_check attribute for the kernel allocator. > >

Re: svn commit: r327684 - in head/sys/compat: cloudabi32 cloudabi64

2018-01-08 Thread Brooks Davis
On Mon, Jan 08, 2018 at 04:13:42PM +0100, Ed Schouten wrote: > Hi Andrew, > > 2018-01-08 8:37 GMT+01:00 Andrew Turner : > > Won???t this lead to a NULL pointer dereference on overflow? mallocarray > > can return NULL even with M_WAITOK. > > Yes, it will, but an overflow shouldn't happen in the f

Re: svn commit: r327684 - in head/sys/compat: cloudabi32 cloudabi64

2018-01-08 Thread Warner Losh
On Mon, Jan 8, 2018 at 9:29 AM, Mark Johnston wrote: > On Mon, Jan 08, 2018 at 09:18:28AM -0700, Ian Lepore wrote: > > On Mon, 2018-01-08 at 09:13 -0700, Warner Losh wrote: > > > On Jan 8, 2018 8:37 AM, "Pedro Giffuni" wrote: > > > On 01/08/18 10:13, Ed Schouten wrote: > > > > > > > > > > > Hi A

Re: svn commit: r327684 - in head/sys/compat: cloudabi32 cloudabi64

2018-01-08 Thread Mark Johnston
On Mon, Jan 08, 2018 at 09:18:28AM -0700, Ian Lepore wrote: > On Mon, 2018-01-08 at 09:13 -0700, Warner Losh wrote: > > On Jan 8, 2018 8:37 AM, "Pedro Giffuni" wrote: > > On 01/08/18 10:13, Ed Schouten wrote: > > > > > > > > Hi Andrew, > > > > > > 2018-01-08 8:37 GMT+01:00 Andrew Turner : > > >

Re: svn commit: r327684 - in head/sys/compat: cloudabi32 cloudabi64

2018-01-08 Thread Ian Lepore
On Mon, 2018-01-08 at 09:13 -0700, Warner Losh wrote: > On Jan 8, 2018 8:37 AM, "Pedro Giffuni" wrote: > > > On 01/08/18 10:13, Ed Schouten wrote: > > > > > Hi Andrew, > > > > 2018-01-08 8:37 GMT+01:00 Andrew Turner : > > > > > > > > Won’t this lead to a NULL pointer dereference on overflow

Re: svn commit: r327684 - in head/sys/compat: cloudabi32 cloudabi64

2018-01-08 Thread Warner Losh
On Jan 8, 2018 8:37 AM, "Pedro Giffuni" wrote: On 01/08/18 10:13, Ed Schouten wrote: > Hi Andrew, > > 2018-01-08 8:37 GMT+01:00 Andrew Turner : > >> Won’t this lead to a NULL pointer dereference on overflow? mallocarray >> can return NULL even with M_WAITOK. >> > Yes, it will, but an overflow s

Re: svn commit: r327699 - head/sys/sys

2018-01-08 Thread Rodney W. Grimes
> Author: pfg > Date: Mon Jan 8 15:54:29 2018 > New Revision: 327699 > URL: https://svnweb.freebsd.org/changeset/base/327699 > > Log: > Revert r327697: > malloc(9): drop the __result_use_check attribute for the kernel allocator. > > My bad: __result_use_check just checks the for the gene

Re: svn commit: r327697 - head/sys/sys

2018-01-08 Thread Pedro Giffuni
On 01/08/18 10:41, Pedro F. Giffuni wrote: Author: pfg Date: Mon Jan 8 15:41:48 2018 New Revision: 327697 URL: https://svnweb.freebsd.org/changeset/base/327697 Log: malloc(9): drop the __result_use_check attribute for the kernel allocator. The __result_use_check attribute was brough

svn commit: r327700 - head/sys/geom/mirror

2018-01-08 Thread Mark Johnston
Author: markj Date: Mon Jan 8 15:56:40 2018 New Revision: 327700 URL: https://svnweb.freebsd.org/changeset/base/327700 Log: Sort and remove unneeded includes. MFC after:1 week Sponsored by: Dell EMC Isilon Modified: head/sys/geom/mirror/g_mirror.c head/sys/geom/mirror/g_mirror_c

svn commit: r327699 - head/sys/sys

2018-01-08 Thread Pedro F. Giffuni
Author: pfg Date: Mon Jan 8 15:54:29 2018 New Revision: 327699 URL: https://svnweb.freebsd.org/changeset/base/327699 Log: Revert r327697: malloc(9): drop the __result_use_check attribute for the kernel allocator. My bad: __result_use_check just checks the for the general and we always

svn commit: r327698 - head/sys/geom/mirror

2018-01-08 Thread Mark Johnston
Author: markj Date: Mon Jan 8 15:41:49 2018 New Revision: 327698 URL: https://svnweb.freebsd.org/changeset/base/327698 Log: Release the queue lock before restarting the worker loop. Reported and tested by: pho MFC after:3 days Sponsored by: Dell EMC Isilon Modified: head/s

svn commit: r327697 - head/sys/sys

2018-01-08 Thread Pedro F. Giffuni
Author: pfg Date: Mon Jan 8 15:41:48 2018 New Revision: 327697 URL: https://svnweb.freebsd.org/changeset/base/327697 Log: malloc(9): drop the __result_use_check attribute for the kernel allocator. The __result_use_check attribute was brought to the kernel malloc in r281203 for consistenc

Re: svn commit: r327684 - in head/sys/compat: cloudabi32 cloudabi64

2018-01-08 Thread Pedro Giffuni
On 01/08/18 10:13, Ed Schouten wrote: Hi Andrew, 2018-01-08 8:37 GMT+01:00 Andrew Turner : Won’t this lead to a NULL pointer dereference on overflow? mallocarray can return NULL even with M_WAITOK. Yes, it will, but an overflow shouldn't happen in the first place. ri_data_len is compared wit

Re: svn commit: r327684 - in head/sys/compat: cloudabi32 cloudabi64

2018-01-08 Thread Pedro Giffuni
Hi; On 08/01/2018 02:37, Andrew Turner wrote: On 7 Jan 2018, at 22:38, Ed Schouten wrote: Author: ed Date: Sun Jan 7 22:38:45 2018 New Revision: 327684 URL: https://svnweb.freebsd.org/changeset/base/327684 Log: Use mallocarray(9) in CloudABI kernel code where possible. Submitted by: pfg

Re: svn commit: r327684 - in head/sys/compat: cloudabi32 cloudabi64

2018-01-08 Thread Ed Schouten
Hi Andrew, 2018-01-08 8:37 GMT+01:00 Andrew Turner : > Won’t this lead to a NULL pointer dereference on overflow? mallocarray can > return NULL even with M_WAITOK. Yes, it will, but an overflow shouldn't happen in the first place. ri_data_len is compared with UIO_MAXIOV a few lines above. Even i

svn commit: r327696 - head/sys/opencrypto

2018-01-08 Thread Fabien Thomas
Author: fabient Date: Mon Jan 8 13:43:12 2018 New Revision: 327696 URL: https://svnweb.freebsd.org/changeset/base/327696 Log: Fix uninitialized crp_retw_id when using asynchronous crypto drivers with defered callbacks. Submitted by: emeric.pou...@stormshield.eu Reported by: mav@ Rev

svn commit: r327691 - head/sys/arm64/arm64

2018-01-08 Thread Andrew Turner
Author: andrew Date: Mon Jan 8 11:08:45 2018 New Revision: 327691 URL: https://svnweb.freebsd.org/changeset/base/327691 Log: Only install the new pagetable pointer into ttbr0_el1 when it differs from the existing value. MFC after:1 week Sponsored by: DARPA, AFRL Modified: head/s

svn commit: r327690 - in head/sys/arm64: arm64 include

2018-01-08 Thread Andrew Turner
Author: andrew Date: Mon Jan 8 10:23:31 2018 New Revision: 327690 URL: https://svnweb.freebsd.org/changeset/base/327690 Log: Move some of the common thread switching code into C. This will help with future optimisations, e.g. using Address Space IDs (asid). MFC after:1 week Sponsor

svn commit: r327689 - head/lib/libcasper/services/cap_dns

2018-01-08 Thread Mariusz Zaborski
Author: oshogbo Date: Mon Jan 8 09:20:08 2018 New Revision: 327689 URL: https://svnweb.freebsd.org/changeset/base/327689 Log: Document the DNS Casper service. Reviewed by: brueffer@, bcr@ Differential Revision:https://reviews.freebsd.org/D13762 Added: head/lib/libcasper/servi