svn commit: r328390 - head/sys/kern

2018-01-24 Thread Li-Wen Hsu
Author: lwhsu (ports committer) Date: Thu Jan 25 06:37:14 2018 New Revision: 328390 URL: https://svnweb.freebsd.org/changeset/base/328390 Log: Fix build for architectures where size_t is not unsigned long Reviewed by: cem Differential Revision:https://reviews.freebsd.org/D14045

svn commit: r328389 - head/sys/dev/etherswitch/rtl8366

2018-01-24 Thread Michael Zhilin
Author: mizhka Date: Thu Jan 25 05:48:42 2018 New Revision: 328389 URL: https://svnweb.freebsd.org/changeset/base/328389 Log: [etherswitch] fix LINT build for rtl8366rb Build with rtl8366rb has been broken due to incorrect retrieval of pointer to device_t. Reported by: lwhsu Diffe

svn commit: r328388 - head/share/man/man8

2018-01-24 Thread Li-Wen Hsu
Author: lwhsu (ports committer) Date: Thu Jan 25 05:15:44 2018 New Revision: 328388 URL: https://svnweb.freebsd.org/changeset/base/328388 Log: Fix manual page install on non-amd64 Reviewed by: emaste, imp Differential Revision:https://reviews.freebsd.org/D14038 Modified: head/

Re: svn commit: r328313 - head/sys/netpfil/pf

2018-01-24 Thread Kristof Provost
On 25 Jan 2018, at 12:08, Kristof Provost wrote: On 25 Jan 2018, at 11:34, Ian Lepore wrote: On Wed, 2018-01-24 at 16:13 -0800, Gleb Smirnoff wrote: (r328313) K> @@ -1613,6 +1613,7 @@ int K>  pf_unlink_state(struct pf_state *s, u_int flags) K>  { K>   struct pf_idhash *ih = &V_pf_idhash[PF_IDHA

svn commit: r328387 - head/sys/cam/scsi

2018-01-24 Thread Warner Losh
Author: imp Date: Thu Jan 25 02:52:44 2018 New Revision: 328387 URL: https://svnweb.freebsd.org/changeset/base/328387 Log: Minor whitespace cleanup to remove leading space before tab. No functional changes. Modified: head/sys/cam/scsi/scsi_da.c Modified: head/sys/cam/scsi/scsi_da.c ===

Re: svn commit: r328313 - head/sys/netpfil/pf

2018-01-24 Thread Warner Losh
On Jan 24, 2018 6:08 PM, "Kristof Provost" wrote: On 25 Jan 2018, at 11:34, Ian Lepore wrote: > On Wed, 2018-01-24 at 16:13 -0800, Gleb Smirnoff wrote: > >> (r328313) >> K> @@ -1613,6 +1613,7 @@ int >> K> pf_unlink_state(struct pf_state *s, u_int flags) >> K> { >> K> struct pf_idhash *ih

Re: svn commit: r328313 - head/sys/netpfil/pf

2018-01-24 Thread Kristof Provost
On 25 Jan 2018, at 11:34, Ian Lepore wrote: On Wed, 2018-01-24 at 16:13 -0800, Gleb Smirnoff wrote: (r328313) K> @@ -1613,6 +1613,7 @@ int K>  pf_unlink_state(struct pf_state *s, u_int flags) K>  { K>   struct pf_idhash *ih = &V_pf_idhash[PF_IDHASH(s)]; K> + int last; K>   K>   if ((flags & PF_E

Re: svn commit: r328313 - head/sys/netpfil/pf

2018-01-24 Thread Ian Lepore
On Wed, 2018-01-24 at 16:13 -0800, Gleb Smirnoff wrote: >   Hi Kristof, > > On Wed, Jan 24, 2018 at 04:29:17AM +, Kristof Provost wrote: > K> Author: kp > K> Date: Wed Jan 24 04:29:16 2018 > K> New Revision: 328313 > K> URL: https://svnweb.freebsd.org/changeset/base/328313 > K>  > K> Log: > K>

Re: svn commit: r328313 - head/sys/netpfil/pf

2018-01-24 Thread Gleb Smirnoff
On Thu, Jan 25, 2018 at 11:16:23AM +1100, Kristof Provost wrote: K> On 25 Jan 2018, at 11:13, Gleb Smirnoff wrote: K> > On Wed, Jan 24, 2018 at 04:29:17AM +, Kristof Provost wrote: K> > K> Author: kp K> > K> Date: Wed Jan 24 04:29:16 2018 K> > K> New Revision: 328313 K> > K> URL: https://svnweb

Re: svn commit: r328377 - in head/sys/dev/etherswitch: arswitch e6000sw infineon ip17x micrel mtkswitch rtl8366 ukswitch

2018-01-24 Thread Gleb Smirnoff
Hi Michael, I already replied to Dmitry that this patch isn't correct. The if_alloc() shall never fail. All checks like that needs to be removed. Inside the if_alloc() the check for L2COM allocation should also be removed. Everything happens with M_WAITOK in this path. On Wed, Jan 24, 2018 at 0

Re: svn commit: r328313 - head/sys/netpfil/pf

2018-01-24 Thread Kristof Provost
On 25 Jan 2018, at 11:13, Gleb Smirnoff wrote: On Wed, Jan 24, 2018 at 04:29:17AM +, Kristof Provost wrote: K> Author: kp K> Date: Wed Jan 24 04:29:16 2018 K> New Revision: 328313 K> URL: https://svnweb.freebsd.org/changeset/base/328313 K> K> Log: K> pf: States have at least two references

Re: svn commit: r328313 - head/sys/netpfil/pf

2018-01-24 Thread Gleb Smirnoff
Hi Kristof, On Wed, Jan 24, 2018 at 04:29:17AM +, Kristof Provost wrote: K> Author: kp K> Date: Wed Jan 24 04:29:16 2018 K> New Revision: 328313 K> URL: https://svnweb.freebsd.org/changeset/base/328313 K> K> Log: K> pf: States have at least two references K> K> pf_unlink_state() rele

svn commit: r328383 - head/sbin/fsck_ffs

2018-01-24 Thread Kirk McKusick
Author: mckusick Date: Wed Jan 24 23:57:40 2018 New Revision: 328383 URL: https://svnweb.freebsd.org/changeset/base/328383 Log: More throughly integrate libufs into fsck_ffs by using its cgput() routine to write out the cylinder groups rather than recreating the calculation of the cylinder-g

svn commit: r328382 - head/lib/libc/sys

2018-01-24 Thread Kirk McKusick
Author: mckusick Date: Wed Jan 24 22:36:21 2018 New Revision: 328382 URL: https://svnweb.freebsd.org/changeset/base/328382 Log: Update .Dd missed in -r328304. Reported by: Bjoern Zeeb (bz) MFC with:328304 Modified: head/lib/libc/sys/setgroups.2 Modified: head/lib/libc/sys/setgroup

svn commit: r328381 - in head: contrib/compiler-rt/lib/builtins contrib/llvm/include/llvm/Analysis contrib/llvm/include/llvm/CodeGen contrib/llvm/include/llvm/MC contrib/llvm/include/llvm/Support c...

2018-01-24 Thread Dimitry Andric
Author: dim Date: Wed Jan 24 22:35:00 2018 New Revision: 328381 URL: https://svnweb.freebsd.org/changeset/base/328381 Log: Upgrade our copies of clang, llvm, lld, lldb, compiler-rt and libc++ to 6.0.0 (branches/release_60 r323338). MFC after:3 months X-MFC-With: r327952 PR:

svn commit: r328380 - in head/sys: arm/conf arm/lpc dev/uart modules/uart

2018-01-24 Thread Emmanuel Vadot
Author: manu Date: Wed Jan 24 22:04:16 2018 New Revision: 328380 URL: https://svnweb.freebsd.org/changeset/base/328380 Log: arm: lpc: Remove support Code hasn't been touch this it's original commit in 2012 beside api changes. Reviewed by: ian Differential Revision:https://re

Re: svn commit: r328218 - in head/sys: amd64/amd64 arm/xscale/ixp425 arm64/arm64 cam cam/ctl compat/ndis dev/aacraid dev/advansys dev/ath dev/beri/virtio dev/bnxt dev/bwn dev/ciss dev/cxgbe/crypto dev

2018-01-24 Thread Warner Losh
On Wed, Jan 24, 2018 at 2:40 PM, Conrad Meyer wrote: > On Wed, Jan 24, 2018 at 1:13 PM, Warner Losh wrote: > > mallocarray should be the last line of defense, not the only line of > > defense. > > Agreed. > > > most of the time, it's more correct to say > > > > if (WOULD_OVERFLOW(a,b)) > > r

Re: svn commit: r328378 - head/share/man/man8

2018-01-24 Thread Rodney W. Grimes
[ Charset UTF-8 unsupported, converting... ] > Author: emaste > Date: Wed Jan 24 21:39:40 2018 > New Revision: 328378 > URL: https://svnweb.freebsd.org/changeset/base/328378 > > Log: > Add efi.8 as a man page link to uefi.8 > > FreeBSD and industry has been inconsistent in the use of UEFI a

Re: svn commit: r328218 - in head/sys: amd64/amd64 arm/xscale/ixp425 arm64/arm64 cam cam/ctl compat/ndis dev/aacraid dev/advansys dev/ath dev/beri/virtio dev/bnxt dev/bwn dev/ciss dev/cxgbe/crypto dev

2018-01-24 Thread Conrad Meyer
On Wed, Jan 24, 2018 at 1:13 PM, Warner Losh wrote: > mallocarray should be the last line of defense, not the only line of > defense. Agreed. > most of the time, it's more correct to say > > if (WOULD_OVERFLOW(a,b)) > return EINVAL; > ptr = mallocarray(a,b...); Disagree -- the right check t

svn commit: r328378 - head/share/man/man8

2018-01-24 Thread Ed Maste
Author: emaste Date: Wed Jan 24 21:39:40 2018 New Revision: 328378 URL: https://svnweb.freebsd.org/changeset/base/328378 Log: Add efi.8 as a man page link to uefi.8 FreeBSD and industry has been inconsistent in the use of UEFI and EFI. They are essentially just different versions of the s

svn commit: r328377 - in head/sys/dev/etherswitch: arswitch e6000sw infineon ip17x micrel mtkswitch rtl8366 ukswitch

2018-01-24 Thread Michael Zhilin
Author: mizhka Date: Wed Jan 24 21:33:18 2018 New Revision: 328377 URL: https://svnweb.freebsd.org/changeset/base/328377 Log: [etherswitch] check if_alloc returns NULL This patch is cosmetic. It checks if allocation of ifnet structure failed. It's better to have this check rather than ass

svn commit: r328376 - head/share/man/man8

2018-01-24 Thread Ed Maste
Author: emaste Date: Wed Jan 24 21:26:01 2018 New Revision: 328376 URL: https://svnweb.freebsd.org/changeset/base/328376 Log: uefi.8: add .Xr cross references to new efi tools Modified: head/share/man/man8/uefi.8 Modified: head/share/man/man8/uefi.8 ==

svn commit: r328375 - head/share/man/man8

2018-01-24 Thread Ed Maste
Author: emaste Date: Wed Jan 24 21:20:24 2018 New Revision: 328375 URL: https://svnweb.freebsd.org/changeset/base/328375 Log: uefi.8: note that UEFI and EFI are used interchangeably Modified: head/share/man/man8/uefi.8 Modified: head/share/man/man8/uefi.8

Re: svn commit: r328218 - in head/sys: amd64/amd64 arm/xscale/ixp425 arm64/arm64 cam cam/ctl compat/ndis dev/aacraid dev/advansys dev/ath dev/beri/virtio dev/bnxt dev/bwn dev/ciss dev/cxgbe/crypto dev

2018-01-24 Thread Warner Losh
On Wed, Jan 24, 2018 at 12:40 PM, Conrad Meyer wrote: > On Wed, Jan 24, 2018 at 11:27 AM, Warner Losh wrote: > > > > Which is why we should add check overflows for most of the no wait cases. > > They should be checked, but not primarily with mallocarray... > > I don't understand what the distinc

svn commit: r328374 - head/share/man/man8

2018-01-24 Thread Ed Maste
Author: emaste Date: Wed Jan 24 21:11:35 2018 New Revision: 328374 URL: https://svnweb.freebsd.org/changeset/base/328374 Log: uefi.8: update HISTORY and remove incomplete AUTHORS - EFI support appeared in 5.0 for ia64 - arm64 UEFI support added in 11.0 The AUTHORS section included th

svn commit: r328361 - head/sys/dev/cxgbe/crypto

2018-01-24 Thread John Baldwin
Author: jhb Date: Wed Jan 24 20:16:48 2018 New Revision: 328361 URL: https://svnweb.freebsd.org/changeset/base/328361 Log: Store IV in output buffer in GCM software fallback when requested. Properly honor the lack of the CRD_F_IV_PRESENT flag in the GCM software fallback case for encrypti

svn commit: r328360 - head/sys/dev/cxgbe/crypto

2018-01-24 Thread John Baldwin
Author: jhb Date: Wed Jan 24 20:15:49 2018 New Revision: 328360 URL: https://svnweb.freebsd.org/changeset/base/328360 Log: Don't read or generate an IV until all error checking is complete. In particular, this avoids edge cases where a generated IV might be written into the output buffer

svn commit: r328359 - head/sys/dev/cxgbe/crypto

2018-01-24 Thread John Baldwin
Author: jhb Date: Wed Jan 24 20:14:57 2018 New Revision: 328359 URL: https://svnweb.freebsd.org/changeset/base/328359 Log: Expand the software fallback for GCM to cover more cases. - Extend ccr_gcm_soft() to handle requests with a non-empty payload. While here, switch to allocating the

svn commit: r328358 - head/sys/dev/cxgbe/crypto

2018-01-24 Thread John Baldwin
Author: jhb Date: Wed Jan 24 20:13:07 2018 New Revision: 328358 URL: https://svnweb.freebsd.org/changeset/base/328358 Log: Clamp DSGL entries to a length of 2KB. This works around an issue in the T6 that can result in DMA engine stalls if an error occurs while processing a DSGL entry with

svn commit: r328357 - head/sys/dev/cxgbe/crypto

2018-01-24 Thread John Baldwin
Author: jhb Date: Wed Jan 24 20:12:00 2018 New Revision: 328357 URL: https://svnweb.freebsd.org/changeset/base/328357 Log: Fail crypto requests when the resulting work request is too large. Most crypto requests will not trigger this condition, but a request with a highly-fragmented data b

svn commit: r328356 - head/sys/dev/cxgbe/crypto

2018-01-24 Thread John Baldwin
Author: jhb Date: Wed Jan 24 20:11:00 2018 New Revision: 328356 URL: https://svnweb.freebsd.org/changeset/base/328356 Log: Don't discard AAD and IV output data for AEAD requests. The T6 can hang when processing certain AEAD requests if the request sets a flag asking the crypto engine to d

svn commit: r328355 - head/sys/dev/cxgbe/crypto

2018-01-24 Thread John Baldwin
Author: jhb Date: Wed Jan 24 20:08:10 2018 New Revision: 328355 URL: https://svnweb.freebsd.org/changeset/base/328355 Log: Reject requests with AAD and IV larger than 511 bytes. The T6 crypto engine's control messages only support a total AAD length (including the prefixed IV) of 511 byte

svn commit: r328354 - head/sys/dev/cxgbe/crypto

2018-01-24 Thread John Baldwin
Author: jhb Date: Wed Jan 24 20:06:02 2018 New Revision: 328354 URL: https://svnweb.freebsd.org/changeset/base/328354 Log: Always set the IV location to IV_NOP. The firmware ignores this field in the FW_CRYPTO_LOOKASIDE_WR work request. Submitted by: Harsh Jain @ Chelsio Sponsored

svn commit: r328353 - head/sys/dev/cxgbe/crypto

2018-01-24 Thread John Baldwin
Author: jhb Date: Wed Jan 24 20:04:08 2018 New Revision: 328353 URL: https://svnweb.freebsd.org/changeset/base/328353 Log: Always store the IV in the immediate portion of a work request. Combined authentication-encryption and GCM requests already stored the IV in the immediate explicitly.

svn commit: r328352 - head/sys/netipsec

2018-01-24 Thread Andrey V. Elsukov
Author: ae Date: Wed Jan 24 19:48:25 2018 New Revision: 328352 URL: https://svnweb.freebsd.org/changeset/base/328352 Log: Adopt revision 1.76 and 1.77 from NetBSD: Fix a vulnerability in IPsec-IPv6-AH, that allows an attacker to remotely crash the kernel with a single packet. In t

Re: svn commit: r328218 - in head/sys: amd64/amd64 arm/xscale/ixp425 arm64/arm64 cam cam/ctl compat/ndis dev/aacraid dev/advansys dev/ath dev/beri/virtio dev/bnxt dev/bwn dev/ciss dev/cxgbe/crypto dev

2018-01-24 Thread Conrad Meyer
On Wed, Jan 24, 2018 at 11:27 AM, Warner Losh wrote: > > Which is why we should add check overflows for most of the no wait cases. > They should be checked, but not primarily with mallocarray... I don't understand what the distinction is here. Can you help me understand why the overflow check sh

svn commit: r328351 - in head: share/man/man9 sys/kern sys/sys

2018-01-24 Thread Conrad Meyer
Author: cem Date: Wed Jan 24 19:37:18 2018 New Revision: 328351 URL: https://svnweb.freebsd.org/changeset/base/328351 Log: malloc(9): Change nominal size to size_t to match standard C No functional change -- size_t matches unsigned long on all platforms. Reported by: bde Discussed w

Re: svn commit: r328218 - in head/sys: amd64/amd64 arm/xscale/ixp425 arm64/arm64 cam cam/ctl compat/ndis dev/aacraid dev/advansys dev/ath dev/beri/virtio dev/bnxt dev/bwn dev/ciss dev/cxgbe/crypto dev

2018-01-24 Thread Warner Losh
On Jan 24, 2018 12:24 PM, "Conrad Meyer" wrote: On Wed, Jan 24, 2018 at 10:51 AM, Pedro Giffuni wrote: > FWIW, I suggested a panic for M_WAITOK and returning NULL for M_NOWAIT, but > cem didn't like it because it was inconsistent. > > I think the current argument is more about the size/trigger t

Re: svn commit: r328218 - in head/sys: amd64/amd64 arm/xscale/ixp425 arm64/arm64 cam cam/ctl compat/ndis dev/aacraid dev/advansys dev/ath dev/beri/virtio dev/bnxt dev/bwn dev/ciss dev/cxgbe/crypto dev

2018-01-24 Thread Conrad Meyer
On Wed, Jan 24, 2018 at 10:44 AM, Pedro Giffuni wrote: > ... > On 24/01/2018 13:30, Conrad Meyer wrote: >> >> ... >> size_t can handle 10GB, but u_long can't. >> This whole argument hinges upon incorrect assumption that size_t is >> larger than u_long. > > > Hmm... > > Lets just make it "unsigned

Re: svn commit: r328218 - in head/sys: amd64/amd64 arm/xscale/ixp425 arm64/arm64 cam cam/ctl compat/ndis dev/aacraid dev/advansys dev/ath dev/beri/virtio dev/bnxt dev/bwn dev/ciss dev/cxgbe/crypto dev

2018-01-24 Thread Conrad Meyer
On Wed, Jan 24, 2018 at 10:51 AM, Pedro Giffuni wrote: > FWIW, I suggested a panic for M_WAITOK and returning NULL for M_NOWAIT, but > cem didn't like it because it was inconsistent. > > I think the current argument is more about the size/trigger than the > behavior though. Yeah. If an overflow

Re: svn commit: r328218 - in head/sys: amd64/amd64 arm/xscale/ixp425 arm64/arm64 cam cam/ctl compat/ndis dev/aacraid dev/advansys dev/ath dev/beri/virtio dev/bnxt dev/bwn dev/ciss dev/cxgbe/crypto dev

2018-01-24 Thread Pedro Giffuni
On 24/01/2018 13:40, Hans Petter Selasky wrote: On 01/24/18 19:28, Warner Losh wrote: Does mallocarray(10 ,1Gb) panic on i386? It does not. It should. Hi, If M_WAITOK is specified, then sleep forever and print a message. Else return NULL ? FWIW, I suggested a panic for M_WAITOK and return

svn commit: r328350 - head/sys/netipsec

2018-01-24 Thread Andrey V. Elsukov
Author: ae Date: Wed Jan 24 19:06:44 2018 New Revision: 328350 URL: https://svnweb.freebsd.org/changeset/base/328350 Log: Merge revision 1.35 from NetBSD: fix pointer/offset mistakes in handling of IPv4 options Reported by: Maxime Villard MFC after:1 week Modified: head/sys/n

Re: svn commit: r328218 - in head/sys: amd64/amd64 arm/xscale/ixp425 arm64/arm64 cam cam/ctl compat/ndis dev/aacraid dev/advansys dev/ath dev/beri/virtio dev/bnxt dev/bwn dev/ciss dev/cxgbe/crypto dev

2018-01-24 Thread Pedro Giffuni
... On 24/01/2018 13:30, Conrad Meyer wrote: ... size_t can handle 10GB, but u_long can't. This whole argument hinges upon incorrect assumption that size_t is larger than u_long. Hmm... Lets just make it "unsigned long" to be consistent with malloc(9) and avoid confusion? Pedro. ___

Re: svn commit: r328218 - in head/sys: amd64/amd64 arm/xscale/ixp425 arm64/arm64 cam cam/ctl compat/ndis dev/aacraid dev/advansys dev/ath dev/beri/virtio dev/bnxt dev/bwn dev/ciss dev/cxgbe/crypto dev

2018-01-24 Thread Conrad Meyer
On Wed, Jan 24, 2018 at 10:40 AM, Hans Petter Selasky wrote: > On 01/24/18 19:28, Warner Losh wrote: >> >> Does mallocarray(10 ,1Gb) panic on i386? It does not. It should. > > > Hi, > > If M_WAITOK is specified, then sleep forever and print a message. > Else return NULL ? Depends on the machine.

Re: svn commit: r328218 - in head/sys: amd64/amd64 arm/xscale/ixp425 arm64/arm64 cam cam/ctl compat/ndis dev/aacraid dev/advansys dev/ath dev/beri/virtio dev/bnxt dev/bwn dev/ciss dev/cxgbe/crypto dev

2018-01-24 Thread Warner Losh
On Jan 24, 2018 11:33 AM, "Conrad Meyer" wrote: Bruce didn't get this wrong, you've just misread his (style / opinion) complaint as an actual bug (which is kind of the whole reason why it's hard to treat his complaints seriously): > size_t happens to have the same representation as u_long on all

Re: svn commit: r328218 - in head/sys: amd64/amd64 arm/xscale/ixp425 arm64/arm64 cam cam/ctl compat/ndis dev/aacraid dev/advansys dev/ath dev/beri/virtio dev/bnxt dev/bwn dev/ciss dev/cxgbe/crypto dev

2018-01-24 Thread Hans Petter Selasky
On 01/24/18 19:28, Warner Losh wrote: Does mallocarray(10 ,1Gb) panic on i386? It does not. It should. Hi, If M_WAITOK is specified, then sleep forever and print a message. Else return NULL ? --HPS ___ svn-src-head@freebsd.org mailing list https://l

Re: svn commit: r328218 - in head/sys: amd64/amd64 arm/xscale/ixp425 arm64/arm64 cam cam/ctl compat/ndis dev/aacraid dev/advansys dev/ath dev/beri/virtio dev/bnxt dev/bwn dev/ciss dev/cxgbe/crypto dev

2018-01-24 Thread Conrad Meyer
Bruce didn't get this wrong, you've just misread his (style / opinion) complaint as an actual bug (which is kind of the whole reason why it's hard to treat his complaints seriously): > size_t happens to have the same representation as u_long on all supported > arches So yes, the check works on i

Re: svn commit: r328218 - in head/sys: amd64/amd64 arm/xscale/ixp425 arm64/arm64 cam cam/ctl compat/ndis dev/aacraid dev/advansys dev/ath dev/beri/virtio dev/bnxt dev/bwn dev/ciss dev/cxgbe/crypto dev

2018-01-24 Thread Conrad Meyer
On Wed, Jan 24, 2018 at 10:05 AM, Warner Losh wrote: > It changes the fundamental 'can't fail' allocations into 'maybe panic' > allocations, which was my big objection. No, it doesn't make any such change. The only calls that will panic now would have "succeeded" before but returned a smaller si

Re: svn commit: r328218 - in head/sys: amd64/amd64 arm/xscale/ixp425 arm64/arm64 cam cam/ctl compat/ndis dev/aacraid dev/advansys dev/ath dev/beri/virtio dev/bnxt dev/bwn dev/ciss dev/cxgbe/crypto dev

2018-01-24 Thread Warner Losh
Does mallocarray(10 ,1Gb) panic on i386? It does not. It should. Warner On Jan 24, 2018 11:20 AM, "Conrad Meyer" wrote: > Please point out what in Bruce's rant is actually relevant. Again, I > usually start reading them and get sidetracked in things that are > opinions stated as fact, or outri

Re: svn commit: r328218 - in head/sys: amd64/amd64 arm/xscale/ixp425 arm64/arm64 cam cam/ctl compat/ndis dev/aacraid dev/advansys dev/ath dev/beri/virtio dev/bnxt dev/bwn dev/ciss dev/cxgbe/crypto dev

2018-01-24 Thread Konstantin Belousov
On Wed, Jan 24, 2018 at 11:05:24AM -0700, Warner Losh wrote: > Let's start with his point about u_long vs size_t causing problems: > > void*malloc(unsigned long size, struct malloc_type *type, int flags) > vs > void*mallocarray(size_t nmemb, size_t size, struct malloc_type *type, > > Sinc

Re: svn commit: r328218 - in head/sys: amd64/amd64 arm/xscale/ixp425 arm64/arm64 cam cam/ctl compat/ndis dev/aacraid dev/advansys dev/ath dev/beri/virtio dev/bnxt dev/bwn dev/ciss dev/cxgbe/crypto dev

2018-01-24 Thread Conrad Meyer
Please point out what in Bruce's rant is actually relevant. Again, I usually start reading them and get sidetracked in things that are opinions stated as fact, or outright incorrect. At which point, I give up on them. ___ svn-src-head@freebsd.org mailin

Re: svn commit: r328218 - in head/sys: amd64/amd64 arm/xscale/ixp425 arm64/arm64 cam cam/ctl compat/ndis dev/aacraid dev/advansys dev/ath dev/beri/virtio dev/bnxt dev/bwn dev/ciss dev/cxgbe/crypto dev

2018-01-24 Thread Pedro Giffuni
On 01/24/18 12:37, Conrad Meyer wrote: On Tue, Jan 23, 2018 at 11:40 AM, Pedro Giffuni wrote: On 23/01/2018 14:08, Conrad Meyer wrote: On Sun, Jan 21, 2018 at 7:42 AM, Pedro F. Giffuni wrote: Author: pfg Date: Sun Jan 21 15:42:36 2018 New Revision: 328218 I'm confused about this change.

svn commit: r328349 - head/sys/arm/freescale/imx

2018-01-24 Thread Ian Lepore
Author: ian Date: Wed Jan 24 18:10:11 2018 New Revision: 328349 URL: https://svnweb.freebsd.org/changeset/base/328349 Log: Make the trivial imx_soc_family() function an inline in imx_machdep.h. The imx_machdep.c file is on the fast path to non-existance and this would be the only thing le

svn commit: r328348 - head

2018-01-24 Thread Bryan Drewery
Author: bdrewery Date: Wed Jan 24 18:09:44 2018 New Revision: 328348 URL: https://svnweb.freebsd.org/changeset/base/328348 Log: test-system-compiler: Display X_ variants for compiler/linker. Sponsored by: Dell EMC Modified: head/Makefile.inc1 Modified: head/Makefile.inc1 ===

svn commit: r328347 - head

2018-01-24 Thread Bryan Drewery
Author: bdrewery Date: Wed Jan 24 18:08:37 2018 New Revision: 328347 URL: https://svnweb.freebsd.org/changeset/base/328347 Log: X_COMPILER_* may not be defined. Sponsored by: Dell EMC Modified: head/Makefile.inc1 head/Makefile.libcompat Modified: head/Makefile.inc1 ===

Re: svn commit: r328218 - in head/sys: amd64/amd64 arm/xscale/ixp425 arm64/arm64 cam cam/ctl compat/ndis dev/aacraid dev/advansys dev/ath dev/beri/virtio dev/bnxt dev/bwn dev/ciss dev/cxgbe/crypto dev

2018-01-24 Thread Warner Losh
On Wed, Jan 24, 2018 at 10:34 AM, Conrad Meyer wrote: > On Wed, Jan 24, 2018 at 7:44 AM, Warner Losh wrote: > > I agree completely. It doesn't do what you think it is doing, for all the > > reasons that Bruce outlines. We thought it was a bad idea when it came > up 2 > > years ago and nothing ha

Re: svn commit: r328218 - in head/sys: amd64/amd64 arm/xscale/ixp425 arm64/arm64 cam cam/ctl compat/ndis dev/aacraid dev/advansys dev/ath dev/beri/virtio dev/bnxt dev/bwn dev/ciss dev/cxgbe/crypto dev

2018-01-24 Thread Ian Lepore
On Wed, 2018-01-24 at 09:34 -0800, Conrad Meyer wrote: > On Wed, Jan 24, 2018 at 7:44 AM, Warner Losh wrote: > > > > I agree completely. It doesn't do what you think it is doing, for all the > > reasons that Bruce outlines. We thought it was a bad idea when it came up 2 > > years ago and nothing

svn commit: r328346 - in head/sys: fs/ext2fs ufs/ffs ufs/ufs

2018-01-24 Thread Pedro F. Giffuni
Author: pfg Date: Wed Jan 24 17:58:48 2018 New Revision: 328346 URL: https://svnweb.freebsd.org/changeset/base/328346 Log: ext2fs|ufs:Unsign some values related to allocation. When allocating memory through malloc(9), we always expect the amount of memory requested to be unsigned as a neg

svn commit: r328345 - head/sys/arm/freescale/imx

2018-01-24 Thread Ian Lepore
Author: ian Date: Wed Jan 24 17:52:06 2018 New Revision: 328345 URL: https://svnweb.freebsd.org/changeset/base/328345 Log: Reformat indentation to match other imx5/6 register definition headers, and tweak some comments. No functional changes. Modified: head/sys/arm/freescale/imx/imx_wdogre

svn commit: r328344 - head/tests/sys/kern

2018-01-24 Thread John Baldwin
Author: jhb Date: Wed Jan 24 17:46:20 2018 New Revision: 328344 URL: https://svnweb.freebsd.org/changeset/base/328344 Log: Mark the unused argument to continue_thread() as such. clang in HEAD and 11 does not warn about this, but clang in 10 does. Modified: head/tests/sys/kern/ptrace_test

Re: svn commit: r328218 - in head/sys: amd64/amd64 arm/xscale/ixp425 arm64/arm64 cam cam/ctl compat/ndis dev/aacraid dev/advansys dev/ath dev/beri/virtio dev/bnxt dev/bwn dev/ciss dev/cxgbe/crypto dev

2018-01-24 Thread Conrad Meyer
On Tue, Jan 23, 2018 at 11:40 AM, Pedro Giffuni wrote: > On 23/01/2018 14:08, Conrad Meyer wrote: >> On Sun, Jan 21, 2018 at 7:42 AM, Pedro F. Giffuni wrote: >>> >>> Author: pfg >>> Date: Sun Jan 21 15:42:36 2018 >>> New Revision: 328218 >> >> I'm confused about this change. Wouldn't it be bette

Re: svn commit: r328218 - in head/sys: amd64/amd64 arm/xscale/ixp425 arm64/arm64 cam cam/ctl compat/ndis dev/aacraid dev/advansys dev/ath dev/beri/virtio dev/bnxt dev/bwn dev/ciss dev/cxgbe/crypto dev

2018-01-24 Thread Conrad Meyer
On Wed, Jan 24, 2018 at 7:44 AM, Warner Losh wrote: > I agree completely. It doesn't do what you think it is doing, for all the > reasons that Bruce outlines. We thought it was a bad idea when it came up 2 > years ago and nothing has really changed. I disagree. I'm not sure what you mean by "it

Re: svn commit: r328218 - in head/sys: amd64/amd64 arm/xscale/ixp425 arm64/arm64 cam cam/ctl compat/ndis dev/aacraid dev/advansys dev/ath dev/beri/virtio dev/bnxt dev/bwn dev/ciss dev/cxgbe/crypto dev

2018-01-24 Thread Pedro Giffuni
On 01/24/18 03:50, Bruce Evans wrote: On Tue, 23 Jan 2018, Pedro Giffuni wrote: On 23/01/2018 14:08, Conrad Meyer wrote: Hi Pedro, On Sun, Jan 21, 2018 at 7:42 AM, Pedro F. Giffuni wrote: Author: pfg Date: Sun Jan 21 15:42:36 2018 New Revision: 328218 URL: https://svnweb.freebsd.org/chan

Re: svn commit: r328342 - in head/sys: amd64/linux dev/usb/storage

2018-01-24 Thread Edward Tomasz Napierala
On 0124T1216, Pedro Giffuni wrote: > > On 01/24/18 12:04, Edward Tomasz Napierala wrote: > > Author: trasz > > Date: Wed Jan 24 17:04:01 2018 > > New Revision: 328342 > > URL: https://svnweb.freebsd.org/changeset/base/328342 > > > > Log: > >Add SPDX identifiers to linux_ptrace.c and cfumass.c.

Re: svn commit: r328342 - in head/sys: amd64/linux dev/usb/storage

2018-01-24 Thread Pedro Giffuni
On 01/24/18 12:04, Edward Tomasz Napierala wrote: Author: trasz Date: Wed Jan 24 17:04:01 2018 New Revision: 328342 URL: https://svnweb.freebsd.org/changeset/base/328342 Log: Add SPDX identifiers to linux_ptrace.c and cfumass.c. MFC after: 2 weeks Thanks for all these! For the rec

svn commit: r328343 - head/usr.bin/time

2018-01-24 Thread Alan Somers
Author: asomers Date: Wed Jan 24 17:12:34 2018 New Revision: 328343 URL: https://svnweb.freebsd.org/changeset/base/328343 Log: time(1): use clock_gettime(2) instead of gettimeofday(2) This is a prerequisite to adding support for the monotonic clock Reviewed by: ken, imp MFC after:

svn commit: r328342 - in head/sys: amd64/linux dev/usb/storage

2018-01-24 Thread Edward Tomasz Napierala
Author: trasz Date: Wed Jan 24 17:04:01 2018 New Revision: 328342 URL: https://svnweb.freebsd.org/changeset/base/328342 Log: Add SPDX identifiers to linux_ptrace.c and cfumass.c. MFC after:2 weeks Modified: head/sys/amd64/linux/linux_ptrace.c head/sys/dev/usb/storage/cfumass.c Mod

svn commit: r328341 - head/sys/dev/iscsi

2018-01-24 Thread Edward Tomasz Napierala
Author: trasz Date: Wed Jan 24 16:58:26 2018 New Revision: 328341 URL: https://svnweb.freebsd.org/changeset/base/328341 Log: Add SPDX tags to iscsi(4). MFC after:2 weeks Modified: head/sys/dev/iscsi/icl_conn_if.m head/sys/dev/iscsi/icl_soft.c head/sys/dev/iscsi/icl_wrappers.h Mo

svn commit: r328340 - in head/sys: fs/ext2fs ufs/ffs ufs/ufs

2018-01-24 Thread Pedro F. Giffuni
Author: pfg Date: Wed Jan 24 16:44:57 2018 New Revision: 328340 URL: https://svnweb.freebsd.org/changeset/base/328340 Log: Revert r327781, r328093, r328056: ufs|ext2fs: Revert uses of mallocarray(9). These aren't really useful: drop them. Variable unsigning will be brought again later.

svn commit: r328339 - head/sys/fs/autofs

2018-01-24 Thread Edward Tomasz Napierala
Author: trasz Date: Wed Jan 24 16:40:26 2018 New Revision: 328339 URL: https://svnweb.freebsd.org/changeset/base/328339 Log: Add SPDX tags to autofs(5). MFC after:2 weeks Modified: head/sys/fs/autofs/autofs.h head/sys/fs/autofs/autofs_ioctl.h head/sys/fs/autofs/autofs_vfsops.c

svn commit: r328338 - head/usr.sbin/autofs

2018-01-24 Thread Edward Tomasz Napierala
Author: trasz Date: Wed Jan 24 16:39:02 2018 New Revision: 328338 URL: https://svnweb.freebsd.org/changeset/base/328338 Log: Add SPDX tags for automount(8) et al. MFC after:2 weeks Modified: head/usr.sbin/autofs/automount.c head/usr.sbin/autofs/automountd.c head/usr.sbin/autofs/a

svn commit: r328337 - head/usr.sbin/ctld

2018-01-24 Thread Edward Tomasz Napierala
Author: trasz Date: Wed Jan 24 16:37:29 2018 New Revision: 328337 URL: https://svnweb.freebsd.org/changeset/base/328337 Log: Add missing SPDX tags for ctld(8). MFC after:2 weeks Modified: head/usr.sbin/ctld/chap.c head/usr.sbin/ctld/isns.c head/usr.sbin/ctld/uclparse.c Modified:

svn commit: r328335 - head/usr.sbin/uefisign

2018-01-24 Thread Edward Tomasz Napierala
Author: trasz Date: Wed Jan 24 16:33:33 2018 New Revision: 328335 URL: https://svnweb.freebsd.org/changeset/base/328335 Log: Add SPDX identifiers for uefisign(8) sources. MFC after:2 weeks Modified: head/usr.sbin/uefisign/child.c head/usr.sbin/uefisign/magic.h head/usr.sbin/uefis

svn commit: r328336 - head/usr.sbin/iscsid

2018-01-24 Thread Edward Tomasz Napierala
Author: trasz Date: Wed Jan 24 16:34:37 2018 New Revision: 328336 URL: https://svnweb.freebsd.org/changeset/base/328336 Log: Add missing SPDX identifier in iscsid(8). MFC after:2 weeks Modified: head/usr.sbin/iscsid/chap.c Modified: head/usr.sbin/iscsid/chap.c ==

Re: svn commit: r328218 - in head/sys: amd64/amd64 arm/xscale/ixp425 arm64/arm64 cam cam/ctl compat/ndis dev/aacraid dev/advansys dev/ath dev/beri/virtio dev/bnxt dev/bwn dev/ciss dev/cxgbe/crypto dev

2018-01-24 Thread Warner Losh
On Wed, Jan 24, 2018 at 1:50 AM, Bruce Evans wrote: > On Tue, 23 Jan 2018, Pedro Giffuni wrote: > > On 23/01/2018 14:08, Conrad Meyer wrote: >> >>> Hi Pedro, >>> >>> On Sun, Jan 21, 2018 at 7:42 AM, Pedro F. Giffuni >>> wrote: >>> Author: pfg Date: Sun Jan 21 15:42:36 2018 New Rev

Re: svn commit: r328330 - head/sys/kern

2018-01-24 Thread Cy Schubert
In message <82d52ee3-1c2a-2399-0142-0027b4370...@selasky.org>, Hans Petter Sela sky writes: > On 01/24/18 15:00, Cy Schubert wrote: > > Why? What happened? > > > > Hi, > > See r326376 . This patch is out of date :-) This makes my point. Someone browsing through the log will not be able to deter

svn commit: r328332 - in head: contrib/libarchive/cat contrib/libarchive/cat/test contrib/libarchive/libarchive contrib/libarchive/libarchive/test contrib/libarchive/tar/test lib/libarchive/tests u...

2018-01-24 Thread Martin Matuska
Author: mm Date: Wed Jan 24 14:24:17 2018 New Revision: 328332 URL: https://svnweb.freebsd.org/changeset/base/328332 Log: MFV r328323,328324: Sync libarchive with vendor. Relevant vendor changes: PR #893: delete dead ppmd7 alloc callbacks PR #904: Fix archive freeing bug in bsdcat

svn commit: r328331 - head/etc

2018-01-24 Thread Dmitry Marakasov
Author: amdmi3 (ports committer) Date: Wed Jan 24 14:15:06 2018 New Revision: 328331 URL: https://svnweb.freebsd.org/changeset/base/328331 Log: Support configuring arbitrary limits(1) for any daemon in rc.conf Usage is ${name}_limits, and the argument is any flags accepted by limits(1), s

Re: svn commit: r328330 - head/sys/kern

2018-01-24 Thread Hans Petter Selasky
On 01/24/18 15:00, Cy Schubert wrote: Why? What happened? Hi, See r326376 . This patch is out of date :-) --HPS ___ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn

Re: svn commit: r328330 - head/sys/kern

2018-01-24 Thread Cy Schubert
In message <201801241357.w0odv1tm043...@repo.freebsd.org>, Wojciech Macek write s: > Author: wma > Date: Wed Jan 24 13:57:01 2018 > New Revision: 328330 > URL: https://svnweb.freebsd.org/changeset/base/328330 > > Log: > Reverting r328320 > > Modified: > head/sys/kern/sched_ule.c > > Modified:

svn commit: r328330 - head/sys/kern

2018-01-24 Thread Wojciech Macek
Author: wma Date: Wed Jan 24 13:57:01 2018 New Revision: 328330 URL: https://svnweb.freebsd.org/changeset/base/328330 Log: Reverting r328320 Modified: head/sys/kern/sched_ule.c Modified: head/sys/kern/sched_ule.c ==

Re: svn commit: r328320 - head/sys/kern

2018-01-24 Thread Hans Petter Selasky
On 01/24/18 08:54, Wojciech Macek wrote: Author: wma Date: Wed Jan 24 07:54:05 2018 New Revision: 328320 URL: https://svnweb.freebsd.org/changeset/base/328320 Log: ULE: provide defaults to ts_cpu Fix a bug when the system has no CPU 0. When created, threads were implicitly assigned to

svn commit: r328329 - head/sys/compat/linuxkpi/common/src

2018-01-24 Thread Hans Petter Selasky
Author: hselasky Date: Wed Jan 24 13:37:07 2018 New Revision: 328329 URL: https://svnweb.freebsd.org/changeset/base/328329 Log: Properly implement the "id" callback argument in the "idr_for_each" function in the LinuxKPI. The old implementation assumed only one IDR layer was present. Take a

Re: svn commit: r328305 - head/lib/libcxxrt

2018-01-24 Thread Ed Maste
On 24 January 2018 at 06:51, Dimitry Andric wrote: >> -# C++11 typeinfo not understood by our linker >> -# std::nullptr_t >> -_ZTIDn;_ZTIPDn;_ZTIPKDn; > > Maybe, for readability, we should change these to unmangled form instead? I believe they're mangled because ld.bfd 2.1

svn commit: r328326 - head/sys/netpfil/ipfw

2018-01-24 Thread Andrey V. Elsukov
Author: ae Date: Wed Jan 24 12:40:28 2018 New Revision: 328326 URL: https://svnweb.freebsd.org/changeset/base/328326 Log: When IPv6 packet is handled by O_REJECT opcode, convert ICMP code specified in the arg1 into ICMPv6 destination unreachable code according to RFC7915. Obtained from:

svn commit: r328325 - head/sys/powerpc/powerpc

2018-01-24 Thread Wojciech Macek
Author: wma Date: Wed Jan 24 12:01:32 2018 New Revision: 328325 URL: https://svnweb.freebsd.org/changeset/base/328325 Log: PPC: Add KASSERT in intrcnt_add which checks for buffer overflow Authored by: Patryk Duda Submitted by: Wojciech Macek Obtained from: S

Re: svn commit: r328305 - head/lib/libcxxrt

2018-01-24 Thread Dimitry Andric
On 23 Jan 2018, at 23:41, Ed Maste wrote: > > Author: emaste > Date: Tue Jan 23 22:41:13 2018 > New Revision: 328305 > URL: https://svnweb.freebsd.org/changeset/base/328305 > > Log: > libcxxrt: Move mangled symbols out of extern "C++" in Version.map > > r260553 added a number of mangled C++ s

svn commit: r328321 - head/sys/net

2018-01-24 Thread Steven Hartland
Author: smh Date: Wed Jan 24 10:13:14 2018 New Revision: 328321 URL: https://svnweb.freebsd.org/changeset/base/328321 Log: Added missing CTLFLAG_VNET to lacp default_strict_mode Added CTLFLAG_VNET to net.link.lagg.lacp.default_strict_mode which was missed in r290450. Reported by: ju

Re: svn commit: r328218 - in head/sys: amd64/amd64 arm/xscale/ixp425 arm64/arm64 cam cam/ctl compat/ndis dev/aacraid dev/advansys dev/ath dev/beri/virtio dev/bnxt dev/bwn dev/ciss dev/cxgbe/crypto dev

2018-01-24 Thread Bruce Evans
On Tue, 23 Jan 2018, Pedro Giffuni wrote: On 23/01/2018 14:08, Conrad Meyer wrote: Hi Pedro, On Sun, Jan 21, 2018 at 7:42 AM, Pedro F. Giffuni wrote: Author: pfg Date: Sun Jan 21 15:42:36 2018 New Revision: 328218 URL: https://svnweb.freebsd.org/changeset/base/328218 Log: Revert r327828,