Re: svn commit: r340450 - head/sys/sys

2018-11-18 Thread Warner Losh
On Mon, Nov 19, 2018 at 12:31 AM Andriy Gapon wrote: > On 19/11/2018 03:38, Warner Losh wrote: > > I'll talk to Allan to see if he can test that. the bare 1 should be > handled > > properly because of C's promotion rules. 1ull << 32 is an unsigned long > long. > > What I really wanted was

Re: svn commit: r340450 - head/sys/sys

2018-11-18 Thread Andriy Gapon
On 19/11/2018 03:38, Warner Losh wrote: > I'll talk to Allan to see if he can test that. the bare 1 should be handled > properly because of C's promotion rules. 1ull << 32 is an unsigned long long. > What I really wanted was "~(uint32_t)0" but that construct has bit me in the > past. I think

svn commit: r340617 - head/sys/netgraph

2018-11-18 Thread Eugene Grosbein
Author: eugen Date: Mon Nov 19 07:27:50 2018 New Revision: 340617 URL: https://svnweb.freebsd.org/changeset/base/340617 Log: Unbreak ng_source(4) for 64-bit platforms including amd64. Modified: head/sys/netgraph/ng_source.c Modified: head/sys/netgraph/ng_source.c

svn commit: r340613 - head/sys/mips/mediatek

2018-11-18 Thread Stanislav Galabov
Author: sgalabov Date: Mon Nov 19 06:48:48 2018 New Revision: 340613 URL: https://svnweb.freebsd.org/changeset/base/340613 Log: Fix access to cpu_model[] in mtk_soc_set_cpu_model() There may be cases where cpu_model[] may not be 32bit aligned, so it is better to not try to access it as

svn commit: r340602 - head/sys/arm64/arm64

2018-11-18 Thread Jayachandran C.
Author: jchandra Date: Mon Nov 19 03:52:56 2018 New Revision: 340602 URL: https://svnweb.freebsd.org/changeset/base/340602 Log: gitv3_its: fixes for multiple GIC ITS blocks First pass of support for multiple GIC ITS blocks with ACPI. Changes are to: * register the correct subset of

svn commit: r340601 - head/sys/dev/pci

2018-11-18 Thread Jayachandran C.
Author: jchandra Date: Mon Nov 19 03:43:10 2018 New Revision: 340601 URL: https://svnweb.freebsd.org/changeset/base/340601 Log: pci_host_generic : move activate/release to generic code Now that the ACPI and FDT implementations for activating and deactivating resources are the same, we

svn commit: r340600 - in head/sys/dev: acpica pci

2018-11-18 Thread Jayachandran C.
Author: jchandra Date: Mon Nov 19 03:34:15 2018 New Revision: 340600 URL: https://svnweb.freebsd.org/changeset/base/340600 Log: pci_host_generic, acpi_resource: drop unneeded code Now that we are handling PCI resources in pci_host_generic_acpi.c, we don't need these change (made by

svn commit: r340599 - in head/sys/dev: acpica pci

2018-11-18 Thread Jayachandran C.
Author: jchandra Date: Mon Nov 19 03:16:16 2018 New Revision: 340599 URL: https://svnweb.freebsd.org/changeset/base/340599 Log: acpica, pci_host_generic_acpi: redo pci_host_generic_acpi.c This is a major update for pci_host_generic_acpi.c, the current implementation has some gaps that

svn commit: r340598 - in head/sys: arm/arm dev/acpica

2018-11-18 Thread Jayachandran C.
Author: jchandra Date: Mon Nov 19 03:02:47 2018 New Revision: 340598 URL: https://svnweb.freebsd.org/changeset/base/340598 Log: acpica: rework INTRNG interrupts On arm64 (where INTRNG is enabled), the interrupts have to be mapped with ACPI_BUS_MAP_INTR() before adding them as resources

svn commit: r340597 - head/sys/dev/pci

2018-11-18 Thread Jayachandran C.
Author: jchandra Date: Mon Nov 19 02:55:18 2018 New Revision: 340597 URL: https://svnweb.freebsd.org/changeset/base/340597 Log: pci_host_generic*: basic implementation of bus range Both ACPI and FDT support bus ranges for pci host bridges. Update pci_host_generic*.[ch] with a default

svn commit: r340596 - head/sys/dev/pci

2018-11-18 Thread Jayachandran C.
Author: jchandra Date: Mon Nov 19 02:43:34 2018 New Revision: 340596 URL: https://svnweb.freebsd.org/changeset/base/340596 Log: pci_host_generic: allocate resources against devices Fix up pci_host_generic.c and pci_host_generic_fdt.c to allocate resources against devices that requested

svn commit: r340595 - head/sys/dev/pci

2018-11-18 Thread Jayachandran C.
Author: jchandra Date: Mon Nov 19 02:38:02 2018 New Revision: 340595 URL: https://svnweb.freebsd.org/changeset/base/340595 Log: pci_host_generic: remove unneeded ThunderX2 quirk The current quirk implementation writes a fixed address to the PCI BAR to fix a firmware bug. The PCI BARs are

svn commit: r340594 - in head: etc/mtree sbin/bectl sbin/bectl/tests

2018-11-18 Thread Kyle Evans
Author: kevans Date: Mon Nov 19 02:30:12 2018 New Revision: 340594 URL: https://svnweb.freebsd.org/changeset/base/340594 Log: bectl(8): Add some regression tests These tests operate on a file-backed zpool that gets created in the kyua temp dir. root and ZFS support are both required for

svn commit: r340593 - head/lib/libbe

2018-11-18 Thread Kyle Evans
Author: kevans Date: Mon Nov 19 02:16:20 2018 New Revision: 340593 URL: https://svnweb.freebsd.org/changeset/base/340593 Log: libbe(3): Properly account for altroot when creating new BEs Previously we would blindly copy the 'mountpoint' property, which includes the altroot. The altroot

svn commit: r340592 - in head: lib/libbe sbin/bectl

2018-11-18 Thread Kyle Evans
Author: kevans Date: Mon Nov 19 02:12:08 2018 New Revision: 340592 URL: https://svnweb.freebsd.org/changeset/base/340592 Log: bectl(3)/libbe(3): Allow BE root to be specified Add an undocumented -r option preceding the bectl subcommand to specify a BE root to operate out of. This will

Re: svn commit: r340450 - head/sys/sys

2018-11-18 Thread Warner Losh
On Sun, Nov 18, 2018 at 6:04 PM Rodney W. Grimes < free...@pdx.rh.cn85.dnsmgr.net> wrote: > [ Charset UTF-8 unsupported, converting... ] > > I don't see how this could possibly have changed things. The changes will > > change the least significant bit by one for fractional results. I've > looked

Re: svn commit: r340450 - head/sys/sys

2018-11-18 Thread Rodney W. Grimes
[ Charset UTF-8 unsupported, converting... ] > I don't see how this could possibly have changed things. The changes will > change the least significant bit by one for fractional results. I've looked > at all the functions that use it and get called by the mlx driver and have > trouble seeing where

svn commit: r340591 - in head/sys: kern sys

2018-11-18 Thread Kevin Bowling
Author: kbowling (ports committer) Date: Mon Nov 19 00:54:31 2018 New Revision: 340591 URL: https://svnweb.freebsd.org/changeset/base/340591 Log: Retire sbsndptr() KPI As of r340465 all consumers use sbsndptr_adv and sbsndptr_noadv Reviewed by: gallatin Approved by: krion (mentor)

Re: svn commit: r340450 - head/sys/sys

2018-11-18 Thread Warner Losh
I don't see how this could possibly have changed things. The changes will change the least significant bit by one for fractional results. I've looked at all the functions that use it and get called by the mlx driver and have trouble seeing where it could be relevant... Can you do an experiment to

Re: svn commit: r339618 - head/sys/compat/linuxkpi/common/include/linux

2018-11-18 Thread Matthew Macy
> > > > PowerPC barrier instructions are needed to prevent reordering. > > > > Correct. The current lkpi implementation also assumes that device > > endian == host endian. The Linux generic accessors will do use endian > > macros to byte swap where necessary. > > Yes, these functions are used to

Re: svn commit: r339618 - head/sys/compat/linuxkpi/common/include/linux

2018-11-18 Thread Matthew Macy
Correct. This is just the generic case. We just need to define the __io macros as __compiler_membar in x86/io.h Cheers. -M On Sun, Nov 18, 2018 at 13:08 Tijl Coosemans wrote: > On Sun, 18 Nov 2018 12:10:25 -0800 Matthew Macy > wrote: > >> Note that these functions are normally used on

Re: svn commit: r339618 - head/sys/compat/linuxkpi/common/include/linux

2018-11-18 Thread Tijl Coosemans
On Sun, 18 Nov 2018 12:10:25 -0800 Matthew Macy wrote: >> Note that these functions are normally used on uncacheable memory which >> is strongly ordered on x86. There should be no reordering at all. On >> PowerPC barrier instructions are needed to prevent reordering. > > Correct. The current

Re: svn commit: r339618 - head/sys/compat/linuxkpi/common/include/linux

2018-11-18 Thread Matthew Macy
> Note that these functions are normally used on uncacheable memory which > is strongly ordered on x86. There should be no reordering at all. On > PowerPC barrier instructions are needed to prevent reordering. Correct. The current lkpi implementation also assumes that device endian == host

Re: svn commit: r340450 - head/sys/sys

2018-11-18 Thread Allan Jude
On 2018-11-15 11:02, Warner Losh wrote: > Author: imp > Date: Thu Nov 15 16:02:13 2018 > New Revision: 340450 > URL: https://svnweb.freebsd.org/changeset/base/340450 > > Log: > When converting ns,us,ms to sbt, return the ceil() of the result > rather than the floor(). Returning the floor

svn commit: r340587 - head

2018-11-18 Thread Alex Richardson
Author: arichardson Date: Sun Nov 18 19:55:03 2018 New Revision: 340587 URL: https://svnweb.freebsd.org/changeset/base/340587 Log: Fix -DNO_CLEAN amd64 build after r340463 Without this change I got the following error: clang-7: error: no such file or directory:

Re: svn commit: r340572 - head/usr.bin/brandelf

2018-11-18 Thread Mariusz Zaborski
Reviewed by: emaste, markj, allanjude Differential Revision:https://reviews.freebsd.org/D17967 On Sun, 18 Nov 2018 at 13:23, Mariusz Zaborski wrote: > > Author: oshogbo > Date: Sun Nov 18 12:23:03 2018 > New Revision: 340572 > URL: https://svnweb.freebsd.org/changeset/base/340572 > >

svn commit: r340572 - head/usr.bin/brandelf

2018-11-18 Thread Mariusz Zaborski
Author: oshogbo Date: Sun Nov 18 12:23:03 2018 New Revision: 340572 URL: https://svnweb.freebsd.org/changeset/base/340572 Log: brandelf: capsicumize it Modified: head/usr.bin/brandelf/Makefile head/usr.bin/brandelf/brandelf.c Modified: head/usr.bin/brandelf/Makefile

svn commit: r340567 - head/usr.bin/brandelf

2018-11-18 Thread Mariusz Zaborski
Author: oshogbo Date: Sun Nov 18 12:03:12 2018 New Revision: 340567 URL: https://svnweb.freebsd.org/changeset/base/340567 Log: brandelf: fix style nits No functional change intended. Reviewed by: emaste, markj Differential Revision:https://reviews.freebsd.org/D17966

svn commit: r340564 - head/lib/libcasper/services/cap_dns

2018-11-18 Thread Mariusz Zaborski
Author: oshogbo Date: Sun Nov 18 11:11:27 2018 New Revision: 340564 URL: https://svnweb.freebsd.org/changeset/base/340564 Log: Update the names in the LIMITS and EXAMPLES sections after r340363. Reported by: markj Modified: head/lib/libcasper/services/cap_dns/cap_dns.3 Modified:

Re: svn commit: r339618 - head/sys/compat/linuxkpi/common/include/linux

2018-11-18 Thread Tijl Coosemans
On Sat, 17 Nov 2018 14:55:05 -0800 Matthew Macy wrote: > When looking at powerpc io.h raw and relaxed are not aliases, but it > appears that on x86, they are: > https://github.com/torvalds/linux/blob/master/arch/x86/include/asm/io.h > > Sorry for the noise. But let's starting moving the x86