On Thu, 8 May 2014, Alan Somers wrote:
On Wed, May 7, 2014 at 9:39 PM, Bruce Evans b...@optusnet.com.au wrote:
On Wed, 7 May 2014, Jilles Tjoelker wrote:
On Wed, May 07, 2014 at 12:10:31PM -0600, Alan Somers wrote:
On Tue, May 6, 2014 at 9:47 PM, Bruce Evans b...@optusnet.com.au wrote
On Wed, 7 May 2014, Jilles Tjoelker wrote:
On Wed, May 07, 2014 at 12:10:31PM -0600, Alan Somers wrote:
On Tue, May 6, 2014 at 9:47 PM, Bruce Evans b...@optusnet.com.au wrote:
On Tue, 6 May 2014, Alan Somers wrote:
...
The solution is to use clock_gettime(2) with CLOCK_MONOTONIC_PRECISE
On Wed, 7 May 2014, Alan Somers wrote:
On Wed, May 7, 2014 at 2:26 PM, Jilles Tjoelker jil...@stack.nl wrote:
The floating point addition starts losing precision after 8388608
seconds (slightly more than 97 days, a plausible uptime for a server).
It is better to subtract the timespecs to avoid
On Tue, 6 May 2014, David Chisnall wrote:
On 6 May 2014, at 05:46, Bruce Evans b...@optusnet.com.au wrote:
The standard behaviour is undefined. It cannot be relied on. From C99
(n869.txt):
%7.20.3.1 The calloc function
% %Synopsis
% %[#1
On Tue, 6 May 2014, Matthew Fleming wrote:
On Tue, May 6, 2014 at 6:52 AM, Aleksandr Rybalko r...@freebsd.org wrote:
Log:
Implement KDMKTONE ioctl.
Does it have to have to be even worse than syscons?
Modified: head/sys/dev/vt/vt_core.c
On Tue, 6 May 2014, Alan Somers wrote:
Log:
dd(1) uses gettimeofday(2) to compute the throughput statistics. However,
gettimeofday returns the system clock, which may jump forward or back,
especially if NTP is in use. If the time jumps backwards, then dd will see
negative elapsed time,
On Tue, 6 May 2014, Andrey Chernov wrote:
On 05.05.2014 22:28, David Chisnall wrote:
On 5 May 2014, at 18:42, Andrey Chernov a...@freebsd.org wrote:
Please don't commit OpenBSD errors. Now you mix calloc() with the
realloc() for the same variable later which makes calloc() zeroing
pointless
On Tue, 6 May 2014, Andrey Chernov wrote:
On 06.05.2014 2:12, David Chisnall wrote:
On 5 May 2014, at 22:51, Andrey Chernov a...@freebsd.org wrote:
For standard malloc/realloc interface it is up to the caller to check
n*size not overflows. You must trust caller already does such check.
Do
On Thu, 1 May 2014, Eitan Adler wrote:
On 1 May 2014 09:59, Jung-uk Kim j...@freebsd.org wrote:
On 2014-04-30 15:38:18 -0400, ?? wrote:
On 2014-04-30 02:20:48 -0400, ?? wrote:
Mail clients keep getting worse. Fitst the apostrophes were corrupted,
now the names...
Author: eadler Date:
On Thu, 1 May 2014, Luiz Otavio O Souza wrote:
Log:
Remove unnecessary headers. Sort out the headers. Add a missing header on
ofw_gpiobus.c (it was working because of sys/libkern.h).
Do you use /usr/src/tools/tools/kerninclude/kerninclude.sh to find the
unused includes? There are many
On Wed, 30 Apr 2014, Matthew Fleming wrote:
On Wed, Apr 30, 2014 at 7:48 AM, Ian Lepore i...@freebsd.org wrote:
For some reason this reminded me of something I've been wanting for a
while but never get around to writing... /dev/ones, it's just
like /dev/zero except it returns 0xff bytes.
On Mon, 28 Apr 2014, Ed Maste wrote:
Log:
Drop explicit unsigned from FD_SETSIZE constant
FD_SETSIZE is often used as an argument to select or compared with an
integer file descriptor. Rather than force 3rd party software to add
explicit casts, just make it a plain (int) constant as on
On Sun, 20 Apr 2014, Andrew Turner wrote:
Log:
Add the deprecated fp{get,set}* functions, a few ports use them.
Added:
head/lib/libc/arm/gen/fpgetmask.c (contents, props changed)
head/lib/libc/arm/gen/fpgetround.c (contents, props changed)
head/lib/libc/arm/gen/fpgetsticky.c
On Sat, 5 Apr 2014, Warner Losh wrote:
Log:
Make some unwise casts. On i386 these casts wind up being safe. Rather
than disturb the API, go with these casts to shut gcc up.
These casts seem to be correct, while the old ones were just wrong. Now
the old ones are still there, but seem to be
On Sat, 5 Apr 2014, Warner Losh wrote:
Log:
Make some unwise casts. On i386 these casts wind up being safe. Rather
than disturb the API, go with these casts to shut gcc up.
Another reply.
The bug is mostly in clang. It doesn't complain about casting pointers
to integers that are neither
On Wed, 2 Apr 2014, Xin Li wrote:
On 4/2/14, 9:45 PM, Bruce Evans wrote:
On Thu, 3 Apr 2014, Xin LI wrote:
0x00020 -#defineC_FILES0x00040 -#defineC_IBS
0x00080 -#defineC_IF0x00100 -#defineC_LCASE
0x00200 -#defineC_NOERROR0x00400 -#defineC_NOTRUNC
On Thu, 3 Apr 2014, Xin LI wrote:
Log:
Implement GNU's extension of 'status' operand. The GNU syntax is
borrowed where syntax status=noxfer means no transfer statistics
and status=none means no status information at all.
This feature is useful because the statistics information can
On Tue, 25 Mar 2014, John-Mark Gurney wrote:
Edward Tomasz Napierala wrote this message on Tue, Mar 25, 2014 at 18:30 +:
Author: trasz
Date: Tue Mar 25 18:30:57 2014
New Revision: 263740
URL: http://svnweb.freebsd.org/changeset/base/263740
Log:
Use a less unusual syntax in debug
On Sun, 16 Mar 2014, Warner Losh wrote:
Log:
Align all comments in config files on same column. This consistency
helps when bits and pieces of GENERIC from i386 or amd64 are cut and
pasted into other architecture's config files (which in the case of
ARM had gotten rather akimbo).
On Sat, 15 Mar 2014, Hans Petter Selasky wrote:
On 03/15/14 00:26, Bruce Evans wrote:
LED toggling has to work in critical sections too. Then the LED code
itself is not being reentered (unless parts of it are locked by
critical sections), but there are other complications. Of course,
the LED
On Fri, 14 Mar 2014, Rui Paulo wrote:
On 14 Mar 2014, at 02:32, Hans Petter Selasky h...@bitfrost.no wrote:
On 03/14/14 03:15, Rui Paulo wrote:
On 10 Mar 2014, at 01:52, Hans Petter Selasky hsela...@freebsd.org wrote:
[* excessive quoting deleted]
Modified: head/sys/dev/usb/input/ukbd.c
On Thu, 13 Mar 2014, John Baldwin wrote:
Log:
Correct type for malloc().
Submitted by: Conrad Meyer conrad.me...@isilon.com
Not so nice a cleanup as a previous one by the same author.
Modified: head/sys/x86/x86/mca.c
On Wed, 12 Mar 2014, Konstantin Belousov wrote:
Log:
Use correct types for sizeof() in the calculations for the malloc(9) sizes [1].
While there, remove unneeded checks for failed allocations with M_WAITOK flag.
Submitted by: Conrad Meyer ceme...@uw.edu [1]
MFC after: 1 week
Nice
On Tue, 11 Mar 2014, Marcel Moolenaar wrote:
Log:
Pass the actual baudrate to tty_init_console(). This defines the initial
baudrate of the device special file, and makes sure that on open(2) the
UART is programmed with the correct baudrate. This then eliminates the
need in uart_tty_param()
On Sun, 9 Mar 2014, Marcel Moolenaar wrote:
Log: Add 3wire and std as terminal types/classes. These are similar to
the existing terminal types/classes that have the baudrate suffix,
but differ in that no baudrate is set/defined.
The purpose of these new types/classes is to allow them to
On Sun, 9 Mar 2014, Marcel Moolenaar wrote:
Log:
Change the terminal type/class for enabled serial lines to 3wire. This
allows us to change the uart(4) driver to not hardcode specific line
settings for the serial console.
/etc/ttys and /etc/gettytab are still stupid configuration methods.
On Fri, 7 Mar 2014, Alexey Dokuchaev wrote:
On Fri, Mar 07, 2014 at 01:23:49AM +, Eitan Adler wrote:
New Revision: 262882
URL: http://svnweb.freebsd.org/changeset/base/262882
Log:
wlanstats: add help
- add a help (-h) flag
- move usage into itsown function
it looks like the only
On Sun, 2 Mar 2014, Ian Lepore wrote:
Log:
Add __attribute__((used)) so that the delay implementation doesn't get
optimized away as unreferenced, causing linker errors when trying to
resolve the weak reference to the missing function.
Why not use the standard FreeBSD macro __used?
On Mon, 17 Feb 2014, Mark Felder wrote:
Log:
Fix formatting.
Manpages should start a new sentence on a new line. This makes it easier
for translators to track changes. -jhb
This has very little to do with translators.
This makes it possible for man(1) to format the output correctly, at
On Sat, 15 Feb 2014, Dimitry Andric wrote:
Log:
In sys/dev/xen/console/console.c, #if 0 an unused static function.
MFC after: 3 days
Modified:
head/sys/dev/xen/console/console.c
Modified: head/sys/dev/xen/console/console.c
On Sat, 15 Feb 2014, David Chisnall wrote:
On 15 Feb 2014, at 17:02, Bruce Evans b...@optusnet.com.au wrote:
Why? There are hundreds if not thousands of static inline functions in
headers, and most of these functions are not always used, so there would
be [hundreds if not thousands
On Wed, 12 Feb 2014, Gleb Smirnoff wrote:
Log:
While it isn't too late and kvm_read_zpcpu() function isn't yet used
outside libkvm(3), change its order of arguments, so that it is the
same as in kvm_read().
This also fixes some but not all namespace pollution.
Modified:
On Wed, 5 Feb 2014, Eitan Adler wrote:
Log:
libc/net: fix a portability issue
* POSIX does not require socklen_t to be unsigned
Submitted by: bde
Thanks.
Modified: head/lib/libc/net/ip6opt.c
==
---
On Tue, 4 Feb 2014, Eitan Adler wrote:
Log:
libc/net: Fix some issues in inet6_opt_init() (from RFC 3542):
* The RFC says (in section 10.1) that only when extbuf is not NULL,
extlen shall be checked, so don't perform this check when NULL is
passed.
* socklen_t is unsigned, so checking
On Thu, 23 Jan 2014, Konstantin Belousov wrote:
Author: kib
Log:
The posix_fallocate(2) syscall should return error number on error,
without modifying errno.
Reported and tested by:Gennady Proskurin g...@mail.ru
Reviewed by: mdf
This needs many more fixes. I pointed out some
On Fri, 10 Jan 2014, Gleb Smirnoff wrote:
Alexander,
some nitpicking:
Some more:
On Thu, Jan 09, 2014 at 06:13:25PM +, Alexander V. Chernikov wrote:
A @@ -52,6 +53,7 @@
A #include sys/proc.h
A #include sys/domain.h
A #include sys/kernel.h
A +#include sys/kdb.h
Further unsorting
On Thu, 9 Jan 2014, Dimitry Andric wrote:
On 09 Jan 2014, at 16:02, Ian Lepore i...@freebsd.org wrote:
...
At r259730:
cc -c -O -pipe -std=c99 -g -Wall -Wredundant-decls -Wnested-externs
-Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline
-Wcast-qual -Wundef
On Thu, 19 Dec 2013, Stefan Esser wrote:
Log:
Fix overflow for timeout values of more than 68 years, which is the maximum
covered by sbintime (LONG_MAX seconds).
Not LONG_MAX seconds, but INT32_MAX seconds. LONG_MAX seconds is about 2**32
times larger on 64-bit arches.
sbintimes and their
On Sun, 8 Dec 2013, Justin Hibbits wrote:
On Sun, 8 Dec 2013 13:53:30 +1100 (EST)
Bruce Evans b...@optusnet.com.au wrote:
On Sat, 7 Dec 2013, Justin Hibbits wrote:
[]* [...]
Modified: head/sys/geom/cache/g_cache.c
On Fri, 15 Nov 2013, John Baldwin wrote:
Log:
Don't allow vfs.lorunningspace or vfs.hirunningspace to be set such
that lorunningspace is greater than hirunningspace as the system
performs terribly if it is mistuned in this fashion.
Ugh, almost all writeable sysctls have foot-shooting
On Thu, 14 Nov 2013, George Neville-Neil wrote:
On Nov 14, 2013, at 16:03 , Sergey Kandaurov pluk...@freebsd.org wrote:
On 15 November 2013 00:07, George V. Neville-Neil g...@freebsd.org wrote:
Log:
Shift our OUI correctly.
Pointed out by: emaste
Modified:
head/sys/net/ieee_oui.h
On Tue, 12 Nov 2013, John Baldwin wrote:
On Tuesday, November 12, 2013 12:10:56 pm Sean Bruno wrote:
Author: sbruno
Log:
Noted that the stripe_size argument was not being displayed in the usage
message
Does this need some wrapping to fit in 80 cols now?
Of course. The output style is
On Wed, 13 Nov 2013, Konstantin Belousov wrote:
On Tue, Nov 12, 2013 at 04:29:06PM -0800, John-Mark Gurney wrote:
Bruce Evans wrote this message on Tue, Nov 12, 2013 at 22:13 +1100:
On Tue, 12 Nov 2013, Konstantin Belousov wrote:
Log:
Avoid overflow for the page counts.
Reported and tested
On Mon, 11 Nov 2013, Dimitry Andric wrote:
Log:
Disable building the ctl module for the i386 XEN kernel configuration
for now, since it causes gcc warnings about casting 64 bit bus_addr_t's
to 32 bit pointers, and vice versa.
Why not disable clang, since it is incompatible? :-)/2
The
On Tue, 12 Nov 2013, Konstantin Belousov wrote:
Log:
Avoid overflow for the page counts.
Reported and tested by:pho
Sponsored by: The FreeBSD Foundation
MFC after: 1 week
Modified: head/sys/kern/vfs_vnops.c
On Sat, 9 Nov 2013, Eitan Adler wrote:
Log:
Add support for SIIG x1 pci-e single parallel port card (JJ-E01211-S1)
PR:kern/182217
Submitted by: Craig Leres le...@ee.lbl.gov
MFC After: 1 week
Modified: head/sys/dev/ppc/ppc_pci.c
On Sat, 9 Nov 2013, Eitan Adler wrote:
On Sat, Nov 9, 2013 at 2:55 PM, Sean Bruno sean_br...@yahoo.com wrote:
On Sat, 2013-11-09 at 03:58 -0500, Eitan Adler wrote:
{ 0x95131415, Oxford Semiconductor OX16PCI954 Parallel
port,
0x10 },
+ { 0xc1101415, Oxford Semiconductor
On Wed, 6 Nov 2013, Dimitry Andric wrote:
On 06 Nov 2013, at 05:30, Bruce Evans b...@optusnet.com.au wrote:
On Tue, 5 Nov 2013, Luigi Rizzo wrote:
On Tue, Nov 05, 2013 at 07:37:35AM +, Dimitry Andric wrote:
Log:
Fix libgcc build with gcc after r257645, by using -Wno-static-in-inline
On Tue, 5 Nov 2013, Luigi Rizzo wrote:
On Tue, Nov 05, 2013 at 07:37:35AM +, Dimitry Andric wrote:
Log:
Fix libgcc build with gcc after r257645, by using -Wno-static-in-inline
for clang only.
This still just breaks the warning. See my previous reply. (For gcc,
it is unclear if the
On Mon, 4 Nov 2013, Eitan Adler wrote:
Log:
Use OpenBSD's revamped description of strlcpy and strlcat.
This explanation is supposed to be simpler and better. In particular
comparing it to the snprintf API provides lots of value, since it raises the
bar on understanding, so that
On Mon, 4 Nov 2013, Sean Bruno wrote:
Log:
Quiesce warning regarding %llf which has no effect.
Submitted as illumos issue #4284
Reviewed by: delphij
Modified:
head/cddl/contrib/opensolaris/lib/libnvpair/libnvpair.c
Modified: head/cddl/contrib/opensolaris/lib/libnvpair/libnvpair.c
On Mon, 4 Nov 2013, Dimitry Andric wrote:
On 04 Nov 2013, at 19:15, Sean Bruno sbr...@freebsd.org wrote:
Author: sbruno
Date: Mon Nov 4 18:15:45 2013
New Revision: 257645
URL: http://svnweb.freebsd.org/changeset/base/257645
Log:
Quiesce warning around gcc_assert() for an inline macro that
On Mon, 4 Nov 2013, John-Mark Gurney wrote:
Eitan Adler wrote this message on Mon, Nov 04, 2013 at 19:05 +:
Log:
Use OpenBSD's revamped description of strlcpy and strlcat.
...
Can we add a warning that it is not safe to just simply replace strncpy
with strlcpy? strncpy does something
On Sat, 2 Nov 2013, Mark R V Murray wrote:
On 2 Nov 2013, at 09:32, Mark R V Murray m...@grondar.org wrote:
Mark - did you initially mean the address of the mbuf m_data pointer,
or the data payload itself?
As Bruce says - the address of payload data itself. We don?t have 12-byte
pointers in
On Sat, 2 Nov 2013, Adrian Chadd wrote:
Log:
Teach the netgraph code to use a const char * pointer too.
This actually fixes a much larger bug that was apparently accidentally
exposed by new const poisoning and new smaller type bugs.
Pointy hat to: adrian
Outpointed by the previous bug.
On Tue, 29 Oct 2013, Mark Johnston wrote:
Log:
Revert r257248 and fix the problem in a way that doesn't violate style(9).
Why did gcc complain about the original version?
Modified: head/lib/libproc/_libproc.h
==
On Tue, 29 Oct 2013, Mark Johnston wrote:
On Wed, Oct 30, 2013 at 12:21:28AM +1100, Bruce Evans wrote:
On Tue, 29 Oct 2013, Mark Johnston wrote:
Log:
Revert r257248 and fix the problem in a way that doesn't violate style(9).
Why did gcc complain about the original version?
It looks like
On Tue, 29 Oct 2013, Sean Bruno wrote:
Log:
Queisce sign errors by using unsigned char * and casting MAP_FAILED as unsigned
char *
This increases the type errors.
Modified: head/usr.bin/xinstall/xinstall.c
==
---
On Sun, 27 Oct 2013, Ian Lepore wrote:
Log:
Remove all #include machine/pmap.h from arm code. It's already
included by vm/pmap.h, which is a prerequisite for arm/machine/pmap.h
so there's no reason to ever include it directly.
Thanks to alc@ for pointing this out.
I noticed this style
On Sun, 27 Oct 2013, Ian Lepore wrote:
Log:
Remove #include machine/frame.h from all the arm code that doesn't
really need it. That would be almost everywhere it was included. Add
it in a couple files that really do need it and were previously getting
it by accident via another header.
On Sun, 27 Oct 2013, Ian Lepore wrote:
Log:
Eliminate a compiler warning about extraneous parens.
Wow, what flags give these warnings?
Next I'll ask for -Wexcessive-braces, -Wbogus-cast and -Wno-sloppy-format.
Modified: head/sys/arm/arm/busdma_machdep.c
On Sun, 27 Oct 2013, Ian Lepore wrote:
While doing that, I noticed a whole lot of other includes in arm source
code that just aren't needed (things like cpu.h and intr.h in virtually
every file). So much of our arm code gets created by wholesale pasting
some other code and then hacking.
On Sun, 27 Oct 2013, Ian Lepore wrote:
Log:
Remove the last dregs of trapframe_t. It turns out only arm was using
this type, so remove it to make arm code more consistant with other
platforms. Thanks to bde@ for pointing out only arm used trapframe_t.
Thanks.
Bruce
On Sun, 27 Oct 2013, Ian Lepore wrote:
On Mon, 2013-10-28 at 04:42 +1100, Bruce Evans wrote:
On Sun, 27 Oct 2013, Ian Lepore wrote:
Log:
Eliminate a compiler warning about extraneous parens.
Wow, what flags give these warnings?
--- busdma_machdep.o ---
/local/build/staging/freebsd/dp10
On Tue, 15 Oct 2013, Kevin Lo wrote:
Log:
Treat INADDR_NONE as uint32_t.
Reviewed by: glebius
Modified:
head/sys/netinet/in.h
Modified: head/sys/netinet/in.h
==
--- head/sys/netinet/in.h Tue Oct 15
On Thu, 12 Sep 2013, Bryan Drewery wrote:
On 9/12/2013 6:36 AM, Hiroki Sato wrote:
Bryan Drewery bdrew...@freebsd.org wrote
in 201309120053.r8c0rc7h082...@svn.freebsd.org:
bd Author: bdrewery (ports committer)
bd Date: Thu Sep 12 00:53:38 2013
bd New Revision: 255486
bd URL:
On Thu, 29 Aug 2013, Sergey Kandaurov wrote:
On 22 August 2013 14:51, Bruce Evans b...@optusnet.com.au wrote:
expand_number() remains a very badly designed and implemented function.
Its design errors start with its name. It doesn't expand numbers. It
...
[...]
Some of the other bugs
On Wed, 21 Aug 2013, Jilles Tjoelker wrote:
On Thu, Aug 22, 2013 at 01:24:13AM +0400, Sergey Kandaurov wrote:
On Wed, Aug 21, 2013 at 10:27:25PM +0200, Jilles Tjoelker wrote:
On Wed, Aug 21, 2013 at 11:03:10PM +0400, Sergey Kandaurov wrote:
On Wed, Aug 21, 2013 at 09:21:47PM +0400, Andrey
On Wed, 14 Aug 2013, Dimitry Andric wrote:
On Aug 13, 2013, at 20:39, Pedro F. Giffuni p...@freebsd.org wrote:
Log:
ext2fs: update format specifiers for ext4 type.
This is still quite broken.
Modified: head/sys/fs/ext2fs/ext2_subr.c
On Thu, 8 Aug 2013, Ulrich [utf-8] Sp??rlein wrote:
On Fri, 2013-07-26 at 15:53:43 +, Dag-Erling Smrgrav wrote:
Modified: head/lib/libfetch/common.c
==
--- head/lib/libfetch/common.c Fri Jul 26 14:43:38 2013
On Wed, 7 Aug 2013, Hiroki Sato wrote:
Ian Lepore i...@freebsd.org wrote
in 1375807689.3320.48.ca...@revolution.hippie.lan:
ia On Tue, 2013-08-06 at 15:49 +, Hiroki Sato wrote:
ia /* Generate maximum time in timespec. */
ia - memset(tm_max.tv_sec, 0xff, sizeof(tm_max.tv_sec));
ia
On Tue, 30 Jul 2013, Sergey Kandaurov wrote:
Log:
Fix up paths after r253790.
While here, use $? contraction.
Reported by: O. Hartmann
Modified:
head/sys/modules/usb/runfw/Makefile
Modified: head/sys/modules/usb/runfw/Makefile
On Mon, 29 Jul 2013, Andrey Zonov wrote:
Log:
Unbreak sysctl ABI changes introduced in r253662
Requested by: bde
Thanks.
Bruce
___
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send
On Tue, 30 Jul 2013, David O'Brien wrote:
On Wed, Jul 24, 2013 at 03:29:34PM -0400, John Baldwin wrote:
On Wednesday, July 24, 2013 2:32:15 pm David E. O'Brien wrote:
per style(9):
Kernel include files (i.e. sys/*.h) come first; normally, include
sys/types.h OR sys/param.h, but
On Mon, 29 Jul 2013, David Chisnall wrote:
Author: theraven
Date: Mon Jul 29 08:32:13 2013
New Revision: 253764
URL: http://svnweb.freebsd.org/changeset/base/253764
Log:
Reenable the isnan(double) / isinf(double) declarations when targeting C89 +
SUSv2 mode.
This isn't reenabling. but
On Mon, 29 Jul 2013, David Chisnall wrote:
Bruce,
It's very difficult within this verbiage to work out what you believe the
correct code should look like. Please either provide a patch or commit the fix
yourself.
I prefer to give details.
[Context lost to top posting.]
Bruce
On Fri, 26 Jul 2013, Juli Mallett wrote:
On Fri, Jul 26, 2013 at 2:26 PM, Andrey Zonov z...@freebsd.org wrote:
On 7/26/13 8:09 AM, Jilles Tjoelker wrote:
As noted in mail from Bruce Evans, please preserve the ABI of
VM_SWAPPING_ENABLED here.
I don't think it's a big problem. Internally we
On Sat, 27 Jul 2013, Andrey Zonov wrote:
On 7/27/13 12:47 AM, Bruce Evans wrote:
...
Especially since the main reason numbered sysctls exist is to support old
binaries (and sources) that use them.
Does it look OK?
It looks functionally OK, but ugly.
diff --git a/sys/vm/vm_param.h b/sys
On Thu, 25 Jul 2013, Tim Kientzle wrote:
Log:
Clear entire map structure including locks so that the
locks don't accidentally appear to have been already
initialized.
In particular, this fixes a consistent kernel crash on
armv6 with:
panic: lock vm map (user) 0xc09cc050 already
On Thu, 25 Jul 2013, Marko Zec wrote:
On Thursday 25 July 2013 10:07:58 Marius Strobl wrote:
On Mon, Jul 15, 2013 at 01:32:55AM +, Craig Rodrigues wrote:
Author: rodrigc
Date: Mon Jul 15 01:32:55 2013
New Revision: 253346
URL: http://svnweb.freebsd.org/changeset/base/253346
Log:
PR:
On Thu, 25 Jul 2013, David Chisnall wrote:
On 25 Jul 2013, at 09:11, Hans Petter Selasky h...@bitfrost.no wrote:
The structure looks like some size, so bzero() might run faster than memset()
depending on the compiler settings. Should be profiled before changed!
They will generate identical
On Wed, 24 Jul 2013, John Baldwin wrote:
On Wednesday, July 24, 2013 2:32:15 pm David E. O'Brien wrote:
Author: obrien
Date: Wed Jul 24 18:32:15 2013
New Revision: 253618
URL: http://svnweb.freebsd.org/changeset/base/253618
Log:
per style(9):
Kernel include files (i.e. sys/*.h) come
On Thu, 18 Jul 2013, Kevin Lo wrote:
Log:
Replace PRId64 with jd in a printf call. Cast the corresponding value to
intmax_t, because the original type is off_t.
Reported by: bde
Thanks, but it still includes inttypes.h for the definition of PRId64.
Use of inttypes.h instead of stdint.h
On Wed, 17 Jul 2013, Kevin Lo wrote:
Log:
Use PRId64 instead of %gd to print an int64_t.
This is a different printf format error, and a style bug.
Printf format errors:
commit log: %gd doesn't exist. You mean %qd
old: file_size has type off_t, but was printed using %qd. off_t is only
On Tue, 16 Jul 2013, John Baldwin wrote:
On Monday, July 15, 2013 11:40:58 am Andrey V. Elsukov wrote:
Log:
Include sys/systm.h after sys/param.h.
Suggested by: pluknet
Does this fix something?
Style bugs at least. sys/systm.h defines APIs which may be used in
other headers (in
On Sat, 13 Jul 2013, Tijl Coosemans wrote:
On 2013-07-12 11:14, Bruce Evans wrote:
On Thu, 11 Jul 2013, Tijl Coosemans wrote:
On 2013-07-11 22:03, Tijl Coosemans wrote:
...
isnan(double) is part of SUSv2. It should be visible when compiling with
-D_XOPEN_SOURCE=500. I think you need
On Thu, 11 Jul 2013, David Chisnall wrote:
On 11 Jul 2013, at 19:52, Tijl Coosemans t...@coosemans.org wrote:
GCC doesn't support _Generic yet for -std=c11.
Ugh. Given that they also lack a fine-grained feature check mechanism, they
really should not advertise support for a language
On Thu, 11 Jul 2013, Tijl Coosemans wrote:
On 2013-07-11 22:03, Tijl Coosemans wrote:
On 2013-07-11 21:36, David Chisnall wrote:
On 11 Jul 2013, at 19:52, Tijl Coosemans t...@coosemans.org wrote:
@@ -227,8 +250,6 @@ double expm1(double);
double fma(double, double, double);
double
On Mon, 8 Jul 2013, Aleksandr Rybalko wrote:
On Mon, 1 Jul 2013 11:56:25 +1000 (EST)
Bruce Evans b...@optusnet.com.au wrote:
On Sun, 30 Jun 2013, Aleksandr Rybalko wrote:
Log:
Decrypt magic numbers - define names for fields of Generic Timer's CNTKCTL reg.
Submitted by: Ruslan Bukin b
On Tue, 9 Jul 2013, Andriy Gapon wrote:
Log:
should_yield: protect from td_swvoltick being uninitialized or too stale
The distance between ticks and td_swvoltick should be calculated as
an unsigned number. Previously we could end up comparing a negative
number with hogticks in which case
On Tue, 9 Jul 2013, Jim Harris wrote:
On Sat, Jul 6, 2013 at 7:26 PM, Bruce Evans b...@optusnet.com.au wrote:
On Sat, 6 Jul 2013, Jilles Tjoelker wrote:
On Sat, Jul 06, 2013 at 08:42:49PM +0200, Pawel Jakub Dawidek wrote:
[]* ...
Bruce, until sysexits(3) doesn't explicitly say
On Mon, 8 Jul 2013, Pedro F. Giffuni wrote:
Log:
Avoid a panic and return EINVAL instead.
Merge from UFS r232692:
syscall() fuzzing can trigger this panic.
This breaks the assertion without fixing the bug.
I don't know what is in the inscrutable reference r232692, but UFS doesn't
exist,
On Tue, 9 Jul 2013, Pedro F. Giffuni wrote:
Author: pfg
Date: Tue Jul 9 01:31:04 2013
New Revision: 253050
URL: http://svnweb.freebsd.org/changeset/base/253050
Log:
Enhancement when writing an entire block of a file.
Merge from UFS r231313:
This change first attempts the uiomove() to
On Tue, 9 Jul 2013, Bruce Evans wrote:
On Tue, 9 Jul 2013, Pedro F. Giffuni wrote:
...
Log:
Enhancement when writing an entire block of a file.
Merge from UFS r231313:
...
Oops, I didn't mean to reply to that (it seemed to be correct :-), and
just quoted it all.
Bruce
On Sat, 6 Jul 2013, Jilles Tjoelker wrote:
On Sat, Jul 06, 2013 at 08:42:49PM +0200, Pawel Jakub Dawidek wrote:
On Thu, Jul 04, 2013 at 11:44:28AM +1000, Bruce Evans wrote:
Many style bugs are visible in this patch:
[...]
- sysexits.h is used
[...]
Bruce, until sysexits(3) doesn't
On Thu, 4 Jul 2013, Andrey Chernov wrote:
On 04.07.2013 6:47, Bruce Evans wrote:
Er, I think it is too dangerous to change either RAND_MAX or the offset
without more preparation:
- increasing the range returned (and increasing RAND_MAX to match) would
obviously be binary-incompatible. Old
On Thu, 4 Jul 2013, Jim Harris wrote:
Log:
Fix printf argument mismatch reported by gcc on i386.
This just substitutes one printf format with another.
Modified: head/sbin/nvmecontrol/firmware.c
==
---
On Wed, 3 Jul 2013, Andrey A. Chernov wrote:
Log:
1) POSIX requires rand(3) return values to be in the [0, RAND_MAX] range,
but ACM formula we use have internal state (and return value) in the
[1, 0x7ffe] range, so our RAND_MAX (0x7fff) is never reached
because it is off by one,
On Tue, 2 Jul 2013, Bruce Evans wrote:
...
Also, random(9) is internally broken on 64-bit arches. It shouldn't
exist. It is not random() at all, but just rand() with the clamp to
RAND_MAX removed. Its linear congruential generator is suboptimal
for 64 bits, and other parts of its algorithm
On Tue, 2 Jul 2013, Andrey Chernov wrote:
On 02.07.2013 11:39, Bruce Evans wrote:
The bugs are a little different than I said above. There is no overflow
problem and no problem with invalid values being produces, since the
algorithm from ACM is careful to do everything with 32 bit signed
1201 - 1300 of 1900 matches
Mail list logo
