svn commit: r306310 - in head/sys: amd64/amd64 i386/i386

2016-09-25 Thread Bruce Evans
Author: bde Date: Sun Sep 25 14:56:24 2016 New Revision: 306310 URL: https://svnweb.freebsd.org/changeset/base/306310 Log: Fix vm86 initialization, part 3 of 2 and a half. (Actually, just fix early printfs and debugging of vm86 initialization and some other early initialization in some case

Re: svn commit: r306012 - head/etc/autofs

2016-09-20 Thread Bruce Evans
On Tue, 20 Sep 2016, Edward Tomasz Napierala wrote: On 0920T1653, Bruce Evans wrote: On Tue, 20 Sep 2016, Edward Tomasz Napierala wrote: Log: Fix -media to not mount ufs with "async"; it doesn't make sense when there is softupdates. It does make sense when there isn't

Re: svn commit: r306012 - head/etc/autofs

2016-09-19 Thread Bruce Evans
On Tue, 20 Sep 2016, Edward Tomasz Napierala wrote: Log: Fix -media to not mount ufs with "async"; it doesn't make sense when there is softupdates. It does make sense when there isn't soft updates. With soft updates, it is silently ignored. However, I don't like changing the default. asyn

Re: svn commit: r305998 - in head/usr.bin: cmp indent tr

2016-09-19 Thread Bruce Evans
On Mon, 19 Sep 2016, John Baldwin wrote: On Monday, September 19, 2016 01:45:01 PM Ngie Cooper wrote: On Sep 19, 2016, at 1:43 PM, Conrad E. Meyer wrote: Log: Move sys/capsicum.h includes after types.h or param.h This is not actually documented or even implied in style(9). Make the chang

Re: svn commit: r305899 - in head/sys/i386: i386 include

2016-09-17 Thread Bruce Evans
On Sat, 17 Sep 2016, Bruce Evans wrote: Author: bde Date: Sat Sep 17 14:00:52 2016 New Revision: 305899 URL: https://svnweb.freebsd.org/changeset/base/305899 Log: Remove all kernel uses of pcb_psl, but keep in in the struct to preserve the ABI and API for applications. It was removed in the

svn commit: r305899 - in head/sys/i386: i386 include

2016-09-17 Thread Bruce Evans
Author: bde Date: Sat Sep 17 14:00:52 2016 New Revision: 305899 URL: https://svnweb.freebsd.org/changeset/base/305899 Log: Remove all kernel uses of pcb_psl, but keep in in the struct to preserve the ABI and API for applications. It was removed in the port to amd64, but was remained as garb

svn commit: r305897 - head/sys/ddb

2016-09-17 Thread Bruce Evans
Author: bde Date: Sat Sep 17 11:43:51 2016 New Revision: 305897 URL: https://svnweb.freebsd.org/changeset/base/305897 Log: Silently ignore unexpected single-step traps (except for turning off single-stepping). Only do this on arches (only x86 so far) which classify single-step traps unambig

svn commit: r305865 - in head/sys: amd64/amd64 x86/include

2016-09-16 Thread Bruce Evans
Author: bde Date: Fri Sep 16 07:09:35 2016 New Revision: 305865 URL: https://svnweb.freebsd.org/changeset/base/305865 Log: Fix decoding of tf_rsp on amd64, and move TF_HAS_STACKREGS() to the i386-only section, and fix a comment about the amd64 kernel trapframe not having stackregs. tf_r

svn commit: r305864 - head/sys/ddb

2016-09-15 Thread Bruce Evans
Author: bde Date: Fri Sep 16 06:31:10 2016 New Revision: 305864 URL: https://svnweb.freebsd.org/changeset/base/305864 Log: Statically initialize the run mode to the one that will become current on first entry. This fixes a spurious "Stepping aborted" message when the first entry is for a br

svn commit: r305862 - in head/sys: amd64/amd64 i386/i386

2016-09-15 Thread Bruce Evans
Author: bde Date: Fri Sep 16 04:58:37 2016 New Revision: 305862 URL: https://svnweb.freebsd.org/changeset/base/305862 Log: (1) Ifdef the new dr6 variable for KDB. While here, avoid using the old variable 'code' and remove it in trap(). ('code' was meant for holding things like %dr6, bu

svn commit: r305849 - head/sys/amd64/include

2016-09-15 Thread Bruce Evans
Author: bde Date: Thu Sep 15 18:30:53 2016 New Revision: 305849 URL: https://svnweb.freebsd.org/changeset/base/305849 Log: Decode some REX prefixes in inst_call(). This makes the 'next' and 'until' commands work in more cases. Modified: head/sys/amd64/include/db_machdep.h Modified: head/s

svn commit: r305840 - in head/sys: amd64/amd64 amd64/include ddb i386/i386 i386/include

2016-09-15 Thread Bruce Evans
Author: bde Date: Thu Sep 15 17:24:23 2016 New Revision: 305840 URL: https://svnweb.freebsd.org/changeset/base/305840 Log: Abort single stepping in ddb if the trap is not for single-stepping. This is not very easy to do, since ddb didn't know when traps are for single-stepping. It more or l

Re: svn commit: r305821 - head/usr.bin/login

2016-09-14 Thread Bruce Evans
On Thu, 15 Sep 2016, Ed Maste wrote: Log: login: clean up errx strings errx() prefixes the error string with argv[0] so including "login: " in the string is redundant. Also remove a superfluous newline. The strings still have plenty of dirt: Modified: head/usr.bin/login/login_audit.c ===

Re: svn commit: r305814 - head/sys/boot/common

2016-09-14 Thread Bruce Evans
On Wed, 14 Sep 2016, Emmanuel Vadot wrote: Bruce Evans wrote: On Wed, 14 Sep 2016, Emmanuel Vadot wrote: Log: ufsread: Do not cast struct direct from void * This cause alignment problem on ARM (and possibly other archs), instead copy it. ... This looks like a good pessimization for

Re: svn commit: r305814 - head/sys/boot/common

2016-09-14 Thread Bruce Evans
On Wed, 14 Sep 2016, Emmanuel Vadot wrote: Log: ufsread: Do not cast struct direct from void * This cause alignment problem on ARM (and possibly other archs), instead copy it. MFC after: 1 week Modified: head/sys/boot/common/ufsread.c Modified: head/sys/boot/common/ufsread.c

Re: svn commit: r305807 - in head/sys: amd64/amd64 i386/i386 x86/include

2016-09-14 Thread Bruce Evans
On Wed, 14 Sep 2016, Bjoern A. Zeeb wrote: On 14 Sep 2016, at 12:57, Bruce Evans wrote: Author: bde Date: Wed Sep 14 12:57:40 2016 New Revision: 305807 URL: https://svnweb.freebsd.org/changeset/base/305807 Log: Modified: head/sys/amd64/amd64/trap.c breaks all amd64 LINT* kernels

Re: svn commit: r305811 - head/sys/amd64/amd64

2016-09-14 Thread Bruce Evans
On Wed, 14 Sep 2016, Bjoern A. Zeeb wrote: Log: Try to fix LINT builds after r305807. Seems to be a simple s&r error I missed while reading through the 1st time as well. Thanks. The fix looks right. Modified: head/sys/amd64/amd64/trap.c Modified: head/sys/amd64/amd64/trap.c ===

Re: svn commit: r305807 - in head/sys: amd64/amd64 i386/i386 x86/include

2016-09-14 Thread Bruce Evans
On Wed, 14 Sep 2016, Bruce Evans wrote: ... Log: ... Fix logic errors in treating vm86 bioscall mode as kernel mode. The main place checked all the necessary flags, but put the necessary parentheses for the PSL_VM and PCB_VM86CALL checks in the wrong place. The broken case is only

svn commit: r305807 - in head/sys: amd64/amd64 i386/i386 x86/include

2016-09-14 Thread Bruce Evans
Author: bde Date: Wed Sep 14 12:57:40 2016 New Revision: 305807 URL: https://svnweb.freebsd.org/changeset/base/305807 Log: Use the MI macro TRAPF_USERMODE() instead of open-coded checks for SEL_UPL and sometimes PSL_VM. This is just a style change on amd64, but on i386 it fixes 1 unimportan

svn commit: r305665 - head/sys/ddb

2016-09-09 Thread Bruce Evans
Author: bde Date: Fri Sep 9 15:53:42 2016 New Revision: 305665 URL: https://svnweb.freebsd.org/changeset/base/305665 Log: Pass the trap type and code down from db_trap() to db_stop_at_pc() so that the latter can easily determine what the trap type actually is after callers are fixed to enco

svn commit: r305663 - head/sys/ddb

2016-09-09 Thread Bruce Evans
Author: bde Date: Fri Sep 9 14:09:50 2016 New Revision: 305663 URL: https://svnweb.freebsd.org/changeset/base/305663 Log: Fix stopping when the specified breakpoint count is reached. The countdown was done correctly, but the action when the count was not reduced to 0 was to fall through to

svn commit: r305661 - head/share/man/man4

2016-09-09 Thread Bruce Evans
Author: bde Date: Fri Sep 9 13:23:07 2016 New Revision: 305661 URL: https://svnweb.freebsd.org/changeset/base/305661 Log: Give the full syntax of the 'count' arg for all commmands that support it. This arg is most interesting for the 'break' command where it never worked, and for the step

Re: svn commit: r305636 - head/sys/ddb

2016-09-08 Thread Bruce Evans
On Fri, 9 Sep 2016, Justin Hibbits wrote: Log: Correct the type of db_cmd_loop_done. On big endian hardware that uses 1 byte bool a type mismatch of bool vs int will cause the least signifcant byte of db_cmd_loop_done to be set, but the MSB to be read, and read as 0. This causes ddb to s

svn commit: r305622 - in head/sys/ufs: ffs ufs

2016-09-08 Thread Bruce Evans
Author: bde Date: Thu Sep 8 17:40:40 2016 New Revision: 305622 URL: https://svnweb.freebsd.org/changeset/base/305622 Log: Sprinkle DOINGASYNC() checks so as to do delayed writes for async mounts in almost all cases instead of in most cases. Don't override DOINGASYNC() by any condition exce

svn commit: r305612 - head/sys/i386/i386

2016-09-08 Thread Bruce Evans
Author: bde Date: Thu Sep 8 14:43:39 2016 New Revision: 305612 URL: https://svnweb.freebsd.org/changeset/base/305612 Log: Fix single-stepping of instructions emulated by vm86. In vm86.c, fix 2 (rarely used) cases where the return code lost the single-step indicator. While here, fix 2 mi

Re: svn commit: r305382 - in head/lib/msun: amd64 i387

2016-09-04 Thread Bruce Evans
On Sun, 4 Sep 2016, Konstantin Belousov wrote: On Sun, Sep 04, 2016 at 12:22:14PM +, Bruce Evans wrote: ... Log: Add asm versions of fmod(), fmodf() and fmodl() on amd64. Add asm versions of fmodf() amd fmodl() on i387. ... It seems that wrong version of i387/f_fmodf.S, it is

svn commit: r305385 - head/lib/msun/i387

2016-09-04 Thread Bruce Evans
Author: bde Date: Sun Sep 4 15:08:14 2016 New Revision: 305385 URL: https://svnweb.freebsd.org/changeset/base/305385 Log: Oops, the previous i386 version of e_fmodf.S and e_fmodl.S was actually the amd64 version. Modified: head/lib/msun/i387/e_fmodf.S head/lib/msun/i387/e_fmodl.S Modifi

svn commit: r305384 - head/lib/msun/i387

2016-09-04 Thread Bruce Evans
Author: bde Date: Sun Sep 4 14:12:19 2016 New Revision: 305384 URL: https://svnweb.freebsd.org/changeset/base/305384 Log: Disconnect the "optimized" asm variants of cos(), sin() and tan() from the build on i386. Leave them in the source tree for regression tests. The asm functions were

svn commit: r305382 - in head/lib/msun: amd64 i387

2016-09-04 Thread Bruce Evans
Author: bde Date: Sun Sep 4 12:22:14 2016 New Revision: 305382 URL: https://svnweb.freebsd.org/changeset/base/305382 Log: Add asm versions of fmod(), fmodf() and fmodl() on amd64. Add asm versions of fmodf() amd fmodl() on i387. fmod is similar to remainder, and the C versions are 3 to

svn commit: r305380 - head/lib/msun/src

2016-09-04 Thread Bruce Evans
Author: bde Date: Sun Sep 4 12:01:32 2016 New Revision: 305380 URL: https://svnweb.freebsd.org/changeset/base/305380 Log: Fix missing fmodl() on arches with 53-bit long doubles. PR: 199422, 211965 MFC after:1 week Modified: head/lib/msun/src/e_fmod.c Modified: head/lib/

Re: svn commit: r305362 - in head: share/man/man9 sys/amd64/amd64 sys/arm/arm sys/arm64/arm64 sys/conf sys/i386/i386 sys/i386/include sys/mips/mips sys/powerpc/aim sys/powerpc/booke sys/powerpc/powerp

2016-09-03 Thread Bruce Evans
On Sat, 3 Sep 2016, Mark Johnston wrote: Log: Remove support for idle page zeroing. Idle page zeroing has been disabled by default on all architectures since r170816 and has some bugs that make it seemingly unusable. Specifically, the idle-priority pagezero thread exacerbates contention for

svn commit: r305231 - head/sys/dev/syscons

2016-09-01 Thread Bruce Evans
Author: bde Date: Thu Sep 1 19:18:26 2016 New Revision: 305231 URL: https://svnweb.freebsd.org/changeset/base/305231 Log: The log message for the previous commit didn't mention the most the important detail that sc_cngetc() now opens and closes the keyboard on every call again. This was mo

Re: svn commit: r305129 - head/sys/vm

2016-08-31 Thread Bruce Evans
On Wed, 31 Aug 2016, Konstantin Belousov wrote: Log: Make swapoff reliable. The swap_pager_swapoff() function uses trylock for the object lock before pagein, which means that either i/o to md(4) over swap, or intensive page faults over swap pager objects might prevent swapoff() from making

svn commit: r305121 - head/sys/dev/syscons

2016-08-31 Thread Bruce Evans
Author: bde Date: Wed Aug 31 11:10:39 2016 New Revision: 305121 URL: https://svnweb.freebsd.org/changeset/base/305121 Log: Add some locking to sc_cngetc(). Keyboard input needs Giant locking, and that is not possible to do correctly here. Use mtx_trylock() and proceed unlocked as before

Re: svn commit: r305091 - head/sys/sys

2016-08-30 Thread Bruce Evans
On Wed, 31 Aug 2016, Mateusz Guzik wrote: On Tue, Aug 30, 2016 at 03:35:39PM -0700, Conrad Meyer wrote: On Tue, Aug 30, 2016 at 2:48 PM, Mateusz Guzik wrote: Author: mjg Date: Tue Aug 30 21:48:10 2016 New Revision: 305091 URL: https://svnweb.freebsd.org/changeset/base/305091 Log: fd: simpl

svn commit: r305060 - head/sys/dev/kbdmux

2016-08-30 Thread Bruce Evans
Author: bde Date: Tue Aug 30 12:36:14 2016 New Revision: 305060 URL: https://svnweb.freebsd.org/changeset/base/305060 Log: Fix keyboard polling "on/off" to support recursion. vt depends on this, and sc will soon depend on it again. The on/off request is passed without modification to low

svn commit: r305059 - head/sys/dev/syscons

2016-08-30 Thread Bruce Evans
Author: bde Date: Tue Aug 30 10:57:19 2016 New Revision: 305059 URL: https://svnweb.freebsd.org/changeset/base/305059 Log: Start adding locking to sc_cngetc(). Restore an splx() lost in r228644. We aren't nearly ready to remove spl's. They give hints about missing locking. This lost on

Re: svn commit: r304895 - head/usr.bin/netstat

2016-08-30 Thread Bruce Evans
On Mon, 29 Aug 2016, hiren panchasara wrote: On 08/29/16 at 05:14P, Bruce Evans wrote: On Sun, 28 Aug 2016, hiren panchasara wrote: On 08/27/16 at 11:06P, Bruce Evans wrote: Log: Fix build without INET6 and with gcc. A function definition was ifdefed for INET6, but its protototype was

svn commit: r305010 - head/sys/dev/syscons

2016-08-29 Thread Bruce Evans
Author: bde Date: Mon Aug 29 18:41:06 2016 New Revision: 305010 URL: https://svnweb.freebsd.org/changeset/base/305010 Log: Add screen locking calls to sc cn grab and ungrab. The locking functions just use the same mutex locking as sc cn putc so they have the same defects. The locking c

Re: svn commit: r305004 - in head/sys: amd64/amd64 amd64/include i386/i386

2016-08-29 Thread Bruce Evans
On Mon, 29 Aug 2016, Slawa Olhovchenkov wrote: On Mon, Aug 29, 2016 at 01:07:21PM +, Bruce Evans wrote: ... Log: On amd64, declare sse2_pagezero() and start using it again, but only for zeroing pages in idle where nontemporal writes are clearly best. This is almost a no-op since

svn commit: r305005 - in head/sys: amd64/amd64 i386/i386

2016-08-29 Thread Bruce Evans
Author: bde Date: Mon Aug 29 14:38:31 2016 New Revision: 305005 URL: https://svnweb.freebsd.org/changeset/base/305005 Log: Shorten banal comments about zeroing and copying pages. Don't give implementation details that last echoed the code 15-20 years ago. But add a detail about pagezero() o

svn commit: r305004 - in head/sys: amd64/amd64 amd64/include i386/i386

2016-08-29 Thread Bruce Evans
Author: bde Date: Mon Aug 29 13:07:21 2016 New Revision: 305004 URL: https://svnweb.freebsd.org/changeset/base/305004 Log: On amd64, declare sse2_pagezero() and start using it again, but only for zeroing pages in idle where nontemporal writes are clearly best. This is almost a no-op since ze

svn commit: r304986 - head/sys/amd64/amd64

2016-08-28 Thread Bruce Evans
Author: bde Date: Mon Aug 29 06:07:43 2016 New Revision: 304986 URL: https://svnweb.freebsd.org/changeset/base/304986 Log: Restore the nontemporal pagezero() under the name sse2_pagezero() (the same name as for i386). It is not reconnected yet. Which method is better is too machine-depen

svn commit: r304962 - head/sys/ddb

2016-08-28 Thread Bruce Evans
Author: bde Date: Sun Aug 28 19:33:09 2016 New Revision: 304962 URL: https://svnweb.freebsd.org/changeset/base/304962 Log: Expand error messages: print symbol names, parentheses and shift tokens, and negative shift counts. Fix error messages: print "Division" instead of "Divide"; print

Re: svn commit: r304895 - head/usr.bin/netstat

2016-08-28 Thread Bruce Evans
On Sun, 28 Aug 2016, hiren panchasara wrote: On 08/27/16 at 11:06P, Bruce Evans wrote: Log: Fix build without INET6 and with gcc. A function definition was ifdefed for INET6, but its protototype was not, and gcc detects the error. Modified: head/usr.bin/netstat/route.c Thanks for

svn commit: r304958 - head/sys/i386/i386

2016-08-28 Thread Bruce Evans
Author: bde Date: Sun Aug 28 15:23:44 2016 New Revision: 304958 URL: https://svnweb.freebsd.org/changeset/base/304958 Log: Fix vm86 initialization, part 1 of 2 and a half. Early use of vm86 depends on the PIC being reset to mask interrupts, but r286667 moved PIC initialization to after wh

svn commit: r304957 - head/sys/i386/i386

2016-08-28 Thread Bruce Evans
Author: bde Date: Sun Aug 28 14:03:25 2016 New Revision: 304957 URL: https://svnweb.freebsd.org/changeset/base/304957 Log: Fix vm86 initialization, part 1 of 2 and a half. vm86 uses the tss, but r273995 moved tss initialization to after where it may be first used, just because tss_esp0 no

Re: svn commit: r304928 - in head/lib/libc: amd64/sys i386/sys sys

2016-08-27 Thread Bruce Evans
On Sun, 28 Aug 2016, Andrey Chernov wrote: On 28.08.2016 4:52, Konstantin Belousov wrote: POSIX: "For each thread of a process, the value of errno shall not be affected by function calls or assignments to errno by other threads." And ? What should the citation add new to the substance of the

svn commit: r304895 - head/usr.bin/netstat

2016-08-27 Thread Bruce Evans
Author: bde Date: Sat Aug 27 11:06:06 2016 New Revision: 304895 URL: https://svnweb.freebsd.org/changeset/base/304895 Log: Fix build without INET6 and with gcc. A function definition was ifdefed for INET6, but its protototype was not, and gcc detects the error. Modified: head/usr.bin/netst

svn commit: r304804 - in head/sys: dev/syscons kern

2016-08-25 Thread Bruce Evans
Author: bde Date: Thu Aug 25 13:46:52 2016 New Revision: 304804 URL: https://svnweb.freebsd.org/changeset/base/304804 Log: Less-quick fix for locking fixes in r172250. r172250 added a second syscons spinlock for the output routine alone. It is better to extend the coverage of the first sys

svn commit: r304800 - head/sys/dev/syscons

2016-08-25 Thread Bruce Evans
Author: bde Date: Thu Aug 25 12:04:57 2016 New Revision: 304800 URL: https://svnweb.freebsd.org/changeset/base/304800 Log: Fix logic errors in bounds checks in previous commit. The 2-entry stack was overrun for grab levels larger than 2. Reported by: pluknet Modified: head/sys/dev/sy

svn commit: r304773 - head/sys/dev/syscons

2016-08-24 Thread Bruce Evans
Author: bde Date: Wed Aug 24 18:59:24 2016 New Revision: 304773 URL: https://svnweb.freebsd.org/changeset/base/304773 Log: Flesh out the state and flags args to sccnopen(). Set state flags to indicate (potentially partial) success of the open. Use these to decide what to close in sccnclose

svn commit: r304758 - head/sys/dev/syscons

2016-08-24 Thread Bruce Evans
Author: bde Date: Wed Aug 24 17:26:11 2016 New Revision: 304758 URL: https://svnweb.freebsd.org/changeset/base/304758 Log: Reorganise a little to prepare for locking fixes: - in sccnopen(), open the keyboard before the screen. The keyboard currently requires Giant (although it must be spi

Re: svn commit: r304699 - head/sys/dev/usb/input

2016-08-24 Thread Bruce Evans
On Wed, 24 Aug 2016, Hans Petter Selasky wrote: On 08/23/16 21:50, Bruce Evans wrote: + kbd->kb_delay1 = imax(((int *)arg)[0], 250); + kbd->kb_delay2 = imax(((int *)arg)[1], 34); It looks like this will pass negative kb_delay's. How do you handle t

svn commit: r304735 - head/sys/dev/usb/input

2016-08-23 Thread Bruce Evans
Author: bde Date: Wed Aug 24 05:54:11 2016 New Revision: 304735 URL: https://svnweb.freebsd.org/changeset/base/304735 Log: Fix key delay and repeat, part 2. Use sbintime_t timeouts with precision control to get very accurate timing. It costs little to always ask for about 1% accuracy, an

Re: svn commit: r304567 - head/sys/dev/usb/input

2016-08-23 Thread Bruce Evans
On Tue, 23 Aug 2016, Ngie Cooper (yaneurabeya) wrote: On Aug 23, 2016, at 13:57, Bryan Drewery wrote: ... Well yours only supports stable/10+ and not 9- with the older merge style. *shrugs* The older method promoted broken mergeinfo? The method I wrote up works fine with ^/stable/

Re: svn commit: r304699 - head/sys/dev/usb/input

2016-08-23 Thread Bruce Evans
On Tue, 23 Aug 2016, Oliver Pinter wrote: On 8/23/16, Bruce Evans wrote: ... Log: Fix key delay and repeat, part 1. ... Convert 0.0 to the documented 250.34. ... Do you plan to MFC these changes to 10-STABLE? It would be really nice to see all of these improvements. Maybe when I

svn commit: r304699 - head/sys/dev/usb/input

2016-08-23 Thread Bruce Evans
Author: bde Date: Tue Aug 23 19:50:16 2016 New Revision: 304699 URL: https://svnweb.freebsd.org/changeset/base/304699 Log: Fix key delay and repeat, part 1. kbdcontrol -r fast is documented to give a non-emulated atkbd's fastest rate of 250.34, but is misimplemented to request this as 0.0

svn commit: r304612 - head/sys/dev/usb/input

2016-08-22 Thread Bruce Evans
Author: bde Date: Mon Aug 22 16:39:51 2016 New Revision: 304612 URL: https://svnweb.freebsd.org/changeset/base/304612 Log: Further fixes for translation of PrintScreen/SysRq. The previous fix was tested mainly on 3 AT keyboards with USB adaptors where it works. 1 USB keyboard doesn't tra

Re: svn commit: r304567 - head/sys/dev/usb/input

2016-08-22 Thread Bruce Evans
On Sun, 21 Aug 2016, Hans Petter Selasky wrote: On 08/21/16 18:06, Bruce Evans wrote: Author: bde Date: Sun Aug 21 16:06:00 2016 New Revision: 304567 URL: https://svnweb.freebsd.org/changeset/base/304567 Don't forget to MFC. I had forgotten if for this commit. I might do it for com

Re: svn commit: r304555 - head/sys/compat/cloudabi

2016-08-22 Thread Bruce Evans
On Sun, 21 Aug 2016, Slawa Olhovchenkov wrote: On Mon, Aug 22, 2016 at 02:49:07AM +1000, Bruce Evans wrote: On Sun, 21 Aug 2016, Slawa Olhovchenkov wrote: On Sun, Aug 21, 2016 at 11:39:02PM +1000, Bruce Evans wrote: On Sun, 21 Aug 2016, Slawa Olhovchenkov wrote: I am remeber about

Re: svn commit: r304555 - head/sys/compat/cloudabi

2016-08-21 Thread Bruce Evans
On Sun, 21 Aug 2016, Slawa Olhovchenkov wrote: On Sun, Aug 21, 2016 at 11:39:02PM +1000, Bruce Evans wrote: On Sun, 21 Aug 2016, Slawa Olhovchenkov wrote: I am remeber about platforms with missaligment trap when accessing int16 by odd address. Now platforms like this do not exist anymore

svn commit: r304567 - head/sys/dev/usb/input

2016-08-21 Thread Bruce Evans
Author: bde Date: Sun Aug 21 16:06:00 2016 New Revision: 304567 URL: https://svnweb.freebsd.org/changeset/base/304567 Log: Fix translation of the PrintScreen/SysRq and Pause/Break keys. Almost everything was broken. The cases that I noticed were Ctrl-PrintScreen not being mapped to the vir

Re: svn commit: r304555 - head/sys/compat/cloudabi

2016-08-21 Thread Bruce Evans
On Sun, 21 Aug 2016, Slawa Olhovchenkov wrote: On Sun, Aug 21, 2016 at 11:00:24PM +1000, Bruce Evans wrote: On Sun, 21 Aug 2016, Slawa Olhovchenkov wrote: On Sun, Aug 21, 2016 at 09:32:35PM +1000, Bruce Evans wrote: ... *(foo_t *)asks for alignment bugs. We have already fixed lots of

Re: svn commit: r304555 - head/sys/compat/cloudabi

2016-08-21 Thread Bruce Evans
On Sun, 21 Aug 2016, Slawa Olhovchenkov wrote: On Sun, Aug 21, 2016 at 09:32:35PM +1000, Bruce Evans wrote: ... *(foo_t *)asks for alignment bugs. We have already fixed lots of these bugs for copying struct timevals in places like ping.c. Compilers warn about misalignment when certain

Re: svn commit: r304555 - head/sys/compat/cloudabi

2016-08-21 Thread Bruce Evans
On Sun, 21 Aug 2016, Slawa Olhovchenkov wrote: On Sun, Aug 21, 2016 at 07:41:11AM +, Ed Schouten wrote: ... Log: Use memcpy() to copy 64-bit timestamps into the syscall return values. On 32-bit platforms, our 64-bit timestamps need to be split up across two registers. A simple assign

Re: svn commit: r304187 - in head: . share/man/man4 sys/conf sys/dev/mcd sys/modules sys/modules/mcd

2016-08-19 Thread Bruce Evans
On Fri, 19 Aug 2016, Alexey Dokuchaev wrote: On Fri, Aug 19, 2016 at 09:12:53PM +1000, Bruce Evans wrote: I normally use my version of biosboot for boot2. I improved its caching just a couple of years ago. It was using 9K buffer optimized for 1440K floppies. Now it uses a 32K buffer

Re: svn commit: r304187 - in head: . share/man/man4 sys/conf sys/dev/mcd sys/modules sys/modules/mcd

2016-08-19 Thread Bruce Evans
On Fri, 19 Aug 2016, Konstantin Belousov wrote: On Thu, Aug 18, 2016 at 09:28:57PM -0600, Warner Losh wrote: On Thu, Aug 18, 2016 at 12:50 AM, Julian Elischer wrote: On 16/08/2016 4:54 AM, John Baldwin wrote: On Monday, August 15, 2016 08:38:02 PM John Baldwin wrote: ,,, Log: Remove the

Re: svn commit: r304320 - head/secure/lib/libcrypto

2016-08-17 Thread Bruce Evans
On Wed, 17 Aug 2016, Jung-uk Kim wrote: Log: Disable assembly sources when compiler/assembler cannot compile certain instructions. For example, GCC 4.2.1 + binutils 2.17.50 does not support AVX instructions. Reported by: bde MFC after: 2 weeks Thanks. I tried WITHOUT_SSL to work

Re: svn commit: r304180 - head/sys/ufs/ffs

2016-08-17 Thread Bruce Evans
On Wed, 17 Aug 2016, Konstantin Belousov wrote: On Tue, Aug 16, 2016 at 11:53:55PM +0200, Jilles Tjoelker wrote: Hmm, some people interpret POSIX differently than I do, but I think it is clear that XBD 3.384 Synchronized I/O Data Integrity Completion requires the indirect blocks to be written (

Re: svn commit: r304221 - head/sys/boot/efi/boot1

2016-08-16 Thread Bruce Evans
On Tue, 16 Aug 2016, Ed Schouten wrote: Hi Emmanuel, Log: Use %ju modifier for u_int64_t and %jd modifier for off_t. off_t is long long on arm32 and long on amd64 I think both of these should be solved differently: - For uint64_t, you can use 's PRIu64 in the formatting string. In kerne

svn commit: r304186 - head/sys/dev/syscons

2016-08-15 Thread Bruce Evans
Author: bde Date: Mon Aug 15 20:17:48 2016 New Revision: 304186 URL: https://svnweb.freebsd.org/changeset/base/304186 Log: Clean up the new sc cn open and close functions (old sc cn grab and ungrab functions). Mainly, spell sc as itself instead of as scp->sc. Modified: head/sys/dev/syscons

svn commit: r304181 - head/sys/dev/syscons

2016-08-15 Thread Bruce Evans
Author: bde Date: Mon Aug 15 19:37:18 2016 New Revision: 304181 URL: https://svnweb.freebsd.org/changeset/base/304181 Log: Restructure the grabbing functions into mere wrappers of new open and close functions. Scattered calls to sc_cnputc() and sc_cngetc() were broken by turning the semi-re

svn commit: r304173 - head/sys/dev/syscons

2016-08-15 Thread Bruce Evans
Author: bde Date: Mon Aug 15 18:02:37 2016 New Revision: 304173 URL: https://svnweb.freebsd.org/changeset/base/304173 Log: Fix restoring the kbd_mode part of the keyboard state in grab/ungrab. Simply change the mode to K_XLATE using a local variable and use the grab level as a flag to tell s

svn commit: r304166 - head/sys/dev/syscons

2016-08-15 Thread Bruce Evans
Author: bde Date: Mon Aug 15 17:11:05 2016 New Revision: 304166 URL: https://svnweb.freebsd.org/changeset/base/304166 Log: [Oops, the previous commit was missing the update to syscons.h.] Like scr_lock, the grab count needs to be per-physical-device to work. This bug corrupted the grab

svn commit: r304165 - head/sys/dev/syscons

2016-08-15 Thread Bruce Evans
Author: bde Date: Mon Aug 15 17:08:25 2016 New Revision: 304165 URL: https://svnweb.freebsd.org/changeset/base/304165 Log: Like scr_lock, the grab count needs to be per-physical-device to work. This bug corrupted the grab count on both vtys if the ungrabbed vty is different from the conso

svn commit: r304164 - head/sys/dev/syscons

2016-08-15 Thread Bruce Evans
Author: bde Date: Mon Aug 15 15:34:53 2016 New Revision: 304164 URL: https://svnweb.freebsd.org/changeset/base/304164 Log: Disable some more unsafe things in (low level) console mode: - never call up to the tty layer to restart output for keyboard input in console mode. This was already d

svn commit: r304161 - head/sys/dev/syscons

2016-08-15 Thread Bruce Evans
Author: bde Date: Mon Aug 15 14:28:16 2016 New Revision: 304161 URL: https://svnweb.freebsd.org/changeset/base/304161 Log: Change all uses of 'debugger' to kdb_active and remove this variable. This restores avoidance of doing dangerous things like calling wakeup() and callouts while in ddb.

Re: svn commit: r304153 - head/sys/dev/syscons

2016-08-15 Thread Bruce Evans
On Mon, 15 Aug 2016, Shawn Webb wrote: On Mon, Aug 15, 2016 at 12:56:45PM +, Bruce Evans wrote: Log: Quick fix for locking fixes in r172250. The lock added there was per- virtual-device, but needs to be per-physical-device so that it protects shared data. Usually, scp->

svn commit: r304153 - head/sys/dev/syscons

2016-08-15 Thread Bruce Evans
Author: bde Date: Mon Aug 15 12:56:45 2016 New Revision: 304153 URL: https://svnweb.freebsd.org/changeset/base/304153 Log: Quick fix for locking fixes in r172250. The lock added there was per- virtual-device, but needs to be per-physical-device so that it protects shared data. Usually, scp

svn commit: r304147 - head/sys/i386/include

2016-08-15 Thread Bruce Evans
Author: bde Date: Mon Aug 15 10:46:33 2016 New Revision: 304147 URL: https://svnweb.freebsd.org/changeset/base/304147 Log: Remove duplicate definition of get_pcb_td(). gcc works for detecting this error. Modified: head/sys/i386/include/md_var.h Modified: head/sys/i386/include/md_var.h ===

svn commit: r304085 - in head/sys/i386: i386 include

2016-08-14 Thread Bruce Evans
Author: bde Date: Sun Aug 14 16:51:25 2016 New Revision: 304085 URL: https://svnweb.freebsd.org/changeset/base/304085 Log: Fix the variables $esp, $ds, $es, $fs, $gs and $ss in vm86 mode. Fix PC_REGS() so that printing of instructions works in some useful cases. ddb only understands a si

svn commit: r304083 - head/sys/kern

2016-08-14 Thread Bruce Evans
Author: bde Date: Sun Aug 14 15:52:00 2016 New Revision: 304083 URL: https://svnweb.freebsd.org/changeset/base/304083 Log: Print the tid of curthread in "show pcpu" in ddb. It was remarkably hard to trace all current threads. "show pcpu" only showed the pid, and there was nothing (?) bet

svn commit: r304080 - head/sys/ddb

2016-08-14 Thread Bruce Evans
Author: bde Date: Sun Aug 14 15:26:40 2016 New Revision: 304080 URL: https://svnweb.freebsd.org/changeset/base/304080 Log: In ddb ps, left justify the non-numeric fields 'state' and 'wmesg' and the fixed-width numeric field 'wchan', as in ps(1). They were sort of centered, although the temp

svn commit: r304078 - head/sys/ddb

2016-08-14 Thread Bruce Evans
Author: bde Date: Sun Aug 14 13:23:02 2016 New Revision: 304078 URL: https://svnweb.freebsd.org/changeset/base/304078 Log: Don't print an extra newline after the instruction when printing for single stepping of multiple instructions (e.g., s/p, and n/p). db_print_loc_and_inst() already print

Re: svn commit: r303890 - in head/sys: contrib/ncsw/user/env contrib/octeon-sdk dev/auxio dev/bktr dev/e1000 dev/ixgb dev/ixgbe dev/ixl dev/netmap dev/pci dev/sound/sbus dev/tpm kern mips/nlm/dev/net

2016-08-09 Thread Bruce Evans
On Tue, 9 Aug 2016, [UTF-8] Jean-S??bastien P??dron wrote: Log: Consistently use `device_t` Several files use the internal name of `struct device` instead of `device_t` which is part of the public API. This patch changes all `struct device *` to `device_t`. device_t is properly opque, yet

Re: svn commit: r303811 - in head/sys: net net80211

2016-08-07 Thread Bruce Evans
On Mon, 8 Aug 2016, Bruce Simpson wrote: On 07/08/16 20:23, Peter Jeremy wrote: On 08/07/16 05:48, Adrian Chadd wrote: +#defineETHER_IS_BROADCAST(addr) \ ... IMHO, Adrian's code is clearer and micro-optimisations like this belong in the complier, not the code. Both are unclear micr

Re: svn commit: r303733 - head/contrib/libpcap

2016-08-04 Thread Bruce Evans
On Thu, 4 Aug 2016, Jung-uk Kim wrote: On 08/03/16 11:40 PM, Bruce Evans wrote: On Wed, 3 Aug 2016, Jung-uk Kim wrote: Log: Support nanosecond time stamps for pcap_dispatch(3) and pcap_loop(3). Modified: head/contrib/libpcap/pcap-bpf.c Modified: head/contrib/libpcap/pcap-bpf.c

Re: svn commit: r303733 - head/contrib/libpcap

2016-08-03 Thread Bruce Evans
On Wed, 3 Aug 2016, Jung-uk Kim wrote: Log: Support nanosecond time stamps for pcap_dispatch(3) and pcap_loop(3). Modified: head/contrib/libpcap/pcap-bpf.c Modified: head/contrib/libpcap/pcap-bpf.c == --- head/contri

Re: svn commit: r303710 - head/sys/fs/nfsclient

2016-08-03 Thread Bruce Evans
On Wed, 3 Aug 2016, Konstantin Belousov wrote: Log: Remove unneeded (recursing) Giant acquisition around vprintf(9). Reviewed by: rmacklem Sponsored by: The FreeBSD Foundation MFC after: 1 week Modified: head/sys/fs/nfsclient/nfs_clsubs.c Modified: head/sys/fs/nfsclient/nfs_clsubs

Re: svn commit: r303600 - head/usr.bin/indent

2016-08-01 Thread Bruce Evans
On Sun, 31 Jul 2016, Xin Li wrote: On 7/31/16 14:36, Pedro F. Giffuni wrote: Log: indent(1): replace function call to bzero with memset. Reference: https://github.com/pstef/freebsd_indent/commit/7422f42f80099c69d34833d7106035dc09230235 Differential Revision: https://reviews.freebsd.

Re: svn commit: r303586 - head/bin/sh

2016-08-01 Thread Bruce Evans
On Sun, 31 Jul 2016, Warner Losh wrote: On Sun, Jul 31, 2016 at 2:16 PM, Jilles Tjoelker wrote: On Sun, Jul 31, 2016 at 01:43:16PM +, Alexey Dokuchaev wrote: On Sun, Jul 31, 2016 at 01:11:34PM +, Jilles Tjoelker wrote: New Revision: 303586 URL: https://svnweb.freebsd.org/changeset/ba

Re: svn commit: r303583 - head/sys/amd64/amd64

2016-07-31 Thread Bruce Evans
On Sun, 31 Jul 2016, Konstantin Belousov wrote: On Sun, Jul 31, 2016 at 11:11:25PM +1000, Bruce Evans wrote: I said that I didn't replace (sse2) pagecopy() by bcopy() on amd64 for Haswell. Actually I do, for a small improvement on makeworld. i386 doesn't have (sse*) pagecopy()

Re: svn commit: r303583 - head/sys/amd64/amd64

2016-07-31 Thread Bruce Evans
On Sun, 31 Jul 2016, Slawa Olhovchenkov wrote: On Sun, Jul 31, 2016 at 11:11:25PM +1000, Bruce Evans wrote: Misalignment of this loop made it almost twice as slow on old Turion2 with slow DDR2 memory. It made no difference on Haswell. I added an extra movnti, but that makes little or no

Re: svn commit: r303583 - head/sys/amd64/amd64

2016-07-31 Thread Bruce Evans
On Sun, 31 Jul 2016, Mateusz Guzik wrote: Log: amd64: implement pagezero using rep stos The current implementation uses non-temporal writes. This turns out to be detrimental to performance if the page is used shortly after, which is the typical case with page faults. Switch to rep stos.

Re: svn commit: r303560 - head/usr.sbin/uathload

2016-07-30 Thread Bruce Evans
On Sat, 30 Jul 2016, Bjoern A. Zeeb wrote: Log: Rename devname to udevname after including stdlib.h in r303445 as gcc trips over the devname(3) and reports 'shadows a global declaration'. You mean "as gcc actually works, so it detects and reports that devname in the program 'shadows a global

Re: svn commit: r303530 - head/lib/libc/gen

2016-07-30 Thread Bruce Evans
On Sat, 30 Jul 2016, Andrey Chernov wrote: On 30.07.2016 7:15, Bruce Evans wrote: On Sat, 30 Jul 2016, Andrey A. Chernov wrote: Log: Reset errno for readdirfunc() before contunue. In C99, library functions are not permitted to set errno to 0. The glob() family shouldn't use a diff

Re: svn commit: r303530 - head/lib/libc/gen

2016-07-29 Thread Bruce Evans
On Sat, 30 Jul 2016, Andrey A. Chernov wrote: Log: Reset errno for readdirfunc() before contunue. In C99, library functions are not permitted to set errno to 0. The glob() family shouldn't use a different (worse) convention, and POSIX doesn't seem to have any special wording to allow differe

Re: svn commit: r303524 - in head: include lib/libc/stdio

2016-07-29 Thread Bruce Evans
On Sat, 30 Jul 2016, Baptiste Daroussin wrote: Log: Remove _WITH_GETLINE and _WITH_DPRINTF guards When adding getline(3) and dprintf(3) into libc, those guards were added to prevent breaking too many ports. 7 years later the ports tree have been fixed, it is time to remove this FreeBSDism

Re: svn commit: r303523 - head/usr.bin/indent

2016-07-29 Thread Bruce Evans
On Fri, 29 Jul 2016, Pedro F. Giffuni wrote: Log: indent(1): Attempt to preserve some consistent style. Remove the excessive braces from r303485 and align the comments to the right as done in the rest of the code. This is not nice but there is no clear way to make it nice (and KNF). Point

<    3   4   5   6   7   8   9   10   11   12   >