svn commit: r234289 - head/tools/build/mk

2012-04-14 Thread Dimitry Andric
Author: dim Date: Sat Apr 14 16:42:17 2012 New Revision: 234289 URL: http://svn.freebsd.org/changeset/base/234289 Log: Add files and directories to be cleaned up if WITHOUT_GCC is in effect to OptionalObsoleteFiles.inc. MFC after:1 week Modified:

svn commit: r234058 - head/usr.bin/kdump

2012-04-09 Thread Dimitry Andric
Author: dim Date: Mon Apr 9 14:47:18 2012 New Revision: 234058 URL: http://svn.freebsd.org/changeset/base/234058 Log: In kdump's mkioctls script, use '${CPP}' instead of hardcodedly using 'gcc -E'. This fixes building when WITH_CLANG_IS_CC is in effect. Report by:Niclas Zeising

svn commit: r234060 - head/usr.bin/truss

2012-04-09 Thread Dimitry Andric
Author: dim Date: Mon Apr 9 15:34:22 2012 New Revision: 234060 URL: http://svn.freebsd.org/changeset/base/234060 Log: Since truss also uses kdump's mkioctls script, pass the value of ${CPP} there too, similar to r234058. MFC after:1 week Modified: head/usr.bin/truss/Makefile

Re: svn commit: r233684 - head/sys/x86/include

2012-03-30 Thread Dimitry Andric
On 2012-03-30 10:25, Andrey Chernov wrote: On Thu, Mar 29, 2012 at 11:31:48PM +, Dimitry Andric wrote: However, the arguments are not properly masked, which results in the wrong value being calculated in some instances. For example, bswap32(0x12345678) returns 0x7c563412

Re: svn commit: r233700 - head/sys/kern

2012-03-30 Thread Dimitry Andric
On 2012-03-30 15:30, Stefan Farfeleder wrote: here are a few similar cases. Hm, what about this one that clang warns about: sys/dev/asr/asr.c:2420:57: warning: for loop has empty body [-Wempty-body] for (ha = Asr_softc_list; *ha; ha = ((*ha)-ha_next));

svn commit: r233710 - head/sys/dev/isci

2012-03-30 Thread Dimitry Andric
Author: dim Date: Fri Mar 30 22:52:08 2012 New Revision: 233710 URL: http://svn.freebsd.org/changeset/base/233710 Log: Fix the following compilation warning with clang trunk in isci(4): sys/dev/isci/isci_task_request.c:198:7: error: case value not in enumerated type 'SCI_TASK_STATUS'

svn commit: r233683 - head/sys/x86/include

2012-03-29 Thread Dimitry Andric
Author: dim Date: Thu Mar 29 23:30:17 2012 New Revision: 233683 URL: http://svn.freebsd.org/changeset/base/233683 Log: Revert sys/x86/include/endian.h to what it was before r233419, as that revision has two problems: - It can produce worse code with both clang and gcc. - It doesn't fix

svn commit: r233684 - head/sys/x86/include

2012-03-29 Thread Dimitry Andric
Author: dim Date: Thu Mar 29 23:31:48 2012 New Revision: 233684 URL: http://svn.freebsd.org/changeset/base/233684 Log: Fix an issue introduced in sys/x86/include/endian.h with r232721. In that revision, the bswapXX_const() macros were renamed to bswapXX_gen(). Also, bswap64_gen() was

svn commit: r233419 - head/sys/x86/include

2012-03-24 Thread Dimitry Andric
Author: dim Date: Sat Mar 24 10:07:21 2012 New Revision: 233419 URL: http://svn.freebsd.org/changeset/base/233419 Log: Fix the following clang warning in sys/dev/dcons/dcons.c, caused by the recent changes in sys/x86/include/endian.h: sys/dev/dcons/dcons.c:190:15: error: implicit

Re: svn commit: r233271 - in head/sys: amd64/conf arm/conf i386/conf ia64/conf mips/conf pc98/conf powerpc/conf sparc64/conf

2012-03-24 Thread Dimitry Andric
On 2012-03-21 09:38, Ed Schouten wrote: Author: ed Date: Wed Mar 21 08:38:42 2012 New Revision: 233271 URL: http://svn.freebsd.org/changeset/base/233271 Log: Remove pty(4) from our kernel configurations. As of FreeBSD 8, this driver should not be used. Applications that use

Re: svn commit: r233419 - head/sys/x86/include

2012-03-24 Thread Dimitry Andric
On 2012-03-24 18:48, Bruce Evans wrote: On Sat, 24 Mar 2012, Dimitry Andric wrote: Log: Fix the following clang warning in sys/dev/dcons/dcons.c, caused by the recent changes in sys/x86/include/endian.h: sys/dev/dcons/dcons.c:190:15: error: implicit conversion from '__uint32_t' (aka

svn commit: r233352 - head/lib/libarchive

2012-03-23 Thread Dimitry Andric
Author: dim Date: Fri Mar 23 11:18:07 2012 New Revision: 233352 URL: http://svn.freebsd.org/changeset/base/233352 Log: Silence alignment warnings from clang in libarchive's ppmd code (which is actually third-party code). Clang even warns about alignment issues on x86, and the warnings are

svn commit: r233354 - in head/sys: conf modules/mps

2012-03-23 Thread Dimitry Andric
Author: dim Date: Fri Mar 23 11:35:01 2012 New Revision: 233354 URL: http://svn.freebsd.org/changeset/base/233354 Log: Work around the following clang warning in mps(4): sys/dev/mps/mps_sas.c:861:1: error: function 'mpssas_discovery_timeout' is not needed and will not be emitted

svn commit: r233195 - head/usr.sbin/dconschat

2012-03-19 Thread Dimitry Andric
Author: dim Date: Mon Mar 19 19:17:55 2012 New Revision: 233195 URL: http://svn.freebsd.org/changeset/base/233195 Log: Fix the following warning from clang trunk: usr.sbin/dconschat/dconschat.c:163:65: error: format specifies type 'size_t' (aka 'unsigned int') but the argument has type

Re: svn commit: r233052 - head/share/mk

2012-03-19 Thread Dimitry Andric
On 2012-03-19 08:21, Chris Rees wrote: On 17 Mar 2012 05:40, Bruce Evans b...@optusnet.com.au mailto:b...@optusnet.com.au wrote: On Fri, 16 Mar 2012, Dimitry Andric wrote: Log: Change the style of share/mk/bsd.sys.mk http://bsd.sys.mk to that of the other bsd.*.mk files

svn commit: r233052 - head/share/mk

2012-03-16 Thread Dimitry Andric
Author: dim Date: Fri Mar 16 23:19:45 2012 New Revision: 233052 URL: http://svn.freebsd.org/changeset/base/233052 Log: Change the style of share/mk/bsd.sys.mk to that of the other bsd.*.mk files, and style.Makefile(5), where applicable. While here, update the link to the gcc warning

svn commit: r232933 - head/sys/conf

2012-03-13 Thread Dimitry Andric
Author: dim Date: Tue Mar 13 19:18:34 2012 New Revision: 232933 URL: http://svn.freebsd.org/changeset/base/232933 Log: Update comments and CFLAGS in sys/conf/kern.mk, introduced in r221879, to match reality: clang does _not_ disable SSE automatically when -mno-mmx is used, you have to

Re: svn commit: r232894 - head/contrib/llvm/tools/clang/lib/Basic

2012-03-13 Thread Dimitry Andric
On 2012-03-13 03:15, Alexander Best wrote: On Mon Mar 12 12, Dimitry Andric wrote: Author: dim Date: Mon Mar 12 21:07:22 2012 New Revision: 232894 URL: http://svn.freebsd.org/changeset/base/232894 Log: Pull in r145194 from upstream clang trunk: Make our handling of MMX x SSE

svn commit: r232858 - head/sbin/growfs

2012-03-12 Thread Dimitry Andric
Author: dim Date: Mon Mar 12 11:15:44 2012 New Revision: 232858 URL: http://svn.freebsd.org/changeset/base/232858 Log: After r232548, clang complains about the apparent '=-' operator (a left-over from ancient C times, and a frequent typo) in growfs.c: sbin/growfs/growfs.c:1550:8: error:

svn commit: r232859 - head/libexec/rtld-elf

2012-03-12 Thread Dimitry Andric
Author: dim Date: Mon Mar 12 11:22:23 2012 New Revision: 232859 URL: http://svn.freebsd.org/changeset/base/232859 Log: Amend r232857, now dropping the casts entirely, as they were not necessary at all. Submitted by: stefanf Modified: head/libexec/rtld-elf/rtld.c Modified:

svn commit: r232894 - head/contrib/llvm/tools/clang/lib/Basic

2012-03-12 Thread Dimitry Andric
Author: dim Date: Mon Mar 12 21:07:22 2012 New Revision: 232894 URL: http://svn.freebsd.org/changeset/base/232894 Log: Pull in r145194 from upstream clang trunk: Make our handling of MMX x SSE closer to what gcc does: * Enabling sse enables mmx. * Disabling (-mno-mmx) mmx,

Re: svn commit: r232721 - head/sys/x86/include

2012-03-09 Thread Dimitry Andric
On 2012-03-09 12:48, Tijl Coosemans wrote: Author: tijl Date: Fri Mar 9 11:48:56 2012 New Revision: 232721 URL: http://svn.freebsd.org/changeset/base/232721 Log: Clean up x86 endian.h: - Remove extern C. There are no functions with external linkage here. [1] - Rename

svn commit: r232745 - in head/sys: powerpc/include sparc64/include x86/include

2012-03-09 Thread Dimitry Andric
Author: dim Date: Fri Mar 9 20:34:31 2012 New Revision: 232745 URL: http://svn.freebsd.org/changeset/base/232745 Log: Add casts to __uint16_t to the __bswap16() macros on all arches which didn't already have them. This is because the ternary expression will return int, due to the Usual

svn commit: r232748 - head/usr.bin/netstat

2012-03-09 Thread Dimitry Andric
Author: dim Date: Fri Mar 9 20:50:15 2012 New Revision: 232748 URL: http://svn.freebsd.org/changeset/base/232748 Log: After r232745, which makes sure __bswap16(), ntohs() and htons() return __uint16_t, we can partially undo r228668. Note the remark Work around a clang false positive

svn commit: r232749 - head/sbin/fsdb

2012-03-09 Thread Dimitry Andric
Author: dim Date: Fri Mar 9 21:02:39 2012 New Revision: 232749 URL: http://svn.freebsd.org/changeset/base/232749 Log: Partially undo r228693, by removing NO_WFORMAT.clang in fsdb's Makefile, and fixing the format string in sbin/fsdb/fsdbutil.c instead. Note the remark Work around a

svn commit: r232620 - in head/include: . xlocale

2012-03-06 Thread Dimitry Andric
Author: dim Date: Tue Mar 6 20:15:23 2012 New Revision: 232620 URL: http://svn.freebsd.org/changeset/base/232620 Log: After r232498, programs built with -ansi or -std=c89 including ctype.h would not compile anymore, due to plain 'inline' keywords. Fix this by using __inline instead.

svn commit: r232522 - head

2012-03-04 Thread Dimitry Andric
Author: dim Date: Sun Mar 4 21:36:18 2012 New Revision: 232522 URL: http://svn.freebsd.org/changeset/base/232522 Log: Fix a thinko in r232322, where gcc (and its tools) are not built during the cross-tools stage, if CC=clang and WITH_CLANG_IS_CC is not set. This causes no 'cc' to be

svn commit: r232473 - in head: share/mk sys/conf

2012-03-03 Thread Dimitry Andric
Author: dim Date: Sat Mar 3 18:58:15 2012 New Revision: 232473 URL: http://svn.freebsd.org/changeset/base/232473 Log: After r232322, it turned out many people (and some ports) are building kernel modules using their old installed /usr/share/mk/bsd.*.mk files, instead of the updated ones in

Re: svn commit: r232473 - in head: share/mk sys/conf

2012-03-03 Thread Dimitry Andric
On 2012-03-03 21:03, Doug Barton wrote: On 03/03/2012 10:58, Dimitry Andric wrote: However, since it is apparently an expected use case to build using old .mk files, Expected how? It shouldn't happen if you're building in /usr/src. No, but it apparently happens if you build kernel modules

svn commit: r232476 - in head: share/mk sys/conf

2012-03-03 Thread Dimitry Andric
Author: dim Date: Sat Mar 3 23:49:53 2012 New Revision: 232476 URL: http://svn.freebsd.org/changeset/base/232476 Log: Revert r232473. I have been convinced by Doug Barton and Bjoern Zeeb that it is better to error out when people attempt to build using the wrong bsd.*.mk files, than to

svn commit: r232477 - head/sys/conf

2012-03-03 Thread Dimitry Andric
Author: dim Date: Sun Mar 4 00:42:18 2012 New Revision: 232477 URL: http://svn.freebsd.org/changeset/base/232477 Log: In r232322, I forgot one case where a check for MK_CLANG_IS_CC was needed, in sys/conf/kern.pre.mk. Add it now. MFC after:2 weeks Modified:

Re: svn commit: r232322 - in head: . gnu/usr.bin/cc/c++ gnu/usr.bin/cc/cc gnu/usr.bin/cc/cpp share/mk sys/conf tools/build/options usr.bin/clang/clang

2012-03-01 Thread Dimitry Andric
On 2012-03-01 20:34, John Baldwin wrote: On Wednesday, February 29, 2012 5:58:52 pm Dimitry Andric wrote: Author: dim Date: Wed Feb 29 22:58:51 2012 New Revision: 232322 URL: http://svn.freebsd.org/changeset/base/232322 Log: Add a WITH_CLANG_IS_CC option for src.conf(5), disabled

svn commit: r232311 - head/share/man/man5

2012-02-29 Thread Dimitry Andric
Author: dim Date: Wed Feb 29 19:18:32 2012 New Revision: 232311 URL: http://svn.freebsd.org/changeset/base/232311 Log: Regenerate src.conf(5) after r231530 (and to correct a little screwup with the WITH_CLANG_EXTRAS fragment I added). Modified: head/share/man/man5/src.conf.5 Modified:

svn commit: r232322 - in head: . gnu/usr.bin/cc/c++ gnu/usr.bin/cc/cc gnu/usr.bin/cc/cpp share/mk sys/conf tools/build/options usr.bin/clang/clang

2012-02-29 Thread Dimitry Andric
Author: dim Date: Wed Feb 29 22:58:51 2012 New Revision: 232322 URL: http://svn.freebsd.org/changeset/base/232322 Log: Add a WITH_CLANG_IS_CC option for src.conf(5), disabled by default, that installs clang as /usr/bin/cc, /usr/bin/c++ and /usr/bin/cpp. Note this does *not* disable

svn commit: r232323 - head/share/man/man5

2012-02-29 Thread Dimitry Andric
Author: dim Date: Wed Feb 29 23:06:48 2012 New Revision: 232323 URL: http://svn.freebsd.org/changeset/base/232323 Log: Regenerate src.conf(5) after r232322. MFC after:2 weeks Modified: head/share/man/man5/src.conf.5 Modified: head/share/man/man5/src.conf.5

svn commit: r232263 - in head: lib/libsm lib/libthread_db lib/libz libexec/mail.local libexec/smrsh sbin/fsdb share/mk sys/boot/i386/boot0 sys/boot/i386/boot2 sys/boot/i386/btx/btx sys/boot/i386/bt...

2012-02-28 Thread Dimitry Andric
Author: dim Date: Tue Feb 28 18:30:18 2012 New Revision: 232263 URL: http://svn.freebsd.org/changeset/base/232263 Log: Define several extra macros in bsd.sys.mk and sys/conf/kern.pre.mk, to get rid of testing explicitly for clang (using ${CC:T:Mclang}) in individual Makefiles. Instead,

Re: svn commit: r232266 - in head/sys: amd64/include i386/include pc98/include x86/include

2012-02-28 Thread Dimitry Andric
On 2012-02-28 20:39, Tijl Coosemans wrote: Author: tijl Date: Tue Feb 28 19:39:54 2012 New Revision: 232266 URL: http://svn.freebsd.org/changeset/base/232266 Log: Copy amd64 endian.h to x86 and merge with i386 endian.h. Replace amd64/i386/pc98 endian.h with stubs. In

svn commit: r232271 - head/sys/kern

2012-02-28 Thread Dimitry Andric
Author: dim Date: Tue Feb 28 21:45:21 2012 New Revision: 232271 URL: http://svn.freebsd.org/changeset/base/232271 Log: Change definition of pipe_chmod() from KR to C99, to avoid the following clang warning: sys/kern/sys_pipe.c:1556:10: error: promoted type 'int' of KR function parameter

Re: svn commit: r232271 - head/sys/kern

2012-02-28 Thread Dimitry Andric
On 2012-02-28 23:11, Giovanni Trematerra wrote: On Tue, Feb 28, 2012 at 10:45 PM, Dimitry Andric d...@freebsd.org wrote: Author: dim Date: Tue Feb 28 21:45:21 2012 New Revision: 232271 URL: http://svn.freebsd.org/changeset/base/232271 ... It introduces a style(9) violation, though. I think

Re: svn commit: r232074 - head/sys/cam/ctl

2012-02-24 Thread Dimitry Andric
On 2012-02-24 10:38, Alexander Best wrote: is the clang version in base able to do complete universe builds for i386 and amd64 without the need for NO_WERROR= and WERROR= now? universe means all arches, and all kernel configs, so no. The status for head with clang is as follows: - buildworld

svn commit: r232073 - head/sys/conf

2012-02-23 Thread Dimitry Andric
Author: dim Date: Thu Feb 23 21:32:32 2012 New Revision: 232073 URL: http://svn.freebsd.org/changeset/base/232073 Log: Revert r231978, so I can apply a more proper fix to silence unneeded internal declaration warnings in several sys/cam/ctl files. MFC after:1 week Modified:

svn commit: r232074 - head/sys/cam/ctl

2012-02-23 Thread Dimitry Andric
Author: dim Date: Thu Feb 23 21:34:14 2012 New Revision: 232074 URL: http://svn.freebsd.org/changeset/base/232074 Log: Use a better way to silence unneeded internal declaration warnings in several sys/cam/ctl files. Suggested by: ed Reviewed by: ken MFC after:1 week Modified:

svn commit: r231978 - head/sys/conf

2012-02-21 Thread Dimitry Andric
Author: dim Date: Tue Feb 21 20:55:43 2012 New Revision: 231978 URL: http://svn.freebsd.org/changeset/base/231978 Log: When building with clang, disable -Wunneeded-internal-declaration for several sys/cam/ctl files, since these get the following warnings: In file included from

svn commit: r231982 - in head/sys: conf modules/hpt27xx

2012-02-21 Thread Dimitry Andric
Author: dim Date: Tue Feb 21 21:20:52 2012 New Revision: 231982 URL: http://svn.freebsd.org/changeset/base/231982 Log: When building with clang, disable -Wformat-security for sys/dev/hpt27xx/osm_bsd.c, since it gets the following warnings: sys/dev/hpt27xx/osm_bsd.c:1180:25: error: format

svn commit: r231714 - in head: etc/mtree include include/xlocale lib/libc/locale sys/sys

2012-02-14 Thread Dimitry Andric
Author: dim Date: Tue Feb 14 21:48:46 2012 New Revision: 231714 URL: http://svn.freebsd.org/changeset/base/231714 Log: Revert r231673 and r231682 for now, until we can run a full make universe with them. Sorry for the breakage. Pointy hat to: me and brooks Added:

svn commit: r231118 - in head: include/rpc include/rpcsvc lib/libc/rpc lib/libc/yp lib/librpcsvc lib/libypclnt libexec/ypxfr release/picobsd/tinyware/passwd sys/conf sys/modules/kgssapi sys/modules...

2012-02-07 Thread Dimitry Andric
Author: dim Date: Tue Feb 7 09:27:07 2012 New Revision: 231118 URL: http://svn.freebsd.org/changeset/base/231118 Log: Consistently set RPCGEN_CPP when running rpcgen, so the C preprocessor set via ${CPP} is used, instead of always using hardcoded /usr/bin/cpp. MFC after:1 week

Re: svn commit: r231118 - in head: include/rpc include/rpcsvc lib/libc/rpc lib/libc/yp lib/librpcsvc lib/libypclnt libexec/ypxfr release/picobsd/tinyware/passwd sys/conf sys/modules/kgssapi sys/module

2012-02-07 Thread Dimitry Andric
On 2012-02-07 12:07, Konstantin Belousov wrote: On Tue, Feb 07, 2012 at 09:27:08AM +, Dimitry Andric wrote: Author: dim Date: Tue Feb 7 09:27:07 2012 New Revision: 231118 URL: http://svn.freebsd.org/changeset/base/231118 Log: Consistently set RPCGEN_CPP when running rpcgen, so the C

svn commit: r231079 - head/usr.bin/rpcgen

2012-02-06 Thread Dimitry Andric
Author: dim Date: Mon Feb 6 12:03:21 2012 New Revision: 231079 URL: http://svn.freebsd.org/changeset/base/231079 Log: Let rpcgen(1) support an environment variable RPCGEN_CPP to find the C preprocessor to run. Previously, it always ran /usr/bin/cpp, unless you used the -Y option, and even

svn commit: r231080 - head/usr.bin/rpcgen

2012-02-06 Thread Dimitry Andric
Author: dim Date: Mon Feb 6 12:08:41 2012 New Revision: 231080 URL: http://svn.freebsd.org/changeset/base/231080 Log: Amend r231079 by properly shifting up the existing arguments in rpc_main.c's insarg() function. I had forgotten to put this in my patch queue, sorry. Pointy hat to:

svn commit: r231101 - head/usr.bin/rpcgen

2012-02-06 Thread Dimitry Andric
Author: dim Date: Mon Feb 6 21:35:11 2012 New Revision: 231101 URL: http://svn.freebsd.org/changeset/base/231101 Log: In usr.bin/rpcgen/rpc_main.c, use execvp(3) instead of execv(3), so rpcgen will search the current PATH for the preprocessor. This makes it possible to run a preprocessor

svn commit: r231054 - head/usr.bin/rpcgen

2012-02-05 Thread Dimitry Andric
Author: dim Date: Sun Feb 5 20:55:38 2012 New Revision: 231054 URL: http://svn.freebsd.org/changeset/base/231054 Log: In usr.bin/rpcgen/rpc_main.c, properly check the return value of strlcpy(), in addition to checking that of strlcat(). MFC after:1 week Modified:

svn commit: r231055 - head/share/man/man5

2012-02-05 Thread Dimitry Andric
Author: dim Date: Sun Feb 5 23:02:13 2012 New Revision: 231055 URL: http://svn.freebsd.org/changeset/base/231055 Log: Regenerate src.conf.5, after r230972 added the WITHOUT_SOURCELESS build options. MFC after:2 weeks Modified: head/share/man/man5/src.conf.5 Modified:

svn commit: r231057 - in head: contrib/llvm/tools/bugpoint contrib/llvm/tools/llc contrib/llvm/tools/lli contrib/llvm/tools/llvm-ar contrib/llvm/tools/llvm-as contrib/llvm/tools/llvm-bcanalyzer con...

2012-02-05 Thread Dimitry Andric
Author: dim Date: Sun Feb 5 23:56:22 2012 New Revision: 231057 URL: http://svn.freebsd.org/changeset/base/231057 Log: Add a WITH_CLANG_EXTRAS option for src.conf(5), disabled by default, that builds the following additional llvm/clang tools: - bugpoint - llc - lli - llvm-ar -

Re: svn commit: r230622 - head

2012-01-30 Thread Dimitry Andric
On 2012-01-30 20:27, Rafal Jaworowski wrote: ... Fix this by setting PATH to ${BPATH}:${PATH} in stage 2.3, so the bootstrap tools directories are searched before the regular ones. Is this supposed to work for cross building as well? I'm still encountering problems on a 7.3 host build:

Re: svn commit: r230622 - head

2012-01-30 Thread Dimitry Andric
On 2012-01-30 21:48, Ian Lepore wrote: On Mon, 2012-01-30 at 21:08 +0100, Dimitry Andric wrote: On 2012-01-30 20:27, Rafal Jaworowski wrote: ... Fix this by setting PATH to ${BPATH}:${PATH} in stage 2.3, so the bootstrap tools directories are searched before the regular ones

svn commit: r230622 - head

2012-01-27 Thread Dimitry Andric
Author: dim Date: Fri Jan 27 18:29:03 2012 New Revision: 230622 URL: http://svn.freebsd.org/changeset/base/230622 Log: When the buildkernel stage 2.3 (build tools) runs, the PATH is still set to the default from the top-level Makefile. Therefore, invocations of lex and yacc (used during

Re: svn commit: r230354 - head/usr.sbin/makefs

2012-01-23 Thread Dimitry Andric
On 2012-01-23 05:28, Hiroki Sato wrote: ... I don't think it is needed. The makefs utility is a special case because it will probably diverge from the upstream to support FreeBSD-specific feature in the future (this is one of the reasons why it is not in contrib/). It didn't happen so

Re: svn commit: r230354 - head/usr.sbin/makefs

2012-01-23 Thread Dimitry Andric
On 2012-01-23 13:31, Kostik Belousov wrote: On Mon, Jan 23, 2012 at 01:25:04PM +0100, Dimitry Andric wrote: ... There is a typo in the second or condition, should it be gcc46 both times ? Ah, sorry, that was a copy/paste error. Anyway, the reason to answer this message is two ask

Re: svn commit: r230368 - head/tools/regression/usr.bin/cc

2012-01-20 Thread Dimitry Andric
On 2012-01-20 08:55, Roman Divacky wrote: http://llvm.org/bugs/show_bug.cgi?id=11406 says this has been fixed, is this just problem with us having older clang in base? Obviously, it has only been fixed in llvm trunk. If this is a pressing problem, we can backport the fix. Otherwise, it will

svn commit: r230393 - head/contrib/llvm/lib/Target/X86

2012-01-20 Thread Dimitry Andric
Author: dim Date: Fri Jan 20 19:18:11 2012 New Revision: 230393 URL: http://svn.freebsd.org/changeset/base/230393 Log: Pull in r148240 from upstream llvm trunk: Make sure the non-SSE lowering for fences correctly clobbers EFLAGS. PR11768. In particular, this fixes segfaults

Re: svn commit: r213765 - head/sys/dev/aic7xxx/aicasm

2012-01-12 Thread Dimitry Andric
On 2010-10-14 21:23, Jung-uk Kim wrote: On Thursday 14 October 2010 03:11 pm, Dmitry Morozovsky wrote: On Thu, 14 Oct 2010, Jung-uk Kim wrote: ... cc -O2 -pipe -nostdinc -I/usr/include -I. -I/FreeBSD/src.current.svn/sys/dev/aic7xxx/aicasm -std=gnu99 -Wsystem-headers -Werror -Wall

Re: svn commit: r229415 - head/lib/libvgl

2012-01-10 Thread Dimitry Andric
On 2012-01-10 05:48, Eitan Adler wrote: On Mon, Jan 9, 2012 at 11:02 PM, John-Mark Gurneyj...@funkthat.com wrote: Last time I did benchmarking on this ~10 years ago, it was slower to use xor instead of using assignments... I'd be shocked if the compiler didn't optimize this away to an XCHG.

Re: svn commit: r229415 - head/lib/libvgl

2012-01-10 Thread Dimitry Andric
On 2012-01-03 20:47, Pedro F. Giffuni wrote: Author: pfg Date: Tue Jan 3 19:47:32 2012 New Revision: 229415 URL: http://svn.freebsd.org/changeset/base/229415 Log: Integrate the line drawing algorithm from the book Graphic Gems 1. http://www.graphicsgems.org/ At the time it claimed

Re: svn commit: r229908 - head/usr.bin/brandelf

2012-01-10 Thread Dimitry Andric
On 2012-01-10 09:21, Pawel Jakub Dawidek wrote: On Tue, Jan 10, 2012 at 02:58:29AM +, Eitan Adler wrote: Author: eadler (ports committer) Date: Tue Jan 10 02:58:29 2012 New Revision: 229908 URL: http://svn.freebsd.org/changeset/base/229908 Log: Fix warning when compiling with gcc46:

Re: svn commit: r228985 - head/sys/boot/forth

2012-01-09 Thread Dimitry Andric
On 2012-01-08 21:35, Sergey Kandaurov wrote: ... So, the problem arise when beastie_disable is set. In this case menu.rc is not evaluated and consequently menu-unset does not have a body yet. This results in the ficl warning not found when try-menu-unset calls menu-unset. The warning cannot be

Re: svn commit: r228985 - head/sys/boot/forth

2012-01-07 Thread Dimitry Andric
On 2011-12-30 07:24, Sergey Kandaurov wrote: Author: pluknet Date: Fri Dec 30 06:24:59 2011 New Revision: 228985 URL: http://svn.freebsd.org/changeset/base/228985 Log: Unset the environment variables associated with individual menu items before invoking the kernel. When I did a

svn commit: r229753 - head/sys/contrib/rdma

2012-01-06 Thread Dimitry Andric
Author: dim Date: Sat Jan 7 00:47:27 2012 New Revision: 229753 URL: http://svn.freebsd.org/changeset/base/229753 Log: In sys/contrib/rdma/ib_addr.h, bump MAX_ADDR_LEN to 20 bytes (the same value used in sys/ofed/include/linux/netdevice.h), so there will be no buffer overruns in the rest of

svn commit: r229600 - head/sys/fs/nullfs

2012-01-05 Thread Dimitry Andric
Author: dim Date: Thu Jan 5 17:06:04 2012 New Revision: 229600 URL: http://svn.freebsd.org/changeset/base/229600 Log: In sys/fs/nullfs/null_subr.c, in a KASSERT, output the correct vnode pointer 'lowervp' instead of 'vp', which is uninitialized at that point. Reviewed by: kib MFC

svn commit: r229401 - head/sys/dev/if_ndis

2012-01-03 Thread Dimitry Andric
Author: dim Date: Tue Jan 3 18:40:41 2012 New Revision: 229401 URL: http://svn.freebsd.org/changeset/base/229401 Log: In sys/dev/if_ndis/if_ndis_pccard.c, fix a bug where a garbage rid was passed to resource_list_add(). The rid that was just returned by bus_alloc_resource_any() should

svn commit: r229402 - head/sys/compat/linux

2012-01-03 Thread Dimitry Andric
Author: dim Date: Tue Jan 3 18:49:39 2012 New Revision: 229402 URL: http://svn.freebsd.org/changeset/base/229402 Log: In sys/compat/linux/linux_ioctl.c, work around a warning when a pointer is compared to an integer, by casting the pointer to l_uintptr_t. No functional difference on both

svn commit: r229423 - head/sys/dev/qlxgb

2012-01-03 Thread Dimitry Andric
Author: dim Date: Tue Jan 3 20:51:26 2012 New Revision: 229423 URL: http://svn.freebsd.org/changeset/base/229423 Log: In sys/dev/qlxgb/qla_misc.c, fix a copy/paste issue. Clang complained the variable 'val' was uninitialized when used. Instead, 'sig' should have been printed.

svn commit: r229425 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2012-01-03 Thread Dimitry Andric
Author: dim Date: Tue Jan 3 20:53:07 2012 New Revision: 229425 URL: http://svn.freebsd.org/changeset/base/229425 Log: In sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c, check the the number of links against LINK_MAX (which is INT16_MAX), not against UINT32_MAX. Otherwise, the

Re: svn commit: r229169 - head/lib/clang

2012-01-01 Thread Dimitry Andric
On 2012-01-01 16:56, Nathan Whitehorn wrote: Author: nwhitehorn Date: Sun Jan 1 15:56:15 2012 New Revision: 229169 URL: http://svn.freebsd.org/changeset/base/229169 Log: Instead of forcing -O1 on PowerPC for LLVM and clang, fix the actual problem by adding -fno-strict-aliasing to CFLAGS.

Re: svn commit: r228801 - head

2012-01-01 Thread Dimitry Andric
On 2012-01-01 03:04, David Schultz wrote: On Thu, Dec 22, 2011, Dimitry Andric wrote: Remove -mfancy-math from LIB32CPUFLAGS for amd64. It has been default for our gcc since more than three years (see r181534, which is also in stable/9 and stable/8). This flag used

svn commit: r229183 - in head/lib/clang: libllvmarminfo libllvmmipsinfo libllvmpowerpcinfo libllvmx86info

2012-01-01 Thread Dimitry Andric
Author: dim Date: Sun Jan 1 18:36:42 2012 New Revision: 229183 URL: http://svn.freebsd.org/changeset/base/229183 Log: In several llvm library Makefiles, remove extraneous slashes at the end of SRCDIR definitions. MFC after:3 days Modified: head/lib/clang/libllvmarminfo/Makefile

svn commit: r229196 - head/contrib/less

2012-01-01 Thread Dimitry Andric
Author: dim Date: Sun Jan 1 20:13:02 2012 New Revision: 229196 URL: http://svn.freebsd.org/changeset/base/229196 Log: Redo r228645, but instead of casting away const conversion warnings in contrib/less, add a few const qualifiers in the right places. Suggested by: das MFC after:1

svn commit: r229076 - head/sys/dev/hwpmc

2011-12-31 Thread Dimitry Andric
Author: dim Date: Sat Dec 31 12:37:07 2011 New Revision: 229076 URL: http://svn.freebsd.org/changeset/base/229076 Log: In sys/dev/hwpmc/hwpmc_amd.c, fix a clang warning about invalid enum conversions. Reviewed by: jkoshy MFC after:1 week Modified: head/sys/dev/hwpmc/hwpmc_amd.c

svn commit: r228994 - in head/sys: conf modules/ipfilter modules/nxge modules/xfs

2011-12-30 Thread Dimitry Andric
Author: dim Date: Fri Dec 30 13:16:59 2011 New Revision: 228994 URL: http://svn.freebsd.org/changeset/base/228994 Log: Disable several instances instances of clang's -Wself-assign warning. All of these are harmless, and are in fact used to shut up warnings from lint. While here, remove

svn commit: r229004 - head/sys/compat/ndis

2011-12-30 Thread Dimitry Andric
Author: dim Date: Fri Dec 30 17:18:09 2011 New Revision: 229004 URL: http://svn.freebsd.org/changeset/base/229004 Log: In sys/compat/ndis/subr_ntoskrnl.c, change the RtlFillMemory function definition from KR to ANSI, to avoid a clang warning about the uint8_t parameter being promoted to

svn commit: r229024 - head/lib/libc/gen

2011-12-30 Thread Dimitry Andric
Author: dim Date: Fri Dec 30 20:41:24 2011 New Revision: 229024 URL: http://svn.freebsd.org/changeset/base/229024 Log: Add some additional const poison after r228972. The 'mapping' array in lib/libc/gen/strtofflags.c became const, but gcc did not warn about assigning its members to

svn commit: r228963 - in head/sys/dev: ce cp

2011-12-29 Thread Dimitry Andric
Author: dim Date: Thu Dec 29 17:46:24 2011 New Revision: 228963 URL: http://svn.freebsd.org/changeset/base/228963 Log: Fix clang warnings in sys/dev/ce/if_ce.c and sys/dev/cp/if_cp.c, using jkim's last patch (reviewed by bde) from here:

svn commit: r228971 - in head/sys: conf modules/ce

2011-12-29 Thread Dimitry Andric
Author: dim Date: Thu Dec 29 21:17:35 2011 New Revision: 228971 URL: http://svn.freebsd.org/changeset/base/228971 Log: For sys/dev/ce/tau32-ddk.c, disable the following warning when building with clang: sys/dev/ce/tau32-ddk.c:1228:37: warning: implicit truncation from 'int' to bitfield

svn commit: r228978 - in head/sys: conf modules/drm/r128 modules/drm/radeon modules/drm/via

2011-12-29 Thread Dimitry Andric
Author: dim Date: Fri Dec 30 01:54:45 2011 New Revision: 228978 URL: http://svn.freebsd.org/changeset/base/228978 Log: For several files in sys/dev/drm, disable -Wunused-value when building with clang. There are several macros in these files that return values, and in some cases nothing is

svn commit: r228980 - in head/sys/dev/ath/ath_hal: ar5210 ar5211

2011-12-29 Thread Dimitry Andric
Author: dim Date: Fri Dec 30 02:58:37 2011 New Revision: 228980 URL: http://svn.freebsd.org/changeset/base/228980 Log: Reapply r228785 now it has been tested by Adrian. Also add comments with the old AR_SCR_SLE_XXX values, with a short explanation why they were changed. Reviewed by:

svn commit: r228860 - head/sys/conf

2011-12-24 Thread Dimitry Andric
Author: dim Date: Sat Dec 24 13:30:15 2011 New Revision: 228860 URL: http://svn.freebsd.org/changeset/base/228860 Log: Make another clang warning, -Wempty-body, non-fatal during kernel builds. All the instances of this warning in our tree are completely harmless. (Most of the empty bodies

svn commit: r228861 - head/sys/modules/nve

2011-12-24 Thread Dimitry Andric
Author: dim Date: Sat Dec 24 13:36:28 2011 New Revision: 228861 URL: http://svn.freebsd.org/changeset/base/228861 Log: Set WERROR= for the nve(4) module. This driver gives several warnings with clang, which will probably never be fixed, as it is unmaintained, and superseded by nfe(4).

svn commit: r228865 - head/sys/modules/asr

2011-12-24 Thread Dimitry Andric
Author: dim Date: Sat Dec 24 17:54:58 2011 New Revision: 228865 URL: http://svn.freebsd.org/changeset/base/228865 Log: Amend r228781 by also disabling -Warray-bounds warnings for the asr module. MFC after:1 week Modified: head/sys/modules/asr/Makefile Modified:

svn commit: r228867 - head/sys/conf

2011-12-24 Thread Dimitry Andric
Author: dim Date: Sat Dec 24 18:57:42 2011 New Revision: 228867 URL: http://svn.freebsd.org/changeset/base/228867 Log: Make another clang warning, -Wparentheses-equality, non-fatal during kernel builds. All the instances of this warning in our tree are completely harmless, and many people

svn commit: r228868 - head/sys/conf

2011-12-24 Thread Dimitry Andric
Author: dim Date: Sat Dec 24 19:01:31 2011 New Revision: 228868 URL: http://svn.freebsd.org/changeset/base/228868 Log: When building the kernel for amd64 with clang, don't attempt to use the -frename-registers option, as it is not supported. No change for builds with gcc. MFC after:

svn commit: r228841 - head/sys/conf

2011-12-23 Thread Dimitry Andric
Author: dim Date: Fri Dec 23 13:50:33 2011 New Revision: 228841 URL: http://svn.freebsd.org/changeset/base/228841 Log: Amend r228822 by not directly adding to CWARNFLAGS, but to an optional CWARNEXTRA variable, which gets included into the initial CWARNFLAGS setting. This makes it easier

Re: svn commit: r228783 - head/sys/conf

2011-12-22 Thread Dimitry Andric
On 2011-12-22 09:43, Adrian Chadd wrote: On 21 December 2011 09:01, Dimitry Andricd...@freebsd.org wrote: Author: dim Date: Wed Dec 21 17:01:13 2011 New Revision: 228783 URL: http://svn.freebsd.org/changeset/base/228783 ... Both warnings are false positives, caused by LLVM PR 10030. For

svn commit: r228801 - head

2011-12-22 Thread Dimitry Andric
Author: dim Date: Thu Dec 22 15:03:48 2011 New Revision: 228801 URL: http://svn.freebsd.org/changeset/base/228801 Log: Remove -mfancy-math from LIB32CPUFLAGS for amd64. It has been default for our gcc since more than three years (see r181534, which is also in stable/9 and stable/8). This

svn commit: r228805 - in head/sys/modules/aic7xxx: ahc/ahc_pci ahd

2011-12-22 Thread Dimitry Andric
Author: dim Date: Thu Dec 22 16:16:12 2011 New Revision: 228805 URL: http://svn.freebsd.org/changeset/base/228805 Log: Disable -Wconstant-conversion warnings for the aic7xxx module in a more fine-grained way: only add the option for the specific .c files that need them, like via

svn commit: r228818 - head/sys/modules/ath

2011-12-22 Thread Dimitry Andric
Author: dim Date: Thu Dec 22 23:40:52 2011 New Revision: 228818 URL: http://svn.freebsd.org/changeset/base/228818 Log: Disable various warnings for the ath module in a more fine-grained way: only add the option for the specific .c files that need them, like via sys/conf/files. MFC

svn commit: r228822 - head/sys/conf

2011-12-22 Thread Dimitry Andric
Author: dim Date: Fri Dec 23 00:23:37 2011 New Revision: 228822 URL: http://svn.freebsd.org/changeset/base/228822 Log: When building the kernel with clang, it produces several warnings which might be useful in some cases, but which are not severe enough to error out the whole kernel build.

svn commit: r228779 - head/sys/conf

2011-12-21 Thread Dimitry Andric
Author: dim Date: Wed Dec 21 15:59:18 2011 New Revision: 228779 URL: http://svn.freebsd.org/changeset/base/228779 Log: Start selectively disabling a few kernel build warnings for clang, since there are some places in the kernel where fixing them is too disruptive, or where there is a false

svn commit: r228783 - head/sys/conf

2011-12-21 Thread Dimitry Andric
Author: dim Date: Wed Dec 21 17:01:13 2011 New Revision: 228783 URL: http://svn.freebsd.org/changeset/base/228783 Log: When building with clang, disable -Wshift-count-negative and -Wshift-count-overflow for sys/dev/ath/ath_hal/ah_regdomain.c, as it gets multiple instances of the following

svn commit: r228785 - in head/sys/dev/ath/ath_hal: ar5210 ar5211

2011-12-21 Thread Dimitry Andric
Author: dim Date: Wed Dec 21 17:16:43 2011 New Revision: 228785 URL: http://svn.freebsd.org/changeset/base/228785 Log: Fix shift overflow problem in sys/dev/ath/ath_hal/ar5210/ar5210_power.c and sys/dev/ath/ath_hal/ar5211/ar5211_power.c: sys/dev/ath/ath_hal/ar5210/ar5210_power.c:36:3:

svn commit: r228786 - in head/sys/dev/ath/ath_hal: ar5212 ar5416

2011-12-21 Thread Dimitry Andric
Author: dim Date: Wed Dec 21 17:36:45 2011 New Revision: 228786 URL: http://svn.freebsd.org/changeset/base/228786 Log: Fix enum conversion problems in sys/dev/ath/ath_hal/ar5212/ar5212_misc.c and sys/dev/ath/ath_hal/ar5416/ar5416_misc.c: sys/dev/ath/ath_hal/ar5212/ar5212_misc.c:577:24:

svn commit: r228789 - in head/sys/modules/aic7xxx: ahc/ahc_pci ahd

2011-12-21 Thread Dimitry Andric
Author: dim Date: Wed Dec 21 20:23:03 2011 New Revision: 228789 URL: http://svn.freebsd.org/changeset/base/228789 Log: Amend r228779 by also disabling -Wconstant-conversion warnings for the aic7xxx module. MFC after:1 week Modified: head/sys/modules/aic7xxx/ahc/ahc_pci/Makefile

<    8   9   10   11   12   13   14   15   16   >