Re: svn commit: r363875 - head/sys/ufs/ffs

2020-08-05 Thread Peter Holm
On Wed, Aug 05, 2020 at 11:15:53AM -0400, Mark Johnston wrote: > On Tue, Aug 04, 2020 at 11:09:16PM +, Mateusz Guzik wrote: > > Author: mjg > > Date: Tue Aug 4 23:09:15 2020 > > New Revision: 363875 > > URL: https://svnweb.freebsd.org/changeset/base/363875 > > > > Log: > > ufs: only pass LK

Re: svn commit: r363069 - head/sys/kern

2020-07-10 Thread Peter Holm
On Fri, Jul 10, 2020 at 11:25:52AM +0200, Mateusz Guzik wrote: > On 7/10/20, Mateusz Guzik wrote: > > On 7/10/20, Peter Holm wrote: > >> On Fri, Jul 10, 2020 at 06:47:58AM +, Mateusz Guzik wrote: > >>> Author: mjg > >>> Date: Fri Jul 10 06:47:58

Re: svn commit: r363069 - head/sys/kern

2020-07-10 Thread Peter Holm
On Fri, Jul 10, 2020 at 06:47:58AM +, Mateusz Guzik wrote: > Author: mjg > Date: Fri Jul 10 06:47:58 2020 > New Revision: 363069 > URL: https://svnweb.freebsd.org/changeset/base/363069 > > Log: > vfs: depessimize getfsstat when only the count is requested > > This avoids relocking mount

Re: svn commit: r361275 - in head/sys: conf dev/hyperv/hvsock dev/hyperv/include dev/hyperv/vmbus modules/hyperv modules/hyperv/hvsock sys

2020-05-21 Thread Peter Holm
On Thu, May 21, 2020 at 01:01:18PM +, Wei Hu wrote: > > -Original Message- > > From: Peter Holm > > Sent: Thursday, May 21, 2020 8:24 PM > > To: Wei Hu > > Cc: src-committ...@freebsd.org; svn-src-...@freebsd.org; svn-src- > > h...@freebsd.org >

Re: svn commit: r361275 - in head/sys: conf dev/hyperv/hvsock dev/hyperv/include dev/hyperv/vmbus modules/hyperv modules/hyperv/hvsock sys

2020-05-21 Thread Peter Holm
On Wed, May 20, 2020 at 11:03:59AM +, Wei Hu wrote: > Author: whu > Date: Wed May 20 11:03:59 2020 > New Revision: 361275 > URL: https://svnweb.freebsd.org/changeset/base/361275 > > Log: > HyperV socket implementation for FreeBSD > > This change adds Hyper-V socket feature in FreeBSD. N

Re: svn commit: r353292 - in head/sys: contrib/ipfilter/netinet dev/firewire dev/iicbus dev/usb/net kern net netgraph netinet netinet6 netipsec netpfil/ipfw netpfil/pf ofed/drivers/infiniband/ulp/ipoi

2019-10-07 Thread Peter Holm
On Mon, Oct 07, 2019 at 10:40:06PM +, Gleb Smirnoff wrote: > Author: glebius > Date: Mon Oct 7 22:40:05 2019 > New Revision: 353292 > URL: https://svnweb.freebsd.org/changeset/base/353292 > > Log: > Widen NET_EPOCH coverage. > This seems to trigger this: Autoloading module: uhid.ko Aut

Re: svn commit: r352658 - head/sys/kern

2019-09-24 Thread Peter Holm
On Tue, Sep 24, 2019 at 08:01:20PM +, Alexander Motin wrote: > Author: mav > Date: Tue Sep 24 20:01:20 2019 > New Revision: 352658 > URL: https://svnweb.freebsd.org/changeset/base/352658 > > Log: > Fix/improve interrupt threads scheduling. > > Doing some tests with very high interrupt r

Re: svn commit: r351522 - in head: sbin/ifconfig share/man/man4 sys/conf sys/kern sys/modules sys/modules/ktls_ocf sys/net sys/netinet sys/netinet/tcp_stacks sys/netinet6 sys/opencrypto sys/sys tools/

2019-08-27 Thread Peter Holm
On Tue, Aug 27, 2019 at 09:02:31AM -0700, John Baldwin wrote: > On 8/27/19 7:39 AM, Peter Holm wrote: > > On Tue, Aug 27, 2019 at 12:01:57AM +, John Baldwin wrote: > >> Author: jhb > >> Date: Tue Aug 27 00:01:56 2019 > >> New Revision: 351522 > >> U

Re: svn commit: r351522 - in head: sbin/ifconfig share/man/man4 sys/conf sys/kern sys/modules sys/modules/ktls_ocf sys/net sys/netinet sys/netinet/tcp_stacks sys/netinet6 sys/opencrypto sys/sys tools/

2019-08-27 Thread Peter Holm
On Tue, Aug 27, 2019 at 12:01:57AM +, John Baldwin wrote: > Author: jhb > Date: Tue Aug 27 00:01:56 2019 > New Revision: 351522 > URL: https://svnweb.freebsd.org/changeset/base/351522 > > Log: > Add kernel-side support for in-kernel TLS. > Could this be yours? 20190827 15:55:34 all (496

Re: svn commit: r344757 - head/sys/fs/ext2fs

2019-03-06 Thread Peter Holm
On Mon, Mar 04, 2019 at 11:33:49AM +, Fedor Uporov wrote: > Author: fsu > Date: Mon Mar 4 11:33:49 2019 > New Revision: 344757 > URL: https://svnweb.freebsd.org/changeset/base/344757 > > Log: > Fix double free in case of mount error. > > Reported by:Christopher Krah > Reported a

Re: svn commit: r339634 - in head/sys: kern net

2018-10-23 Thread Peter Holm
On Tue, Oct 23, 2018 at 04:37:29AM +, Eric Joyner wrote: > Author: erj > Date: Tue Oct 23 04:37:29 2018 > New Revision: 339634 > URL: https://svnweb.freebsd.org/changeset/base/339634 > > Log: > iflib: drain enqueued tasks before detaching from taskqgroup > > The taskqgroup_detach functi

Re: svn commit: r333744 - in head/sys: kern sys

2018-06-07 Thread Peter Holm
Jun 6, 2018 at 7:12 PM, Matthew Macy wrote: > > On Wed, Jun 6, 2018 at 12:03 PM, Peter Holm wrote: > >> On Thu, May 17, 2018 at 05:59:35PM +, Matt Macy wrote: > >>> Author: mmacy > >>> Date: Thu May 17 17:59:35 2018 > >>> New Revision:

Re: svn commit: r333744 - in head/sys: kern sys

2018-06-06 Thread Peter Holm
On Thu, May 17, 2018 at 05:59:35PM +, Matt Macy wrote: > Author: mmacy > Date: Thu May 17 17:59:35 2018 > New Revision: 333744 > URL: https://svnweb.freebsd.org/changeset/base/333744 > > Log: > AF_UNIX: make unix socket locking finer grained > > This change moves to using a reference co

Re: svn commit: r334305 - head/sys/net

2018-05-28 Thread Peter Holm
On Tue, May 29, 2018 at 12:53:54AM +, Matt Macy wrote: > Author: mmacy > Date: Tue May 29 00:53:53 2018 > New Revision: 334305 > URL: https://svnweb.freebsd.org/changeset/base/334305 > > Log: > route: fix missed ref adds >- ensure that we bump the ifa ref whenever we add a reference >

Re: svn commit: r333509 - in head/sys: dev/hwpmc kern sys

2018-05-12 Thread Peter Holm
On Sat, May 12, 2018 at 01:26:34AM +, Matt Macy wrote: > Author: mmacy > Date: Sat May 12 01:26:34 2018 > New Revision: 333509 > URL: https://svnweb.freebsd.org/changeset/base/333509 > > Log: > hwpmc(9): Make pmclog buffer pcpu and update constants > > On non-trivial SMP systems the con

Re: svn commit: r333480 - head/sys/kern

2018-05-11 Thread Peter Holm
May 11, 2018 at 12:29 AM, Matthew Macy wrote: > > Yes. Can you give me the line number for epoch_call_task+0x7b > > > > > > On Fri, May 11, 2018 at 12:18 AM, Peter Holm wrote: > >> On Fri, May 11, 2018 at 04:54:13AM +, Matt Macy wrote: > >>> Auth

Re: svn commit: r333480 - head/sys/kern

2018-05-11 Thread Peter Holm
ist); 562 } 563 sched_unbind(td); 564 thread_unlock(td); (kgdb) - Peter > > On Fri, May 11, 2018 at 12:18 AM, Peter Holm wrote: > > On Fri, May 11, 2018 at 04:54:13AM +, Matt Macy wrote: > >> Author: mmacy > >> Date: Fri May 1

Re: svn commit: r333480 - head/sys/kern

2018-05-11 Thread Peter Holm
On Fri, May 11, 2018 at 04:54:13AM +, Matt Macy wrote: > Author: mmacy > Date: Fri May 11 04:54:12 2018 > New Revision: 333480 > URL: https://svnweb.freebsd.org/changeset/base/333480 > > Log: > epoch(9): fix priority handling, make callback lists pcpu, and other fixes > > - Lend priorit

Re: svn commit: r329448 - head/sys/kern

2018-02-18 Thread Peter Holm
On Sat, Feb 17, 2018 at 07:47:38PM +0100, Mateusz Guzik wrote: > On Sat, Feb 17, 2018 at 7:42 PM, Peter Holm wrote: > > > On Sat, Feb 17, 2018 at 06:34:34PM +0100, Mateusz Guzik wrote: > > > On Sat, Feb 17, 2018 at 5:38 PM, Peter Holm wrote: > > > > > &g

Re: svn commit: r329448 - head/sys/kern

2018-02-17 Thread Peter Holm
On Sat, Feb 17, 2018 at 06:34:34PM +0100, Mateusz Guzik wrote: > On Sat, Feb 17, 2018 at 5:38 PM, Peter Holm wrote: > > > On Sat, Feb 17, 2018 at 06:26:32PM +0200, Konstantin Belousov wrote: > > > On Sat, Feb 17, 2018 at 05:07:07PM +0100, Mateusz Guzik wrote: > > >

Re: svn commit: r329448 - head/sys/kern

2018-02-17 Thread Peter Holm
ven for a case where > > it decides to report, I don't see anything which would depend on the > > suspending thread to finish. > It was definitely not harmless when I tried to avoid the spin lock there, > but I do not remember exact failure mode. Most likely, it was a missed

Re: svn commit: r328916 - in head/sys: kern vm

2018-02-07 Thread Peter Holm
On Wed, Feb 07, 2018 at 09:44:59AM -0800, Gleb Smirnoff wrote: > On Wed, Feb 07, 2018 at 08:46:19AM -0800, Gleb Smirnoff wrote: > T> On Wed, Feb 07, 2018 at 07:46:17AM +0100, Peter Holm wrote: > T> P> On Tue, Feb 06, 2018 at 04:45:49PM -0800, Gleb Smirnoff wrote: > T> P>

Re: svn commit: r328916 - in head/sys: kern vm

2018-02-07 Thread Peter Holm
On Wed, Feb 07, 2018 at 08:46:19AM -0800, Gleb Smirnoff wrote: > On Wed, Feb 07, 2018 at 07:46:17AM +0100, Peter Holm wrote: > P> On Tue, Feb 06, 2018 at 04:45:49PM -0800, Gleb Smirnoff wrote: > P> > On Tue, Feb 06, 2018 at 04:42:13PM -0800, Gleb Smirnoff wrote: > P> &

Re: svn commit: r328916 - in head/sys: kern vm

2018-02-06 Thread Peter Holm
On Wed, Feb 07, 2018 at 07:46:17AM +0100, Peter Holm wrote: > On Tue, Feb 06, 2018 at 04:45:49PM -0800, Gleb Smirnoff wrote: > > On Tue, Feb 06, 2018 at 04:42:13PM -0800, Gleb Smirnoff wrote: > > T> Hi Peter, > > T> > > T> can you please try this patch?

Re: svn commit: r328916 - in head/sys: kern vm

2018-02-06 Thread Peter Holm
On Tue, Feb 06, 2018 at 04:45:49PM -0800, Gleb Smirnoff wrote: > On Tue, Feb 06, 2018 at 04:42:13PM -0800, Gleb Smirnoff wrote: > T> Hi Peter, > T> > T> can you please try this patch? In either case success > T> or not, please provide me with dmesg. Thanks a lot! > > Sorry, patch was missing

Re: svn commit: r328916 - in head/sys: kern vm

2018-02-06 Thread Peter Holm
On Tue, Feb 06, 2018 at 03:06:35PM -0800, Gleb Smirnoff wrote: > On Tue, Feb 06, 2018 at 11:52:44PM +0100, Peter Holm wrote: > P> On Tue, Feb 06, 2018 at 02:15:55PM -0800, Gleb Smirnoff wrote: > P> > Peter, > P> > > P> > can you please check post r328952

Re: svn commit: r328916 - in head/sys: kern vm

2018-02-06 Thread Peter Holm
On Tue, Feb 06, 2018 at 02:15:55PM -0800, Gleb Smirnoff wrote: > Peter, > > can you please check post r328952 kernel? > Sure. FreeBSD 12.0-CURRENT #0 r328956: Tue Feb 6 23:26:58 CET 2018 p...@x4.osted.lan:/usr/src/sys/i386/compile/PHO i386 FreeBSD clang version 6.0.0 (branches/release_

Re: svn commit: r328916 - in head/sys: kern vm

2018-02-06 Thread Peter Holm
On Tue, Feb 06, 2018 at 10:28:39AM -0800, Gleb Smirnoff wrote: > Peter, > > On Tue, Feb 06, 2018 at 12:30:17PM +0100, Peter Holm wrote: > P> i386 also doesn't boot: > P> > P> FreeBSD 12.0-CURRENT #1 r328924: Tue Feb 6 11:51:17 CET 2018 > P> p...@x4.o

Re: svn commit: r328916 - in head/sys: kern vm

2018-02-06 Thread Peter Holm
On Tue, Feb 06, 2018 at 04:16:00AM +, Gleb Smirnoff wrote: > Author: glebius > Date: Tue Feb 6 04:16:00 2018 > New Revision: 328916 > URL: https://svnweb.freebsd.org/changeset/base/328916 > > Log: > Followup on r302393 by cperciva, improving calculation of boot pages > required > for UMA

Re: svn commit: r327168 - head/sys/vm

2017-12-25 Thread Peter Holm
On Mon, Dec 25, 2017 at 11:51:17AM -0800, Mark Johnston wrote: > On Mon, Dec 25, 2017 at 06:49:46PM +0100, Peter Holm wrote: > > On Sun, Dec 24, 2017 at 07:45:16PM +, Mark Johnston wrote: > > > Author: markj > > > Date: Sun Dec 24 19:45:16 2017 > > > N

Re: svn commit: r327168 - head/sys/vm

2017-12-25 Thread Peter Holm
On Sun, Dec 24, 2017 at 07:45:16PM +, Mark Johnston wrote: > Author: markj > Date: Sun Dec 24 19:45:16 2017 > New Revision: 327168 > URL: https://svnweb.freebsd.org/changeset/base/327168 > > Log: > Fix two problems with the page daemon control loop. > > Both issues caused the page daemo

Re: svn commit: r326200 - head/sys/kern

2017-11-29 Thread Peter Holm
PM, Alan Somers wrote: > > > On Sun, Nov 26, 2017 at 11:49 PM, Peter Holm wrote: > > > On Sun, Nov 26, 2017 at 10:11:21PM +0100, Mateusz Guzik wrote: > > >> On Sun, Nov 26, 2017 at 7:49 AM, Peter Holm wrote: > > >> > > >> > On Sa

Re: svn commit: r326200 - head/sys/kern

2017-11-26 Thread Peter Holm
On Sun, Nov 26, 2017 at 10:11:21PM +0100, Mateusz Guzik wrote: > On Sun, Nov 26, 2017 at 7:49 AM, Peter Holm wrote: > > > On Sat, Nov 25, 2017 at 08:49:27PM +, Mateusz Guzik wrote: > > > Author: mjg > > > Date: Sat Nov 25 20:49:27 2017 > > >

Re: svn commit: r326200 - head/sys/kern

2017-11-25 Thread Peter Holm
On Sat, Nov 25, 2017 at 08:49:27PM +, Mateusz Guzik wrote: > Author: mjg > Date: Sat Nov 25 20:49:27 2017 > New Revision: 326200 > URL: https://svnweb.freebsd.org/changeset/base/326200 > > Log: > Add the missing lockstat check for thread lock. > > Modified: > head/sys/kern/kern_mutex.c >

Re: svn commit: r319921 - head/sys/net

2017-06-15 Thread Peter Holm
On Wed, Jun 14, 2017 at 09:21:30AM -0600, Sean Bruno wrote: > > > On 06/14/17 08:46, Peter Holm wrote: > > On Wed, Jun 14, 2017 at 08:38:36AM -0600, Sean Bruno wrote: > >> > >> > >> On 06/14/17 03:17, Peter Holm wrote: > >>> On T

Re: svn commit: r319921 - head/sys/net

2017-06-14 Thread Peter Holm
On Wed, Jun 14, 2017 at 09:21:30AM -0600, Sean Bruno wrote: > > > On 06/14/17 08:46, Peter Holm wrote: > > On Wed, Jun 14, 2017 at 08:38:36AM -0600, Sean Bruno wrote: > >> > >> > >> On 06/14/17 03:17, Peter Holm wrote: > >>> On T

Re: svn commit: r319921 - head/sys/net

2017-06-14 Thread Peter Holm
On Wed, Jun 14, 2017 at 08:38:36AM -0600, Sean Bruno wrote: > > > On 06/14/17 03:17, Peter Holm wrote: > > On Tue, Jun 13, 2017 at 11:16:39PM +, Sean Bruno wrote: > >> Author: sbruno > >> Date: Tue Jun 13 23:16:38 2017 > >> New Revision: 319921 >

Re: svn commit: r319921 - head/sys/net

2017-06-14 Thread Peter Holm
On Tue, Jun 13, 2017 at 11:16:39PM +, Sean Bruno wrote: > Author: sbruno > Date: Tue Jun 13 23:16:38 2017 > New Revision: 319921 > URL: https://svnweb.freebsd.org/changeset/base/319921 > > Log: > Add new sysctl to allow changing of timing of the txq timers. > > Add new sysctl to overrid

Re: svn commit: r278623 - head/sys/kern

2015-02-13 Thread Peter Holm
ade it so that it > > would separate out direct/vs/non-direct. This is incorrect and can > > cause panics as Peter Holm has found for me (Thanks so much Peter for > > all your help in this). What this change does is restore that behavior > > but also get rid of the

Re: svn commit: r278472 - in head/sys: netinet netinet6

2015-02-10 Thread Peter Holm
On Tue, Feb 10, 2015 at 01:12:45AM -0500, randall wrote: > Peter: > > I am not sure what you mean.. :-) > I just realized that the reported panic is in r278471. I'm not able to reproduce the problem with r278472. Sorry for having wasted your time! - Peter _

Re: svn commit: r278472 - in head/sys: netinet netinet6

2015-02-09 Thread Peter Holm
On Mon, Feb 09, 2015 at 07:28:12PM +, Randall Stewart wrote: > Author: rrs > Date: Mon Feb 9 19:28:11 2015 > New Revision: 278472 > URL: https://svnweb.freebsd.org/changeset/base/278472 > > Log: > This fixes a bug in the way that the LLE timers for nd6 > and arp were being used. They basi

Re: svn commit: r271635 - in head: lib/libc/sys sys/vm

2014-09-16 Thread Peter Holm
On Mon, Sep 15, 2014 at 05:20:13PM +, John Baldwin wrote: > Author: jhb > Date: Mon Sep 15 17:20:13 2014 > New Revision: 271635 > URL: http://svnweb.freebsd.org/changeset/base/271635 > > Log: > Add stricter checking of some mmap() arguments: > - Fail with EINVAL if an invalid protection ma

svn commit: r265534 - in head: lib/libc/sys sys/vm

2014-05-07 Thread Peter Holm
Author: pho Date: Wed May 7 08:38:02 2014 New Revision: 265534 URL: http://svnweb.freebsd.org/changeset/base/265534 Log: msync(2) must return ENOMEM and not EINVAL when the address is outside the allowed range or when one or more pages are not mapped. This according to The Open Group Base S

svn commit: r263336 - head/tests/sys/kern

2014-03-19 Thread Peter Holm
Author: pho Date: Wed Mar 19 09:41:12 2014 New Revision: 263336 URL: http://svnweb.freebsd.org/changeset/base/263336 Log: Added sysctl kern.maxfiles increase test, do not use /etc/passwd for tests and use volatile sig_atomic_t for signal handler variable. Reviewed by: asomers (previous

svn commit: r262781 - head/tests/sys/kern

2014-03-05 Thread Peter Holm
Author: pho Date: Wed Mar 5 08:33:58 2014 New Revision: 262781 URL: http://svnweb.freebsd.org/changeset/base/262781 Log: Preserve naming consistency for test cases. Pointed out by:jmmv Sponsored by: EMC / Isilon storage division Modified: head/tests/sys/kern/kern_descrip_test.

svn commit: r262730 - head/tests/sys/kern

2014-03-04 Thread Peter Holm
Author: pho Date: Tue Mar 4 10:47:35 2014 New Revision: 262730 URL: http://svnweb.freebsd.org/changeset/base/262730 Log: Changed name of test case to a more descriptive one and moved comment to the "descr" property. Suggested by: jmmv Sponsored by: EMC / Isilon storage division Modif

svn commit: r262526 - head/tests/sys/kern

2014-02-26 Thread Peter Holm
Author: pho Date: Wed Feb 26 09:08:25 2014 New Revision: 262526 URL: http://svnweb.freebsd.org/changeset/base/262526 Log: Added a regression test for r234131. Discussed with:asomers Sponsored by: EMC / Isilon storage division Added: head/tests/sys/kern/kern_descrip_test.c (co

svn commit: r254558 - head/sys/kern

2013-08-20 Thread Peter Holm
Author: pho Date: Tue Aug 20 11:06:56 2013 New Revision: 254558 URL: http://svnweb.freebsd.org/changeset/base/254558 Log: Added sysctl to turn off calls to vmem_check(). Sponsored by: EMC / Isilon storage division Discussed with:jeff Modified: head/sys/kern/subr_vmem.c Modifie

svn commit: r247399 - head/sbin/tunefs

2013-02-27 Thread Peter Holm
Author: pho Date: Wed Feb 27 18:12:04 2013 New Revision: 247399 URL: http://svnweb.freebsd.org/changeset/base/247399 Log: The .journal file needs to reside on the ROOTINO which must not extend beyond direct blocks. A typo caused this check to fail. Modified: head/sbin/tunefs/tunefs.c Modif

svn commit: r237219 - head/sys/kern

2012-06-18 Thread Peter Holm
Author: pho Date: Mon Jun 18 07:34:38 2012 New Revision: 237219 URL: http://svn.freebsd.org/changeset/base/237219 Log: In tty_makedev() the following construction: dev = make_dev_cred(); dev->si_drv1 = tp; leaves a small window where the newly created device may be opened and si_dr

svn commit: r234932 - head/sys/dev/sound/pcm

2012-05-02 Thread Peter Holm
Author: pho Date: Wed May 2 19:32:11 2012 New Revision: 234932 URL: http://svn.freebsd.org/changeset/base/234932 Log: Added D_TRACKCLOSE to sndstat_cdevsw to fix the situation when another process is in open() or stat() for the device node, then close() from the owning process does not resu

Re: svn commit: r232702 - head/sys/kern

2012-04-24 Thread Peter Holm
On Tue, Apr 24, 2012 at 07:50:12PM +0400, Dmitry Morozovsky wrote: > Dear Peter, > > On Thu, 8 Mar 2012, Peter Holm wrote: > > > Author: pho > > Date: Thu Mar 8 20:34:13 2012 > > New Revision: 232702 > > URL: http://svn.freebsd.org/changeset/base/232702 &

svn commit: r232860 - head/sys/kern

2012-03-12 Thread Peter Holm
Author: pho Date: Mon Mar 12 11:56:57 2012 New Revision: 232860 URL: http://svn.freebsd.org/changeset/base/232860 Log: Allways call fdrop(). Modified: head/sys/kern/sys_capability.c Modified: head/sys/kern/sys_capability.c =

svn commit: r232750 - head/sys/kern

2012-03-09 Thread Peter Holm
Author: pho Date: Fri Mar 9 21:31:12 2012 New Revision: 232750 URL: http://svn.freebsd.org/changeset/base/232750 Log: Perform the parameter validation before assigning it to a signed int variable. This fixes the problem seen with readdir(3) fuzzing. Submitted by: bde MFC after:1 we

svn commit: r232732 - head/sys/ufs/ffs

2012-03-09 Thread Peter Holm
Author: pho Date: Fri Mar 9 17:19:50 2012 New Revision: 232732 URL: http://svn.freebsd.org/changeset/base/232732 Log: Revert r232692 as the correct place to fix this is at the syscall level. Modified: head/sys/ufs/ffs/ffs_vnops.c Modified: head/sys/ufs/ffs/ffs_vnops.c ==

Re: svn commit: r232692 - head/sys/ufs/ffs

2012-03-09 Thread Peter Holm
On Sat, Mar 10, 2012 at 01:48:20AM +1100, Bruce Evans wrote: > On Fri, 9 Mar 2012, Peter Holm wrote: > > >On Fri, Mar 09, 2012 at 03:51:30PM +1100, Bruce Evans wrote: > >>On Thu, 8 Mar 2012, Peter Holm wrote: > >> > >>>Log: > >>>syscall()

Re: svn commit: r232692 - head/sys/ufs/ffs

2012-03-08 Thread Peter Holm
On Fri, Mar 09, 2012 at 03:51:30PM +1100, Bruce Evans wrote: > On Thu, 8 Mar 2012, Peter Holm wrote: > > >Log: > > syscall() fuzzing can trigger this panic. Return EINVAL instead. > > > > MFC after: 1 week > > If so, then, this is not the place to hide the bu

svn commit: r232702 - head/sys/kern

2012-03-08 Thread Peter Holm
Author: pho Date: Thu Mar 8 20:34:13 2012 New Revision: 232702 URL: http://svn.freebsd.org/changeset/base/232702 Log: Free up allocated memory used by posix_fadvise(2). Modified: head/sys/kern/kern_descrip.c head/sys/kern/vfs_syscalls.c Modified: head/sys/kern/kern_descrip.c =

svn commit: r232692 - head/sys/ufs/ffs

2012-03-08 Thread Peter Holm
Author: pho Date: Thu Mar 8 12:49:08 2012 New Revision: 232692 URL: http://svn.freebsd.org/changeset/base/232692 Log: syscall() fuzzing can trigger this panic. Return EINVAL instead. MFC after:1 week Modified: head/sys/ufs/ffs/ffs_vnops.c Modified: head/sys/ufs/ffs/ffs_vnops.c

Re: svn commit: r226967 - head/sys/ufs/ufs

2012-03-05 Thread Peter Holm
On Mon, Mar 05, 2012 at 12:38:57PM -0500, John Baldwin wrote: > On Saturday, March 03, 2012 11:38:43 am Peter Holm wrote: > > On Sat, Mar 03, 2012 at 01:01:32AM -0500, Rick Macklem wrote: > > > John Baldwin wrote: > > > > On Friday, March 02, 2012 8:29:21 am Peter Hol

Re: svn commit: r226967 - head/sys/ufs/ufs

2012-03-03 Thread Peter Holm
On Sat, Mar 03, 2012 at 01:01:32AM -0500, Rick Macklem wrote: > John Baldwin wrote: > > On Friday, March 02, 2012 8:29:21 am Peter Holm wrote: > > > On Thu, Mar 01, 2012 at 04:47:41PM -0500, John Baldwin wrote: > > > > On Monday, October 31, 2011 11:01:47 am Peter Hol

Re: svn commit: r226967 - head/sys/ufs/ufs

2012-03-02 Thread Peter Holm
On Fri, Mar 02, 2012 at 11:53:06AM -0500, John Baldwin wrote: > On Friday, March 02, 2012 8:29:21 am Peter Holm wrote: > > On Thu, Mar 01, 2012 at 04:47:41PM -0500, John Baldwin wrote: > > > On Monday, October 31, 2011 11:01:47 am Peter Holm wrote: > > > > Author: p

Re: svn commit: r226967 - head/sys/ufs/ufs

2012-03-02 Thread Peter Holm
On Thu, Mar 01, 2012 at 04:47:41PM -0500, John Baldwin wrote: > On Monday, October 31, 2011 11:01:47 am Peter Holm wrote: > > Author: pho > > Date: Mon Oct 31 15:01:47 2011 > > New Revision: 226967 > > URL: http://svn.freebsd.org/changeset/base/226967 > > > &g

Re: svn commit: r226967 - head/sys/ufs/ufs

2012-03-01 Thread Peter Holm
On Thu, Mar 01, 2012 at 04:47:41PM -0500, John Baldwin wrote: > On Monday, October 31, 2011 11:01:47 am Peter Holm wrote: > > Author: pho > > Date: Mon Oct 31 15:01:47 2011 > > New Revision: 226967 > > URL: http://svn.freebsd.org/changeset/base/226967 > > > &g

svn commit: r228360 - head/sys/kern

2011-12-09 Thread Peter Holm
Author: pho Date: Fri Dec 9 17:19:41 2011 New Revision: 228360 URL: http://svn.freebsd.org/changeset/base/228360 Log: Move cpu_set_upcall(newtd, td) up before the first call of thread_free(newtd). This to avoid a possible page fault in cpu_thread_clean() as seen on amd64 with syscall fuzzi

svn commit: r228221 - head/sys/kern

2011-12-03 Thread Peter Holm
Author: pho Date: Sat Dec 3 12:35:13 2011 New Revision: 228221 URL: http://svn.freebsd.org/changeset/base/228221 Log: Use umtx_copyin_timeout() to copy and check timeout parameter. In collaboration with:kib MFC after:1 week Modified: head/sys/kern/kern_thr.c Modified: hea

svn commit: r228220 - head/sys/sys

2011-12-03 Thread Peter Holm
Author: pho Date: Sat Dec 3 12:33:17 2011 New Revision: 228220 URL: http://svn.freebsd.org/changeset/base/228220 Log: Add declaration of umtx_copyin_timeout() In collaboration with:kib MFC after:1 week Modified: head/sys/sys/umtx.h Modified: head/sys/sys/umtx.h ==

svn commit: r228219 - head/sys/kern

2011-12-03 Thread Peter Holm
Author: pho Date: Sat Dec 3 12:30:58 2011 New Revision: 228219 URL: http://svn.freebsd.org/changeset/base/228219 Log: Add umtx_copyin_timeout() and move parameter checks here. In collaboration with:kib MFC after:1 week Modified: head/sys/kern/kern_umtx.c Modified: head/sy

svn commit: r228218 - head/sys/kern

2011-12-03 Thread Peter Holm
Author: pho Date: Sat Dec 3 12:28:33 2011 New Revision: 228218 URL: http://svn.freebsd.org/changeset/base/228218 Log: Rename copyin_timeout32 to umtx_copyin_timeout32 and move parameter check here. Include check for negative seconds value. In collaboration with:kib MFC after:

svn commit: r227674 - head/sys/kern

2011-11-18 Thread Peter Holm
Author: pho Date: Fri Nov 18 19:14:42 2011 New Revision: 227674 URL: http://svn.freebsd.org/changeset/base/227674 Log: Added check for negative seconds value. Found by syscall() fuzzing. MFC after:1 week Modified: head/sys/kern/kern_thr.c Modified: head/sys/kern/kern_thr.c =

svn commit: r227550 - head/sys/fs/pseudofs

2011-11-16 Thread Peter Holm
Author: pho Date: Wed Nov 16 10:11:55 2011 New Revision: 227550 URL: http://svn.freebsd.org/changeset/base/227550 Log: Handle invalid large values for getdirentries(2) data buffer size. In collaboration with:kib Reviewed by: des Reported by: The iknowthis syscall fuzzer. MFC

svn commit: r227527 - head/sys/fs/pseudofs

2011-11-15 Thread Peter Holm
Author: pho Date: Tue Nov 15 09:23:21 2011 New Revision: 227527 URL: http://svn.freebsd.org/changeset/base/227527 Log: Removed extra PRELE() call. MFC after:1 week Modified: head/sys/fs/pseudofs/pseudofs_vnops.c Modified: head/sys/fs/pseudofs/pseudofs_vnops.c ===

svn commit: r226987 - head/sys/fs/tmpfs

2011-11-01 Thread Peter Holm
Author: pho Date: Tue Nov 1 12:33:06 2011 New Revision: 226987 URL: http://svn.freebsd.org/changeset/base/226987 Log: Added missing cache purge of from argument for rename(). Reported by: Anton Yuzhaninov In collaboration with:kib MFC after:1 week Modified: head/sys/fs

svn commit: r226971 - head/sys/ufs/ufs

2011-10-31 Thread Peter Holm
Author: pho Date: Mon Oct 31 20:24:33 2011 New Revision: 226971 URL: http://svn.freebsd.org/changeset/base/226971 Log: Fix the wrong commit log message for r226967: "Added missing cache purge of from argument" and fix the comment. Modified: head/sys/ufs/ufs/ufs_vnops.c Modified: head/sys/u

Re: svn commit: r226967 - head/sys/ufs/ufs

2011-10-31 Thread Peter Holm
On Mon, Oct 31, 2011 at 12:41:41PM -0400, John Baldwin wrote: > On Monday, October 31, 2011 11:01:47 am Peter Holm wrote: > > Author: pho > > Date: Mon Oct 31 15:01:47 2011 > > New Revision: 226967 > > URL: http://svn.freebsd.org/changeset/base/226967 > > > &g

svn commit: r226967 - head/sys/ufs/ufs

2011-10-31 Thread Peter Holm
Author: pho Date: Mon Oct 31 15:01:47 2011 New Revision: 226967 URL: http://svn.freebsd.org/changeset/base/226967 Log: The kern_renameat() looks up the fvp using the DELETE flag, which causes the removal of the name cache entry for fvp. Reported by: Anton Yuzhaninov In collaboration w

svn commit: r226681 - head/sys/fs/nullfs

2011-10-24 Thread Peter Holm
Author: pho Date: Mon Oct 24 10:35:37 2011 New Revision: 226681 URL: http://svn.freebsd.org/changeset/base/226681 Log: Only unlock if the lock is exclusive. Reported by: Subbsd Discussed with: kib Modified: head/sys/fs/nullfs/null_vfsops.c Modified: head/sys/fs/nullfs/null_vfs

svn commit: r215950 - head/sys/ufs/ffs

2010-11-27 Thread Peter Holm
Author: pho Date: Sat Nov 27 20:27:07 2010 New Revision: 215950 URL: http://svn.freebsd.org/changeset/base/215950 Log: First step in fixing the handle_workitem_freeblocks panic. In collaboration with: kib Modified: head/sys/ufs/ffs/ffs_softdep.c Modified: head/sys/ufs/ffs/ffs_so

Re: svn commit: r213714 - in head/sys: kern sys

2010-10-14 Thread Peter Holm
On Tue, Oct 12, 2010 at 12:36:56AM +, David Xu wrote: > Author: davidxu > Date: Tue Oct 12 00:36:56 2010 > New Revision: 213714 > URL: http://svn.freebsd.org/changeset/base/213714 > > Log: > Add a flag TDF_TIDHASH to prevent a thread from being > added to or removed from thread hash table

svn commit: r213568 - head/sys/boot/i386/gptboot

2010-10-08 Thread Peter Holm
Author: pho Date: Fri Oct 8 10:27:52 2010 New Revision: 213568 URL: http://svn.freebsd.org/changeset/base/213568 Log: Ensure that a make from sys/boot does not pick up include files from /usr/include. Discussed with:kib Modified: head/sys/boot/i386/gptboot/Makefile Modified:

Re: svn commit: r210926 - head/sys/dev/null

2010-08-06 Thread Peter Holm
On Fri, Aug 06, 2010 at 09:47:48AM +, Konstantin Belousov wrote: > Author: kib > Date: Fri Aug 6 09:47:48 2010 > New Revision: 210926 > URL: http://svn.freebsd.org/changeset/base/210926 > > Log: > Mark /dev/zero and /dev/null as eternal. > > In collaboration with: pho > MFC afte