Re: svn commit: r211318 - head/usr.sbin/sysinstall

2010-08-19 Thread Alexey Dokuchaev
On Thu, Aug 19, 2010 at 11:33:31AM +0200, Dag-Erling Sm??rgrav wrote: > Peter Jeremy writes: > > Probably a good example of why the Project's guidelines require the > > separation of whitespace and functional changes. > > Well, the second-to-last hunk is not really a functional change either. Ri

Re: svn commit: r211318 - head/usr.sbin/sysinstall

2010-08-19 Thread Dag-Erling Smørgrav
Peter Jeremy writes: > Probably a good example of why the Project's guidelines require the > separation of whitespace and functional changes. Well, the second-to-last hunk is not really a functional change either. DES -- Dag-Erling Smørgrav - d...@des.no

Re: svn commit: r211318 - head/usr.sbin/sysinstall

2010-08-18 Thread Alexey Dokuchaev
On Thu, Aug 19, 2010 at 06:37:30AM +1000, Peter Jeremy wrote: > On 2010-Aug-18 19:30:13 +, Alexey Dokuchaev wrote: > >Actually, I did; but the last hunk is just a whitespace change, > >irrelevant to the commit message (just as most of the other hunks). > >No wonder I missed the hunk before the

Re: svn commit: r211318 - head/usr.sbin/sysinstall

2010-08-18 Thread Peter Jeremy
On 2010-Aug-18 19:30:13 +, Alexey Dokuchaev wrote: >Actually, I did; but the last hunk is just a whitespace change, >irrelevant to the commit message (just as most of the other hunks). >No wonder I missed the hunk before the last one. Probably a good example of why the Project's guidelines re

Re: svn commit: r211318 - head/usr.sbin/sysinstall

2010-08-18 Thread Alexey Dokuchaev
On Wed, Aug 18, 2010 at 11:01:49AM +0200, Dag-Erling Sm??rgrav wrote: > Alexey Dokuchaev writes: > > Jens Schweikhardt writes: > > > Log: > > > Correctly spell janice and jimmy as janis and jimi (assuming > > > the famous rock stars meant were Miss Joplin and Mr Hendrix.) > > Are you sure thi

Re: svn commit: r211318 - head/usr.sbin/sysinstall

2010-08-18 Thread Dag-Erling Smørgrav
Alexey Dokuchaev writes: > Jens Schweikhardt writes: > > Log: > > Correctly spell janice and jimmy as janis and jimi (assuming > > the famous rock stars meant were Miss Joplin and Mr Hendrix.) > Are you sure this is correct message for the commit, or I am simply > missing the irony? Look at

Re: svn commit: r211318 - head/usr.sbin/sysinstall

2010-08-17 Thread Alexey Dokuchaev
On Sat, Aug 14, 2010 at 09:48:22PM +, Jens Schweikhardt wrote: > Author: schweikh > Date: Sat Aug 14 21:48:22 2010 > New Revision: 211318 > URL: http://svn.freebsd.org/changeset/base/211318 > > Log: > Correctly spell janice and jimmy as janis and jimi (assuming > the famous rock stars mean

svn commit: r211318 - head/usr.sbin/sysinstall

2010-08-14 Thread Jens Schweikhardt
Author: schweikh Date: Sat Aug 14 21:48:22 2010 New Revision: 211318 URL: http://svn.freebsd.org/changeset/base/211318 Log: Correctly spell janice and jimmy as janis and jimi (assuming the famous rock stars meant were Miss Joplin and Mr Hendrix.) Modified: head/usr.sbin/sysinstall/config.c