Re: svn commit: r218232 - head/sys/netinet

2011-02-05 Thread Robert Watson
On Fri, 4 Feb 2011, Robert N. M. Watson wrote: On 4 Feb 2011, at 10:56, John Baldwin wrote: The difference here is that FOREACH_THREAD_IN_PROC() is just a TAILQ_FOREACH(). The CPU iterators are more complex. I agree that that we should have topology-aware iterators, though part of the pro

Re: svn commit: r218232 - head/sys/netinet

2011-02-04 Thread Robert N. M. Watson
On 4 Feb 2011, at 10:56, John Baldwin wrote: > The difference here is that FOREACH_THREAD_IN_PROC() is just a > TAILQ_FOREACH(). The CPU iterators are more complex. > > I agree that that we should have topology-aware iterators, though part of the > problem is what do you iterate? We'd have to

Re: svn commit: r218232 - head/sys/netinet

2011-02-04 Thread John Baldwin
On Friday, February 04, 2011 1:30:33 pm Julian Elischer wrote: > On 2/4/11 9:38 AM, Robert Watson wrote: > > > > On Thu, 3 Feb 2011, John Baldwin wrote: > > > >>> 1) Move per John Baldwin to mp_maxid > >>> 2) Some signed/unsigned errors found by Mac OS compiler (from > >>> Michael) > >>> 3)

Re: svn commit: r218232 - head/sys/netinet

2011-02-04 Thread Julian Elischer
On 2/4/11 9:38 AM, Robert Watson wrote: On Thu, 3 Feb 2011, John Baldwin wrote: 1) Move per John Baldwin to mp_maxid 2) Some signed/unsigned errors found by Mac OS compiler (from Michael) 3) a couple of copyright updates on the effected files. Note that mp_maxid is the maxium valid I

Re: svn commit: r218232 - head/sys/netinet

2011-02-04 Thread Robert Watson
On Thu, 3 Feb 2011, John Baldwin wrote: 1) Move per John Baldwin to mp_maxid 2) Some signed/unsigned errors found by Mac OS compiler (from Michael) 3) a couple of copyright updates on the effected files. Note that mp_maxid is the maxium valid ID, so you typically have to do things like

Re: svn commit: r218232 - head/sys/netinet

2011-02-03 Thread Juli Mallett
On Thu, Feb 3, 2011 at 12:29, John Baldwin wrote: >>               ip = mtod(m, struct ip *); >>               offset = off + sizeof(*sh); >>               if (SCTP_BUF_LEN(m) < offset) { >> @@ -5944,7 +5947,7 @@ sctp_input(struct mbuf *m, int off) >>                       ip = mtod(m, struct ip *

Re: svn commit: r218232 - head/sys/netinet

2011-02-03 Thread John Baldwin
On Thursday, February 03, 2011 2:22:21 pm Randall Stewart wrote: > Author: rrs > Date: Thu Feb 3 19:22:21 2011 > New Revision: 218232 > URL: http://svn.freebsd.org/changeset/base/218232 > > Log: > 1) Move per John Baldwin to mp_maxid > 2) Some signed/unsigned errors found by Mac OS compiler (

svn commit: r218232 - head/sys/netinet

2011-02-03 Thread Randall Stewart
Author: rrs Date: Thu Feb 3 19:22:21 2011 New Revision: 218232 URL: http://svn.freebsd.org/changeset/base/218232 Log: 1) Move per John Baldwin to mp_maxid 2) Some signed/unsigned errors found by Mac OS compiler (from Michael) 3) a couple of copyright updates on the effected files. MFC