Re: svn commit: r220736 - head/sbin/natd

2011-04-18 Thread Maxim Sobolev
On 4/18/2011 3:12 PM, YongHyeon PYUN wrote: SYNCDHCP may restore old behavior of dhclient. Thanks, but I would rather not. -dynamic kinda suggests that the interface can go up and down, so if natd running in the background can handle this condition gracefully instead of silently exit this wou

Re: svn commit: r220736 - head/sbin/natd

2011-04-18 Thread Maxim Sobolev
On 4/18/2011 3:26 PM, Garrett Cooper wrote: And I don't see any problem with natd waiting indefinitely on the interface to acquire IP address, it's no better and no worse than the current behavior when the natd simply bails out. If it does this when backgrounded, that seems ok. If it blocks for

Re: svn commit: r220736 - head/sbin/natd

2011-04-18 Thread YongHyeon PYUN
On Mon, Apr 18, 2011 at 02:44:35PM -0700, Maxim Sobolev wrote: > On 4/18/2011 11:13 AM, Gleb Smirnoff wrote: > >This looks like a hack and better place for this hack would be shell > >scripts rather than nat daemon. > > Well, I am not sure how would you apply shell script in such case. The > prob

Re: svn commit: r220736 - head/sbin/natd

2011-04-18 Thread Garrett Cooper
2011/4/18 Maxim Sobolev : > On 4/18/2011 11:13 AM, Gleb Smirnoff wrote: >> >> This looks like a hack and better place for this hack would be shell >> scripts rather than nat daemon. > > Well, I am not sure how would you apply shell script in such case. The > problem with the original code is that n

Re: svn commit: r220736 - head/sbin/natd

2011-04-18 Thread Gleb Smirnoff
On Mon, Apr 18, 2011 at 02:44:35PM -0700, Maxim Sobolev wrote: M> On 4/18/2011 11:13 AM, Gleb Smirnoff wrote: M> > This looks like a hack and better place for this hack would be shell M> > scripts rather than nat daemon. M> M> Well, I am not sure how would you apply shell script in such case. The

Re: svn commit: r220736 - head/sbin/natd

2011-04-18 Thread Maxim Sobolev
On 4/18/2011 2:46 PM, Maxim Sobolev wrote: Well, as I already said I don't see any problem with natd waiting on interface to get IP address in all cases. This is no better or no worse than just bailing out, except it will make things working automatically once IP address has been provisioned. G

Re: svn commit: r220736 - head/sbin/natd

2011-04-18 Thread Maxim Sobolev
On 4/18/2011 12:42 PM, Garrett Cooper wrote: +1 -- in particular because this will affect all cases, and not just the dhclient-acquired IP external NIC case as the above commit message notes. Well, as I already said I don't see any problem with natd waiting on interface to get IP address

Re: svn commit: r220736 - head/sbin/natd

2011-04-18 Thread Maxim Sobolev
On 4/18/2011 11:13 AM, Gleb Smirnoff wrote: This looks like a hack and better place for this hack would be shell scripts rather than nat daemon. Well, I am not sure how would you apply shell script in such case. The problem with the original code is that natd just silently exits, leaving mach

Re: svn commit: r220736 - head/sbin/natd

2011-04-18 Thread Garrett Cooper
2011/4/18 Gleb Smirnoff : > On Sun, Apr 17, 2011 at 06:05:38AM +, Maxim Sobolev wrote: > M> Author: sobomax > M> Date: Sun Apr 17 06:05:37 2011 > M> New Revision: 220736 > M> URL: http://svn.freebsd.org/changeset/base/220736 > M> > M> Log: > M>   If we can retrieve interface address sleep for o

Re: svn commit: r220736 - head/sbin/natd

2011-04-18 Thread Gleb Smirnoff
On Sun, Apr 17, 2011 at 06:05:38AM +, Maxim Sobolev wrote: M> Author: sobomax M> Date: Sun Apr 17 06:05:37 2011 M> New Revision: 220736 M> URL: http://svn.freebsd.org/changeset/base/220736 M> M> Log: M> If we can retrieve interface address sleep for one second and try again. M> This can ha

svn commit: r220736 - head/sbin/natd

2011-04-16 Thread Maxim Sobolev
Author: sobomax Date: Sun Apr 17 06:05:37 2011 New Revision: 220736 URL: http://svn.freebsd.org/changeset/base/220736 Log: If we can retrieve interface address sleep for one second and try again. This can happen during start-up, when natd starts before dhclient has a chance to receive IP add