Author: ed
Date: Sun Nov 6 19:01:41 2011
New Revision: 227251
URL: http://svn.freebsd.org/changeset/base/227251
Log:
Mark global functions and/or variables in chown(8) static where possible.
This allows compilers and static analyzers to do more thorough analysis.
Modified:
head/usr.sbin/chown/chown.c
Modified: head/usr.sbin/chown/chown.c
==============================================================================
--- head/usr.sbin/chown/chown.c Sun Nov 6 19:01:35 2011 (r227250)
+++ head/usr.sbin/chown/chown.c Sun Nov 6 19:01:41 2011 (r227251)
@@ -57,16 +57,16 @@ __FBSDID("$FreeBSD$");
#include <string.h>
#include <unistd.h>
-void a_gid(const char *);
-void a_uid(const char *);
-void chownerr(const char *);
-uid_t id(const char *, const char *);
-void usage(void);
-
-uid_t uid;
-gid_t gid;
-int ischown;
-const char *gname;
+static void a_gid(const char *);
+static void a_uid(const char *);
+static void chownerr(const char *);
+static uid_t id(const char *, const char *);
+static void usage(void);
+
+static uid_t uid;
+static gid_t gid;
+static int ischown;
+static const char *gname;
int
main(int argc, char **argv)
@@ -229,7 +229,7 @@ main(int argc, char **argv)
exit(rval);
}
-void
+static void
a_gid(const char *s)
{
struct group *gr;
@@ -240,7 +240,7 @@ a_gid(const char *s)
gid = ((gr = getgrnam(s)) != NULL) ? gr->gr_gid : id(s, "group");
}
-void
+static void
a_uid(const char *s)
{
struct passwd *pw;
@@ -250,7 +250,7 @@ a_uid(const char *s)
uid = ((pw = getpwnam(s)) != NULL) ? pw->pw_uid : id(s, "user");
}
-uid_t
+static uid_t
id(const char *name, const char *type)
{
uid_t val;
@@ -267,7 +267,7 @@ id(const char *name, const char *type)
return (val);
}
-void
+static void
chownerr(const char *file)
{
static uid_t euid = -1;
@@ -299,7 +299,7 @@ chownerr(const char *file)
warn("%s", file);
}
-void
+static void
usage(void)
{
_______________________________________________
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
