On Jan 17, 2012, at 3:58 AM, Bruce Evans wrote:
> On Mon, 16 Jan 2012, Pawel Jakub Dawidek wrote:
>
>> On Mon, Jan 16, 2012 at 11:14:32AM -0600, Guy Helmer wrote:
>>> I've pasted the diff below that I think captures the majority of the issues
>>> you have brought up. I have not attempted to tack
On Mon, 16 Jan 2012, Pawel Jakub Dawidek wrote:
On Mon, Jan 16, 2012 at 11:14:32AM -0600, Guy Helmer wrote:
I've pasted the diff below that I think captures the majority of the issues you have
brought up. I have not attempted to tackle the property.3/properties.3 issues, nor
the objections to
On Mon, 16 Jan 2012, Guy Helmer wrote:
On Jan 14, 2012, at 3:02 PM, Bruce Evans wrote:
...
I've pasted the diff below that I think captures the majority of the issues you have
brought up. I have not attempted to tackle the property.3/properties.3 issues, nor
the objections to the prefixes that
On Mon, Jan 16, 2012 at 11:14:32AM -0600, Guy Helmer wrote:
> I've pasted the diff below that I think captures the majority of the issues
> you have brought up. I have not attempted to tackle the
> property.3/properties.3 issues, nor the objections to the prefixes that I
> think would take consi
On Jan 14, 2012, at 3:02 PM, Bruce Evans wrote:
> On Sat, 14 Jan 2012, Pawel Jakub Dawidek wrote:
>
>> On Sat, Jan 14, 2012 at 09:59:27PM +1100, Bruce Evans wrote:
>>> ...
>>> It's good to declare mode_t, since pidfile_open() uses it and we want
>>> to remove the dependency on . However, this de
On Sat, 14 Jan 2012, Pawel Jakub Dawidek wrote:
On Sat, Jan 14, 2012 at 09:59:27PM +1100, Bruce Evans wrote:
...
It's good to declare mode_t, since pidfile_open() uses it and we want
to remove the dependency on . However, this definition
doesn't follow KNF or the style of all the other typedef
On Sat, Jan 14, 2012 at 09:59:27PM +1100, Bruce Evans wrote:
> On Thu, 12 Jan 2012, Guy Helmer wrote:
>
> > Log:
> > Move struct pidfh definition into pidfile.c, and leave a forward
> > declaration
> > for pidfh in libutil.h in its place.
> > This allows us to hide the contents of the pidfh st
On Thu, 12 Jan 2012, Guy Helmer wrote:
Log:
Move struct pidfh definition into pidfile.c, and leave a forward declaration
for pidfh in libutil.h in its place.
This allows us to hide the contents of the pidfh structure, and also
allowed removal of the "#ifdef _SYS_PARAM_H" guard from around th
Author: ghelmer
Date: Thu Jan 12 22:49:36 2012
New Revision: 230037
URL: http://svn.freebsd.org/changeset/base/230037
Log:
Move struct pidfh definition into pidfile.c, and leave a forward declaration
for pidfh in libutil.h in its place.
This allows us to hide the contents of the pidfh struct
