Re: svn commit: r230125 - head/sys/kern

2012-01-17 Thread John Baldwin
On Tuesday, January 17, 2012 2:22:26 pm Scott Long wrote: > On Jan 17, 2012, at 8:08 AM, John Baldwin wrote: > > On Sunday, January 15, 2012 6:32:43 pm Colin Percival wrote: > >> On 01/15/12 15:28, John Baldwin wrote: > >>> On 1/15/12 2:09 AM, Eitan Adler wrote: > Log: > - Fix undefined

Re: svn commit: r230125 - head/sys/kern

2012-01-17 Thread Scott Long
On Jan 17, 2012, at 8:08 AM, John Baldwin wrote: > On Sunday, January 15, 2012 6:32:43 pm Colin Percival wrote: >> On 01/15/12 15:28, John Baldwin wrote: >>> On 1/15/12 2:09 AM, Eitan Adler wrote: Log: - Fix undefined behavior when device_get_name is null - Make error message more

Re: svn commit: r230125 - head/sys/kern

2012-01-17 Thread Doug Barton
On 01/17/2012 10:48, John Baldwin wrote: > On Tuesday, January 17, 2012 12:29:06 pm Andriy Gapon wrote: >> on 17/01/2012 19:12 Eitan Adler said the following: >>> To me seeing "(null)" from the output of printf indicates "There is a >>> bug here, printf should never be given a NULL argument.". >>>

Re: svn commit: r230125 - head/sys/kern

2012-01-17 Thread John Baldwin
On Tuesday, January 17, 2012 12:29:06 pm Andriy Gapon wrote: > on 17/01/2012 19:12 Eitan Adler said the following: > > To me seeing "(null)" from the output of printf indicates "There is a > > bug here, printf should never be given a NULL argument.". > > However, given that it isn't undefined here,

Re: svn commit: r230125 - head/sys/kern

2012-01-17 Thread Andriy Gapon
on 17/01/2012 19:12 Eitan Adler said the following: > To me seeing "(null)" from the output of printf indicates "There is a > bug here, printf should never be given a NULL argument.". > However, given that it isn't undefined here, and the objections I've > received I will revert this part of the ch

Re: svn commit: r230125 - head/sys/kern

2012-01-17 Thread Eitan Adler
On Tue, Jan 17, 2012 at 10:08 AM, John Baldwin wrote: > On Sunday, January 15, 2012 6:32:43 pm Colin Percival wrote: >> On 01/15/12 15:28, John Baldwin wrote: >> > On 1/15/12 2:09 AM, Eitan Adler wrote: >> >> Log: >> >>    - Fix undefined behavior when device_get_name is null >> >>    - Make error

Re: svn commit: r230125 - head/sys/kern

2012-01-17 Thread John Baldwin
On Sunday, January 15, 2012 6:32:43 pm Colin Percival wrote: > On 01/15/12 15:28, John Baldwin wrote: > > On 1/15/12 2:09 AM, Eitan Adler wrote: > >> Log: > >>- Fix undefined behavior when device_get_name is null > >>- Make error message more informative > > > > The in-kernel printf(9) alw

Re: svn commit: r230125 - head/sys/kern

2012-01-15 Thread Colin Percival
On 01/15/12 15:28, John Baldwin wrote: > On 1/15/12 2:09 AM, Eitan Adler wrote: >> Log: >>- Fix undefined behavior when device_get_name is null >>- Make error message more informative > > The in-kernel printf(9) always prints "(null)" for %s when the pointer is > NULL, > so that wasn't un

Re: svn commit: r230125 - head/sys/kern

2012-01-15 Thread John Baldwin
On 1/15/12 2:09 AM, Eitan Adler wrote: Author: eadler (ports committer) Date: Sun Jan 15 07:09:18 2012 New Revision: 230125 URL: http://svn.freebsd.org/changeset/base/230125 Log: - Fix undefined behavior when device_get_name is null - Make error message more informative The in-kernel pri

svn commit: r230125 - head/sys/kern

2012-01-14 Thread Eitan Adler
Author: eadler (ports committer) Date: Sun Jan 15 07:09:18 2012 New Revision: 230125 URL: http://svn.freebsd.org/changeset/base/230125 Log: - Fix undefined behavior when device_get_name is null - Make error message more informative PR: kern/149800 Submitted by: olgeni Approv