Re: svn commit: r232351 - in head/sys: kern sys ufs/ffs ufs/ufs

2012-04-07 Thread David Schultz
On Fri, Mar 02, 2012, David Chisnall wrote: On 2 Mar 2012, at 12:53, Konstantin Belousov wrote: This part of the change breaks KBI. I suggest that for merge to stable/9 you would leave the bread and breadn as functions. Can we not do this for the general case? Provide them as inline

Re: svn commit: r232351 - in head/sys: kern sys ufs/ffs ufs/ufs

2012-04-07 Thread David Chisnall
On 7 Apr 2012, at 18:10, David Schultz wrote: The biggest hinderance to using extern inline is that gcc and C99 disagree about what it means, unless you use a reasonably recent compiler in C99 mode. I first tried to use extern inline in the tree several years after I backported gcc's C99

Re: svn commit: r232351 - in head/sys: kern sys ufs/ffs ufs/ufs

2012-03-02 Thread Konstantin Belousov
On Thu, Mar 01, 2012 at 06:45:25PM +, Kirk McKusick wrote: Author: mckusick Date: Thu Mar 1 18:45:25 2012 New Revision: 232351 URL: http://svn.freebsd.org/changeset/base/232351 Modified: head/sys/sys/buf.h ==

Re: svn commit: r232351 - in head/sys: kern sys ufs/ffs ufs/ufs

2012-03-02 Thread David Chisnall
On 2 Mar 2012, at 12:53, Konstantin Belousov wrote: This part of the change breaks KBI. I suggest that for merge to stable/9 you would leave the bread and breadn as functions. Can we not do this for the general case? Provide them as inline extern functions in the header, and implement them

svn commit: r232351 - in head/sys: kern sys ufs/ffs ufs/ufs

2012-03-01 Thread Kirk McKusick
Author: mckusick Date: Thu Mar 1 18:45:25 2012 New Revision: 232351 URL: http://svn.freebsd.org/changeset/base/232351 Log: This change avoids a kernel deadlock on snaplk when using snapshots on UFS filesystems running with journaled soft updates. This is the first of several bugs that need