svn commit: r233052 - head/share/mk

2012-03-16 Thread Dimitry Andric
Author: dim Date: Fri Mar 16 23:19:45 2012 New Revision: 233052 URL: http://svn.freebsd.org/changeset/base/233052 Log: Change the style of share/mk/bsd.sys.mk to that of the other bsd.*.mk files, and style.Makefile(5), where applicable. While here, update the link to the gcc warning documen

Re: svn commit: r233052 - head/share/mk

2012-03-16 Thread Bruce Evans
On Fri, 16 Mar 2012, Dimitry Andric wrote: Log: Change the style of share/mk/bsd.sys.mk to that of the other bsd.*.mk files, and style.Makefile(5), where applicable. While here, update the link to the gcc warning documentation. Thanks. I rather liked the "^.* foo" style for making ifdefs

Re: svn commit: r233052 - head/share/mk

2012-03-19 Thread Chris Rees
On 17 Mar 2012 05:40, "Bruce Evans" wrote: > > On Fri, 16 Mar 2012, Dimitry Andric wrote: > >> Log: >> Change the style of share/mk/bsd.sys.mk to that of the other bsd.*.mk >> files, and style.Makefile(5), where applicable. While here, update the >> link to the gcc warning documentation. > > >

Re: svn commit: r233052 - head/share/mk

2012-03-19 Thread Dimitry Andric
On 2012-03-19 08:21, Chris Rees wrote: > On 17 Mar 2012 05:40, "Bruce Evans" > wrote: >> >> On Fri, 16 Mar 2012, Dimitry Andric wrote: >> >>> Log: >>> Change the style of share/mk/bsd.sys.mk to that of the >>> other bsd.*.mk >>> files, and style.

Re: svn commit: r233052 - head/share/mk

2012-03-19 Thread Chris Rees
On 19 March 2012 19:37, Dimitry Andric wrote: > On 2012-03-19 08:21, Chris Rees wrote: >> On 17 Mar 2012 05:40, "Bruce Evans" > > wrote: >>> >>> On Fri, 16 Mar 2012, Dimitry Andric wrote: >>> Log:  Change the style of share/mk/bsd.sys.mk t

Re: svn commit: r233052 - head/share/mk

2012-03-19 Thread Doug Barton
On 3/19/2012 12:37 PM, Dimitry Andric wrote: > It would be much nicer to be able to write: > > .if defined(FOO) > .if defined(BAR) > CFLAGS+= -DFOO_BAR > .endif > .endif Take a look at /usr/ports/Mk/bsd.port.mk for how this can be done. -- This .signature sanitized for your protec

Re: svn commit: r233052 - head/share/mk

2012-03-20 Thread John Baldwin
On Monday, March 19, 2012 5:39:53 pm Doug Barton wrote: > On 3/19/2012 12:37 PM, Dimitry Andric wrote: > > It would be much nicer to be able to write: > > > > .if defined(FOO) > > .if defined(BAR) > > CFLAGS+=-DFOO_BAR > > .endif > > .endif > > Take a look at /usr/ports/Mk/bsd.por

Re: svn commit: r233052 - head/share/mk

2012-03-20 Thread Chris Rees
On 20 March 2012 14:19, John Baldwin wrote: > On Monday, March 19, 2012 5:39:53 pm Doug Barton wrote: >> On 3/19/2012 12:37 PM, Dimitry Andric wrote: >> > It would be much nicer to be able to write: >> > >> > .if defined(FOO) >> >   .if defined(BAR) >> >     CFLAGS+=        -DFOO_BAR >> >   .endif

Re: svn commit: r233052 - head/share/mk

2012-03-20 Thread John Baldwin
On Tuesday, March 20, 2012 5:20:04 pm Chris Rees wrote: > On 20 March 2012 14:19, John Baldwin wrote: > > On Monday, March 19, 2012 5:39:53 pm Doug Barton wrote: > >> On 3/19/2012 12:37 PM, Dimitry Andric wrote: > >> > It would be much nicer to be able to write: > >> > > >> > .if defined(FOO) > >>

Re: svn commit: r233052 - head/share/mk

2012-03-20 Thread Chris Rees
On 20 March 2012 21:28, John Baldwin wrote: > On Tuesday, March 20, 2012 5:20:04 pm Chris Rees wrote: >> On 20 March 2012 14:19, John Baldwin wrote: >> > On Monday, March 19, 2012 5:39:53 pm Doug Barton wrote: >> >> On 3/19/2012 12:37 PM, Dimitry Andric wrote: >> >> > It would be much nicer to be

Re: svn commit: r233052 - head/share/mk

2012-03-20 Thread Daniel O'Connor
On 21/03/2012, at 8:10, Chris Rees wrote: > Yes-- it'd be nice if less could read the ex:ts=4 bit. > > That can go on my todo list. Are you going to teach it emacs commands for the same? ;) IMO any file which wants to be viewed with tabs != 8 spaces is broken. The extra cost of disk to store

Re: svn commit: r233052 - head/share/mk

2012-03-20 Thread Mark Linimon
The style in bsd.port.mk is not consistent. (I know, this is shocking for something that's at r1.706.) Here's what I recall seeing in it, that I found readable: .if defined(USE_GL) . if ${USE_GL:L} == "yes" USE_GL= glu . endif . for _component in ${USE_GL} . if !defined(_GL_${_component}_LI

Re: svn commit: r233052 - head/share/mk

2012-03-20 Thread Daniel O'Connor
On 21/03/2012, at 11:18, Mark Linimon wrote: > Personally, I'd like to see us pick a "recommended way for new code", > whether it's one or two spaces, whatever. (8 spaces seems too much.) 2 space indents are fine IMO, but they are spaces. A tab character should be viewed as 8 spaces wide, but t

Re: svn commit: r233052 - head/share/mk

2012-03-20 Thread Alexey Dokuchaev
On Tue, Mar 20, 2012 at 07:48:36PM -0500, Mark Linimon wrote: > Personally, I'd like to see us pick a "recommended way for new code", > whether it's one or two spaces, whatever. (8 spaces seems too much.) +1. I always hesitate between one or two spaces; but last time I recall I was using one. I