Re: svn commit: r233745 - head/sys/netinet/ipfw

2012-04-04 Thread Gleb Smirnoff
Julian, On Tue, Apr 03, 2012 at 04:46:56PM -0700, Julian Elischer wrote: J Many years ago there was the possibility that malloc M_WAITOK could J return on shutdown or in some other rare error cases. J J Are we certain this is no longer true? At least it is documented so. -- Totus tuus,

Re: svn commit: r233745 - head/sys/netinet/ipfw

2012-04-04 Thread John Baldwin
On Tuesday, April 03, 2012 7:46:56 pm Julian Elischer wrote: On 3/31/12 4:20 AM, Gleb Smirnoff wrote: Many years ago there was the possibility that malloc M_WAITOK could return on shutdown or in some other rare error cases. Are we certain this is no longer true? That hasn't been true in

Re: svn commit: r233745 - head/sys/netinet/ipfw

2012-04-04 Thread Julian Elischer
On 4/4/12 4:57 AM, John Baldwin wrote: On Tuesday, April 03, 2012 7:46:56 pm Julian Elischer wrote: On 3/31/12 4:20 AM, Gleb Smirnoff wrote: Many years ago there was the possibility that malloc M_WAITOK could return on shutdown or in some other rare error cases. Are we certain this is no

Re: svn commit: r233745 - head/sys/netinet/ipfw

2012-04-04 Thread John Baldwin
On Wednesday, April 04, 2012 3:32:26 pm Julian Elischer wrote: On 4/4/12 4:57 AM, John Baldwin wrote: On Tuesday, April 03, 2012 7:46:56 pm Julian Elischer wrote: On 3/31/12 4:20 AM, Gleb Smirnoff wrote: Many years ago there was the possibility that malloc M_WAITOK could return on

Re: svn commit: r233745 - head/sys/netinet/ipfw

2012-04-03 Thread Julian Elischer
On 3/31/12 4:20 AM, Gleb Smirnoff wrote: Many years ago there was the possibility that malloc M_WAITOK could return on shutdown or in some other rare error cases. Are we certain this is no longer true? Author: glebius Date: Sat Mar 31 11:20:48 2012 New Revision: 233745 URL:

svn commit: r233745 - head/sys/netinet/ipfw

2012-03-31 Thread Gleb Smirnoff
Author: glebius Date: Sat Mar 31 11:20:48 2012 New Revision: 233745 URL: http://svn.freebsd.org/changeset/base/233745 Log: Don't check malloc(M_WAITOK) results. Modified: head/sys/netinet/ipfw/ip_fw_sockopt.c Modified: head/sys/netinet/ipfw/ip_fw_sockopt.c