Re: svn commit: r238172 - head/sys/dev/agp

2012-07-09 Thread John Baldwin
On Saturday, July 07, 2012 10:44:14 am Marcel Moolenaar wrote: > The commit log states the motivation: developers tend to copy-n-paste without > truly understanding the subtle differences and may use the Maxmem use in > agp_i810.c as the wrong precedence. Secondly, also mentioned in the commit > lo

Re: svn commit: r238172 - head/sys/dev/agp

2012-07-07 Thread Marcel Moolenaar
On Jul 7, 2012, at 1:35 AM, Konstantin Belousov wrote: > On Fri, Jul 06, 2012 at 06:11:56PM -0700, Marcel Moolenaar wrote: >> >> On Jul 6, 2012, at 11:12 AM, Konstantin Belousov wrote: >> agp_i810.c: While arguably the use of Maxmem can be considered correct, replace its use with

Re: svn commit: r238172 - head/sys/dev/agp

2012-07-07 Thread Konstantin Belousov
On Fri, Jul 06, 2012 at 06:11:56PM -0700, Marcel Moolenaar wrote: > > On Jul 6, 2012, at 11:12 AM, Konstantin Belousov wrote: > > >> agp_i810.c: > >> While arguably the use of Maxmem can be considered correct, replace its > >> use > >> with realmem anyway. agp_i810.c is specific to amd64, i38

Re: svn commit: r238172 - head/sys/dev/agp

2012-07-06 Thread Marcel Moolenaar
On Jul 6, 2012, at 11:12 AM, Konstantin Belousov wrote: >> agp_i810.c: >> While arguably the use of Maxmem can be considered correct, replace its use >> with realmem anyway. agp_i810.c is specific to amd64, i386 & pc98, which >> have a dense physical memory layout. Avoiding Maxmem here is don

Re: svn commit: r238172 - head/sys/dev/agp

2012-07-06 Thread Konstantin Belousov
On Fri, Jul 06, 2012 at 03:57:04PM +, Marcel Moolenaar wrote: > Author: marcel > Date: Fri Jul 6 15:57:03 2012 > New Revision: 238172 > URL: http://svn.freebsd.org/changeset/base/238172 > > Log: > agp.c: > Don't use Maxmem when the amount of memory is meant. Use realmem instead. > Maxme

svn commit: r238172 - head/sys/dev/agp

2012-07-06 Thread Marcel Moolenaar
Author: marcel Date: Fri Jul 6 15:57:03 2012 New Revision: 238172 URL: http://svn.freebsd.org/changeset/base/238172 Log: agp.c: Don't use Maxmem when the amount of memory is meant. Use realmem instead. Maxmem is not only a MD variable, it represents the highest physical memory address in