Re: svn commit: r243019 - head/sbin/route

2012-12-04 Thread Xin Li
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 12/04/12 02:22, Gleb Smirnoff wrote: > Xin, > > On Mon, Dec 03, 2012 at 11:47:32AM -0800, Xin LI wrote: X> It seems > that this commit breaks the following commands like this: X> X> > route add -net 10.8/16 10.2.0.1 > > Thanks for report. Do you

Re: svn commit: r243019 - head/sbin/route

2012-12-04 Thread Gleb Smirnoff
Xin, On Mon, Dec 03, 2012 at 11:47:32AM -0800, Xin LI wrote: X> It seems that this commit breaks the following commands like this: X> X> route add -net 10.8/16 10.2.0.1 Thanks for report. Do you agree with attached patch? -- Totus tuus, Glebius. Index: route.c =

Re: svn commit: r243019 - head/sbin/route

2012-12-03 Thread Xin LI
It seems that this commit breaks the following commands like this: route add -net 10.8/16 10.2.0.1 --- Script started on Mon Dec 3 11:36:49 2012 delphij has logged on ttyv0 from local. [delphij@epsilon] ~> netstat -anrafinet Routing tables Internet: DestinationGatewayFlags

Re: svn commit: r243019 - head/sbin/route

2012-11-14 Thread Ben Kaduk
On Wed, Nov 14, 2012 at 11:27 AM, Eitan Adler wrote: > On 14 November 2012 11:12, Ben Kaduk wrote: >> Andre, they are used (for better or for worse) in a multi-site >> database synchronization protocol that currently works portably across >> operating systems. Removing them would change the sema

Re: svn commit: r243019 - head/sbin/route

2012-11-14 Thread Eitan Adler
On 14 November 2012 11:12, Ben Kaduk wrote: > On Wed, Nov 14, 2012 at 4:32 AM, Gleb Smirnoff wrote: >> A> Can the IN_CLASS[A-C]_NET... definitions go away as well? >> >> They are defines that don't generate any code. >> >> Also, on this mailing list I've promised once not to remove them :) > > I'

Re: svn commit: r243019 - head/sbin/route

2012-11-14 Thread Ben Kaduk
On Wed, Nov 14, 2012 at 4:32 AM, Gleb Smirnoff wrote: > A> Can the IN_CLASS[A-C]_NET... definitions go away as well? > > They are defines that don't generate any code. > > Also, on this mailing list I've promised once not to remove them :) I'm glad you remember :) Andre, they are used (for bette

Re: svn commit: r243019 - head/sbin/route

2012-11-14 Thread Gleb Smirnoff
On Wed, Nov 14, 2012 at 10:30:22AM +0100, Andre Oppermann wrote: A> On 14.11.2012 09:05, Gleb Smirnoff wrote: A> > Author: glebius A> > Date: Wed Nov 14 08:05:21 2012 A> > New Revision: 243019 A> > URL: http://svnweb.freebsd.org/changeset/base/243019 A> > A> > Log: A> >Remove remnants of classf

Re: svn commit: r243019 - head/sbin/route

2012-11-14 Thread Andre Oppermann
On 14.11.2012 09:05, Gleb Smirnoff wrote: Author: glebius Date: Wed Nov 14 08:05:21 2012 New Revision: 243019 URL: http://svnweb.freebsd.org/changeset/base/243019 Log: Remove remnants of classful addressing. These magic transformations of supplied arguments is not what a modern sysadmin ex

svn commit: r243019 - head/sbin/route

2012-11-14 Thread Gleb Smirnoff
Author: glebius Date: Wed Nov 14 08:05:21 2012 New Revision: 243019 URL: http://svnweb.freebsd.org/changeset/base/243019 Log: Remove remnants of classful addressing. These magic transformations of supplied arguments is not what a modern sysadmin expect. Modified: head/sbin/route/route.c Mo