Re: svn commit: r245506 - head/bin/pwait

2013-01-17 Thread Bruce Evans
On Fri, 18 Jan 2013, Bruce Evans wrote: The orignal BSD style guide (/usr/src/admin/style/style) actually says not to use [non-arbitrary] sequential values to indicate all exit points: ... but was changed in FreeBSD to say something quite different: ... and then was changed to say something even

Re: svn commit: r245506 - head/bin/pwait

2013-01-17 Thread Bruce Evans
On Thu, 17 Jan 2013, Pawel Jakub Dawidek wrote: On Thu, Jan 17, 2013 at 10:50:07AM -0500, John Baldwin wrote: On Wednesday, January 16, 2013 10:40:51 pm Eitan Adler wrote: On 16 January 2013 21:25, Bruce Evans wrote: This uses the sysexits mistake. style(9) was fixed to not give an example

Re: svn commit: r245506 - head/bin/pwait

2013-01-17 Thread Eitan Adler
On 17 January 2013 10:50, John Baldwin wrote: > Eh, I think bde@ has quite a bit more experience with this than you. No doubt. > is not part of POSIX or any other standard. It's comments > reference delivermail (the predecessor to sendmail). Looking at its history, ... Understood. I have fo

Re: svn commit: r245506 - head/bin/pwait

2013-01-17 Thread Pawel Jakub Dawidek
On Thu, Jan 17, 2013 at 10:50:07AM -0500, John Baldwin wrote: > On Wednesday, January 16, 2013 10:40:51 pm Eitan Adler wrote: > > On 16 January 2013 21:25, Bruce Evans wrote: > > > This uses the sysexits mistake. style(9) was fixed to not give an example > > > of this mistake. Before this, sysex

Re: svn commit: r245506 - head/bin/pwait

2013-01-17 Thread John Baldwin
On Wednesday, January 16, 2013 10:40:51 pm Eitan Adler wrote: > On 16 January 2013 21:25, Bruce Evans wrote: > > This uses the sysexits mistake. style(9) was fixed to not give an example > > of this mistake. Before this, sysexits was used a whole once in pwait(1) > > (for EX_USAGE) in usage().

Re: svn commit: r245506 - head/bin/pwait

2013-01-16 Thread Eitan Adler
On 16 January 2013 21:25, Bruce Evans wrote: > This uses the sysexits mistake. style(9) was fixed to not give an example > of this mistake. Before this, sysexits was used a whole once in pwait(1) > (for EX_USAGE) in usage(). EX_USAGE happens to be 64. As usual when the > mistake is used, this

Re: svn commit: r245506 - head/bin/pwait

2013-01-16 Thread Bruce Evans
On Wed, 16 Jan 2013, Xin LI wrote: Log: Use a different way to silence clang analyzer as done in r245494 by explicitly telling the compiler that we are on the exit route. X-MFC: together with r245494 Modified: head/bin/pwait/pwait.c Modified: head/bin/pwait/pwait.c ===

svn commit: r245506 - head/bin/pwait

2013-01-16 Thread Xin LI
Author: delphij Date: Wed Jan 16 18:15:25 2013 New Revision: 245506 URL: http://svnweb.freebsd.org/changeset/base/245506 Log: Use a different way to silence clang analyzer as done in r245494 by explicitly telling the compiler that we are on the exit route. X-MFC:together with r245