Re: svn commit: r250806 - head/sys/sys

2013-05-20 Thread Bruce Evans
On Mon, 20 May 2013, Benjamin Kaduk wrote: On Mon, May 20, 2013 at 11:50 AM, Stefan Farfeleder wrote: Since nobody wants to update lint to recent C standards, maybe it's time to remove it? I'm not going to defend it. At first I thought it was useful for checking for old sources, but with sy

Re: svn commit: r250806 - head/sys/sys

2013-05-20 Thread Benjamin Kaduk
On Mon, May 20, 2013 at 11:50 AM, Stefan Farfeleder wrote: > Since nobody wants to update lint to recent C standards, maybe it's time to > remove it? > It does seem like compilers can do a better job of finding lint-like things than lint itself, these days (especially clang). -Ben __

Re: svn commit: r250806 - head/sys/sys

2013-05-20 Thread Stefan Farfeleder
On Tue, May 21, 2013 at 01:15:11AM +1000, Bruce Evans wrote: > On Mon, 20 May 2013, Stefan Farfeleder wrote: > > > I think you misunderstood what I meant. We now have quiet a few > > occurrences of `#ifdef lint' or equivalent in /usr/include. I think those > > should be changed to `#ifdef __lint'

Re: svn commit: r250806 - head/sys/sys

2013-05-20 Thread Bruce Evans
On Mon, 20 May 2013, Stefan Farfeleder wrote: On Mon, May 20, 2013 at 01:06:50PM +0200, Ed Schouten wrote: Hi Stefan, 2013/5/19 Stefan Farfeleder : Shouldn't we fix lint and our headers to use a different macro name? One starting with __? Fixing lint: yes. Changing our macros to use a diffe

Re: svn commit: r250806 - head/sys/sys

2013-05-20 Thread Stefan Farfeleder
On Mon, May 20, 2013 at 01:06:50PM +0200, Ed Schouten wrote: > Hi Stefan, > > 2013/5/19 Stefan Farfeleder : > > Shouldn't we fix lint and our headers to use a different macro name? One > > starting with __? > > Fixing lint: yes. Changing our macros to use a different name: no. > The reason why w

Re: svn commit: r250806 - head/sys/sys

2013-05-20 Thread Ed Schouten
Hi Stefan, 2013/5/19 Stefan Farfeleder : > Shouldn't we fix lint and our headers to use a different macro name? One > starting with __? Fixing lint: yes. Changing our macros to use a different name: no. The reason why we had __volatile, __inline, etc. in the first place, was because adding defin

Re: svn commit: r250806 - head/sys/sys

2013-05-19 Thread Stefan Farfeleder
On Sun, May 19, 2013 at 07:44:02AM +, Ed Schouten wrote: > Author: ed > Date: Sun May 19 07:44:01 2013 > New Revision: 250806 > URL: http://svnweb.freebsd.org/changeset/base/250806 > > Log: > Remove lint case for _Thread_local. > > I added this block, knowing that lint does not support

svn commit: r250806 - head/sys/sys

2013-05-19 Thread Ed Schouten
Author: ed Date: Sun May 19 07:44:01 2013 New Revision: 250806 URL: http://svnweb.freebsd.org/changeset/base/250806 Log: Remove lint case for _Thread_local. I added this block, knowing that lint does not support _Thread_local. When linting, we could argue that we don't care about TLS (yet