Re: svn commit: r259468 - head/usr.sbin/bsdinstall/scripts

2013-12-21 Thread Teske, Devin
On Dec 21, 2013, at 8:31 AM, Nathan Whitehorn wrote: > On 12/21/13 10:25, Teske, Devin wrote: >> On Dec 21, 2013, at 8:12 AM, Nathan Whitehorn wrote: >> >>> Looks great, thanks -- although you don't need the f_quietly, which >>> isn't defined there. >>> >>> The issue is that this patch very spe

Re: svn commit: r259468 - head/usr.sbin/bsdinstall/scripts

2013-12-21 Thread Nathan Whitehorn
On 12/21/13 10:25, Teske, Devin wrote: > On Dec 21, 2013, at 8:12 AM, Nathan Whitehorn wrote: > >> Looks great, thanks -- although you don't need the f_quietly, which >> isn't defined there. >> >> The issue is that this patch very specific to running the installer on a >> video console. There are m

Re: svn commit: r259468 - head/usr.sbin/bsdinstall/scripts

2013-12-21 Thread Teske, Devin
On Dec 21, 2013, at 8:12 AM, Nathan Whitehorn wrote: > Looks great, thanks -- although you don't need the f_quietly, which > isn't defined there. > > The issue is that this patch very specific to running the installer on a > video console. There are many circumstances in which it is not, in whic

Re: svn commit: r259468 - head/usr.sbin/bsdinstall/scripts

2013-12-21 Thread Nathan Whitehorn
Looks great, thanks -- although you don't need the f_quietly, which isn't defined there. The issue is that this patch very specific to running the installer on a video console. There are many circumstances in which it is not, in which case this will fail (e.g. a serial console). The other thing is

Re: svn commit: r259468 - head/usr.sbin/bsdinstall/scripts

2013-12-21 Thread Teske, Devin
I tried to rationalize... "in what case is it actually _desirably_ that the left or right command key _should_ generate an escape sequence and thus cancel the existing dialog" and I couldn't think of any. That being said... I'm still happy to move it. Can you have a look at the attached patch to s

Re: svn commit: r259468 - head/usr.sbin/bsdinstall/scripts

2013-12-21 Thread Nathan Whitehorn
Could you please revert this and move the fix to the correct place? -Nathan On 12/16/13 10:06, Nathan Whitehorn wrote: > Please add this to release/rc.local instead under the console setup. > There is no guarantee that "auto" is running from an environment where > this is defined -- for example, i

Re: svn commit: r259468 - head/usr.sbin/bsdinstall/scripts

2013-12-16 Thread Nathan Whitehorn
Please add this to release/rc.local instead under the console setup. There is no guarantee that "auto" is running from an environment where this is defined -- for example, it may be running from a serial console or an xterm -- and the actual installer should not be polluted with assumptions abo

svn commit: r259468 - head/usr.sbin/bsdinstall/scripts

2013-12-16 Thread Devin Teske
Author: dteske Date: Mon Dec 16 15:50:59 2013 New Revision: 259468 URL: http://svnweb.freebsd.org/changeset/base/259468 Log: Add a fix for Long-standing problem with VMware. Described in below links: https://communities.vmware.com/thread/107230 https://communities.vmware.com/docs/DOC-11677