Re: svn commit: r259642 - head/sys/netinet

2013-12-20 Thread Adrian Chadd
On 20 December 2013 00:44, Gleb Smirnoff gleb...@freebsd.org wrote: I didn't get to review of actual patch, but IMO it would be better just to remove the code, not ifdef 0 it. The code ifdefed has zero probability to be enabled in its current form. If we ever fix it, code would look very

Re: svn commit: r259642 - head/sys/netinet

2013-12-20 Thread Jack Vogel
I agree with Gleb, ifdef 0 is silly, after all, that's why we have source history, its not like the offending code is gone forever :) So I guess its both of us muttering Gleb :) Jack On Fri, Dec 20, 2013 at 9:05 AM, Adrian Chadd adr...@freebsd.org wrote: On 20 December 2013 00:44, Gleb

svn commit: r259642 - head/sys/netinet

2013-12-19 Thread Adrian Chadd
Author: adrian Date: Fri Dec 20 07:41:03 2013 New Revision: 259642 URL: http://svnweb.freebsd.org/changeset/base/259642 Log: Disable the now unpredicably bogus check for whether we have eneough queue space before queuing a bunch of IP fragments. As the comment in the committed change