Re: svn commit: r265003 - head/secure/usr.sbin/sshd

2014-08-24 Thread Jilles Tjoelker
On Sat, Aug 23, 2014 at 09:42:21PM +0300, Konstantin Belousov wrote: On Sat, Aug 23, 2014 at 07:52:44PM +0200, Jilles Tjoelker wrote: On Fri, Aug 22, 2014 at 06:31:39PM +0300, Konstantin Belousov wrote: On Fri, Aug 22, 2014 at 03:43:53PM +0200, Jilles Tjoelker wrote: This is good and

Re: svn commit: r265003 - head/secure/usr.sbin/sshd

2014-08-23 Thread Jilles Tjoelker
On Fri, Aug 22, 2014 at 06:31:39PM +0300, Konstantin Belousov wrote: On Fri, Aug 22, 2014 at 03:43:53PM +0200, Jilles Tjoelker wrote: This is good and necessary for SA_SIGINFO (because of the type of the SIG_DFL and SIG_IGN constants, and because POSIX says so in the description of

Re: svn commit: r265003 - head/secure/usr.sbin/sshd

2014-08-23 Thread Konstantin Belousov
On Sat, Aug 23, 2014 at 07:52:44PM +0200, Jilles Tjoelker wrote: On Fri, Aug 22, 2014 at 06:31:39PM +0300, Konstantin Belousov wrote: On Fri, Aug 22, 2014 at 03:43:53PM +0200, Jilles Tjoelker wrote: This is good and necessary for SA_SIGINFO (because of the type of the SIG_DFL and SIG_IGN

Re: svn commit: r265003 - head/secure/usr.sbin/sshd

2014-08-22 Thread Jilles Tjoelker
On Thu, Aug 21, 2014 at 03:32:46PM +0300, Konstantin Belousov wrote: I think you mis-interpret the man page statement, it only says that SA_SIGINFO should not be set in new-sa_flags IMO. But I do not see much sense in the requirement. Note that we do not test flags for correctness at

Re: svn commit: r265003 - head/secure/usr.sbin/sshd

2014-08-22 Thread Konstantin Belousov
On Fri, Aug 22, 2014 at 03:43:53PM +0200, Jilles Tjoelker wrote: This is good and necessary for SA_SIGINFO (because of the type of the SIG_DFL and SIG_IGN constants, and because POSIX says so in the description of SA_RESETHAND in the sigaction() page). However, there seems no reason to clear

Re: svn commit: r265003 - head/secure/usr.sbin/sshd

2014-08-21 Thread Konstantin Belousov
On Wed, Aug 20, 2014 at 05:34:58PM +0200, Roger Pau Monn? wrote: On 20/08/14 17:28, Bryan Drewery wrote: On 8/20/2014 10:19 AM, Roger Pau Monn? wrote: On 20/08/14 17:13, Konstantin Belousov wrote: On Wed, Aug 20, 2014 at 04:41:05PM +0200, Roger Pau Monn?? wrote: On 27/04/14 07:28,

Re: svn commit: r265003 - head/secure/usr.sbin/sshd

2014-08-21 Thread Roger Pau Monné
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 21/08/14 10:05, Konstantin Belousov wrote: On Wed, Aug 20, 2014 at 05:34:58PM +0200, Roger Pau Monn? wrote: On 20/08/14 17:28, Bryan Drewery wrote: On 8/20/2014 10:19 AM, Roger Pau Monn? wrote: On 20/08/14 17:13, Konstantin Belousov wrote: On

Re: svn commit: r265003 - head/secure/usr.sbin/sshd

2014-08-21 Thread Konstantin Belousov
On Thu, Aug 21, 2014 at 01:12:46PM +0200, Roger Pau Monn? wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 21/08/14 10:05, Konstantin Belousov wrote: On Wed, Aug 20, 2014 at 05:34:58PM +0200, Roger Pau Monn? wrote: On 20/08/14 17:28, Bryan Drewery wrote: On 8/20/2014 10:19 AM,

Re: svn commit: r265003 - head/secure/usr.sbin/sshd

2014-08-20 Thread Roger Pau Monné
On 27/04/14 07:28, Konstantin Belousov wrote: Author: kib Date: Sun Apr 27 05:28:14 2014 New Revision: 265003 URL: http://svnweb.freebsd.org/changeset/base/265003 Log: Fix order of libthr and libc in the global dso list for sshd, by explicitely linking main binary with -lpthread.

Re: svn commit: r265003 - head/secure/usr.sbin/sshd

2014-08-20 Thread Konstantin Belousov
On Wed, Aug 20, 2014 at 04:41:05PM +0200, Roger Pau Monn?? wrote: On 27/04/14 07:28, Konstantin Belousov wrote: Author: kib Date: Sun Apr 27 05:28:14 2014 New Revision: 265003 URL: http://svnweb.freebsd.org/changeset/base/265003 Log: Fix order of libthr and libc in the global dso

Re: svn commit: r265003 - head/secure/usr.sbin/sshd

2014-08-20 Thread Roger Pau Monné
On 20/08/14 17:13, Konstantin Belousov wrote: On Wed, Aug 20, 2014 at 04:41:05PM +0200, Roger Pau Monn?? wrote: On 27/04/14 07:28, Konstantin Belousov wrote: Author: kib Date: Sun Apr 27 05:28:14 2014 New Revision: 265003 URL: http://svnweb.freebsd.org/changeset/base/265003 Log: Fix

Re: svn commit: r265003 - head/secure/usr.sbin/sshd

2014-08-20 Thread Bryan Drewery
On 8/20/2014 10:19 AM, Roger Pau Monné wrote: On 20/08/14 17:13, Konstantin Belousov wrote: On Wed, Aug 20, 2014 at 04:41:05PM +0200, Roger Pau Monn?? wrote: On 27/04/14 07:28, Konstantin Belousov wrote: Author: kib Date: Sun Apr 27 05:28:14 2014 New Revision: 265003 URL:

Re: svn commit: r265003 - head/secure/usr.sbin/sshd

2014-08-20 Thread Roger Pau Monné
On 20/08/14 17:28, Bryan Drewery wrote: On 8/20/2014 10:19 AM, Roger Pau Monné wrote: On 20/08/14 17:13, Konstantin Belousov wrote: On Wed, Aug 20, 2014 at 04:41:05PM +0200, Roger Pau Monn?? wrote: On 27/04/14 07:28, Konstantin Belousov wrote: Author: kib Date: Sun Apr 27 05:28:14 2014 New

Re: svn commit: r265003 - head/secure/usr.sbin/sshd

2014-04-28 Thread Slawa Olhovchenkov
On Sun, Apr 27, 2014 at 05:28:14AM +, Konstantin Belousov wrote: Author: kib Date: Sun Apr 27 05:28:14 2014 New Revision: 265003 URL: http://svnweb.freebsd.org/changeset/base/265003 Log: Fix order of libthr and libc in the global dso list for sshd, by explicitely linking main

svn commit: r265003 - head/secure/usr.sbin/sshd

2014-04-26 Thread Konstantin Belousov
Author: kib Date: Sun Apr 27 05:28:14 2014 New Revision: 265003 URL: http://svnweb.freebsd.org/changeset/base/265003 Log: Fix order of libthr and libc in the global dso list for sshd, by explicitely linking main binary with -lpthread. Before, libthr appeared in the list due to dependency