Re: svn commit: r271788 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2014-09-19 Thread Steven Hartland
- Original Message - From: "Will Andrews" To: "John Baldwin" Cc: "Steven Hartland" ; "src-committ...@freebsd.org" ; ; Sent: Friday, September 19, 2014 6:35 PM Subject: Re: svn commit: r271788 - head/sys/cddl/contrib/opensolaris/uts/common/fs

Re: svn commit: r271788 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2014-09-19 Thread Will Andrews
I found that neither TUNABLE_INT nor CTLFLAG_RWTUN work with this particular implementation of the tunable, so there is a regression that needs to be fixed (i.e. vfs.zfs.debug_flags always comes up 0 no matter what's in loader.conf). I believe it's limited to this particular tunable, however, beca

Re: svn commit: r271788 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2014-09-19 Thread John Baldwin
On Thursday, September 18, 2014 06:37:28 PM Steven Hartland wrote: > You don't need a seperate TUNABLE_INT declations any more since the > excellent SYSCTL refactor. That is my fault. I wasn't certain if SYSCTL_PROC() would work correctly when Will asked me on IRC, but it seems it does so long a

Re: svn commit: r271788 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2014-09-18 Thread Steven Hartland
You don't need a seperate TUNABLE_INT declations any more since the excellent SYSCTL refactor. Regards Steve - Original Message - From: "Will Andrews" To: ; ; Sent: Thursday, September 18, 2014 5:55 PM Subject: svn commit: r271788 - head/sys/cddl/contrib/

Re: svn commit: r271788 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2014-09-18 Thread Andriy Gapon
On 18/09/2014 20:05, Will Andrews wrote: > Which one is more idiomatic? Sorry, I never noticed that one. I prefer your commit. > > On Thu, Sep 18, 2014 at 11:03 AM, Andriy Gapon wrote: >> On 18/09/2014 19:55, Will Andrews wrote: >>> Author: will >>> Date: Thu Sep 18 16:55:41 2014 >>> New Revis

Re: svn commit: r271788 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2014-09-18 Thread Will Andrews
Which one is more idiomatic? Sorry, I never noticed that one. Thanks, --Will. On Thu, Sep 18, 2014 at 11:03 AM, Andriy Gapon wrote: > On 18/09/2014 19:55, Will Andrews wrote: >> Author: will >> Date: Thu Sep 18 16:55:41 2014 >> New Revision: 271788 >> URL: http://svnweb.freebsd.org/changeset/ba

Re: svn commit: r271788 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2014-09-18 Thread Andriy Gapon
On 18/09/2014 19:55, Will Andrews wrote: > Author: will > Date: Thu Sep 18 16:55:41 2014 > New Revision: 271788 > URL: http://svnweb.freebsd.org/changeset/base/271788 > > Log: > Enable ZFS debug flags to be modified via vfs.zfs.debug_flags. > > This is primarily only of interest to ZFS deve

svn commit: r271788 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2014-09-18 Thread Will Andrews
Author: will Date: Thu Sep 18 16:55:41 2014 New Revision: 271788 URL: http://svnweb.freebsd.org/changeset/base/271788 Log: Enable ZFS debug flags to be modified via vfs.zfs.debug_flags. This is primarily only of interest to ZFS developers, but it makes it easier to get additional debuggin