svn commit: r274086 - head/sbin/route

2014-11-04 Thread Alexander V. Chernikov
Author: melifaro Date: Tue Nov 4 10:21:34 2014 New Revision: 274086 URL: https://svnweb.freebsd.org/changeset/base/274086 Log: Put break after err() to please coverity. Reported by: Coverity CID: 1250795 Modified: head/sbin/route/route.c Modified: head/sbin/route/route.c

Re: svn commit: r274086 - head/sbin/route

2014-11-04 Thread Stefan Farfeleder
On Tue, Nov 04, 2014 at 10:21:35AM +, Alexander V. Chernikov wrote: Author: melifaro Date: Tue Nov 4 10:21:34 2014 New Revision: 274086 URL: https://svnweb.freebsd.org/changeset/base/274086 Log: Put break after err() to please coverity. Reported by:Coverity CID:

Re: svn commit: r274086 - head/sbin/route

2014-11-04 Thread David Chisnall
On 4 Nov 2014, at 10:28, Stefan Farfeleder stef...@freebsd.org wrote: Shouldn't Coverity understand that err doesn't return? err() is marked as __dead2, which expands to __attribute__((__noreturn__)). If Coverity doesn't know that __attribute__((__noreturn__)) functions don't return, then

Re: svn commit: r274086 - head/sbin/route

2014-11-04 Thread Bruce Evans
On Tue, 4 Nov 2014, David Chisnall wrote: On 4 Nov 2014, at 10:28, Stefan Farfeleder stef...@freebsd.org wrote: Shouldn't Coverity understand that err doesn't return? err() is marked as __dead2, which expands to __attribute__((__noreturn__)). If Coverity doesn't know that