Re: svn commit: r276747 - head/sys/netpfil/pf

2015-02-16 Thread Craig Rodrigues
Cool. Having the PF + VIMAGE issues resolved and committed to HEAD is what I am most interested in. When you have a patch that you are happy with, would you be OK with getting it into Phabricator? It would be good to have it in there, so that multiple people can review it, including Gleb.

Re: svn commit: r276747 - head/sys/netpfil/pf

2015-02-16 Thread Nikos Vassiliadis
Hi Gleb Craig, I am already working on the issues that need to be fixed, namely: 1) all the changes from projects/pf 2) unloading the module 3) one purge thread per pf instance will remain until we have more experience It's almost ready, I am trying to fix unloading the module. As I am not at

Re: svn commit: r276747 - head/sys/netpfil/pf

2015-02-16 Thread Craig Rodrigues
On Sun, Feb 15, 2015 at 11:46 PM, Gleb Smirnoff gleb...@freebsd.org wrote: On Sun, Feb 15, 2015 at 11:36:17PM -0800, Craig Rodrigues wrote: C On Sun, Feb 15, 2015 at 5:25 PM, Gleb Smirnoff gleb...@freebsd.org wrote: C C On Sun, Feb 15, 2015 at 01:33:19PM -0800, Craig Rodrigues wrote: C C

Re: svn commit: r276747 - head/sys/netpfil/pf

2015-02-15 Thread Gleb Smirnoff
Craig, On Sat, Feb 14, 2015 at 07:35:53PM -0800, Craig Rodrigues wrote: C On Thu, Jan 22, 2015 at 10:09:41PM +0100, Nikos Vassiliadis wrote: C N Sorry guys, I backed this out due to broken kldunload of pf module, C which C N is critical when you are working with pf bugs. C N C N For

Re: svn commit: r276747 - head/sys/netpfil/pf

2015-02-15 Thread Craig Rodrigues
On Sun, Feb 15, 2015 at 11:01 AM, Gleb Smirnoff gleb...@freebsd.org wrote: Craig, On Sat, Feb 14, 2015 at 07:35:53PM -0800, Craig Rodrigues wrote: C On Thu, Jan 22, 2015 at 10:09:41PM +0100, Nikos Vassiliadis wrote: C N Sorry guys, I backed this out due to broken kldunload of pf

Re: svn commit: r276747 - head/sys/netpfil/pf

2015-02-15 Thread Craig Rodrigues
On Sun, Feb 15, 2015 at 1:26 PM, Craig Rodrigues rodr...@freebsd.org wrote: On Sun, Feb 15, 2015 at 11:01 AM, Gleb Smirnoff gleb...@freebsd.org wrote: Craig, On Sat, Feb 14, 2015 at 07:35:53PM -0800, Craig Rodrigues wrote: C On Thu, Jan 22, 2015 at 10:09:41PM +0100, Nikos Vassiliadis

Re: svn commit: r276747 - head/sys/netpfil/pf

2015-02-15 Thread Gleb Smirnoff
On Sun, Feb 15, 2015 at 01:26:18PM -0800, Craig Rodrigues wrote: C What are the problems in 276746 that you were unhappy with C besides being unable to kldunload PF? They were listed in Message-ID: 20150121214445.gl15...@freebsd.org. Also, the fact that commit required a serie of followup

Re: svn commit: r276747 - head/sys/netpfil/pf

2015-02-15 Thread Gleb Smirnoff
On Sun, Feb 15, 2015 at 01:33:19PM -0800, Craig Rodrigues wrote: C By the way, it would be helpful if you could provide feedback in C Phabricator. When I created those Phabricator reviews, I added C you as a reviewer to all of them, so you can't say that you didn't see C the patches. C You did

Re: svn commit: r276747 - head/sys/netpfil/pf

2015-02-15 Thread Craig Rodrigues
On Sun, Feb 15, 2015 at 5:25 PM, Gleb Smirnoff gleb...@freebsd.org wrote: On Sun, Feb 15, 2015 at 01:33:19PM -0800, Craig Rodrigues wrote: C By the way, it would be helpful if you could provide feedback in C Phabricator. When I created those Phabricator reviews, I added C you as a reviewer

Re: svn commit: r276747 - head/sys/netpfil/pf

2015-02-15 Thread Gleb Smirnoff
On Sun, Feb 15, 2015 at 11:36:17PM -0800, Craig Rodrigues wrote: C On Sun, Feb 15, 2015 at 5:25 PM, Gleb Smirnoff gleb...@freebsd.org wrote: C C On Sun, Feb 15, 2015 at 01:33:19PM -0800, Craig Rodrigues wrote: C C By the way, it would be helpful if you could provide feedback in C C

Re: svn commit: r276747 - head/sys/netpfil/pf

2015-02-14 Thread Craig Rodrigues
On Thu, Jan 22, 2015 at 2:23 PM, Gleb Smirnoff gleb...@freebsd.org wrote: On Thu, Jan 22, 2015 at 10:09:41PM +0100, Nikos Vassiliadis wrote: N Sorry guys, I backed this out due to broken kldunload of pf module, which N is critical when you are working with pf bugs. N N For sure. 100%

Re: svn commit: r276747 - head/sys/netpfil/pf

2015-01-22 Thread Gleb Smirnoff
On Thu, Jan 22, 2015 at 10:09:41PM +0100, Nikos Vassiliadis wrote: N Sorry guys, I backed this out due to broken kldunload of pf module, which N is critical when you are working with pf bugs. N N For sure. 100% understood. N N I had to backout r276746 as well, since it has numerous build

Re: svn commit: r276747 - head/sys/netpfil/pf

2015-01-22 Thread Nikos Vassiliadis
On 01/22/15 02:27, Gleb Smirnoff wrote: On Tue, Jan 06, 2015 at 09:03:04AM +, Craig Rodrigues wrote: C Author: rodrigc C Date: Tue Jan 6 09:03:03 2015 C New Revision: 276747 C URL: https://svnweb.freebsd.org/changeset/base/276747 C C Log: C Instead of creating a purge thread for every

Re: svn commit: r276747 - head/sys/netpfil/pf

2015-01-21 Thread Gleb Smirnoff
On Wed, Jan 07, 2015 at 11:46:31PM +0300, Gleb Smirnoff wrote: T On Tue, Jan 06, 2015 at 09:03:04AM +, Craig Rodrigues wrote: T C Author: rodrigc T C Date: Tue Jan 6 09:03:03 2015 T C New Revision: 276747 T C URL: https://svnweb.freebsd.org/changeset/base/276747 T C T C Log: T C Instead of

Re: svn commit: r276747 - head/sys/netpfil/pf

2015-01-21 Thread Gleb Smirnoff
On Tue, Jan 06, 2015 at 09:03:04AM +, Craig Rodrigues wrote: C Author: rodrigc C Date: Tue Jan 6 09:03:03 2015 C New Revision: 276747 C URL: https://svnweb.freebsd.org/changeset/base/276747 C C Log: C Instead of creating a purge thread for every vnet, create C a single purge thread and

Re: svn commit: r276747 - head/sys/netpfil/pf

2015-01-12 Thread Gleb Smirnoff
On Thu, Jan 08, 2015 at 12:49:45AM +, Bjoern A. Zeeb wrote: B B AFAIU, from the PR there is some panic fixed. What is the actual bug B B and why couldn't it be fixed with having per-vnet thread? B B B B You don’t 3 whatever pf purging threads on a system all running, possibly

Re: svn commit: r276747 - head/sys/netpfil/pf

2015-01-12 Thread Slawa Olhovchenkov
On Mon, Jan 12, 2015 at 05:41:36PM +0300, Gleb Smirnoff wrote: On Thu, Jan 08, 2015 at 12:49:45AM +, Bjoern A. Zeeb wrote: B B AFAIU, from the PR there is some panic fixed. What is the actual bug B B and why couldn't it be fixed with having per-vnet thread? B B B B You don't 3

Re: svn commit: r276747 - head/sys/netpfil/pf

2015-01-12 Thread Adrian Chadd
On 12 January 2015 at 08:05, Slawa Olhovchenkov s...@zxy.spb.ru wrote: On Mon, Jan 12, 2015 at 05:41:36PM +0300, Gleb Smirnoff wrote: On Thu, Jan 08, 2015 at 12:49:45AM +, Bjoern A. Zeeb wrote: B B AFAIU, from the PR there is some panic fixed. What is the actual bug B B and why

Re: svn commit: r276747 - head/sys/netpfil/pf

2015-01-08 Thread Ermal Luçi
On Thu, Jan 8, 2015 at 1:21 AM, Bjoern A. Zeeb bzeeb-li...@lists.zabbadoz.net wrote: On 07 Jan 2015, at 20:46 , Gleb Smirnoff gleb...@freebsd.org wrote: On Tue, Jan 06, 2015 at 09:03:04AM +, Craig Rodrigues wrote: C Author: rodrigc C Date: Tue Jan 6 09:03:03 2015 C New

Re: svn commit: r276747 - head/sys/netpfil/pf

2015-01-08 Thread Adrian Chadd
On 8 January 2015 at 00:13, Ermal Luçi e...@freebsd.org wrote: On Thu, Jan 8, 2015 at 1:21 AM, Bjoern A. Zeeb bzeeb-li...@lists.zabbadoz.net wrote: On 07 Jan 2015, at 20:46 , Gleb Smirnoff gleb...@freebsd.org wrote: On Tue, Jan 06, 2015 at 09:03:04AM +, Craig Rodrigues wrote: C

Re: svn commit: r276747 - head/sys/netpfil/pf

2015-01-07 Thread John-Mark Gurney
Julian Elischer wrote this message on Thu, Jan 08, 2015 at 11:37 +0800: On 1/8/15 8:31 AM, Gleb Smirnoff wrote: On Thu, Jan 08, 2015 at 12:21:57AM +, Bjoern A. Zeeb wrote: B B On 07 Jan 2015, at 20:46 , Gleb Smirnoff gleb...@freebsd.org wrote: B B On Tue, Jan 06, 2015 at

Re: svn commit: r276747 - head/sys/netpfil/pf

2015-01-07 Thread Julian Elischer
On 1/8/15 8:31 AM, Gleb Smirnoff wrote: On Thu, Jan 08, 2015 at 12:21:57AM +, Bjoern A. Zeeb wrote: B B On 07 Jan 2015, at 20:46 , Gleb Smirnoff gleb...@freebsd.org wrote: B B On Tue, Jan 06, 2015 at 09:03:04AM +, Craig Rodrigues wrote: B C Author: rodrigc B C Date: Tue Jan 6

Re: svn commit: r276747 - head/sys/netpfil/pf

2015-01-07 Thread Bjoern A. Zeeb
On 07 Jan 2015, at 20:46 , Gleb Smirnoff gleb...@freebsd.org wrote: On Tue, Jan 06, 2015 at 09:03:04AM +, Craig Rodrigues wrote: C Author: rodrigc C Date: Tue Jan 6 09:03:03 2015 C New Revision: 276747 C URL: https://svnweb.freebsd.org/changeset/base/276747 C C Log: C Instead

Re: svn commit: r276747 - head/sys/netpfil/pf

2015-01-07 Thread Gleb Smirnoff
On Thu, Jan 08, 2015 at 12:21:57AM +, Bjoern A. Zeeb wrote: B B On 07 Jan 2015, at 20:46 , Gleb Smirnoff gleb...@freebsd.org wrote: B B On Tue, Jan 06, 2015 at 09:03:04AM +, Craig Rodrigues wrote: B C Author: rodrigc B C Date: Tue Jan 6 09:03:03 2015 B C New Revision: 276747 B C

Re: svn commit: r276747 - head/sys/netpfil/pf

2015-01-07 Thread Bjoern A. Zeeb
On 08 Jan 2015, at 00:31 , Gleb Smirnoff gleb...@freebsd.org wrote: On Thu, Jan 08, 2015 at 12:21:57AM +, Bjoern A. Zeeb wrote: B B On 07 Jan 2015, at 20:46 , Gleb Smirnoff gleb...@freebsd.org wrote: B B On Tue, Jan 06, 2015 at 09:03:04AM +, Craig Rodrigues wrote: B C

Re: svn commit: r276747 - head/sys/netpfil/pf

2015-01-07 Thread Gleb Smirnoff
On Tue, Jan 06, 2015 at 09:03:04AM +, Craig Rodrigues wrote: C Author: rodrigc C Date: Tue Jan 6 09:03:03 2015 C New Revision: 276747 C URL: https://svnweb.freebsd.org/changeset/base/276747 C C Log: C Instead of creating a purge thread for every vnet, create C a single purge thread and

Re: svn commit: r276747 - head/sys/netpfil/pf

2015-01-07 Thread Nikos Vassiliadis
Hi, On 01/07/15 21:46, Gleb Smirnoff wrote: On Tue, Jan 06, 2015 at 09:03:04AM +, Craig Rodrigues wrote: C Author: rodrigc C Date: Tue Jan 6 09:03:03 2015 C New Revision: 276747 C URL: https://svnweb.freebsd.org/changeset/base/276747 C C Log: C Instead of creating a purge thread for

Re: svn commit: r276747 - head/sys/netpfil/pf

2015-01-06 Thread Hans Petter Selasky
On 01/06/15 09:39, Craig Rodrigues wrote: Author: rodrigc Date: Tue Jan 6 08:39:06 2015 New Revision: 276746 URL: https://svnweb.freebsd.org/changeset/base/276746 Log: Merge: r258322 from projects/pf branch Split functions that initialize various pf parts into their

svn commit: r276747 - head/sys/netpfil/pf

2015-01-06 Thread Craig Rodrigues
Author: rodrigc Date: Tue Jan 6 09:03:03 2015 New Revision: 276747 URL: https://svnweb.freebsd.org/changeset/base/276747 Log: Instead of creating a purge thread for every vnet, create a single purge thread and clean up all vnets from this thread. PR: 194515