Re: svn commit: r278479 - in head: etc sys/kern

2015-03-23 Thread Rui Paulo
On Mar 22, 2015, at 18:08, Mateusz Guzik mjgu...@gmail.com wrote: On Mon, Feb 09, 2015 at 11:13:51PM +, Rui Paulo wrote: Author: rpaulo Date: Mon Feb 9 23:13:50 2015 New Revision: 278479 URL: https://svnweb.freebsd.org/changeset/base/278479 Log: Notify devd(8) when a process

Re: svn commit: r278479 - in head: etc sys/kern

2015-03-22 Thread Mateusz Guzik
On Mon, Feb 09, 2015 at 11:13:51PM +, Rui Paulo wrote: Author: rpaulo Date: Mon Feb 9 23:13:50 2015 New Revision: 278479 URL: https://svnweb.freebsd.org/changeset/base/278479 Log: Notify devd(8) when a process crashed. This change implements a notification (via devctl) to

Re: svn commit: r278479 - in head: etc sys/kern

2015-02-27 Thread Warner Losh
[[ I know I’m a little behind… ]] On Feb 10, 2015, at 7:16 AM, John Baldwin j...@freebsd.org wrote: On Monday, February 09, 2015 11:13:51 PM Rui Paulo wrote: Author: rpaulo Date: Mon Feb 9 23:13:50 2015 New Revision: 278479 URL: https://svnweb.freebsd.org/changeset/base/278479 Log:

Re: svn commit: r278479 - in head: etc sys/kern

2015-02-10 Thread John Baldwin
On Tuesday, February 10, 2015 07:06:03 AM Adrian Chadd wrote: On 10 February 2015 at 06:16, John Baldwin j...@freebsd.org wrote: On Monday, February 09, 2015 11:13:51 PM Rui Paulo wrote: Author: rpaulo Date: Mon Feb 9 23:13:50 2015 New Revision: 278479 URL:

Re: svn commit: r278479 - in head: etc sys/kern

2015-02-10 Thread Slawa Olhovchenkov
On Tue, Feb 10, 2015 at 07:06:03AM -0800, Adrian Chadd wrote: On 10 February 2015 at 06:16, John Baldwin j...@freebsd.org wrote: On Monday, February 09, 2015 11:13:51 PM Rui Paulo wrote: Author: rpaulo Date: Mon Feb 9 23:13:50 2015 New Revision: 278479 URL:

Re: svn commit: r278479 - in head: etc sys/kern

2015-02-10 Thread Ian Lepore
On Tue, 2015-02-10 at 07:06 -0800, Adrian Chadd wrote: On 10 February 2015 at 06:16, John Baldwin j...@freebsd.org wrote: On Monday, February 09, 2015 11:13:51 PM Rui Paulo wrote: Author: rpaulo Date: Mon Feb 9 23:13:50 2015 New Revision: 278479 URL:

Re: svn commit: r278479 - in head: etc sys/kern

2015-02-10 Thread Konstantin Belousov
On Mon, Feb 09, 2015 at 06:35:55PM -0800, Rui Paulo wrote: On Feb 9, 2015, at 15:28, Konstantin Belousov kostik...@gmail.com wrote: Arguably, there should be a knob, probably sysctl, to turn the functionality off. I definitely do not want this on crash boxes used for userspace debugging.

Re: svn commit: r278479 - in head: etc sys/kern

2015-02-10 Thread Mateusz Guzik
On Mon, Feb 09, 2015 at 06:57:36PM -0800, Rui Paulo wrote: On Feb 9, 2015, at 18:43, Mateusz Guzik mjgu...@gmail.com wrote: On Mon, Feb 09, 2015 at 11:13:51PM +, Rui Paulo wrote: +notify 10 { + match system kernel; + match subsystem signal; + match type

Re: svn commit: r278479 - in head: etc sys/kern

2015-02-10 Thread Slawa Olhovchenkov
On Tue, Feb 10, 2015 at 06:30:27PM +, Rui Paulo wrote: On Feb 10, 2015, at 07:37 AM, John Baldwin j...@freebsd.org wrote: That wasn't really my question. My question was if we want distinct streams or if we want want unified stream. Having a unified stream might very well make sense

Re: svn commit: r278479 - in head: etc sys/kern

2015-02-10 Thread Rui Paulo
On Feb 10, 2015, at 10:52 AM, Slawa Olhovchenkov s...@zxy.spb.ru wrote: For common case (I am not talk about current devd implementation -- I am don't have any inforamtion/metrics/etc) routing and processing events may be sensitive to delay and ordering: may be exist requirement 'delay not more

Re: svn commit: r278479 - in head: etc sys/kern

2015-02-10 Thread Rui Paulo
On Feb 10, 2015, at 07:37 AM, John Baldwin j...@freebsd.org wrote: That wasn't really my question. My question was if we want distinct streams or if we want want unified stream. Having a unified stream might very well make sense (and if so we could rename devd to make that more obvious). I'm

Re: svn commit: r278479 - in head: etc sys/kern

2015-02-10 Thread David Chisnall
On 10 Feb 2015, at 18:30, Rui Paulo rpa...@me.com wrote: Another thing I had in mind (which is more work) was to abstract the devctl kernel code in an API which could make it easy to fan out the notifications to multiple /dev devices. However, that may be overkill. This kind of

Re: svn commit: r278479 - in head: etc sys/kern

2015-02-10 Thread Slawa Olhovchenkov
On Tue, Feb 10, 2015 at 06:55:28PM +, Rui Paulo wrote: On Feb 10, 2015, at 10:52 AM, Slawa Olhovchenkov s...@zxy.spb.ru wrote: For common case (I am not talk about current devd implementation -- I am don't have any inforamtion/metrics/etc) routing and processing events may be sensitive to

Re: svn commit: r278479 - in head: etc sys/kern

2015-02-10 Thread John-Mark Gurney
John Baldwin wrote this message on Tue, Feb 10, 2015 at 10:36 -0500: I think devd grows these things because it's easier than teaching the devctl interface to support multiple listeners. That wasn't really my question. My question was if we want distinct streams or if we want want

Re: svn commit: r278479 - in head: etc sys/kern

2015-02-10 Thread Ian Lepore
On Tue, 2015-02-10 at 12:15 -0800, John-Mark Gurney wrote: John Baldwin wrote this message on Tue, Feb 10, 2015 at 10:36 -0500: I think devd grows these things because it's easier than teaching the devctl interface to support multiple listeners. That wasn't really my question. My

Re: svn commit: r278479 - in head: etc sys/kern

2015-02-10 Thread Adrian Chadd
On 10 February 2015 at 06:16, John Baldwin j...@freebsd.org wrote: On Monday, February 09, 2015 11:13:51 PM Rui Paulo wrote: Author: rpaulo Date: Mon Feb 9 23:13:50 2015 New Revision: 278479 URL: https://svnweb.freebsd.org/changeset/base/278479 Log: Notify devd(8) when a process

Re: svn commit: r278479 - in head: etc sys/kern

2015-02-10 Thread John Baldwin
On Monday, February 09, 2015 11:13:51 PM Rui Paulo wrote: Author: rpaulo Date: Mon Feb 9 23:13:50 2015 New Revision: 278479 URL: https://svnweb.freebsd.org/changeset/base/278479 Log: Notify devd(8) when a process crashed. This change implements a notification (via devctl) to

Re: svn commit: r278479 - in head: etc sys/kern

2015-02-09 Thread Rui Paulo
On Feb 9, 2015, at 15:28, Konstantin Belousov kostik...@gmail.com wrote: Arguably, there should be a knob, probably sysctl, to turn the functionality off. I definitely do not want this on crash boxes used for userspace debugging. Even despite the example handler is inactive. OK, I can provide

Re: svn commit: r278479 - in head: etc sys/kern

2015-02-09 Thread Don Lewis
On 9 Feb, Don Lewis wrote: On 10 Feb, Mateusz Guzik wrote: On Mon, Feb 09, 2015 at 11:13:51PM +, Rui Paulo wrote: +notify 10 { + match system kernel; + match subsystem signal; + match typecoredump; + action logger $comm $core; +}; + */ [..] +

Re: svn commit: r278479 - in head: etc sys/kern

2015-02-09 Thread Rui Paulo
On Feb 9, 2015, at 18:43, Mateusz Guzik mjgu...@gmail.com wrote: On Mon, Feb 09, 2015 at 11:13:51PM +, Rui Paulo wrote: +notify 10 { +match system kernel; +match subsystem signal; +match typecoredump; +action logger $comm $core; +}; + */

Re: svn commit: r278479 - in head: etc sys/kern

2015-02-09 Thread Don Lewis
On 10 Feb, Mateusz Guzik wrote: On Mon, Feb 09, 2015 at 11:13:51PM +, Rui Paulo wrote: +notify 10 { +match system kernel; +match subsystem signal; +match typecoredump; +action logger $comm $core; +}; + */ [..] +if

Re: svn commit: r278479 - in head: etc sys/kern

2015-02-09 Thread Rui Paulo
On Feb 9, 2015, at 15:29, Benjamin Kaduk bjkf...@gmail.com wrote: The question boils down to: is the time saved by implementing it this way worth the tradeoff of architectural purity. Yes, that was a tradeoff. -- Rui Paulo ___

Re: svn commit: r278479 - in head: etc sys/kern

2015-02-09 Thread Ian Lepore
On Mon, 2015-02-09 at 18:29 -0500, Benjamin Kaduk wrote: On Mon, Feb 9, 2015 at 6:22 PM, Rui Paulo rpa...@me.com wrote: On Feb 09, 2015, at 03:16 PM, Benjamin Kaduk bjkf...@gmail.com wrote: What advantage does putting this in devd have over a standalone daemon for crash reporting? Is

Re: svn commit: r278479 - in head: etc sys/kern

2015-02-09 Thread Benjamin Kaduk
On Mon, Feb 9, 2015 at 6:13 PM, Rui Paulo rpa...@freebsd.org wrote: Author: rpaulo Date: Mon Feb 9 23:13:50 2015 New Revision: 278479 URL: https://svnweb.freebsd.org/changeset/base/278479 Log: Notify devd(8) when a process crashed. This change implements a notification (via devctl)

Re: svn commit: r278479 - in head: etc sys/kern

2015-02-09 Thread Rui Paulo
On Feb 09, 2015, at 03:16 PM, Benjamin Kaduk bjkf...@gmail.com wrote: On Mon, Feb 9, 2015 at 6:13 PM, Rui Paulo rpa...@freebsd.org wrote: Author: rpaulo Date: Mon Feb  9 23:13:50 2015 New Revision: 278479 URL: https://svnweb.freebsd.org/changeset/base/278479 Log:   Notify devd(8) when a process

svn commit: r278479 - in head: etc sys/kern

2015-02-09 Thread Rui Paulo
Author: rpaulo Date: Mon Feb 9 23:13:50 2015 New Revision: 278479 URL: https://svnweb.freebsd.org/changeset/base/278479 Log: Notify devd(8) when a process crashed. This change implements a notification (via devctl) to userland when the kernel produces coredumps after a process has

Re: svn commit: r278479 - in head: etc sys/kern

2015-02-09 Thread Konstantin Belousov
On Mon, Feb 09, 2015 at 11:13:51PM +, Rui Paulo wrote: Author: rpaulo Date: Mon Feb 9 23:13:50 2015 New Revision: 278479 URL: https://svnweb.freebsd.org/changeset/base/278479 Log: Notify devd(8) when a process crashed. This change implements a notification (via devctl) to

Re: svn commit: r278479 - in head: etc sys/kern

2015-02-09 Thread Benjamin Kaduk
On Mon, Feb 9, 2015 at 6:22 PM, Rui Paulo rpa...@me.com wrote: On Feb 09, 2015, at 03:16 PM, Benjamin Kaduk bjkf...@gmail.com wrote: What advantage does putting this in devd have over a standalone daemon for crash reporting? Is it just the ease of implementation to leverage the existing

Re: svn commit: r278479 - in head: etc sys/kern

2015-02-09 Thread Mateusz Guzik
On Mon, Feb 09, 2015 at 11:13:51PM +, Rui Paulo wrote: +notify 10 { + match system kernel; + match subsystem signal; + match typecoredump; + action logger $comm $core; +}; + */ [..] + if (vn_fullpath_global(td, p-p_textvp, fullpath,

Re: svn commit: r278479 - in head: etc sys/kern

2015-02-09 Thread Rui Paulo
On Feb 9, 2015, at 19:11, Don Lewis truck...@freebsd.org wrote: On 10 Feb, Mateusz Guzik wrote: On Mon, Feb 09, 2015 at 11:13:51PM +, Rui Paulo wrote: +notify 10 { + match system kernel; + match subsystem signal; + match typecoredump; + action logger