Author: gnn
Date: Wed Apr 15 14:46:45 2015
New Revision: 281558
URL: https://svnweb.freebsd.org/changeset/base/281558

Log:
  Minor change to the macros to make sure that if an AF is passed that is 
neither AF_INET6 nor AF_INET that we don't touch random bits of memory.
  
  Differential Revision:        https://reviews.freebsd.org/D2291

Modified:
  head/sys/net/pfvar.h

Modified: head/sys/net/pfvar.h
==============================================================================
--- head/sys/net/pfvar.h        Wed Apr 15 14:30:07 2015        (r281557)
+++ head/sys/net/pfvar.h        Wed Apr 15 14:46:45 2015        (r281558)
@@ -192,21 +192,20 @@ extern struct rwlock pf_rules_lock;
 
 #define PF_AEQ(a, b, c) \
        ((c == AF_INET && (a)->addr32[0] == (b)->addr32[0]) || \
-       ((a)->addr32[3] == (b)->addr32[3] && \
+       (c == AF_INET6 && (a)->addr32[3] == (b)->addr32[3] && \
        (a)->addr32[2] == (b)->addr32[2] && \
        (a)->addr32[1] == (b)->addr32[1] && \
        (a)->addr32[0] == (b)->addr32[0])) \
 
 #define PF_ANEQ(a, b, c) \
-       ((c == AF_INET && (a)->addr32[0] != (b)->addr32[0]) || \
-       ((a)->addr32[3] != (b)->addr32[3] || \
-       (a)->addr32[2] != (b)->addr32[2] || \
+       ((a)->addr32[0] != (b)->addr32[0] || \
        (a)->addr32[1] != (b)->addr32[1] || \
-       (a)->addr32[0] != (b)->addr32[0])) \
+       (a)->addr32[2] != (b)->addr32[2] || \
+       (a)->addr32[3] != (b)->addr32[3]) \
 
 #define PF_AZERO(a, c) \
        ((c == AF_INET && !(a)->addr32[0]) || \
-       (!(a)->addr32[0] && !(a)->addr32[1] && \
+       (c == AF_INET6 && !(a)->addr32[0] && !(a)->addr32[1] && \
        !(a)->addr32[2] && !(a)->addr32[3] )) \
 
 #define PF_MATCHA(n, a, m, b, f) \
_______________________________________________
svn-src-head@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-head
To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"

Reply via email to