Re: svn commit: r285021 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2015-08-24 Thread Andriy Gapon
On 03/08/2015 16:29, Fabian Keil wrote: Andriy Gapon a...@freebsd.org wrote: On 30/07/2015 10:24, K. Macy wrote: Just FYI this change introduces a deadlock with with the spa_namespace_lock. Mount will be holding this lock while trying to acquire the spa_namespace_lock. zfskern on the other

Re: svn commit: r285021 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2015-08-05 Thread Glen Barber
On Thu, Aug 06, 2015 at 04:17:23AM +0200, Pawel Jakub Dawidek wrote: On Mon, Aug 03, 2015 at 04:20:04PM +0300, Andriy Gapon wrote: On 30/07/2015 10:24, K. Macy wrote: Just FYI this change introduces a deadlock with with the spa_namespace_lock. Mount will be holding this lock while trying

Re: svn commit: r285021 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2015-08-05 Thread Andriy Gapon
On 06/08/2015 06:07, Glen Barber wrote: On Wed, Aug 05, 2015 at 08:04:55PM -0700, K. Macy wrote: On Wed, Aug 5, 2015 at 7:22 PM, Glen Barber g...@freebsd.org wrote: On Thu, Aug 06, 2015 at 04:17:23AM +0200, Pawel Jakub Dawidek wrote: On Mon, Aug 03, 2015 at 04:20:04PM +0300, Andriy Gapon

Re: svn commit: r285021 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2015-08-05 Thread Glen Barber
On Wed, Aug 05, 2015 at 08:04:55PM -0700, K. Macy wrote: On Wed, Aug 5, 2015 at 7:22 PM, Glen Barber g...@freebsd.org wrote: On Thu, Aug 06, 2015 at 04:17:23AM +0200, Pawel Jakub Dawidek wrote: On Mon, Aug 03, 2015 at 04:20:04PM +0300, Andriy Gapon wrote: On 30/07/2015 10:24, K. Macy

Re: svn commit: r285021 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2015-08-05 Thread Pawel Jakub Dawidek
On Mon, Aug 03, 2015 at 04:20:04PM +0300, Andriy Gapon wrote: On 30/07/2015 10:24, K. Macy wrote: Just FYI this change introduces a deadlock with with the spa_namespace_lock. Mount will be holding this lock while trying to acquire the spa_namespace_lock. zfskern on the other hand holds the

Re: svn commit: r285021 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2015-08-05 Thread K. Macy
His proposed solution looks fine to me. Why don't we commit that? -K On Wed, Aug 5, 2015 at 7:22 PM, Glen Barber g...@freebsd.org wrote: On Thu, Aug 06, 2015 at 04:17:23AM +0200, Pawel Jakub Dawidek wrote: On Mon, Aug 03, 2015 at 04:20:04PM +0300, Andriy Gapon wrote: On 30/07/2015 10:24, K.

Re: svn commit: r285021 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2015-08-03 Thread Andriy Gapon
On 30/07/2015 10:24, K. Macy wrote: Just FYI this change introduces a deadlock with with the spa_namespace_lock. Mount will be holding this lock while trying to acquire the spa_namespace_lock. zfskern on the other hand holds the spa_namespace_lock when calling zfs_freebsd_access which in turn

Re: svn commit: r285021 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2015-08-03 Thread Fabian Keil
Andriy Gapon a...@freebsd.org wrote: On 30/07/2015 10:24, K. Macy wrote: Just FYI this change introduces a deadlock with with the spa_namespace_lock. Mount will be holding this lock while trying to acquire the spa_namespace_lock. zfskern on the other hand holds the spa_namespace_lock

Re: svn commit: r285021 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2015-07-30 Thread K. Macy
Just FYI this change introduces a deadlock with with the spa_namespace_lock. Mount will be holding this lock while trying to acquire the spa_namespace_lock. zfskern on the other hand holds the spa_namespace_lock when calling zfs_freebsd_access which in turn tries to acquire the teardown lock.

svn commit: r285021 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2015-07-02 Thread Andriy Gapon
Author: avg Date: Thu Jul 2 08:32:02 2015 New Revision: 285021 URL: https://svnweb.freebsd.org/changeset/base/285021 Log: zfs_mount(MS_REMOUNT): protect zfs_(un)register_callbacks calls We now take z_teardown_lock as a writer to ensure that there is no I/O while the filesystem state is