Re: svn commit: r286880 - head/sys/kern

2015-08-28 Thread Julien Charbon
Hi Konstantin, On 27/08/15 19:19, Konstantin Belousov wrote: > On Thu, Aug 27, 2015 at 06:28:03PM +0200, Julien Charbon wrote: >> On 27/08/15 12:49, Konstantin Belousov wrote: >>> On Wed, Aug 26, 2015 at 08:14:15PM +0200, Julien Charbon wrote: As I said, I am not opposed to back out this c

Re: svn commit: r286880 - head/sys/kern

2015-08-27 Thread Konstantin Belousov
On Thu, Aug 27, 2015 at 06:28:03PM +0200, Julien Charbon wrote: > > Hi Konstantin, > > On 27/08/15 12:49, Konstantin Belousov wrote: > > On Wed, Aug 26, 2015 at 08:14:15PM +0200, Julien Charbon wrote: > >> As I said, I am not opposed to back out this change, callout(9) API in > >> mpsafe mode i

Re: svn commit: r286880 - head/sys/kern

2015-08-27 Thread Julien Charbon
Hi Konstantin, On 27/08/15 12:49, Konstantin Belousov wrote: > On Wed, Aug 26, 2015 at 08:14:15PM +0200, Julien Charbon wrote: >> As I said, I am not opposed to back out this change, callout(9) API in >> mpsafe mode is a already complex/subtle API, it won't change too much >> the current comple

Re: svn commit: r286880 - head/sys/kern

2015-08-27 Thread Konstantin Belousov
On Wed, Aug 26, 2015 at 08:14:15PM +0200, Julien Charbon wrote: > As I said, I am not opposed to back out this change, callout(9) API in > mpsafe mode is a already complex/subtle API, it won't change too much > the current complexity. > > Let say that if nobody screams until Friday 8/28, I will

Re: svn commit: r286880 - head/sys/kern

2015-08-27 Thread Julien Charbon
Hi Hans, On 26/08/15 20:31, Hans Petter Selasky wrote: > On 08/26/15 20:14, Julien Charbon wrote: >> Let say that if nobody screams until Friday 8/28, I will put back >> r284245 and revert this change_and_ I will make this case clear in the >> man page. > > If you can update the manual page

Re: svn commit: r286880 - head/sys/kern

2015-08-27 Thread Hans Petter Selasky
Hi Julien, On 08/27/15 10:17, Julien Charbon wrote: Hi Hans, After checking the non-mpsafe callout cases, you are completely right, this test makes sense only in mpsafe callout case. Fixed in r287196: https://svnweb.freebsd.org/base?view=revision&revision=287196 Thanks a lot for

Re: svn commit: r286880 - head/sys/kern

2015-08-27 Thread Julien Charbon
Hi Hans, On 26/08/15 18:31, Julien Charbon wrote: > On 26/08/15 09:25, Hans Petter Selasky wrote: >> On 08/18/15 12:15, Julien Charbon wrote: >>> Author: jch >>> Date: Tue Aug 18 10:15:09 2015 >>> New Revision: 286880 >>> URL: https://svnweb.freebsd.org/changeset/base/286880 >>> >>> Log: >>>

Re: svn commit: r286880 - head/sys/kern

2015-08-26 Thread Hans Petter Selasky
On 08/26/15 20:14, Julien Charbon wrote: Let say that if nobody screams until Friday 8/28, I will put back r284245 and revert this change_and_ I will make this case clear in the man page. Hi, If you can update the manual page about this special case for MPSAFE callouts only I presume, then

Re: svn commit: r286880 - head/sys/kern

2015-08-26 Thread Julien Charbon
Hi Hans, On 26/08/15 10:12, Hans Petter Selasky wrote: > On 08/26/15 09:25, Hans Petter Selasky wrote: >> On 08/18/15 12:15, Julien Charbon wrote: >>> Author: jch >>> Date: Tue Aug 18 10:15:09 2015 >>> New Revision: 286880 >>> URL: https://svnweb.freebsd.org/changeset/base/286880 >>> >>> Log: >>

Re: svn commit: r286880 - head/sys/kern

2015-08-26 Thread Julien Charbon
Hi Hans, On 26/08/15 09:25, Hans Petter Selasky wrote: > On 08/18/15 12:15, Julien Charbon wrote: >> Author: jch >> Date: Tue Aug 18 10:15:09 2015 >> New Revision: 286880 >> URL: https://svnweb.freebsd.org/changeset/base/286880 >> >> Log: >>callout_stop() should return 0 (fail) when the call

Re: svn commit: r286880 - head/sys/kern

2015-08-26 Thread Hans Petter Selasky
On 08/26/15 09:25, Hans Petter Selasky wrote: On 08/18/15 12:15, Julien Charbon wrote: Author: jch Date: Tue Aug 18 10:15:09 2015 New Revision: 286880 URL: https://svnweb.freebsd.org/changeset/base/286880 Log: callout_stop() should return 0 (fail) when the callout is currently being servi

Re: svn commit: r286880 - head/sys/kern

2015-08-26 Thread Hans Petter Selasky
On 08/18/15 12:15, Julien Charbon wrote: Author: jch Date: Tue Aug 18 10:15:09 2015 New Revision: 286880 URL: https://svnweb.freebsd.org/changeset/base/286880 Log: callout_stop() should return 0 (fail) when the callout is currently being serviced and indeed unstoppable. A scenario to r

Re: svn commit: r286880 - head/sys/kern

2015-08-18 Thread Julien Charbon
Hi Hans, On 18/08/15 12:59, Hans Petter Selasky wrote: > On 08/18/15 12:15, Julien Charbon wrote: >> Author: jch >> Date: Tue Aug 18 10:15:09 2015 >> New Revision: 286880 >> URL: https://svnweb.freebsd.org/changeset/base/286880 >> >> Log: >>callout_stop() should return 0 (fail) when the call

Re: svn commit: r286880 - head/sys/kern

2015-08-18 Thread Hans Petter Selasky
On 08/18/15 12:15, Julien Charbon wrote: Author: jch Date: Tue Aug 18 10:15:09 2015 New Revision: 286880 URL: https://svnweb.freebsd.org/changeset/base/286880 Log: callout_stop() should return 0 (fail) when the callout is currently being serviced and indeed unstoppable. A scenario to r

svn commit: r286880 - head/sys/kern

2015-08-18 Thread Julien Charbon
Author: jch Date: Tue Aug 18 10:15:09 2015 New Revision: 286880 URL: https://svnweb.freebsd.org/changeset/base/286880 Log: callout_stop() should return 0 (fail) when the callout is currently being serviced and indeed unstoppable. A scenario to reproduce this case is: - the callout is